55002 2011-02-22 14:58:23 -0800 rebaseline-chromium-webkit-tests can't handle GPU variants at all 2011-02-24 15:50:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke atwilson jamesr mihaip ojan tony oldest_to_newest 355634 0 dpranke 2011-02-22 14:58:23 -0800 rebaseline-chromium-webkit-tests can't handle GPU variants 355644 1 83401 dpranke 2011-02-22 15:17:35 -0800 Created attachment 83401 Patch 355646 2 dpranke 2011-02-22 15:18:37 -0800 Okay, I think this patch works, although it probably needs more testing (and unit tests) before it lands. 357454 3 dpranke 2011-02-24 15:34:26 -0800 Okay, I'm going to land this as-is for now (assuming it gets reviewed) and file a separate bug to be able to handle the "GPU" modifier correctly so we don't need the -g flag. 357467 4 83401 mihaip 2011-02-24 15:39:23 -0800 Comment on attachment 83401 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83401&action=review > Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py:148 > + def test_platform_names(self): Might be nice if the the GPU-specific behavior was done via a mixin so that there wouldn't be quite so much repetition, though that's beyond the scope of this patch. 357485 5 dpranke 2011-02-24 15:45:19 -0800 (In reply to comment #4) > (From update of attachment 83401 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=83401&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py:148 > > + def test_platform_names(self): > > Might be nice if the the GPU-specific behavior was done via a mixin so that there wouldn't be quite so much repetition, though that's beyond the scope of this patch. Yeah, there's a bug filed for that already ( bug 48103) and I have a patch waiting in the wings. It'll show up next week some time. 357493 6 dpranke 2011-02-24 15:50:19 -0800 Committed r79636: <http://trac.webkit.org/changeset/79636> 83401 2011-02-22 15:17:35 -0800 2011-02-24 15:39:23 -0800 Patch bug-55002-20110222151734.patch text/plain 7508 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogNzkyODMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlOWE2MzhhNTdlNGNiZmE4YmViZDAwNDEwNTU5OGMyODEz YWU4ODUyLi5hODM4MWFhYzcwZTEwM2JkZWYzMTQxZTYxODNiMTU5ZjlhNzFlOWFkIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDItMjIgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcmViYXNlbGluZS1j aHJvbWl1bS13ZWJraXQtdGVzdHMgY2FuJ3QgaGFuZGxlIEdQVSB2YXJpYW50cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTUwMDIKKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1LnB5OgorICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3JlYmFzZWxpbmVfY2hyb21pdW1f d2Via2l0X3Rlc3RzLnB5OgorCiAyMDExLTAyLTIxICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9ncHUu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dw dS5weQppbmRleCBlOGM3NWM0NDEyM2RlNmJhY2IzY2E0NTI2OGVjMTdkNjM5NWMzYmNhLi5iMTk3 NzM1ZmZjYjg5NDQyMjZkODgyYmZlZDI5NzQ1YmM0YWVlMDczIDEwMDY0NAotLS0gYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdS5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdS5weQpA QCAtODQsNiArODQsMTcgQEAgZGVmIF90ZXN0cyhwb3J0LCBwYXRocyk6CiAgICAgcmV0dXJuIHRl c3RfZmlsZXMuZmluZChwb3J0LCBwYXRocykKIAogCitkZWYgX3Rlc3RfcGxhdGZvcm1fbmFtZXMo c2VsZik6CisgICAgcmV0dXJuICgnbWFjJywgJ3dpbicsICdsaW51eCcpCisKKworZGVmIF90ZXN0 X3BsYXRmb3JtX25hbWVfdG9fbmFtZShzZWxmLCB0ZXN0X3BsYXRmb3JtX25hbWUpOgorICAgIGlm IHRlc3RfcGxhdGZvcm1fbmFtZSBpbiBzZWxmLnRlc3RfcGxhdGZvcm1fbmFtZXMoKToKKyAgICAg ICAgcmV0dXJuICdjaHJvbWl1bS1ncHUtJyArIHRlc3RfcGxhdGZvcm1fbmFtZQorICAgIHJhaXNl IFZhbHVlRXJyb3IoJ1Vuc3VwcG9ydGVkIHRlc3RfcGxhdGZvcm1fbmFtZTogJXMnICUKKyAgICAg ICAgICAgICAgICAgICAgIHRlc3RfcGxhdGZvcm1fbmFtZSkKKworCiBjbGFzcyBDaHJvbWl1bUdw dUxpbnV4UG9ydChjaHJvbWl1bV9saW51eC5DaHJvbWl1bUxpbnV4UG9ydCk6CiAgICAgZGVmIF9f aW5pdF9fKHNlbGYsIHBvcnRfbmFtZT0nY2hyb21pdW0tZ3B1LWxpbnV4JywgKiprd2FyZ3MpOgog ICAgICAgICBjaHJvbWl1bV9saW51eC5DaHJvbWl1bUxpbnV4UG9ydC5fX2luaXRfXyhzZWxmLCBw b3J0X25hbWU9cG9ydF9uYW1lLCAqKmt3YXJncykKQEAgLTEwMyw2ICsxMTQsMTQgQEAgY2xhc3Mg Q2hyb21pdW1HcHVMaW51eFBvcnQoY2hyb21pdW1fbGludXguQ2hyb21pdW1MaW51eFBvcnQpOgog ICAgIGRlZiB0ZXN0cyhzZWxmLCBwYXRocyk6CiAgICAgICAgIHJldHVybiBfdGVzdHMoc2VsZiwg cGF0aHMpCiAKKyAgICBkZWYgdGVzdF9wbGF0Zm9ybV9uYW1lKHNlbGYpOgorICAgICAgICByZXR1 cm4gJ2xpbnV4JworCisgICAgZGVmIHRlc3RfcGxhdGZvcm1fbmFtZXMoc2VsZik6CisgICAgICAg IHJldHVybiBfdGVzdF9wbGF0Zm9ybV9uYW1lcyhzZWxmKQorCisgICAgZGVmIHRlc3RfcGxhdGZv cm1fbmFtZV90b19uYW1lKHNlbGYsIG5hbWUpOgorICAgICAgICByZXR1cm4gX3Rlc3RfcGxhdGZv cm1fbmFtZV90b19uYW1lKHNlbGYsIG5hbWUpCiAKIAogY2xhc3MgQ2hyb21pdW1HcHVNYWNQb3J0 KGNocm9taXVtX21hYy5DaHJvbWl1bU1hY1BvcnQpOgpAQCAtMTIzLDYgKzE0MiwxNCBAQCBjbGFz cyBDaHJvbWl1bUdwdU1hY1BvcnQoY2hyb21pdW1fbWFjLkNocm9taXVtTWFjUG9ydCk6CiAgICAg ZGVmIHRlc3RzKHNlbGYsIHBhdGhzKToKICAgICAgICAgcmV0dXJuIF90ZXN0cyhzZWxmLCBwYXRo cykKIAorICAgIGRlZiB0ZXN0X3BsYXRmb3JtX25hbWUoc2VsZik6CisgICAgICAgIHJldHVybiAn bWFjJworCisgICAgZGVmIHRlc3RfcGxhdGZvcm1fbmFtZXMoc2VsZik6CisgICAgICAgIHJldHVy biBfdGVzdF9wbGF0Zm9ybV9uYW1lcyhzZWxmKQorCisgICAgZGVmIHRlc3RfcGxhdGZvcm1fbmFt ZV90b19uYW1lKHNlbGYsIG5hbWUpOgorICAgICAgICByZXR1cm4gX3Rlc3RfcGxhdGZvcm1fbmFt ZV90b19uYW1lKHNlbGYsIG5hbWUpCiAKIAogY2xhc3MgQ2hyb21pdW1HcHVXaW5Qb3J0KGNocm9t aXVtX3dpbi5DaHJvbWl1bVdpblBvcnQpOgpAQCAtMTQyLDMgKzE2OSwxMiBAQCBjbGFzcyBDaHJv bWl1bUdwdVdpblBvcnQoY2hyb21pdW1fd2luLkNocm9taXVtV2luUG9ydCk6CiAKICAgICBkZWYg dGVzdHMoc2VsZiwgcGF0aHMpOgogICAgICAgICByZXR1cm4gX3Rlc3RzKHNlbGYsIHBhdGhzKQor CisgICAgZGVmIHRlc3RfcGxhdGZvcm1fbmFtZShzZWxmKToKKyAgICAgICAgcmV0dXJuICd3aW4n CisKKyAgICBkZWYgdGVzdF9wbGF0Zm9ybV9uYW1lcyhzZWxmKToKKyAgICAgICAgcmV0dXJuIF90 ZXN0X3BsYXRmb3JtX25hbWVzKHNlbGYpCisKKyAgICBkZWYgdGVzdF9wbGF0Zm9ybV9uYW1lX3Rv X25hbWUoc2VsZiwgbmFtZSk6CisgICAgICAgIHJldHVybiBfdGVzdF9wbGF0Zm9ybV9uYW1lX3Rv X25hbWUoc2VsZiwgbmFtZSkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3JlYmFzZWxpbmVfY2hyb21pdW1fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRfdGVz dHMucHkKaW5kZXggNDVlY2U4YTMzZTdiZDRlZGRkZDM2ZmNjMmJjMTIxOGI5OGY1MTlkZS4uMjRi OGM5NzZlZDdkNjMxYTdlNjE1NTNhNzFhMTA5YTExZmQ1MTQzZSAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNlbGluZV9jaHJvbWl1bV93ZWJraXRf dGVzdHMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcmViYXNl bGluZV9jaHJvbWl1bV93ZWJraXRfdGVzdHMucHkKQEAgLTY2LDExICs2NiwxNyBAQCBBUkNISVZF X0RJUl9OQU1FX0RJQ1QgPSB7J3dpbic6ICdXZWJraXRfV2luX19kZXBzXycsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgJ3dpbi14cCc6ICdXZWJraXRfV2luX19kZXBzXycsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgJ21hYyc6ICdXZWJraXRfTWFjMTBfNV9fZGVwc18nLAogICAgICAgICAg ICAgICAgICAgICAgICAgICdsaW51eCc6ICdXZWJraXRfTGludXhfX2RlcHNfJywKKwogICAgICAg ICAgICAgICAgICAgICAgICAgICd3aW4tY2FuYXJ5JzogJ1dlYmtpdF9XaW4nLAogICAgICAgICAg ICAgICAgICAgICAgICAgICd3aW4tdmlzdGEtY2FuYXJ5JzogJ3dlYmtpdC1kYmctdmlzdGEnLAog ICAgICAgICAgICAgICAgICAgICAgICAgICd3aW4teHAtY2FuYXJ5JzogJ1dlYmtpdF9XaW4nLAog ICAgICAgICAgICAgICAgICAgICAgICAgICdtYWMtY2FuYXJ5JzogJ1dlYmtpdF9NYWMxMF81JywK LSAgICAgICAgICAgICAgICAgICAgICAgICAnbGludXgtY2FuYXJ5JzogJ1dlYmtpdF9MaW51eCd9 CisgICAgICAgICAgICAgICAgICAgICAgICAgJ2xpbnV4LWNhbmFyeSc6ICdXZWJraXRfTGludXgn LAorCisgICAgICAgICAgICAgICAgICAgICAgICAgJ2dwdS1tYWMtY2FuYXJ5JzogJ1dlYmtpdF9N YWMxMF81Xy1fR1BVJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAnZ3B1LXdpbi1jYW5hcnkn OiAnV2Via2l0X1dpbl8tX0dQVScsCisgICAgICAgICAgICAgICAgICAgICAgICAgJ2dwdS1saW51 eC1jYW5hcnknOiAnV2Via2l0X0xpbnV4Xy1fR1BVJywKK30KIAogCiBkZWYgbG9nX2Rhc2hlZF9z dHJpbmcodGV4dCwgcGxhdGZvcm0sIGxvZ2dpbmdfbGV2ZWw9bG9nZ2luZy5JTkZPKToKQEAgLTI3 Niw3ICsyODIsNyBAQCBjbGFzcyBSZWJhc2VsaW5lcihvYmplY3QpOgogICAgICAgICBfbG9nLmlu Zm8oJ0xhdGVzdCByZXZpc2lvbjogIiVzIicsIHJldmlzaW9uc1tsZW4ocmV2aXNpb25zKSAtIDFd KQogICAgICAgICByZXR1cm4gcmV2aXNpb25zW2xlbihyZXZpc2lvbnMpIC0gMV0KIAotICAgIGRl ZiBfZ2V0X2FyY2hpdmVfZGlyX25hbWUoc2VsZiwgcGxhdGZvcm0sIHdlYmtpdF9jYW5hcnkpOgor ICAgIGRlZiBfZ2V0X2FyY2hpdmVfZGlyX25hbWUoc2VsZiwgcGxhdGZvcm0pOgogICAgICAgICAi IiJHZXQgbmFtZSBvZiB0aGUgbGF5b3V0IHRlc3QgYXJjaGl2ZSBkaXJlY3RvcnkuCiAKICAgICAg ICAgUmV0dXJuczoKQEAgLTI4NCw5ICsyOTAsNiBAQCBjbGFzcyBSZWJhc2VsaW5lcihvYmplY3Qp OgogICAgICAgICAgIE5vbmUgb24gZmFpbHVyZQogICAgICAgICAiIiIKIAotICAgICAgICBpZiB3 ZWJraXRfY2FuYXJ5OgotICAgICAgICAgICAgcGxhdGZvcm0gKz0gJy1jYW5hcnknCi0KICAgICAg ICAgaWYgcGxhdGZvcm0gaW4gQVJDSElWRV9ESVJfTkFNRV9ESUNUOgogICAgICAgICAgICAgcmV0 dXJuIEFSQ0hJVkVfRElSX05BTUVfRElDVFtwbGF0Zm9ybV0KICAgICAgICAgZWxzZToKQEAgLTMw NSw4ICszMDgsMTMgQEAgY2xhc3MgUmViYXNlbGluZXIob2JqZWN0KToKICAgICAgICAgaWYgc2Vs Zi5fb3B0aW9ucy5mb3JjZV9hcmNoaXZlX3VybDoKICAgICAgICAgICAgIHJldHVybiBzZWxmLl9v cHRpb25zLmZvcmNlX2FyY2hpdmVfdXJsCiAKLSAgICAgICAgZGlyX25hbWUgPSBzZWxmLl9nZXRf YXJjaGl2ZV9kaXJfbmFtZShzZWxmLl9wbGF0Zm9ybSwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBzZWxmLl9vcHRpb25zLndlYmtpdF9jYW5hcnkpCisgICAg ICAgIHBsYXRmb3JtID0gc2VsZi5fcGxhdGZvcm0KKyAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy53 ZWJraXRfY2FuYXJ5OgorICAgICAgICAgICAgcGxhdGZvcm0gKz0gJy1jYW5hcnknCisgICAgICAg IGlmIHNlbGYuX29wdGlvbnMuZ3B1OgorICAgICAgICAgICAgcGxhdGZvcm0gPSAnZ3B1LScgKyBw bGF0Zm9ybQorCisgICAgICAgIGRpcl9uYW1lID0gc2VsZi5fZ2V0X2FyY2hpdmVfZGlyX25hbWUo cGxhdGZvcm0pCiAgICAgICAgIGlmIG5vdCBkaXJfbmFtZToKICAgICAgICAgICAgIHJldHVybiBO b25lCiAKQEAgLTYyMiw2ICs2MzAsNyBAQCBjbGFzcyBIdG1sR2VuZXJhdG9yKG9iamVjdCk6CiAg ICAgICAgIHNlbGYuX2h0bWxfZGlyZWN0b3J5ID0gb3B0aW9ucy5odG1sX2RpcmVjdG9yeQogICAg ICAgICBzZWxmLl9wb3J0ID0gcG9ydAogICAgICAgICBzZWxmLl90YXJnZXRfcG9ydCA9IHRhcmdl dF9wb3J0CisgICAgICAgIHNlbGYuX29wdGlvbnMgPSBvcHRpb25zCiAgICAgICAgIHNlbGYuX3Bs YXRmb3JtcyA9IHBsYXRmb3JtcwogICAgICAgICBzZWxmLl9yZWJhc2VsaW5pbmdfdGVzdHMgPSBy ZWJhc2VsaW5pbmdfdGVzdHMKICAgICAgICAgc2VsZi5fZmlsZXN5c3RlbSA9IHBvcnQuX2ZpbGVz eXN0ZW0KQEAgLTgwNCw4ICs4MTMsMTIgQEAgZGVmIHBhcnNlX29wdGlvbnMoYXJncyk6CiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGFjdGlvbj0nc3RvcmVfdHJ1ZScsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGhlbHA9J1N1cHByZXNzIHJlc3VsdCBIVE1MIHZpZXdpbmcnKQog CisgICAgb3B0aW9uX3BhcnNlci5hZGRfb3B0aW9uKCctZycsICctLWdwdScsCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgYWN0aW9uPSdzdG9yZV90cnVlJywgZGVmYXVsdD1GYWxzZSwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICBoZWxwPSdSZWJhc2VsaW5lIHRoZSBHUFUgdmVyc2lv bnMnKQorCiAgICAgb3B0aW9uX3BhcnNlci5hZGRfb3B0aW9uKCctcCcsICctLXBsYXRmb3Jtcycs Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRlZmF1bHQ9J21hYyx3aW4sd2luLXhwLHdp bi12aXN0YSxsaW51eCcsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRlZmF1bHQ9Tm9u ZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaGVscD0oJ0NvbW1hIGRlbGltaXRlZCBs aXN0IG9mIHBsYXRmb3JtcyAnCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICd0 aGF0IG5lZWQgcmViYXNlbGluaW5nLicpKQogCkBAIC04NDcsNiArODYwLDExIEBAIGRlZiBwYXJz ZV9vcHRpb25zKGFyZ3MpOgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnKCJt YWMiLCAiY2hyb21pdW0iLCAicXQiLCBldGMuKS4gRGVmYXVsdHMgJwogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAndG8gImNocm9taXVtIi4nKSkKICAgICBvcHRpb25zID0gb3B0 aW9uX3BhcnNlci5wYXJzZV9hcmdzKGFyZ3MpWzBdCisgICAgaWYgb3B0aW9ucy5wbGF0Zm9ybXMg PT0gTm9uZToKKyAgICAgICAgaWYgb3B0aW9ucy5ncHU6CisgICAgICAgICAgICBvcHRpb25zLnBs YXRmb3JtcyA9ICdtYWMsd2luLGxpbnV4JworICAgICAgICBlbHNlOgorICAgICAgICAgICAgb3B0 aW9ucy5wbGF0Zm9ybXMgPSAnbWFjLHdpbix3aW4teHAsd2luLXZpc3RhLGxpbnV4JwogCiAgICAg dGFyZ2V0X29wdGlvbnMgPSBjb3B5LmNvcHkob3B0aW9ucykKICAgICBpZiBvcHRpb25zLnRhcmdl dF9wbGF0Zm9ybSA9PSAnY2hyb21pdW0nOgpAQCAtODY5LDcgKzg4NywxMCBAQCBkZWYgbWFpbihh cmdzKToKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJyUobGV2ZWxuYW1lKXMgJSht ZXNzYWdlKXMnKSwKICAgICAgICAgICAgICAgICAgICAgICAgIGRhdGVmbXQ9JyV5JW0lZCAlSDol TTolUycpCiAKLSAgICB0YXJnZXRfcG9ydF9vYmogPSBwb3J0LmdldChOb25lLCB0YXJnZXRfb3B0 aW9ucykKKyAgICB0YXJnZXRfcG9ydF9uYW1lID0gTm9uZQorICAgIGlmIG9wdGlvbnMuZ3B1IGFu ZCBvcHRpb25zLnRhcmdldF9wbGF0Zm9ybSA9PSAnY2hyb21pdW0nOgorICAgICAgICB0YXJnZXRf cG9ydF9uYW1lID0gJ2Nocm9taXVtLWdwdScKKyAgICB0YXJnZXRfcG9ydF9vYmogPSBwb3J0Lmdl dCh0YXJnZXRfcG9ydF9uYW1lLCB0YXJnZXRfb3B0aW9ucykKICAgICBob3N0X3BvcnRfb2JqID0g Z2V0X2hvc3RfcG9ydF9vYmplY3Qob3B0aW9ucykKICAgICBpZiBub3QgaG9zdF9wb3J0X29iaiBv ciBub3QgdGFyZ2V0X3BvcnRfb2JqOgogICAgICAgICByZXR1cm4gMQo=