54998 2011-02-22 14:10:29 -0800 [Qt] check webkit style fails in qt/tests 2011-02-23 01:07:50 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gopal.1.raghavan webkit-unassigned commit-queue oldest_to_newest 355586 0 gopal.1.raghavan 2011-02-22 14:10:29 -0800 As part of bug 502222, I was getting this error. ------- failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/ChangeLog', u'Source/WebK..." exit_code: 1 Source/WebKit/qt/tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:1: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style. -- So I added a patch to 50222. Reviewer suggested to create a separate patch 355594 1 83386 gopal.1.raghavan 2011-02-22 14:15:33 -0800 Created attachment 83386 checker patch to fix style check errors related to qt/tests 355924 2 83386 commit-queue 2011-02-23 01:07:45 -0800 Comment on attachment 83386 checker patch to fix style check errors related to qt/tests Clearing flags on attachment: 83386 Committed r79419: <http://trac.webkit.org/changeset/79419> 355925 3 commit-queue 2011-02-23 01:07:50 -0800 All reviewed patches have been landed. Closing bug. 83386 2011-02-22 14:15:33 -0800 2011-02-23 01:07:45 -0800 checker patch to fix style check errors related to qt/tests checker.patch text/plain 1426 gopal.1.raghavan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc5MzI3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMTEtMDItMjIgIEdvcGFsIFJhZ2hhdmFuICA8Z29wYWwuMS5yYWdoYXZhbkBu b2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBbUXRdIGNoZWNrIHdlYmtpdCBzdHlsZSBmYWlscyBpbiBxdC90ZXN0cworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ5OTgKKworICAgICAg ICBjaGVjay13ZWJraXQtc3R5bGUgd2FzIGNvbXBsYWluaW5nIGFib3V0IG1pc3NpbmcgY29uZmln LmggaW4gV2ViS2l0L3F0L3Rlc3QvcWRlY2xhcmF0aXZld2Vidmlldy4gVGhpcyBwYXRjaCB3YXMg b3JpZ2luYWxseSBwYXJ0IG9mIDUwMjIyLiBSZXZpZXdlciBzdWdnZXN0ZWQgdG8gc3BsaXQgYW5k IGNyZWF0ZSBhIHNlcGFyYXRlIHBhdGNoIGZvciBjaGVja2VyLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5OgorCiAyMDExLTAyLTIyICBBZGFtIFJvYmVuICA8 YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBEb24ndCB0cmlnZ2VyIGEgV2luZG93cyBidWls ZCB3aGVuIHRoZSB0b3AtbGV2ZWwgQ2hhbmdlTG9nIGNoYW5nZXMKSW5kZXg6IFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkJKHJldmlzaW9uIDc5MDEzKQorKysgVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMjMsNyAr MTIzLDggQEAgX1BBVEhfUlVMRVNfU1BFQ0lGSUVSID0gWwogICAgICAgIyBUaGUgQVBJIHRlc3Qg aGFybmVzc2VzIGhhdmUgbm8gY29uZmlnLmggYW5kIHVzZSBmdW5ueSBtYWNyb3MgbGlrZQogICAg ICAgIyBURVNUX0NMQVNTX05BTUUuCiAgICAgICAiVG9vbHMvV2ViS2l0QVBJVGVzdC8iLAotICAg ICAgIlRvb2xzL1Rlc3RXZWJLaXRBUEkvIl0sCisgICAgICAiVG9vbHMvVGVzdFdlYktpdEFQSS8i LAorICAgICAgIlNvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcWRlY2xhcmF0aXZld2VidmlldyJdLAog ICAgICBbIi1idWlsZC9pbmNsdWRlIiwKICAgICAgICItcmVhZGFiaWxpdHkvbmFtaW5nIl0pLAog ICAgIChbIyBUaGUgRUZMIEFQSXMgdXNlIEVGTCBuYW1pbmcgc3R5bGUsIHdoaWNoIGluY2x1ZGVz Cg==