54996 2011-02-22 13:54:44 -0800 [Qt] [WK2] When the context menu is empty, we should still send the signal QWKPage::showContextMenu() 2011-02-23 01:11:40 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P4 Enhancement --- 1 benjamin benjamin commit-queue oldest_to_newest 355569 0 benjamin 2011-02-22 13:54:44 -0800 Currently, the signal QWKPage::showContextMenu() is sent only if the context menu is not empty. This can be a problem for users who want to extend the context menu because they get no notification in that case. The signal should be sent in any case, with an empty menu if necessary. 355598 1 83387 benjamin 2011-02-22 14:19:17 -0800 Created attachment 83387 Patch 355602 2 83387 kling 2011-02-22 14:22:55 -0800 Comment on attachment 83387 Patch Haia! 355929 3 83387 commit-queue 2011-02-23 01:11:35 -0800 Comment on attachment 83387 Patch Clearing flags on attachment: 83387 Committed r79421: <http://trac.webkit.org/changeset/79421> 355930 4 commit-queue 2011-02-23 01:11:40 -0800 All reviewed patches have been landed. Closing bug. 83387 2011-02-22 14:19:17 -0800 2011-02-23 01:11:35 -0800 Patch bug-54996-20110222232845.patch text/plain 2704 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogNzkzNTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAwMDFhODAwNjAwNDMzNTNm MGIwYzkzNzA2Y2YyYWYzOGM2Y2U5NzM5Li40ZDA5YTlmMTgwYTQyMjE0Yzc5MmJjMjU4MDI1ZDEy OWE5ZjgyNDRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMjIgIEJlbmph bWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFtXSzJdIFdoZW4gdGhlIGNv bnRleHQgbWVudSBpcyBlbXB0eSwgd2Ugc2hvdWxkIHN0aWxsIHNlbmQgdGhlIHNpZ25hbCBRV0tQ YWdlOjpzaG93Q29udGV4dE1lbnUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTQ5OTYKKworICAgICAgICBTZW5kIHRoZSBzaWduYWwgUVdLUGFnZTo6 c2hvd0NvbnRleHRNZW51KCkgd2l0aCBhbiBlbXB0eSBtZW51IGV2ZW4gaWYgdGhlIGNvbnRlbnQg bWVudSBnZW5lcmF0ZWQKKyAgICAgICAgaXMgZW1wdHkvY29udGFpbiBvbmx5IGRpc2FibGVkIGVs ZW1lbnRzLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuY3Bw OgorICAgICAgICAoUUdyYXBoaWNzV0tWaWV3OjpzaG93Q29udGV4dE1lbnUpOgorICAgICAgICAq IFVJUHJvY2Vzcy9xdC9XZWJDb250ZXh0TWVudVByb3h5UXQuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJDb250ZXh0TWVudVByb3h5UXQ6OnNob3dDb250ZXh0TWVudSk6CisKIDIwMTEtMDItMjIg IEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9xdC9xZ3JhcGhpY3N3a3ZpZXcuY3BwCmluZGV4IDk0OTdmNzBlY2I4ZWM2YzdiMTJjNmU2NTc1 ZTY1ZWYwYjZjMDFjY2QuLjk3MmVjYjEyZDMwN2RlODY0NWY3NmZjMDAwYTY1ZWZjYWExY2IxNzUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWdyYXBoaWNzd2t2 aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3dr dmlldy5jcHAKQEAgLTMzMyw2ICszMzMsOSBAQCB2b2lkIFFHcmFwaGljc1dLVmlldzo6c2hvd0Nv bnRleHRNZW51KFFTaGFyZWRQb2ludGVyPFFNZW51PiBtZW51KQogICAgIGlmIChkLT5hY3RpdmVN ZW51KQogICAgICAgICBkLT5hY3RpdmVNZW51LT5oaWRlKCk7CiAKKyAgICBpZiAobWVudS0+aXNF bXB0eSgpKQorICAgICAgICByZXR1cm47CisKICAgICBkLT5hY3RpdmVNZW51ID0gbWVudTsKIAog ICAgIFFXaWRnZXQqIHZpZXcgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL3F0L1dlYkNvbnRleHRNZW51UHJveHlRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvcXQvV2ViQ29udGV4dE1lbnVQcm94eVF0LmNwcAppbmRleCA4NjhlYWE5ZTUyNmY1M2QyNmVm NmMwMDM4ZjFjZjc1Y2U4ZDZiNjYyLi43NzdmOThjN2Y2YmFlNzdiNjhiYzdhNGFhNmZlYzEwOGQ1 ZTdmMjM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvV2ViQ29udGV4 dE1lbnVQcm94eVF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvV2ViQ29u dGV4dE1lbnVQcm94eVF0LmNwcApAQCAtODIsMTAgKzgyLDE1IEBAIFBhc3NSZWZQdHI8V2ViQ29u dGV4dE1lbnVQcm94eVF0PiBXZWJDb250ZXh0TWVudVByb3h5UXQ6OmNyZWF0ZShRV0tQYWdlKiBw YWdlKQogCiB2b2lkIFdlYkNvbnRleHRNZW51UHJveHlRdDo6c2hvd0NvbnRleHRNZW51KGNvbnN0 IEludFBvaW50JiBwb3NpdGlvbiwgY29uc3QgVmVjdG9yPFdlYkNvbnRleHRNZW51SXRlbURhdGE+ JiBpdGVtcykKIHsKLSAgICBpZiAoT3duUHRyPFFNZW51PiBtZW51ID0gY3JlYXRlQ29udGV4dE1l bnUoaXRlbXMpKSB7Ci0gICAgICAgIG1lbnUtPm1vdmUocG9zaXRpb24pOwotICAgICAgICBlbWl0 IG1fcGFnZS0+c2hvd0NvbnRleHRNZW51KFFTaGFyZWRQb2ludGVyPFFNZW51PihtZW51LmxlYWtQ dHIoKSkpOwotICAgIH0KKyAgICBPd25QdHI8UU1lbnU+IG1lbnUgPSBjcmVhdGVDb250ZXh0TWVu dShpdGVtcyk7CisKKyAgICAvLyBXZSBzZW5kIHRoZSBzaWduYWwsIGV2ZW4gd2l0aCBubyBpdGVt cywgYmVjYXVzZSB0aGUgY2xpZW50IHNob3VsZCBiZSBhYmxlIHRvIHNob3cgY3VzdG9tIGl0ZW1z CisgICAgLy8gZXZlbiBpZiBXZWJLaXQgaGFzIG5vdGhpbmcgdG8gc2hvdy4KKyAgICBpZiAoIW1l bnUpCisgICAgICAgIG1lbnUgPSBhZG9wdFB0cihuZXcgUU1lbnUpOworCisgICAgbWVudS0+bW92 ZShwb3NpdGlvbik7CisgICAgZW1pdCBtX3BhZ2UtPnNob3dDb250ZXh0TWVudShRU2hhcmVkUG9p bnRlcjxRTWVudT4obWVudS5sZWFrUHRyKCkpKTsKIH0KIAogdm9pZCBXZWJDb250ZXh0TWVudVBy b3h5UXQ6OmhpZGVDb250ZXh0TWVudSgpCg==