54990 2011-02-22 12:59:27 -0800 [GTK] fast/frames/iframe-scale-applied-twice.html fails after r79167 2011-02-22 14:40:11 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned mitz oldest_to_newest 355532 0 mrobinson 2011-02-22 12:59:27 -0800 r79167 modified ScrollView::visibleContentsRect and we must update the forked version we use for the GTK+ port. 355536 1 mrobinson 2011-02-22 13:03:20 -0800 Link to the changeset that broke the test: http://trac.webkit.org/changeset/79167 355538 2 83373 mrobinson 2011-02-22 13:04:47 -0800 Created attachment 83373 Patch 355539 3 83373 xan.lopez 2011-02-22 13:06:04 -0800 Comment on attachment 83373 Patch OK. 355540 4 mrobinson 2011-02-22 13:06:48 -0800 Committed r79350: <http://trac.webkit.org/changeset/79350> 355601 5 mitz 2011-02-22 14:20:02 -0800 Apologies for the breakage, and thanks for fixing this! 355621 6 mrobinson 2011-02-22 14:40:11 -0800 (In reply to comment #5) > Apologies for the breakage, and thanks for fixing this! No problem! Eventually, when I have more time I'd like to figure out a way to share this code with everyone. 83373 2011-02-22 13:04:47 -0800 2011-02-22 13:07:40 -0800 Patch bug-54990-20110222130444.patch text/plain 2107 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogNzkzNDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxMmYwNWExZWMwZjMyZTY3 ZTBlYzU0ZGU4NDY4ZjRiODZkYjFmMzBjLi5jZGE3ODk1MzFlNmZlZmJkOWJlMzBjN2E4NDI2NzM0 OGNkNmFiMGZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDItMjIgIE1hcnRp biBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIGZhc3QvZnJhbWVzL2lmcmFtZS1zY2Fs ZS1hcHBsaWVkLXR3aWNlLmh0bWwgZmFpbHMgYWZ0ZXIgcjc5MTY3CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDk5MAorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4gVGhpcyB3aWxsIGNhdXNlIGZhc3QvZXZlbnRzL3Njcm9sbC1hZnRlci1jbGljay1vbi10 YWItaW5kZXguaHRtbAorICAgICAgICB0byBzdGFydCBwYXNzaW5nIGFnYWluLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3RrL1Njcm9sbFZpZXdHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Ny b2xsVmlldzo6dmlzaWJsZUNvbnRlbnRSZWN0KTogVXBkYXRlIHRoaXMgbWV0aG9kIHRvIG1hdGNo IHRoZSBvcmlnaW5hbAorICAgICAgICBpbiB0aGUgcGFyZW50IGNsYXNzLgorCiAyMDExLTAxLTE3 ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBYYW4gTG9wZXouCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvU2Nyb2xsVmlld0d0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xs Vmlld0d0ay5jcHAKaW5kZXggZDNhNTI3ODc3NjgzMTk1MjY5M2E3ODgxNTU2NjFmMzg4MTcwOTFk Ni4uYzVmMzJmMzg4ZTU1NzQ5OGIxNzM0ZTdlMjAwYzBlMzdhMWE3NDU5OSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbFZpZXdHdGsuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxWaWV3R3RrLmNwcApAQCAtMTY5LDggKzE2OSw4 IEBAIEludFJlY3QgU2Nyb2xsVmlldzo6dmlzaWJsZUNvbnRlbnRSZWN0KGJvb2wgaW5jbHVkZVNj cm9sbGJhcnMpIGNvbnN0CiAgICAgLy8gc2Nyb2xsYmFyIHdpZHRoIHNob3VsZCBiZS4KICAgICBp ZiAocGFyZW50KCkgfHwgIWhvc3RXaW5kb3coKSB8fCAhaG9zdFdpbmRvdygpLT5wbGF0Zm9ybVBh Z2VDbGllbnQoKSkgewogICAgICAgICByZXR1cm4gSW50UmVjdChJbnRQb2ludChtX3Njcm9sbE9m ZnNldC53aWR0aCgpLCBtX3Njcm9sbE9mZnNldC5oZWlnaHQoKSksCi0gICAgICAgICAgICAgICAg ICAgICAgIEludFNpemUobWF4KDAsIHdpZHRoKCkgLSAodmVydGljYWxTY3JvbGxiYXIoKSAmJiAh aW5jbHVkZVNjcm9sbGJhcnMgPyB2ZXJ0aWNhbFNjcm9sbGJhcigpLT53aWR0aCgpIDogMCkpLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1heCgwLCBoZWlnaHQoKSAtIChob3Jpem9u dGFsU2Nyb2xsYmFyKCkgJiYgIWluY2x1ZGVTY3JvbGxiYXJzID8gaG9yaXpvbnRhbFNjcm9sbGJh cigpLT5oZWlnaHQoKSA6IDApKSkpOworICAgICAgICAgICAgICAgICAgICAgICBJbnRTaXplKG1h eCgwLCBtX2JvdW5kc1NpemUud2lkdGgoKSAtICh2ZXJ0aWNhbFNjcm9sbGJhcigpICYmICFpbmNs dWRlU2Nyb2xsYmFycyA/IHZlcnRpY2FsU2Nyb2xsYmFyKCktPndpZHRoKCkgOiAwKSksCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgbWF4KDAsIG1fYm91bmRzU2l6ZS5oZWlnaHQoKSAt IChob3Jpem9udGFsU2Nyb2xsYmFyKCkgJiYgIWluY2x1ZGVTY3JvbGxiYXJzID8gaG9yaXpvbnRh bFNjcm9sbGJhcigpLT5oZWlnaHQoKSA6IDApKSkpOwogICAgIH0KIAogICAgIC8vIFdlIGRvbid0 IGhhdmUgYSBwYXJlbnQsIHNvIHdlIGFyZSB0aGUgbWFpbiBmcmFtZSBhbmQgdGh1cyBoYXZlCg==