54976 2011-02-22 11:28:39 -0800 Incorrect switch-case fall-through inside InspectorClientQt.cpp 2011-02-28 14:04:08 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED P2 Trivial --- 0 fabrizio.machado webkit-unassigned ademar commit-queue suresh.voruganti oldest_to_newest 355434 0 fabrizio.machado 2011-02-22 11:28:39 -0800 In function variantToSetting(), code falls through to next case if qvariant.type() is QVariant::Bool. This does not make sense since the QVariant::Bool case sets QString retval to "true" or "false". Falling through and executing the block under QVariant::String case would overwrite this value. The correct behavior is to break from the switch. 355441 1 83353 fabrizio.machado 2011-02-22 11:34:39 -0800 Created attachment 83353 Don't fall through case in variantToSetting() if qvariant.type() is Bool 355705 2 83353 laszlo.gombos 2011-02-22 16:57:38 -0800 Comment on attachment 83353 Don't fall through case in variantToSetting() if qvariant.type() is Bool r=me. 355899 3 83353 commit-queue 2011-02-22 23:14:10 -0800 Comment on attachment 83353 Don't fall through case in variantToSetting() if qvariant.type() is Bool Clearing flags on attachment: 83353 Committed r79412: <http://trac.webkit.org/changeset/79412> 355900 4 commit-queue 2011-02-22 23:14:15 -0800 All reviewed patches have been landed. Closing bug. 359049 5 suresh.voruganti 2011-02-28 07:48:30 -0800 Please cherry pick the fixes to Qtwebkit 2.1.x 359330 6 ademar 2011-02-28 14:04:02 -0800 Revision r79412 cherry-picked into qtwebkit-2.1.x with commit 677fa11 <http://gitorious.org/webkit/qtwebkit/commit/677fa11> 83353 2011-02-22 11:34:39 -0800 2011-02-22 23:14:10 -0800 Don't fall through case in variantToSetting() if qvariant.type() is Bool 54976.patch text/plain 1227 fabrizio.machado SW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCShyZXZpc2lvbiA3OTM0MCkKKysrIFNvdXJjZS9XZWJLaXQvcXQv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDItMjIgIEZh YnJpemlvIE1hY2hhZG8gIDxmYWJyaXppby5tYWNoYWRvQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIERvbid0IGZhbGwgdGhy b3VnaCBjYXNlIGluIHZhcmlhbnRUb1NldHRpbmcoKSBpZiBxdmFyaWFudC50eXBlKCkgaXMgQm9v bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ5NzYK KworICAgICAgICBUZXN0IG5vdCBuZWVkZWQuCisgICAgICAgIAorICAgICAgICAqIFdlYkNvcmVT dXBwb3J0L0luc3BlY3RvckNsaWVudFF0LmNwcDoKKwogMjAxMS0wMi0yMiAgQW5kcmFzIEJlY3Np ICA8YWJlY3NpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTGFzemxvIEdvbWJv cy4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50 UXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvSW5z cGVjdG9yQ2xpZW50UXQuY3BwCShyZXZpc2lvbiA3ODg1MSkKKysrIFNvdXJjZS9XZWJLaXQvcXQv V2ViQ29yZVN1cHBvcnQvSW5zcGVjdG9yQ2xpZW50UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x NTIsOCArMTUyLDEwIEBAIHByaXZhdGU6CiAgICAgICAgIHN3aXRjaCAocXZhcmlhbnQudHlwZSgp KSB7CiAgICAgICAgIGNhc2UgUVZhcmlhbnQ6OkJvb2w6CiAgICAgICAgICAgICByZXRWYWwgPSBx dmFyaWFudC50b0Jvb2woKSA/ICJ0cnVlIiA6ICJmYWxzZSI7CisgICAgICAgICAgICBicmVhazsK ICAgICAgICAgY2FzZSBRVmFyaWFudDo6U3RyaW5nOgogICAgICAgICAgICAgcmV0VmFsID0gcXZh cmlhbnQudG9TdHJpbmcoKTsKKyAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBkZWZhdWx0Ogog ICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0K