54953 2011-02-22 06:31:01 -0800 Web Inspector: Linking error for some InspectorController symbols 2011-02-23 08:38:25 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dinu.jacob dinu.jacob apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 355225 0 dinu.jacob 2011-02-22 06:31:01 -0800 Linking fails when building webkit with JAVASCRIPT_DEBUGGER disabled with the following undefined symbols: WebCore::InspectorController::setInspectorExtensionAPI(WTF::String const&) WebCore::InspectorController::dispatchMessageFromFrontend(WTF::String const&) In InspectorController.cpp, the following methods have been incorrectly defined under #if ENABLE(JAVASCRIPT_DEBUGGER): setInspectorExtensionAPI(const String& source) hideHighlight() dispatchMessageFromFrontend(const String& message) 355226 1 dinu.jacob 2011-02-22 06:31:20 -0800 Patch coming 355257 2 83312 dinu.jacob 2011-02-22 07:39:08 -0800 Created attachment 83312 Patch 355835 3 83312 commit-queue 2011-02-22 21:32:14 -0800 Comment on attachment 83312 Patch Rejecting attachment 83312 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2 Last 500 characters of output: " exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/inspector/InspectorController.cpp Hunk #1 FAILED at 244. Hunk #2 succeeded at 268 with fuzz 1 (offset 1 line). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/inspector/InspectorController.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Yury Semikhatsky', u'-..." exit_code: 1 Full output: http://queues.webkit.org/results/7984006 356077 4 dinu.jacob 2011-02-23 08:01:12 -0800 Changes to fix the linking errors were committed in changeset http://trac.webkit.org/changeset/79394 (https://bugs.webkit.org/show_bug.cgi?id=54743). The patch itself was committed after this patch was committed (and hence, didn't see it when submitting this patch, though the bug itself didn't come up in my search :( ). However, one method is still incorrectly under JAVASCRIPT_DEBUGGER flag. This is currently not causing an error as it is not being invoked. Attached a patch to correct this. 356078 5 83482 dinu.jacob 2011-02-23 08:01:56 -0800 Created attachment 83482 Patch 356084 6 83482 pfeldman 2011-02-23 08:14:31 -0800 Comment on attachment 83482 Patch Thanks for fixing this. 356101 7 commit-queue 2011-02-23 08:36:43 -0800 The commit-queue encountered the following flaky tests while processing attachment 83482: animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. 356103 8 83482 commit-queue 2011-02-23 08:38:20 -0800 Comment on attachment 83482 Patch Clearing flags on attachment: 83482 Committed r79449: <http://trac.webkit.org/changeset/79449> 356104 9 commit-queue 2011-02-23 08:38:25 -0800 All reviewed patches have been landed. Closing bug. 83312 2011-02-22 07:39:08 -0800 2011-02-23 08:01:56 -0800 Patch 54953.patch text/plain 1849 dinu.jacob SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5MzIyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMjIgIEphY29iIERp bnUgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBMaW5raW5nIGVycm9yIGZvciBzb21l IEluc3BlY3RvckNvbnRyb2xsZXIgc3ltYm9scworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ5NTMKKworICAgICAgICBNb3ZlZCBvdXQgbWV0aG9kcyB0 aGF0IHdlcmUgaW5jb3JyZWN0bHkgZGVmaW5lZCB1bmRlciBKQVZBU0NSSVBUX0RFQlVHR0VSIGZs YWcgCisgICAgICAgIAorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6OnNldEluc3BlY3RvckV4 dGVuc2lvbkFQSSk6CisKIDIwMTEtMDItMjIgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCShy ZXZpc2lvbiA3OTMxNykKKysrIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250 cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQ0LDE3ICsyNDQsMTkgQEAgYm9vbCBJbnNw ZWN0b3JDb250cm9sbGVyOjppc1JlY29yZGluZ1VzZQogICAgIHJldHVybiBtX2luc3BlY3RvckFn ZW50LT5pc1JlY29yZGluZ1VzZXJJbml0aWF0ZWRQcm9maWxlKCk7CiB9CiAKLXZvaWQgSW5zcGVj dG9yQ29udHJvbGxlcjo6c2V0SW5zcGVjdG9yRXh0ZW5zaW9uQVBJKGNvbnN0IFN0cmluZyYgc291 cmNlKQotewotICAgIG1faW5zcGVjdG9yQWdlbnQtPnNldEluc3BlY3RvckV4dGVuc2lvbkFQSShz b3VyY2UpOwotfQotCiB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OnJlc3VtZSgpCiB7CiAgICAg aWYgKEluc3BlY3RvckRlYnVnZ2VyQWdlbnQqIGRlYnVnZ2VyQWdlbnQgPSBtX2luc3BlY3RvckFn ZW50LT5kZWJ1Z2dlckFnZW50KCkpCiAgICAgICAgIGRlYnVnZ2VyQWdlbnQtPnJlc3VtZSgpOwog fQogCisjZW5kaWYKKwordm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjpzZXRJbnNwZWN0b3JFeHRl bnNpb25BUEkoY29uc3QgU3RyaW5nJiBzb3VyY2UpCit7CisgICAgbV9pbnNwZWN0b3JBZ2VudC0+ c2V0SW5zcGVjdG9yRXh0ZW5zaW9uQVBJKHNvdXJjZSk7Cit9CisKIHZvaWQgSW5zcGVjdG9yQ29u dHJvbGxlcjo6aGlkZUhpZ2hsaWdodCgpCiB7CiAgICAgbV9pbnNwZWN0b3JBZ2VudC0+aGlkZUhp Z2hsaWdodCgpOwpAQCAtMjY1LDggKzI2Nyw2IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6 ZGlzcGF0Y2hNZXNzYWcKICAgICBtX2luc3BlY3RvckJhY2tlbmREaXNwYXRjaGVyLT5kaXNwYXRj aChtZXNzYWdlKTsKIH0KIAotI2VuZGlmCi0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2Vu ZGlmIC8vIEVOQUJMRShJTlNQRUNUT1IpCg== 83482 2011-02-23 08:01:56 -0800 2011-02-23 08:38:20 -0800 Patch 54953.patch text/plain 1534 dinu.jacob SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5NDQxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMjMgIEphY29iIERp bnUgIDxkaW51LmphY29iQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBMaW5raW5nIGVycm9yIGZvciBzb21l IEluc3BlY3RvckNvbnRyb2xsZXIgc3ltYm9scworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ5NTMKKworICAgICAgICBNb3ZlZCBvdXQgaGlkZUhpZ2hs aWdodCBkZWZpbml0aW9uIGZyb20gdW5kZXIgSkFWQVNDUklQVF9ERUJVR0dFUiBmbGFnIAorCisg ICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SW5zcGVjdG9yQ29udHJvbGxlcjo6aGlkZUhpZ2hsaWdodCk6CisgICAgICAgIChXZWJD b3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjpyZXN1bWUpOgorCiAyMDExLTAyLTIzICBQYXRyaWNr IEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFs ZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yQ29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiA3OTQzOSkKKysrIFNvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MjAzLDYgKzIwMywxMSBAQCB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OmRpc3BhdGNoTWVzc2Fn CiAgICAgbV9pbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlci0+ZGlzcGF0Y2gobWVzc2FnZSk7CiB9 CiAKK3ZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6aGlkZUhpZ2hsaWdodCgpCit7CisgICAgbV9p bnNwZWN0b3JBZ2VudC0+aGlkZUhpZ2hsaWdodCgpOworfQorCiAjaWYgRU5BQkxFKEpBVkFTQ1JJ UFRfREVCVUdHRVIpCiB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OmVuYWJsZVByb2ZpbGVyKCkK IHsKQEAgLTI2MSwxMSArMjY2LDYgQEAgdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjpyZXN1bWUo KQogICAgICAgICBkZWJ1Z2dlckFnZW50LT5yZXN1bWUoKTsKIH0KIAotdm9pZCBJbnNwZWN0b3JD b250cm9sbGVyOjpoaWRlSGlnaGxpZ2h0KCkKLXsKLSAgICBtX2luc3BlY3RvckFnZW50LT5oaWRl SGlnaGxpZ2h0KCk7Ci19Ci0KICNlbmRpZgogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==