54952 2011-02-22 06:18:44 -0800 Cleaning: remove a overzealous check for the pointer "files" from Chrome::setToolTip() 2011-02-22 06:50:12 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED EasyFix P5 Enhancement --- 1 benjamin benjamin ap commit-queue oldest_to_newest 355220 0 benjamin 2011-02-22 06:18:44 -0800 In the following code if (input->isFileUpload()) { FileList* files = input->files(); unsigned listSize = files->length(); if (files && listSize > 1) { The pointer "files" always exists if isFileUpload(). Moreover, the check is done after deferencing the pointer anyway. Fix that :) 355222 1 83305 benjamin 2011-02-22 06:22:19 -0800 Created attachment 83305 Patch 355232 2 83305 commit-queue 2011-02-22 06:50:07 -0800 Comment on attachment 83305 Patch Clearing flags on attachment: 83305 Committed r79317: <http://trac.webkit.org/changeset/79317> 355233 3 commit-queue 2011-02-22 06:50:12 -0800 All reviewed patches have been landed. Closing bug. 83305 2011-02-22 06:22:19 -0800 2011-02-22 06:50:07 -0800 Patch bug-54952-20110222153146.patch text/plain 1587 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogNzkzMDEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMzE4NGNlNWQ4M2ZkZTA5 YTUxY2MzNzlhMGZjNzQ4MjFhYzdiN2VkLi4wYjU4NmY5Y2ZhZDA3NzEzMGUyOWYwYTNiY2JiMGEy MGYyZGVmZjcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMjIgIEJlbmph bWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhbmluZzogcmVtb3ZlIGEgb3Zl cnplYWxvdXMgY2hlY2sgZm9yIHRoZSBwb2ludGVyICJmaWxlcyIgZnJvbSBDaHJvbWU6OnNldFRv b2xUaXAoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NTQ5NTIKKworICAgICAgICBSZW1vdmUgdGhlIHVubmVjZXNzYXJ5IGNvbmRpdGlvbiBmcm9tIHRo ZSBpZigpLCBIVE1MSW5wdXRFbGVtZW50OjpmaWxlcygpIGFsd2F5cyByZXR1cm4KKyAgICAgICAg YSB2YWxpZCByZWZlcmVuY2UgZm9yIHRoZSBpbnB1dCB0eXBlIEZpbGVJbnB1dFR5cGUuIAorCisg ICAgICAgICogcGFnZS9DaHJvbWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2hyb21lOjpzZXRU b29sVGlwKToKKwogMjAxMS0wMi0yMiAgU3RldmUgTGFjZXkgIDxzamxAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvQ2hyb21lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lLmNwcApp bmRleCAwOGJmMWMzZWQ5MzczNTUwYzdjMTg0Mjk0MTdlMzU4MjM2NDQ1Nzg2Li4yNmVhMzNiYjlk OTlhMDAwYjRkNDU5ZWM0YmNiZDZhODY4ZjUzYmM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0Nocm9tZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9DaHJvbWUuY3BwCkBA IC0zOTgsNyArMzk4LDcgQEAgdm9pZCBDaHJvbWU6OnNldFRvb2xUaXAoY29uc3QgSGl0VGVzdFJl c3VsdCYgcmVzdWx0KQogICAgICAgICAgICAgICAgIGlmIChpbnB1dC0+aXNGaWxlVXBsb2FkKCkp IHsKICAgICAgICAgICAgICAgICAgICAgRmlsZUxpc3QqIGZpbGVzID0gaW5wdXQtPmZpbGVzKCk7 CiAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxpc3RTaXplID0gZmlsZXMtPmxlbmd0aCgp OwotICAgICAgICAgICAgICAgICAgICBpZiAoZmlsZXMgJiYgbGlzdFNpemUgPiAxKSB7CisgICAg ICAgICAgICAgICAgICAgIGlmIChsaXN0U2l6ZSA+IDEpIHsKICAgICAgICAgICAgICAgICAgICAg ICAgIFZlY3RvcjxVQ2hhcj4gbmFtZXM7CiAgICAgICAgICAgICAgICAgICAgICAgICBmb3IgKHNp emVfdCBpID0gMDsgaSA8IGxpc3RTaXplOyArK2kpIHsKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBhcHBlbmQobmFtZXMsIGZpbGVzLT5pdGVtKGkpLT5maWxlTmFtZSgpKTsK