54947 2011-02-22 04:09:57 -0800 Web Inspector: [REGRESSION] navigation does not work when inspector is opened 2011-02-22 12:15:38 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov podivilov abecsi apavlov bweinstein joepeck keishi loislo ossy pfeldman pmuellr rik timothy yurys oldest_to_newest 355170 0 podivilov 2011-02-22 04:09:57 -0800 Navigation hangs when inspector is opened. 355181 1 83300 podivilov 2011-02-22 04:41:01 -0800 Created attachment 83300 Patch. 355212 2 83300 pfeldman 2011-02-22 06:03:07 -0800 Comment on attachment 83300 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=83300&action=review > Source/WebCore/inspector/InspectorState.cpp:50 > if (!m_properties) else? (otherwise properties from the old instance will stay). 355242 3 podivilov 2011-02-22 07:09:40 -0800 Committed r79319: <http://trac.webkit.org/changeset/79319> 355357 4 ossy 2011-02-22 10:04:16 -0800 (In reply to comment #3) > Committed r79319: <http://trac.webkit.org/changeset/79319> It broke ~90 tests on Qt bot. :( Have you got any idea why? 355465 5 pfeldman 2011-02-22 12:02:38 -0800 (In reply to comment #4) > (In reply to comment #3) > > Committed r79319: <http://trac.webkit.org/changeset/79319> > > It broke ~90 tests on Qt bot. :( Have you got any idea why? It does not seem to change anything wrt Qt. I'll investigate a bit more. 355469 6 pfeldman 2011-02-22 12:04:45 -0800 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > Committed r79319: <http://trac.webkit.org/changeset/79319> > > > > It broke ~90 tests on Qt bot. :( Have you got any idea why? > > It does not seem to change anything wrt Qt. I'll investigate a bit more. Need a Qt build, will do tomorrow. In the meanwhile, we can either roll out or Skipp qt. I prefer the latter since it fixes a nasty problem. 355474 7 ossy 2011-02-22 12:07:11 -0800 I tried to roll out locally, but it didn't solve the problem. And then I tried http://trac.webkit.org/changeset/79319 and it works for me. It seems http://trac.webkit.org/changeset/79320 broke inspector tests somehow. 355479 8 pfeldman 2011-02-22 12:11:04 -0800 (In reply to comment #7) > I tried to roll out locally, but it didn't solve the problem. And then I > tried http://trac.webkit.org/changeset/79319 and it works for me. It seems > http://trac.webkit.org/changeset/79320 broke inspector tests somehow. Oh, ok. That would explain it. The symptoms point to missing front-end. Is it deployed? 355480 9 ossy 2011-02-22 12:13:19 -0800 Andras, it seems your patch broke the inspector tests. Could you check it, please? 355483 10 pfeldman 2011-02-22 12:15:38 -0800 (In reply to comment #9) > Andras, it seems your patch broke the inspector tests. Could you check it, please? Front-end uses generated file: INSPECTOR_BACKEND_STUB_QRC = inspector/front-end/InspectorBackendStub.qrc Is this line missing in the new project file? 83300 2011-02-22 04:41:01 -0800 2011-02-22 06:03:07 -0800 Patch. patch text/plain 2835 podivilov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMzE4NGNlLi41ZTJjNjcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTEtMDItMjIgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIElu c3BlY3RvcjogW1JFR1JFU1NJT05dIG5hdmlnYXRpb24gZG9lcyBub3Qgd29yayB3aGVuIGluc3Bl Y3RvciBpcyBvcGVuZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01NDk0NworCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckFnZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckFnZW50OjpyZXN0b3JlSW5zcGVjdG9yU3RhdGVG cm9tQ29va2llKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yU3RhdGUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yU3RhdGU6OmxvYWRGcm9tQ29va2llKToKKyAgICAgICAg KiBpbnNwZWN0b3IvSW5zcGVjdG9yU3RhdGUuaDoKKwogMjAxMS0wMi0yMiAgU3RldmUgTGFjZXkg IDxzamxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JBZ2VudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQWdlbnQuY3BwCmluZGV4IDM2OTM4 NDQuLmY5YWQ2YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckFnZW50 LmNwcApAQCAtMTk3LDcgKzE5Nyw3IEBAIGJvb2wgSW5zcGVjdG9yQWdlbnQ6OnNlYXJjaGluZ0Zv ck5vZGVJblBhZ2UoKSBjb25zdAogCiB2b2lkIEluc3BlY3RvckFnZW50OjpyZXN0b3JlSW5zcGVj dG9yU3RhdGVGcm9tQ29va2llKGNvbnN0IFN0cmluZyYgaW5zcGVjdG9yU3RhdGVDb29raWUpCiB7 Ci0gICAgbV9zdGF0ZSA9IG5ldyBJbnNwZWN0b3JTdGF0ZShtX2NsaWVudCwgaW5zcGVjdG9yU3Rh dGVDb29raWUpOworICAgIG1fc3RhdGUtPmxvYWRGcm9tQ29va2llKGluc3BlY3RvclN0YXRlQ29v a2llKTsKIAogICAgIG1fZnJvbnRlbmQtPmZyb250ZW5kUmV1c2VkKCk7CiAgICAgbV9mcm9udGVu ZC0+aW5zcGVjdGVkVVJMQ2hhbmdlZChpbnNwZWN0ZWRVUkwoKS5zdHJpbmcoKSk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3RhdGUuY3BwIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0YXRlLmNwcAppbmRleCA4OTc3MjRlLi40ZmIx MjkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3RhdGUu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdGF0ZS5jcHAKQEAg LTQyLDE0ICs0MiwxMSBAQCBJbnNwZWN0b3JTdGF0ZTo6SW5zcGVjdG9yU3RhdGUoSW5zcGVjdG9y Q2xpZW50KiBjbGllbnQpCiB7CiB9CiAKLUluc3BlY3RvclN0YXRlOjpJbnNwZWN0b3JTdGF0ZShJ bnNwZWN0b3JDbGllbnQqIGNsaWVudCwgY29uc3QgU3RyaW5nJiBqc29uKQotICAgIDogbV9jbGll bnQoY2xpZW50KQotICAgICwgbV9wcm9wZXJ0aWVzKEluc3BlY3Rvck9iamVjdDo6Y3JlYXRlKCkp Ci0gICAgLCBtX2lzT25NdXRlKGZhbHNlKQordm9pZCBJbnNwZWN0b3JTdGF0ZTo6bG9hZEZyb21D b29raWUoY29uc3QgU3RyaW5nJiBpbnNwZWN0b3JTdGF0ZUNvb2tpZSkKIHsKLSAgICBSZWZQdHI8 SW5zcGVjdG9yVmFsdWU+IGpzb25WYWx1ZSA9IEluc3BlY3RvclZhbHVlOjpwYXJzZUpTT04oanNv bik7Ci0gICAgaWYgKGpzb25WYWx1ZSkKLSAgICAgICAgbV9wcm9wZXJ0aWVzID0ganNvblZhbHVl LT5hc09iamVjdCgpOworICAgIFJlZlB0cjxJbnNwZWN0b3JWYWx1ZT4gY29va2llID0gSW5zcGVj dG9yVmFsdWU6OnBhcnNlSlNPTihpbnNwZWN0b3JTdGF0ZUNvb2tpZSk7CisgICAgaWYgKGNvb2tp ZSkKKyAgICAgICAgbV9wcm9wZXJ0aWVzID0gY29va2llLT5hc09iamVjdCgpOwogICAgIGlmICgh bV9wcm9wZXJ0aWVzKQogICAgICAgICBtX3Byb3BlcnRpZXMgPSBJbnNwZWN0b3JPYmplY3Q6OmNy ZWF0ZSgpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv clN0YXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3RhdGUuaAppbmRl eCAxY2FlOWFkLi40NDA3YzQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yU3RhdGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y U3RhdGUuaApAQCAtNDYsOSArNDYsMTAgQEAgY2xhc3MgSW5zcGVjdG9yQ2xpZW50OwogY2xhc3Mg SW5zcGVjdG9yU3RhdGUgewogcHVibGljOgogICAgIEluc3BlY3RvclN0YXRlKEluc3BlY3RvckNs aWVudCopOwotICAgIEluc3BlY3RvclN0YXRlKEluc3BlY3RvckNsaWVudCosIGNvbnN0IFN0cmlu ZyYganNvblN0cmluZyk7CiAgICAgdmlydHVhbCB+SW5zcGVjdG9yU3RhdGUoKSB7fQogCisgICAg dm9pZCBsb2FkRnJvbUNvb2tpZShjb25zdCBTdHJpbmcmIGluc3BlY3RvclN0YXRlQ29va2llKTsK KwogICAgIHZvaWQgbXV0ZSgpOwogICAgIHZvaWQgdW5tdXRlKCk7CiAK