54925 2011-02-21 18:54:49 -0800 nrwt: revert behavior on 10.5 to "old-threads" 2022-02-27 23:45:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth atwilson jamesr ojan rniwa tony oldest_to_newest 354977 0 dpranke 2011-02-21 18:54:49 -0800 nrwt: revert behavior on 10.5 to "old-threads" 354979 1 83255 dpranke 2011-02-21 19:01:48 -0800 Created attachment 83255 Patch 354982 2 dpranke 2011-02-21 19:06:38 -0800 Someone wanna rubber-stamp this partial revert of r79062 ? http://trac.webkit.org/changeset/79062 I can't explain why we'd see increased flakiness on 10.5, since we're still only running one DRT at a time, just in a different code path. I'm curious to see if changing things back to the old method does remove the flakiness and timeouts. 10.6 should be unaffected by this patch and continue to run in parallel processes by default. 354985 3 83255 tkent 2011-02-21 19:18:00 -0800 Comment on attachment 83255 Patch Though I'm not so familiar with NRWT code, it's ok to do partial revert. 354991 4 dpranke 2011-02-21 19:31:46 -0800 Committed r79279: <http://trac.webkit.org/changeset/79279> 83255 2011-02-21 19:01:48 -0800 2022-02-27 23:45:12 -0800 Patch bug-54925-20110221190147.patch text/plain 5244 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogNzkyNjEKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxYjAzYjdkOTQ0OTI4ODg1Mzc5YmJkZTU4NWU3OTczNDFm YzY3OTQ1Li41YTdiZjBjM2ExYjNmMzhmOTA0MzFlYjQ3MTZhMzMwYTlkZmU4ZjA0IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTEtMDItMjEgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbnJ3dDogcmV2ZXJ0 IGJlaGF2aW9yIG9uIDEwLjUgdG8gIm9sZC10aHJlYWRzIi4gSXQncyBwb3NzaWJsZQorICAgICAg ICB0aGF0IHI3OTA2MiBoYXMgaW50cm9kdWNlZCBhIGJ1bmNoIG9mIGZsYWtpbmVzcywgYWx0aG91 Z2ggSQorICAgICAgICBjYW4ndCBleHBsYWluIHdoeSByaWdodCBub3cuIFRoaXMgY2hhbmdlIHNo b3VsZCByZXN0b3JlIHRoZQorICAgICAgICBvbGQgYmVoYXZpb3IsIGFuZCB0aGVuIHdlIGNhbiBs b29rIGF0IHRoZSBidWlsZCBsb2dzIHRvIHNlZQorICAgICAgICBpZiB0aGUgdGVzdHMgc3RvcCB0 aW1pbmcgb3V0IG9yIGJlaW5nIGZsYWt5LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01NDkyNQorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWNfdW5pdHRlc3QucHk6CisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWMucHk6CisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWNfdW5pdHRlc3QucHk6CisKKzIw MTEtMDItMjEgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAg UmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgogCiAgICAgICAgIG5yd3Q6IGZpeCB0eXBvIGNh dXNpbmcgdXMgdG8gdHJ5IGFuZCByZXBlYXRlZGx5IHNodXQgZG93biB0aGUgc2VydmVycwpkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1 bV9tYWMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9t aXVtX21hYy5weQppbmRleCA2ZDY4NTQ2MWVmNGZhMzFiMTg4OTUyMThmOTE2ZTg0ZWIwOTYxY2Rh Li43YjhhOTRmMzAzZTIwZGZiM2I5YWE4ZGVhOWMxNTUyZDEzMGUzZDIwIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX21hYy5weQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX21h Yy5weQpAQCAtMTA1LDEwICsxMDUsMjIgQEAgY2xhc3MgQ2hyb21pdW1NYWNQb3J0KGNocm9taXVt LkNocm9taXVtUG9ydCk6CiAgICAgICAgICAgICAgICAgICAgICAgICdNYWNCdWlsZEluc3RydWN0 aW9ucycpCiAgICAgICAgIHJldHVybiByZXN1bHQKIAorICAgIGRlZiBkZWZhdWx0X2NoaWxkX3By b2Nlc3NlcyhzZWxmKToKKyAgICAgICAgaWYgc2VsZi5nZXRfb3B0aW9uKCd3b3JrZXJfbW9kZWwn KSA9PSAnb2xkLXRocmVhZHMnOgorICAgICAgICAgICAgIyBGSVhNRTogd2UgbmVlZCB0byBydW4g c2luZ2xlLXRocmVhZGVkIGZvciBub3cuIFNlZQorICAgICAgICAgICAgIyBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg1NTMuIFVuZm9ydHVuYXRlbHkgdGhpcworICAg ICAgICAgICAgIyByb3V0aW5lIGlzIGNhbGxlZCByaWdodCBiZWZvcmUgdGhlIGxvZ2dlciBpcyBj b25maWd1cmVkLCBzbyBpZiB3ZQorICAgICAgICAgICAgIyB0cnkgdG8gX2xvZy53YXJuaW5nKCks IGl0IGdldHMgdGhyb3duIGF3YXkuCisgICAgICAgICAgICBpbXBvcnQgc3lzCisgICAgICAgICAg ICBzeXMuc3RkZXJyLndyaXRlKCJEZWZhdWx0aW5nIHRvIG9uZSBjaGlsZCAtIHNlZSBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzg1NTNcbiIpCisgICAgICAgICAgICBy ZXR1cm4gMQorCisgICAgICAgIHJldHVybiBjaHJvbWl1bS5DaHJvbWl1bVBvcnQuZGVmYXVsdF9j aGlsZF9wcm9jZXNzZXMoc2VsZikKKwogICAgIGRlZiBkZWZhdWx0X3dvcmtlcl9tb2RlbChzZWxm KToKICAgICAgICAgaWYgbXVsdGlwcm9jZXNzaW5nOgogICAgICAgICAgICAgcmV0dXJuICdwcm9j ZXNzZXMnCi0gICAgICAgIHJldHVybiAnaW5saW5lJworICAgICAgICByZXR1cm4gJ29sZC10aHJl YWRzJwogCiAgICAgZGVmIGRyaXZlcl9uYW1lKHNlbGYpOgogICAgICAgICByZXR1cm4gIkR1bXBS ZW5kZXJUcmVlIgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9jaHJvbWl1bV9tYWNfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX21hY191bml0dGVzdC5weQppbmRleCA0ZmJlMDNk NjVjMzRjZjJhM2Q3NDVlNWI2Y2M4YmYyOGE0MjI3YzczLi42NjZlMWRlOGQwOTE5ZWNkYjBmZDc4 ODE1M2QwYTUyNmYxNTA0MDViIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX21hY191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX21hY191bml0dGVzdC5weQpA QCAtNTcsNyArNTcsNyBAQCBjbGFzcyBDaHJvbWl1bU1hY1BvcnRUZXN0KHBvcnRfdGVzdGNhc2Uu UG9ydFRlc3RDYXNlKToKICAgICAgICAgaWYgbXVsdGlwcm9jZXNzaW5nOgogICAgICAgICAgICAg c2VsZi5hc3NlcnRFcXVhbChwb3J0LmRlZmF1bHRfd29ya2VyX21vZGVsKCksICdwcm9jZXNzZXMn KQogICAgICAgICBlbHNlOgotICAgICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChwb3J0LmRlZmF1 bHRfd29ya2VyX21vZGVsKCksICdpbmxpbmUnKQorICAgICAgICAgICAgc2VsZi5hc3NlcnRFcXVh bChwb3J0LmRlZmF1bHRfd29ya2VyX21vZGVsKCksICdvbGQtdGhyZWFkcycpCiAKICAgICBkZWYg YXNzZXJ0X25hbWUoc2VsZiwgcG9ydF9uYW1lLCBvc192ZXJzaW9uX3N0cmluZywgZXhwZWN0ZWQp OgogICAgICAgICBwb3J0ID0gY2hyb21pdW1fbWFjLkNocm9taXVtTWFjUG9ydChwb3J0X25hbWU9 cG9ydF9uYW1lLApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9tYWMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L21hYy5weQppbmRleCBiMmUxZjgwNWExZjkzMDdhM2E4YzljZDQzNzdlNjc3ZWU0Njg4MWZjLi42 NGI5YmNhMGUwYmU0MTI3NWM2YzdhOTgzZmNkNjZhMTM2MmJjNDM2IDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hYy5weQpAQCAtOTAsMTAgKzkwLDE5 IEBAIGNsYXNzIE1hY1BvcnQoV2ViS2l0UG9ydCk6CiAKICAgICAgICAgV2ViS2l0UG9ydC5fX2lu aXRfXyhzZWxmLCBwb3J0X25hbWU9cG9ydF9uYW1lLCAqKmt3YXJncykKIAorICAgIGRlZiBkZWZh dWx0X2NoaWxkX3Byb2Nlc3NlcyhzZWxmKToKKyAgICAgICAgIyBGSVhNRTogbmV3LXJ1bi13ZWJr aXQtdGVzdHMgaXMgdW5zdGFibGUgb24gTWFjIHJ1bm5pbmcgbW9yZSB0aGFuCisgICAgICAgICMg Zm91ciB0aHJlYWRzIGluIHBhcmFsbGVsLgorICAgICAgICAjIFNlZSBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzY2MjIKKyAgICAgICAgY2hpbGRfcHJvY2Vzc2VzID0g V2ViS2l0UG9ydC5kZWZhdWx0X2NoaWxkX3Byb2Nlc3NlcyhzZWxmKQorICAgICAgICBpZiBzZWxm LmdldF9vcHRpb24oJ3dvcmtlcl9tb2RlbCcpID09ICdvbGQtdGhyZWFkcycgYW5kIGNoaWxkX3By b2Nlc3NlcyA+IDQ6CisgICAgICAgICAgICByZXR1cm4gNAorICAgICAgICByZXR1cm4gY2hpbGRf cHJvY2Vzc2VzCisKICAgICBkZWYgZGVmYXVsdF93b3JrZXJfbW9kZWwoc2VsZik6CiAgICAgICAg IGlmIG11bHRpcHJvY2Vzc2luZzoKICAgICAgICAgICAgIHJldHVybiAncHJvY2Vzc2VzJwotICAg ICAgICByZXR1cm4gJ2lubGluZScKKyAgICAgICAgcmV0dXJuICdvbGQtdGhyZWFkcycKIAogICAg IGRlZiBiYXNlbGluZV9zZWFyY2hfcGF0aChzZWxmKToKICAgICAgICAgcmV0dXJuIG1hcChzZWxm Ll93ZWJraXRfYmFzZWxpbmVfcGF0aCwgc2VsZi5GQUxMQkFDS19QQVRIU1tzZWxmLl92ZXJzaW9u XSkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv bWFjX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9tYWNfdW5pdHRlc3QucHkKaW5kZXggZGFlMDVhOWU2N2I5ZTljNDQ2ZjZlZDg5NzYwMGJmOWMz MGE5ZTgwYS4uY2RkZDY4NTU5OGE0NjlmOTZiYjhiY2JjY2ZiODAxODQ4ZDJiOWQ2ZCAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWNfdW5pdHRl c3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tYWNf dW5pdHRlc3QucHkKQEAgLTU5LDcgKzU5LDcgQEAgY2xhc3MgTWFjVGVzdChwb3J0X3Rlc3RjYXNl LlBvcnRUZXN0Q2FzZSk6CiAgICAgICAgIGlmIG11bHRpcHJvY2Vzc2luZzoKICAgICAgICAgICAg IHNlbGYuYXNzZXJ0RXF1YWwocG9ydC5kZWZhdWx0X3dvcmtlcl9tb2RlbCgpLCAncHJvY2Vzc2Vz JykKICAgICAgICAgZWxzZToKLSAgICAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocG9ydC5kZWZh dWx0X3dvcmtlcl9tb2RlbCgpLCAnaW5saW5lJykKKyAgICAgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWwocG9ydC5kZWZhdWx0X3dvcmtlcl9tb2RlbCgpLCAnb2xkLXRocmVhZHMnKQogCiAgICAgZGVm IHRlc3Rfc2tpcHBlZF9maWxlX3BhdGhzKHNlbGYpOgogICAgICAgICAjIFdlIHNraXAgdGhpcyBv biB3aW4zMiBiZWNhdXNlIHdlIHVzZSAnLycgYXMgdGhlIGRpciBzZXBhcmF0b3IgYW5kIGl0J3MK