54924 2011-02-21 18:53:07 -0800 ImageDocument::imageChanged() confuses clang's -Woverride-virtual 2011-02-21 22:10:49 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 54367 1 thakis webkit-unassigned andersca commit-queue oldest_to_newest 354975 0 thakis 2011-02-21 18:53:07 -0800 ImageDocument has a method called imageChanged(). It indirectly inherits from CachedResourceClient, which has a method of the same name. From what I can tell, the method in ImageDocument is not supposed to override the superclass's method. clang's -Woverride-virtual complains: third_party/WebKit/Source/WebCore/html/ImageDocument.h:46:10:error: 'WebCore::ImageDocument::imageChanged' hides overloaded virtual function [-Woverloaded-virtual] void imageChanged(); ^ In file included from third_party/WebKit/Source/WebCore/html/ImageDocument.cpp:26: In file included from third_party/WebKit/Source/WebCore/html/ImageDocument.h:28: In file included from third_party/WebKit/Source/WebCore/html/HTMLDocument.h:26: third_party/WebKit/Source/WebCore/loader/cache/CachedResourceClient.h:55:22: note: hidden overloaded virtual function 'WebCore::CachedResourceClient::imageChanged' declared here virtual void imageChanged(CachedImage*, const IntRect* = 0) { }; ^ One of the two methods should be renamed. 354980 1 83256 thakis 2011-02-21 19:04:34 -0800 Created attachment 83256 Patch 355050 2 83256 commit-queue 2011-02-21 22:10:44 -0800 Comment on attachment 83256 Patch Clearing flags on attachment: 83256 Committed r79288: <http://trac.webkit.org/changeset/79288> 355051 3 commit-queue 2011-02-21 22:10:49 -0800 All reviewed patches have been landed. Closing bug. 83256 2011-02-21 19:04:34 -0800 2011-02-21 22:10:44 -0800 Patch bug-54924-20110221190433.patch text/plain 2504 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogNzkyNjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNDViZjQ1Yzc1MjIyMTU5 YWIyODY1ZTk3N2E3MzA0ZDU0Zjk1OTQyLi44Y2Y5ZmYwODliOTZmYzk0N2ViMDkyNTlmOWMyZGY5 MGE1MTQ0ZTc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDItMjEgIE5pY28g V2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEltYWdlRG9jdW1lbnQ6OmltYWdlQ2hhbmdlZCgpIGNvbmZ1 c2VzIGNsYW5nJ3MgLVdvdmVycmlkZS12aXJ0dWFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDkyNAorCisgICAgICAgIFJlbmFtZSBJbWFnZURvY3Vt ZW50OjppbWFnZUNoYW5nZWQoKSB0byBpbWFnZVVwZGF0ZWQoKSB0byBtYWtlIGNsZWFyCisgICAg ICAgIHRoYXQgaXQncyBub3QgYW4gb3ZlcnJpZGUgb2YgQ2FjaGVkUmVzb3VyY2VDbGllbnQ6Omlt YWdlQ2hhbmdlZCgpLgorCisgICAgICAgICogaHRtbC9JbWFnZURvY3VtZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkltYWdlRG9jdW1lbnRQYXJzZXI6OmFwcGVuZEJ5dGVzKToKKyAgICAgICAg KFdlYkNvcmU6OkltYWdlRG9jdW1lbnRQYXJzZXI6OmZpbmlzaCk6CisgICAgICAgIChXZWJDb3Jl OjpJbWFnZURvY3VtZW50OjppbWFnZVVwZGF0ZWQpOgorICAgICAgICAqIGh0bWwvSW1hZ2VEb2N1 bWVudC5oOgorCiAyMDExLTAyLTE4ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0ltYWdlRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZURv Y3VtZW50LmNwcAppbmRleCBhNDJjY2M4N2IwMjMxNWQ0OGI0ZDJiZTFiMDAzMjFkYmFhZGYyNTky Li5kMDNlMzdlN2JiNDE4ZjgwYmQzODMzNzcwMjJhYmVjMTQ2YTA2ZDdhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0ltYWdlRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSW1hZ2VEb2N1bWVudC5jcHAKQEAgLTEzNCw3ICsxMzQsNyBAQCB2b2lkIEltYWdlRG9j dW1lbnRQYXJzZXI6OmFwcGVuZEJ5dGVzKERvY3VtZW50V3JpdGVyKiwgY29uc3QgY2hhciosIGlu dCwgYm9vbCkKICAgICBDYWNoZWRJbWFnZSogY2FjaGVkSW1hZ2UgPSBkb2N1bWVudCgpLT5jYWNo ZWRJbWFnZSgpOwogICAgIGNhY2hlZEltYWdlLT5kYXRhKGZyYW1lLT5sb2FkZXIoKS0+ZG9jdW1l bnRMb2FkZXIoKS0+bWFpblJlc291cmNlRGF0YSgpLCBmYWxzZSk7CiAKLSAgICBkb2N1bWVudCgp LT5pbWFnZUNoYW5nZWQoKTsKKyAgICBkb2N1bWVudCgpLT5pbWFnZVVwZGF0ZWQoKTsKIH0KIAog dm9pZCBJbWFnZURvY3VtZW50UGFyc2VyOjpmaW5pc2goKQpAQCAtMTY1LDcgKzE2NSw3IEBAIHZv aWQgSW1hZ2VEb2N1bWVudFBhcnNlcjo6ZmluaXNoKCkKICAgICAgICAgICAgIGRvY3VtZW50KCkt PnNldFRpdGxlKGltYWdlVGl0bGUoZmlsZU5hbWUsIHNpemUpKTsKICAgICAgICAgfQogCi0gICAg ICAgIGRvY3VtZW50KCktPmltYWdlQ2hhbmdlZCgpOworICAgICAgICBkb2N1bWVudCgpLT5pbWFn ZVVwZGF0ZWQoKTsKICAgICB9CiAKICAgICBkb2N1bWVudCgpLT5maW5pc2hlZFBhcnNpbmcoKTsK QEAgLTI4Miw3ICsyODIsNyBAQCB2b2lkIEltYWdlRG9jdW1lbnQ6OmltYWdlQ2xpY2tlZChpbnQg eCwgaW50IHkpCiAgICAgfQogfQogCi12b2lkIEltYWdlRG9jdW1lbnQ6OmltYWdlQ2hhbmdlZCgp Cit2b2lkIEltYWdlRG9jdW1lbnQ6OmltYWdlVXBkYXRlZCgpCiB7CiAgICAgQVNTRVJUKG1faW1h Z2VFbGVtZW50KTsKICAgICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW1hZ2VE b2N1bWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZURvY3VtZW50LmgKaW5kZXggNWQw MGJkNjliNzliNTk5NDJmMjNlYzlhN2Y2YmViNDQzZWZmMjQ2OS4uOWQyODFmMWI4MTQyMjAwZWVk NDYyOGEzYTJiZWRiNGU0ODhmNjYzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9J bWFnZURvY3VtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9JbWFnZURvY3VtZW50LmgK QEAgLTQzLDcgKzQzLDcgQEAgcHVibGljOgogICAgIHZvaWQgZGlzY29ubmVjdEltYWdlRWxlbWVu dCgpIHsgbV9pbWFnZUVsZW1lbnQgPSAwOyB9CiAgICAgCiAgICAgdm9pZCB3aW5kb3dTaXplQ2hh bmdlZCgpOwotICAgIHZvaWQgaW1hZ2VDaGFuZ2VkKCk7CisgICAgdm9pZCBpbWFnZVVwZGF0ZWQo KTsKICAgICB2b2lkIGltYWdlQ2xpY2tlZChpbnQgeCwgaW50IHkpOwogCiBwcml2YXRlOgo=