54923 2011-02-21 18:39:34 -0800 [chromium] PopupContainer::show() confuses clang's -Woverloaded-virtual 2011-02-21 23:05:50 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 54367 1 thakis webkit-unassigned commit-queue jamesr oldest_to_newest 354970 0 thakis 2011-02-21 18:39:34 -0800 …because the superclass ScrollView has a show() method as well: In file included from /b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../platform/chromium/PopupMenuChromium.cpp:33: ../platform/chromium/PopupMenuChromium.h:136:10:error: 'WebCore::PopupContainer::show' hides overloaded virtual function [-Woverloaded-virtual] void show(const IntRect&, FrameView*, int index); ^ In file included from /b/build/slave/mac_clang/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../platform/chromium/PopupMenuChromium.cpp:33: In file included from ../platform/chromium/PopupMenuChromium.h:36: In file included from ../platform/chromium/FramelessScrollView.h:34: ../platform/ScrollView.h:265:18: note: hidden overloaded virtual function 'WebCore::ScrollView::show' declared here virtual void show(); ^ 1 error generated. 354972 1 83254 thakis 2011-02-21 18:46:03 -0800 Created attachment 83254 Patch 355080 2 83254 commit-queue 2011-02-21 23:05:45 -0800 Comment on attachment 83254 Patch Clearing flags on attachment: 83254 Committed r79294: <http://trac.webkit.org/changeset/79294> 355081 3 commit-queue 2011-02-21 23:05:50 -0800 All reviewed patches have been landed. Closing bug. 83254 2011-02-21 18:46:03 -0800 2011-02-21 23:05:45 -0800 Patch bug-54923-20110221184602.patch text/plain 4355 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogNzkyNjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNDViZjQ1Yzc1MjIyMTU5 YWIyODY1ZTk3N2E3MzA0ZDU0Zjk1OTQyLi41YmZjNTk0MTM4YzQ3OWJlZjEwM2UyOTg1NjM0ODY4 OTdkYzk2YWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDItMjEgIE5pY28g V2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gUG9wdXBDb250YWluZXI6OnNob3coKSBj b25mdXNlcyBjbGFuZydzIC1Xb3ZlcmxvYWRlZC12aXJ0dWFsCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDkyMworCisgICAgICAgIFJlbmFtZSBQb3B1 cENvbnRhaW5lcjo6c2hvdygpIHRvIHNob3dJblJlY3QoKSwgdG8gbWFrZSBpdCBvYnZpb3VzIGl0 J3MKKyAgICAgICAgbm90IGFuIG92ZXJyaWRlIG9mIFNjcm9sbFZpZXc6OnNob3coKS4KKworICAg ICAgICBObyBpbnRlbmRlZCBmdW5jdGlvbmFsaXR5IGNoYW5nZS4KKworICAgICAgICAqIHBsYXRm b3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBv cHVwQ29udGFpbmVyOjpzaG93SW5SZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTWVudUNo cm9taXVtOjpzaG93KToKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJv bWl1bS5oOgorCiAyMDExLTAyLTE4ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5jcHAKaW5kZXggNjNhY2Rm ZDAzZjVlOWM5NDQ4M2YyZmQzODUxNTg5MDMxNjFkZTg2Zi4uOTIwNzZkNzE5MGYxNmFmMWI4OTRk ZTM5OTkwODJjYzJmNTVkNDU3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Y2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcApAQCAtNTIzLDcgKzUyMyw3IEBAIENo cm9tZUNsaWVudENocm9taXVtKiBQb3B1cENvbnRhaW5lcjo6Y2hyb21lQ2xpZW50Q2hyb21pdW0o KQogICAgIHJldHVybiBzdGF0aWNfY2FzdDxDaHJvbWVDbGllbnRDaHJvbWl1bSo+KG1fZnJhbWVW aWV3LT5mcmFtZSgpLT5wYWdlKCktPmNocm9tZSgpLT5jbGllbnQoKSk7CiB9CiAKLXZvaWQgUG9w dXBDb250YWluZXI6OnNob3coY29uc3QgSW50UmVjdCYgciwgRnJhbWVWaWV3KiB2LCBpbnQgaW5k ZXgpCit2b2lkIFBvcHVwQ29udGFpbmVyOjpzaG93SW5SZWN0KGNvbnN0IEludFJlY3QmIHIsIEZy YW1lVmlldyogdiwgaW50IGluZGV4KQogewogICAgIC8vIFRoZSByZWN0IGlzIHRoZSBzaXplIG9m IHRoZSBzZWxlY3QgYm94LiBJdCdzIHVzdWFsbHkgbGFyZ2VyIHRoYW4gd2UgbmVlZC4KICAgICAv LyBzdWJ0cmFjdCBib3JkZXIgc2l6ZSBzbyB0aGF0IHVzdWFsbHkgdGhlIGNvbnRhaW5lciB3aWxs IGJlIGRpc3BsYXllZApAQCAtMTM4Miw3ICsxMzgyLDcgQEAgdm9pZCBQb3B1cE1lbnVDaHJvbWl1 bTo6c2hvdyhjb25zdCBJbnRSZWN0JiByLCBGcmFtZVZpZXcqIHYsIGludCBpbmRleCkKIHsKICAg ICBpZiAoIXAucG9wdXApCiAgICAgICAgIHAucG9wdXAgPSBQb3B1cENvbnRhaW5lcjo6Y3JlYXRl KGNsaWVudCgpLCBQb3B1cENvbnRhaW5lcjo6U2VsZWN0LCBkcm9wRG93blNldHRpbmdzKTsKLSAg ICBwLnBvcHVwLT5zaG93KHIsIHYsIGluZGV4KTsKKyAgICBwLnBvcHVwLT5zaG93SW5SZWN0KHIs IHYsIGluZGV4KTsKIH0KIAogdm9pZCBQb3B1cE1lbnVDaHJvbWl1bTo6aGlkZSgpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUG9wdXBNZW51Q2hyb21pdW0uaApp bmRleCAzZDU1Njg2ODIyNWFlMzJhNDEyYWI5NTRmMzQzYzA2N2UwNGE0YjZiLi4zNDM2NjUwMDFk OTdhMzJlMWU2YWU2ZDRiMzk1MGE4YzAzY2E0MjlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9jaHJvbWl1bS9Qb3B1cE1lbnVDaHJvbWl1bS5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmgKQEAgLTEzMyw3ICsxMzMs NyBAQCBwdWJsaWM6CiAgICAgLy8gc28gV2ViVmlld0ltcGwgY2FuIGNyZWF0ZSBhIFBvcHVwQ29u dGFpbmVyLiBUaGlzIG1ldGhvZCBpcyB1c2VkIGZvcgogICAgIC8vIGRpc3BsYXlpbmcgYXV0byBj b21wbGV0ZSBwb3B1cCBtZW51cyBvbiBNYWMgQ2hyb21pdW0sIGFuZCBmb3IgYWxsCiAgICAgLy8g cG9wdXBzIG9uIG90aGVyIHBsYXRmb3Jtcy4KLSAgICB2b2lkIHNob3coY29uc3QgSW50UmVjdCYs IEZyYW1lVmlldyosIGludCBpbmRleCk7CisgICAgdm9pZCBzaG93SW5SZWN0KGNvbnN0IEludFJl Y3QmLCBGcmFtZVZpZXcqLCBpbnQgaW5kZXgpOwogCiAgICAgLy8gSGlkZXMgdGhlIHBvcHVwLgog ICAgIHZvaWQgaGlkZVBvcHVwKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDNhZmQx ODZiYzM2MzhjYjJiZDExODJjNGM1NDNlODRjMjc3OTY3MjUuLmZhZTI4ZGZjZjljZWFhMWE2NTQz NjVmMDQ4YzA0Y2NmMDkxZjNhZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTggQEAKKzIwMTEtMDItMjEgIE5pY28gV2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1 bV0gUG9wdXBDb250YWluZXI6OnNob3coKSBjb25mdXNlcyBjbGFuZydzIC1Xb3ZlcmxvYWRlZC12 aXJ0dWFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NDkyMworCisgICAgICAgIFJlbmFtZSBQb3B1cENvbnRhaW5lcjo6c2hvdygpIHRvIHNob3dJblJl Y3QoKSwgdG8gbWFrZSBpdCBvYnZpb3VzIGl0J3MKKyAgICAgICAgbm90IGFuIG92ZXJyaWRlIG9m IFNjcm9sbFZpZXc6OnNob3coKS4KKworICAgICAgICBObyBpbnRlbmRlZCBmdW5jdGlvbmFsaXR5 IGNoYW5nZS4KKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYlZpZXdJbXBsOjphcHBseUF1dG9GaWxsU3VnZ2VzdGlvbnMpOgorCiAyMDExLTAyLTE3 ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw CmluZGV4IGFlMDdlNWRiYjYxNjc3NzY3OTEwNTUwYTM0NDEyNWM0M2Q1NjJmY2YuLmI0ZDY1YWMy ZGMyMDFmYjRhZDQxMjhkYjllYzMzNTcxN2RhOGM0ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTE5NzksNyArMTk3OSw3IEBAIHZvaWQgV2ViVmll d0ltcGw6OmFwcGx5QXV0b0ZpbGxTdWdnZXN0aW9ucygKICAgICBpZiAobV9hdXRvRmlsbFBvcHVw U2hvd2luZykgewogICAgICAgICByZWZyZXNoQXV0b0ZpbGxQb3B1cCgpOwogICAgIH0gZWxzZSB7 Ci0gICAgICAgIG1fYXV0b0ZpbGxQb3B1cC0+c2hvdyhmb2N1c2VkTm9kZS0+Z2V0UmVjdCgpLCBm b2N1c2VkTm9kZS0+b3duZXJEb2N1bWVudCgpLT52aWV3KCksIDApOworICAgICAgICBtX2F1dG9G aWxsUG9wdXAtPnNob3dJblJlY3QoZm9jdXNlZE5vZGUtPmdldFJlY3QoKSwgZm9jdXNlZE5vZGUt Pm93bmVyRG9jdW1lbnQoKS0+dmlldygpLCAwKTsKICAgICAgICAgbV9hdXRvRmlsbFBvcHVwU2hv d2luZyA9IHRydWU7CiAgICAgfQogfQo=