54922 2011-02-21 18:27:40 -0800 RenderTableCell::baselinePosition() confuses clang's -Woverloaded-virtual 2011-02-21 23:04:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 54367 1 thakis thakis andersca commit-queue oldest_to_newest 354966 0 thakis 2011-02-21 18:27:40 -0800 RenderTableCell::baselinePosition() confuses clang's -Woverloaded-virtual 354969 1 83253 thakis 2011-02-21 18:29:33 -0800 Created attachment 83253 Patch 354983 2 thakis 2011-02-21 19:06:47 -0800 clang says: In file included from third_party/WebKit/Source/WebCore/rendering/FixedTableLayout.cpp:26: third_party/WebKit/Source/WebCore/rendering/RenderTableCell.h:101:9:error: 'WebCore::RenderTableCell::baselinePosition' hides overloaded virtual function [-Woverloaded-virtual] int baselinePosition() const; ^ In file included from third_party/WebKit/Source/WebCore/rendering/FixedTableLayout.cpp:25: In file included from third_party/WebKit/Source/WebCore/rendering/RenderTable.h:29: third_party/WebKit/Source/WebCore/rendering/RenderBlock.h:63:17: note: hidden overloaded virtual function 'WebCore::RenderBlock::baselinePosition' declared here virtual int baselinePosition(FontBaseline, bool firstLine, LineDirectionMode, LinePositionMode = PositionOnContainingLine) const; 355071 3 83253 commit-queue 2011-02-21 22:46:41 -0800 Comment on attachment 83253 Patch Clearing flags on attachment: 83253 Committed r79292: <http://trac.webkit.org/changeset/79292> 355072 4 commit-queue 2011-02-21 22:46:45 -0800 All reviewed patches have been landed. Closing bug. 355079 5 commit-queue 2011-02-21 23:04:33 -0800 The commit-queue encountered the following flaky tests while processing attachment 83253: animations/combo-transform-translate+scale.html bug 50958 (authors: cmarrin@apple.com, darin@apple.com, ojan@chromium.org, and pol@apple.com) The commit-queue is continuing to process your patch. 83253 2011-02-21 18:29:33 -0800 2011-02-21 22:46:41 -0800 Patch bug-54922-20110221182932.patch text/plain 4677 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogNzkyNjAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNDViZjQ1Yzc1MjIyMTU5 YWIyODY1ZTk3N2E3MzA0ZDU0Zjk1OTQyLi5hNDNlZjc3OWYzMjExODJjMDQ0Y2Y5YjA0MWI2N2Rm NTk1ZDNhY2RkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTEtMDItMjEgIE5pY28g V2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlbmRlclRhYmxlQ2VsbDo6YmFzZWxpbmVQb3NpdGlvbigp IGNvbmZ1c2VzIGNsYW5nJ3MgLVdvdmVybG9hZGVkLXZpcnR1YWwKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0OTIyCisKKyAgICAgICAgUmVuZGVyVGFi bGVDZWxsOjpiYXNlbGluZVBvc2l0aW9uKCkgaGFzIHRoZSBzYW1lIG5hbWUgYXMgYSB2aXJ0dWFs CisgICAgICAgIG1ldGhvZCBpbiBzdXBlcmNsYXNzIFJlbmRlckJsb2NrLiBSZW5hbWUgdGhlIHN1 YmNsYXNzIG1ldGhvZCB0byBtYWtlCisgICAgICAgIGl0IGNsZWFyIGl0J3Mgbm90IGFuIGF0dGVt cHRlZCBvdmVycmlkZS4KKworICAgICAgICBObyBpbnRlbmRlZCBmdW5jdGlvbmFsaXR5IGNoYW5n ZS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyVGFibGVDZWxsOjpjZWxsQmFzZWxpbmVQb3NpdGlvbik6CisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5oOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJUYWJsZVNlY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGVTZWN0aW9u OjpjYWxjUm93TG9naWNhbEhlaWdodCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUYWJsZVNl Y3Rpb246OmxheW91dFJvd3MpOgorCiAyMDExLTAyLTE4ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwCmluZGV4IGM0Y2FlYWM1YjU1YjQ1 OGQxN2FiMjc3ZWVmZWUyNDZkZjQ3YzFhN2UuLmEwYTQ3YTM5OTg4MjJiOTA4YTExMzk5MjQ2NmVj NmRiYzNlYjcwNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJU YWJsZUNlbGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNl bGwuY3BwCkBAIC0yOTEsNyArMjkxLDcgQEAgdm9pZCBSZW5kZXJUYWJsZUNlbGw6OmNvbXB1dGVS ZWN0Rm9yUmVwYWludChSZW5kZXJCb3hNb2RlbE9iamVjdCogcmVwYWludENvbnRhaW4KICAgICBS ZW5kZXJCbG9jazo6Y29tcHV0ZVJlY3RGb3JSZXBhaW50KHJlcGFpbnRDb250YWluZXIsIHIsIGZp eGVkKTsKIH0KIAotaW50IFJlbmRlclRhYmxlQ2VsbDo6YmFzZWxpbmVQb3NpdGlvbigpIGNvbnN0 CitpbnQgUmVuZGVyVGFibGVDZWxsOjpjZWxsQmFzZWxpbmVQb3NpdGlvbigpIGNvbnN0CiB7CiAg ICAgLy8gPGh0dHA6Ly93d3cudzMub3JnL1RSLzIwMDcvQ1ItQ1NTMjEtMjAwNzA3MTkvdGFibGVz Lmh0bWwjaGVpZ2h0LWxheW91dD46IFRoZSBiYXNlbGluZSBvZiBhIGNlbGwgaXMgdGhlIGJhc2Vs aW5lIG9mCiAgICAgLy8gdGhlIGZpcnN0IGluLWZsb3cgbGluZSBib3ggaW4gdGhlIGNlbGwsIG9y IHRoZSBmaXJzdCBpbi1mbG93IHRhYmxlLXJvdyBpbiB0aGUgY2VsbCwgd2hpY2hldmVyIGNvbWVz IGZpcnN0LiBJZiB0aGVyZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRhYmxlQ2VsbC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2Vs bC5oCmluZGV4IDViNTk5MmFhMzcyYWZmN2ZhYTg1OTIxODk2NGVlNDcxMTZkYmM2YTguLmNmZGI3 MzlhMjIwYWVkMGFlOWI5NjA2ZDhhNjEyY2M5Y2I2NDM2NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmgKQEAgLTk4LDcgKzk4LDcgQEAgcHVibGljOgogCiAg ICAgdm9pZCBwYWludEJhY2tncm91bmRzQmVoaW5kQ2VsbChQYWludEluZm8mLCBpbnQgdHgsIGlu dCB0eSwgUmVuZGVyT2JqZWN0KiBiYWNrZ3JvdW5kT2JqZWN0KTsKIAotICAgIGludCBiYXNlbGlu ZVBvc2l0aW9uKCkgY29uc3Q7CisgICAgaW50IGNlbGxCYXNlbGluZVBvc2l0aW9uKCkgY29uc3Q7 CiAKICAgICB2b2lkIHNldEludHJpbnNpY1BhZGRpbmdCZWZvcmUoaW50IHApIHsgbV9pbnRyaW5z aWNQYWRkaW5nQmVmb3JlID0gcDsgfQogICAgIHZvaWQgc2V0SW50cmluc2ljUGFkZGluZ0FmdGVy KGludCBwKSB7IG1faW50cmluc2ljUGFkZGluZ0FmdGVyID0gcDsgfQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlU2VjdGlvbi5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVTZWN0aW9uLmNwcAppbmRleCBkZWUyMjI1OGY4ODMw NTIwNDFjZTZiN2U0MjVjMjZhMWQ5YmEzOWQxLi41NTQ5NDUyMDk3MGQ0OTM2NDdiOGNjZmJiNzI2 ZmQ1MjQyYzBkNmU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGFibGVTZWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFi bGVTZWN0aW9uLmNwcApAQCAtMzYzLDcgKzM2Myw3IEBAIGludCBSZW5kZXJUYWJsZVNlY3Rpb246 OmNhbGNSb3dMb2dpY2FsSGVpZ2h0KCkKICAgICAgICAgICAgIC8vIGZpbmQgb3V0IHRoZSBiYXNl bGluZQogICAgICAgICAgICAgRVZlcnRpY2FsQWxpZ24gdmEgPSBjZWxsLT5zdHlsZSgpLT52ZXJ0 aWNhbEFsaWduKCk7CiAgICAgICAgICAgICBpZiAodmEgPT0gQkFTRUxJTkUgfHwgdmEgPT0gVEVY VF9CT1RUT00gfHwgdmEgPT0gVEVYVF9UT1AgfHwgdmEgPT0gU1VQRVIgfHwgdmEgPT0gU1VCKSB7 Ci0gICAgICAgICAgICAgICAgaW50IGIgPSBjZWxsLT5iYXNlbGluZVBvc2l0aW9uKCk7CisgICAg ICAgICAgICAgICAgaW50IGIgPSBjZWxsLT5jZWxsQmFzZWxpbmVQb3NpdGlvbigpOwogICAgICAg ICAgICAgICAgIGlmIChiID4gY2VsbC0+Ym9yZGVyQmVmb3JlKCkgKyBjZWxsLT5wYWRkaW5nQmVm b3JlKCkpIHsKICAgICAgICAgICAgICAgICAgICAgYmFzZWxpbmUgPSBtYXgoYmFzZWxpbmUsIGIg LSBjZWxsLT5pbnRyaW5zaWNQYWRkaW5nQmVmb3JlKCkpOwogICAgICAgICAgICAgICAgICAgICBi ZGVzYyA9IG1heChiZGVzYywgbV9yb3dQb3NbaW5keF0gKyBjaCAtIChiIC0gY2VsbC0+aW50cmlu c2ljUGFkZGluZ0JlZm9yZSgpKSk7CkBAIC01NjgsNyArNTY4LDcgQEAgaW50IFJlbmRlclRhYmxl U2VjdGlvbjo6bGF5b3V0Um93cyhpbnQgdG9BZGQpCiAgICAgICAgICAgICAgICAgLy8gSWYgdGhl IGJhc2VsaW5lIG1vdmVkLCB3ZSBtYXkgaGF2ZSB0byB1cGRhdGUgdGhlIGRhdGEgZm9yIG91ciBy b3cuIEZpbmQgb3V0IHRoZSBuZXcgYmFzZWxpbmUuCiAgICAgICAgICAgICAgICAgRVZlcnRpY2Fs QWxpZ24gdmEgPSBjZWxsLT5zdHlsZSgpLT52ZXJ0aWNhbEFsaWduKCk7CiAgICAgICAgICAgICAg ICAgaWYgKHZhID09IEJBU0VMSU5FIHx8IHZhID09IFRFWFRfQk9UVE9NIHx8IHZhID09IFRFWFRf VE9QIHx8IHZhID09IFNVUEVSIHx8IHZhID09IFNVQikgewotICAgICAgICAgICAgICAgICAgICBp bnQgYiA9IGNlbGwtPmJhc2VsaW5lUG9zaXRpb24oKTsKKyAgICAgICAgICAgICAgICAgICAgaW50 IGIgPSBjZWxsLT5jZWxsQmFzZWxpbmVQb3NpdGlvbigpOwogICAgICAgICAgICAgICAgICAgICBp ZiAoYiA+IGNlbGwtPmJvcmRlckJlZm9yZSgpICsgY2VsbC0+cGFkZGluZ0JlZm9yZSgpKQogICAg ICAgICAgICAgICAgICAgICAgICAgbV9ncmlkW3JdLmJhc2VsaW5lID0gbWF4KG1fZ3JpZFtyXS5i YXNlbGluZSwgYik7CiAgICAgICAgICAgICAgICAgfQpAQCAtNTg1LDcgKzU4NSw3IEBAIGludCBS ZW5kZXJUYWJsZVNlY3Rpb246OmxheW91dFJvd3MoaW50IHRvQWRkKQogICAgICAgICAgICAgICAg IGNhc2UgVEVYVF9UT1A6CiAgICAgICAgICAgICAgICAgY2FzZSBURVhUX0JPVFRPTToKICAgICAg ICAgICAgICAgICBjYXNlIEJBU0VMSU5FOiB7Ci0gICAgICAgICAgICAgICAgICAgIGludCBiID0g Y2VsbC0+YmFzZWxpbmVQb3NpdGlvbigpOworICAgICAgICAgICAgICAgICAgICBpbnQgYiA9IGNl bGwtPmNlbGxCYXNlbGluZVBvc2l0aW9uKCk7CiAgICAgICAgICAgICAgICAgICAgIGlmIChiID4g Y2VsbC0+Ym9yZGVyQmVmb3JlKCkgKyBjZWxsLT5wYWRkaW5nQmVmb3JlKCkpCiAgICAgICAgICAg ICAgICAgICAgICAgICBpbnRyaW5zaWNQYWRkaW5nQmVmb3JlID0gZ2V0QmFzZWxpbmUocikgLSAo YiAtIG9sZEludHJpbnNpY1BhZGRpbmdCZWZvcmUpOwogICAgICAgICAgICAgICAgICAgICBicmVh azsK