<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>54915</bug_id>
          
          <creation_ts>2011-02-21 16:24:59 -0800</creation_ts>
          <short_desc>Remove unused JPEGImageEncoder code</short_desc>
          <delta_ts>2022-06-02 09:05:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>186365</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>54522</dependson>
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Alice Boxhall">aboxhall</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>aboxhall</cc>
    
    <cc>ahmad.saleem792</cc>
    
    <cc>ap</cc>
    
    <cc>mihaip</cc>
    
    <cc>noel.gordon</cc>
    
    <cc>pkasting</cc>
    
    <cc>staikos</cc>
    
    <cc>yong.li.webkit</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>354894</commentid>
    <comment_count>0</comment_count>
    <who name="Alice Boxhall">aboxhall</who>
    <bug_when>2011-02-21 16:24:59 -0800</bug_when>
    <thetext>Remove unused JPEGImageEncoder code</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>354895</commentid>
    <comment_count>1</comment_count>
      <attachid>83238</attachid>
    <who name="Alice Boxhall">aboxhall</who>
    <bug_when>2011-02-21 16:25:26 -0800</bug_when>
    <thetext>Created attachment 83238
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>354908</commentid>
    <comment_count>2</comment_count>
    <who name="Peter Kasting">pkasting</who>
    <bug_when>2011-02-21 16:50:56 -0800</bug_when>
    <thetext>Do any build files (e.g. *.gyp) need to be touched?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>354911</commentid>
    <comment_count>3</comment_count>
    <who name="Alice Boxhall">aboxhall</who>
    <bug_when>2011-02-21 17:02:40 -0800</bug_when>
    <thetext>A grep through WebCore found nothing referring to it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>354958</commentid>
    <comment_count>4</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-02-21 18:12:35 -0800</bug_when>
    <thetext>Why was it added?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>354959</commentid>
    <comment_count>5</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-02-21 18:13:14 -0800</bug_when>
    <thetext>Added in http://trac.webkit.org/changeset/67606</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>354960</commentid>
    <comment_count>6</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-02-21 18:13:52 -0800</bug_when>
    <thetext>@yong &amp; @staikos: Do we need this code?  It seems unused.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>355091</commentid>
    <comment_count>7</comment_count>
    <who name="Peter Kasting">pkasting</who>
    <bug_when>2011-02-21 23:51:51 -0800</bug_when>
    <thetext>(In reply to comment #6)
&gt; @yong &amp; @staikos: Do we need this code?  It seems unused.

Also: Is the PNG encoder unused as well, or is someone using that?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>356832</commentid>
    <comment_count>8</comment_count>
      <attachid>83238</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-02-24 03:11:31 -0800</bug_when>
    <thetext>Comment on attachment 83238
Patch

rs=me, assuming you didn&apos;t break any builds.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>356926</commentid>
    <comment_count>9</comment_count>
    <who name="George Staikos">staikos</who>
    <bug_when>2011-02-24 06:21:36 -0800</bug_when>
    <thetext>We&apos;ll likely be re-adding this commit again, as we are using.  Still in the process of merging.  I&apos;m not sure why the urge to remove it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>357004</commentid>
    <comment_count>10</comment_count>
    <who name="Yong Li">yong.li.webkit</who>
    <bug_when>2011-02-24 08:12:43 -0800</bug_when>
    <thetext>Why do we want to remove it? It allows ImageBuffer to easily support saving images with image/jpeg format. The new ImageBufferOpenVG.cpp patch will use it, which is still in process. https://bugs.webkit.org/show_bug.cgi?id=39230 (the old patch is obsolete). Or this feature can be put into ImageBuffer.cpp to be shared by platforms.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>357139</commentid>
    <comment_count>11</comment_count>
    <who name="Peter Kasting">pkasting</who>
    <bug_when>2011-02-24 10:22:25 -0800</bug_when>
    <thetext>(In reply to comment #10)
&gt; It allows ImageBuffer to easily support saving images with image/jpeg format.

Why is this useful?  How will this be exposed to users?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>357287</commentid>
    <comment_count>12</comment_count>
    <who name="Yong Li">yong.li.webkit</who>
    <bug_when>2011-02-24 12:41:26 -0800</bug_when>
    <thetext>(In reply to comment #11)
&gt; (In reply to comment #10)
&gt; &gt; It allows ImageBuffer to easily support saving images with image/jpeg format.
&gt; 
&gt; Why is this useful?  How will this be exposed to users?

canvas.toDataURL(type);

A web page can use this feature to convert canvas to iamge. A sample:

http://www.nihilogic.dk/labs/canvas2image/</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>357292</commentid>
    <comment_count>13</comment_count>
    <who name="Peter Kasting">pkasting</who>
    <bug_when>2011-02-24 12:43:33 -0800</bug_when>
    <thetext>(In reply to comment #12)
&gt; (In reply to comment #11)
&gt; &gt; (In reply to comment #10)
&gt; &gt; &gt; It allows ImageBuffer to easily support saving images with image/jpeg format.
&gt; &gt; 
&gt; &gt; Why is this useful?  How will this be exposed to users?
&gt; 
&gt; canvas.toDataURL(type);

Hmm.  I&apos;m pretty sure Chrome supports this already, I wonder how it&apos;s implemented there.  Not sure who would know; abarth is already CCed, adding mihaip.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>357299</commentid>
    <comment_count>14</comment_count>
    <who name="Yong Li">yong.li.webkit</who>
    <bug_when>2011-02-24 12:50:11 -0800</bug_when>
    <thetext>(In reply to comment #13)
&gt; (In reply to comment #12)
&gt; &gt; (In reply to comment #11)
&gt; &gt; &gt; (In reply to comment #10)
&gt; &gt; &gt; &gt; It allows ImageBuffer to easily support saving images with image/jpeg format.
&gt; &gt; &gt; 
&gt; &gt; &gt; Why is this useful?  How will this be exposed to users?
&gt; &gt; 
&gt; &gt; canvas.toDataURL(type);
&gt; 
&gt; Hmm.  I&apos;m pretty sure Chrome supports this already, I wonder how it&apos;s implemented there.  Not sure who would know; abarth is already CCed, adding mihaip.

Seems most ports either leave it unimplemented or rely on (graphics)platform feature. skia port is using a PNG encoder in image-encoders/skia. The jpeg/png encoders in image-encoders are platform independent, and can provide a shared implementation for other ports.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>357302</commentid>
    <comment_count>15</comment_count>
    <who name="Mihai Parparita">mihaip</who>
    <bug_when>2011-02-24 12:52:06 -0800</bug_when>
    <thetext>(In reply to comment #14)
&gt; Seems most ports either leave it unimplemented or rely on (graphics)platform feature. skia port is using a PNG encoder in image-encoders/skia. The jpeg/png encoders in image-encoders are platform independent, and can provide a shared implementation for other ports.

Based on http://trac.webkit.org/changeset/75488 the Skia ports are using image-encoders/skia for JPEG too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>357313</commentid>
    <comment_count>16</comment_count>
    <who name="Peter Kasting">pkasting</who>
    <bug_when>2011-02-24 13:02:38 -0800</bug_when>
    <thetext>(In reply to comment #15)
&gt; (In reply to comment #14)
&gt; &gt; Seems most ports either leave it unimplemented or rely on (graphics)platform feature. skia port is using a PNG encoder in image-encoders/skia. The jpeg/png encoders in image-encoders are platform independent, and can provide a shared implementation for other ports.
&gt; 
&gt; Based on http://trac.webkit.org/changeset/75488 the Skia ports are using image-encoders/skia for JPEG too.

Is there a compelling reason to choose a platform-dependent versus platform-independent implementation?  It seems like in principle it would be better to be consistent: either change various ports to all use the common code or have the OpenVG port (or whatever) use a mechanism more similar to the other ports.

I have no idea how this stuff works so I can&apos;t say which is better.  I&apos;m biased towards cross-platform implementations if they don&apos;t come with disadvantages, though.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>359718</commentid>
    <comment_count>17</comment_count>
      <attachid>83238</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2011-03-01 00:37:56 -0800</bug_when>
    <thetext>Comment on attachment 83238
Patch

ok.  Sounds like we shouldn&apos;t remove this code quite yet.  We should either start using it or decide not to use it.  If it&apos;s still unused after some moderate period of time, we should probably remove then.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1873588</commentid>
    <comment_count>18</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2022-06-02 08:05:27 -0700</bug_when>
    <thetext>I think this has been taken care of based on this commit - https://github.com/WebKit/WebKit/commit/142915fea4abca2327bd6ed1e651a3e8671f5d03

Since I am not able to find any &quot;code&quot; with JPEGImageEncoder on Github Webkit mirror, only past commits and above one is latest. Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1873604</commentid>
    <comment_count>19</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2022-06-02 09:05:58 -0700</bug_when>
    <thetext>Thank you for checking!

*** This bug has been marked as a duplicate of bug 186365 ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>83238</attachid>
            <date>2011-02-21 16:25:26 -0800</date>
            <delta_ts>2011-03-01 00:37:56 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-54915-20110222112524.patch</filename>
            <type>text/plain</type>
            <size>7472</size>
            <attacher name="Alice Boxhall">aboxhall</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogNzc0NTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNDViZjQ1Yzc1MjIyMTU5
YWIyODY1ZTk3N2E3MzA0ZDU0Zjk1OTQyLi4zNTk2YTRiOGFjYzVkOTE0M2IwMGFhYjZlM2MxNzky
M2MyMDU0NDAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDItMjEgIEFsaWNl
IEJveGhhbGwgIDxhYm94aGFsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBKUEVHSW1hZ2VFbmNvZGVy
IGNvZGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVHSW1hZ2VFbmNv
ZGVyLmNwcDogUmVtb3ZlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVH
SW1hZ2VFbmNvZGVyLmg6IFJlbW92ZWQuCisKIDIwMTEtMDItMTggIEplciBOb2JsZSAgPGplci5u
b2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL0pQRUdJbWFnZUVu
Y29kZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvSlBFR0lt
YWdlRW5jb2Rlci5jcHAKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IGQ3MDdhYTg2ZGQz
ZTAxOGFiZWJjZjdhZGEwYzU4ZDNjNzZlNzZiMWEuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2Rl
cnMvSlBFR0ltYWdlRW5jb2Rlci5jcHAKKysrIC9kZXYvbnVsbApAQCAtMSwxMzUgKzAsMCBAQAot
LyoKLSAqIENvcHlyaWdodCAoQykgMjAwOSBUb3JjaCBNb2JpbGUsIEluYy4gQWxsIHJpZ2h0cyBy
ZXNlcnZlZC4KLSAqIENvcHlyaWdodCAoQykgUmVzZWFyY2ggSW4gTW90aW9uIExpbWl0ZWQgMjAw
OS0yMDEwLiBBbGwgcmlnaHRzIHJlc2VydmVkLgotICoKLSAqICBUaGlzIGxpYnJhcnkgaXMgZnJl
ZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCi0gKiAgbW9kaWZ5IGl0
IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKLSAqICBM
aWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRo
ZXIKLSAqICB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55
IGxhdGVyIHZlcnNpb24uCi0gKgotICogIFRoaXMgbGlicmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0
aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAotICogIGJ1dCBXSVRIT1VUIEFOWSBXQVJS
QU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCi0gKiAgTUVSQ0hBTlRB
QklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUK
LSAqICBMaWJyYXJ5IEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KLSAq
Ci0gKiAgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIExpYnJhcnkg
R2VuZXJhbCBQdWJsaWMgTGljZW5zZQotICogIGFsb25nIHdpdGggdGhpcyBsaWJyYXJ5OyBzZWUg
dGhlIGZpbGUgQ09QWUlORy5MSUIuICBJZiBub3QsIHdyaXRlIHRvCi0gKiAgdGhlIEZyZWUgU29m
dHdhcmUgRm91bmRhdGlvbiwgSW5jLiwgNTEgRnJhbmtsaW4gU3RyZWV0LCBGaWZ0aCBGbG9vciwK
LSAqICBCb3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4KLSAqLwotCi0KLSNpbmNsdWRlICJjb25m
aWcuaCIKLSNpbmNsdWRlICJKUEVHSW1hZ2VFbmNvZGVyLmgiCi0KLSNpbmNsdWRlICJJbnRTaXpl
LmgiCi0vLyBGSVhNRToganBlZ2xpYi5oIHJlcXVpcmVzIHN0ZGlvLmggdG8gYmUgaW5jbHVkZWQg
Zmlyc3QgZm9yIEZJTEUKLSNpbmNsdWRlIDxzdGRpby5oPgotI2luY2x1ZGUgImpwZWdsaWIuaCIK
LSNpbmNsdWRlIDxzZXRqbXAuaD4KLQotbmFtZXNwYWNlIFdlYkNvcmUgewotCi1jbGFzcyBKUEVH
RGVzdGluYXRpb25NYW5hZ2VyIDogcHVibGljIGpwZWdfZGVzdGluYXRpb25fbWdyIHsKLXB1Ymxp
YzoKLSAgICBleHBsaWNpdCBKUEVHRGVzdGluYXRpb25NYW5hZ2VyKFZlY3RvcjxjaGFyPiYgdG9E
dW1wKQotICAgICAgICA6IG1fZHVtcCh0b0R1bXApCi0gICAgewotICAgICAgICAvLyBaZXJvIGJh
c2UgY2xhc3MgbWVtb3J5LgotICAgICAgICBqcGVnX2Rlc3RpbmF0aW9uX21nciogYmFzZSA9IHRo
aXM7Ci0gICAgICAgIG1lbXNldChiYXNlLCAwLCBzaXplb2YoanBlZ19kZXN0aW5hdGlvbl9tZ3Ip
KTsKLSAgICB9Ci0gICAgVmVjdG9yPGNoYXI+IG1fYnVmZmVyOwotICAgIFZlY3RvcjxjaGFyPiYg
bV9kdW1wOwotfTsKLQotY2xhc3MgSlBFR0NvbXByZXNzRXJyb3JNZ3IgOiBwdWJsaWMganBlZ19l
cnJvcl9tZ3IgewotcHVibGljOgotICAgIEpQRUdDb21wcmVzc0Vycm9yTWdyKCkKLSAgICB7Ci0g
ICAgICAgIC8vIFplcm8gbWVtb3J5Ci0gICAgICAgIG1lbXNldCh0aGlzLCAwLCBzaXplb2YoSlBF
R0NvbXByZXNzRXJyb3JNZ3IpKTsKLSAgICB9Ci0KLSAgICBqbXBfYnVmIG1fc2V0am1wQnVmZmVy
OwotfTsKLQotc3RhdGljIHZvaWQganBlZ0luaXRpYWxpemVEZXN0aW5hdGlvbihqX2NvbXByZXNz
X3B0ciBjb21wcmVzc0RhdGEpCi17Ci0gICAgSlBFR0Rlc3RpbmF0aW9uTWFuYWdlciogZGVzdCA9
IHN0YXRpY19jYXN0PEpQRUdEZXN0aW5hdGlvbk1hbmFnZXIqPihjb21wcmVzc0RhdGEtPmRlc3Qp
OwotICAgIGRlc3QtPm1fYnVmZmVyLnJlc2l6ZSg0MDk2KTsKLSAgICBkZXN0LT5uZXh0X291dHB1
dF9ieXRlID0gcmVpbnRlcnByZXRfY2FzdDxKT0NURVQqPihkZXN0LT5tX2J1ZmZlci5kYXRhKCkp
OwotICAgIGRlc3QtPmZyZWVfaW5fYnVmZmVyID0gZGVzdC0+bV9idWZmZXIuc2l6ZSgpOwotfQot
Ci1zdGF0aWMgYm9vbGVhbiBqcGVnRW1wdHlPdXRwdXRCdWZmZXIoal9jb21wcmVzc19wdHIgY29t
cHJlc3NEYXRhKQotewotICAgIEpQRUdEZXN0aW5hdGlvbk1hbmFnZXIqIGRlc3QgPSBzdGF0aWNf
Y2FzdDxKUEVHRGVzdGluYXRpb25NYW5hZ2VyKj4oY29tcHJlc3NEYXRhLT5kZXN0KTsKLSAgICBk
ZXN0LT5tX2R1bXAuYXBwZW5kKGRlc3QtPm1fYnVmZmVyLmRhdGEoKSwgZGVzdC0+bV9idWZmZXIu
c2l6ZSgpIC0gZGVzdC0+ZnJlZV9pbl9idWZmZXIpOwotICAgIGRlc3QtPm5leHRfb3V0cHV0X2J5
dGUgID0gcmVpbnRlcnByZXRfY2FzdDxKT0NURVQqPihkZXN0LT5tX2J1ZmZlci5kYXRhKCkpOwot
ICAgIGRlc3QtPmZyZWVfaW5fYnVmZmVyICAgID0gZGVzdC0+bV9idWZmZXIuc2l6ZSgpOwotICAg
IHJldHVybiBUUlVFOwotfQotCi1zdGF0aWMgdm9pZCBqcGVnVGVybWluYXRlRGVzdGluYXRpb24o
al9jb21wcmVzc19wdHIgY29tcHJlc3NEYXRhKQotewotICAgIEpQRUdEZXN0aW5hdGlvbk1hbmFn
ZXIqIGRlc3QgPSBzdGF0aWNfY2FzdDxKUEVHRGVzdGluYXRpb25NYW5hZ2VyKj4oY29tcHJlc3NE
YXRhLT5kZXN0KTsKLSAgICBkZXN0LT5tX2R1bXAuYXBwZW5kKGRlc3QtPm1fYnVmZmVyLmRhdGEo
KSwgZGVzdC0+bV9idWZmZXIuc2l6ZSgpIC0gZGVzdC0+ZnJlZV9pbl9idWZmZXIpOwotfQotCi1z
dGF0aWMgdm9pZCBqcGVnRXJyb3JFeGl0KGpfY29tbW9uX3B0ciBjb21wcmVzc0RhdGEpCi17Ci0g
ICAgSlBFR0NvbXByZXNzRXJyb3JNZ3IqIGVyciA9IHN0YXRpY19jYXN0PEpQRUdDb21wcmVzc0Vy
cm9yTWdyKj4oY29tcHJlc3NEYXRhLT5lcnIpOwotICAgIGxvbmdqbXAoZXJyLT5tX3NldGptcEJ1
ZmZlciwgLTEpOwotfQotCi1ib29sIGNvbXByZXNzUkdCQUJpZ0VuZGlhblRvSlBFRyh1bnNpZ25l
ZCBjaGFyKiByZ2JhQmlnRW5kaWFuRGF0YSwgY29uc3QgSW50U2l6ZSYgc2l6ZSwgVmVjdG9yPGNo
YXI+JiBqcGVnRGF0YSkKLXsKLSAgICBzdHJ1Y3QganBlZ19jb21wcmVzc19zdHJ1Y3QgY29tcHJl
c3NEYXRhID0geyAwIH07Ci0gICAgSlBFR0NvbXByZXNzRXJyb3JNZ3IgZXJyOwotICAgIGNvbXBy
ZXNzRGF0YS5lcnIgPSBqcGVnX3N0ZF9lcnJvcigmZXJyKTsKLSAgICBlcnIuZXJyb3JfZXhpdCA9
IGpwZWdFcnJvckV4aXQ7Ci0KLSAgICBqcGVnX2NyZWF0ZV9jb21wcmVzcygmY29tcHJlc3NEYXRh
KTsKLQotICAgIEpQRUdEZXN0aW5hdGlvbk1hbmFnZXIgZGVzdChqcGVnRGF0YSk7Ci0gICAgY29t
cHJlc3NEYXRhLmRlc3QgPSAmZGVzdDsKLSAgICBkZXN0LmluaXRfZGVzdGluYXRpb24gPSBqcGVn
SW5pdGlhbGl6ZURlc3RpbmF0aW9uOwotICAgIGRlc3QuZW1wdHlfb3V0cHV0X2J1ZmZlciA9IGpw
ZWdFbXB0eU91dHB1dEJ1ZmZlcjsKLSAgICBkZXN0LnRlcm1fZGVzdGluYXRpb24gPSBqcGVnVGVy
bWluYXRlRGVzdGluYXRpb247Ci0KLSAgICBjb21wcmVzc0RhdGEuaW1hZ2Vfd2lkdGggPSBzaXpl
LndpZHRoKCk7Ci0gICAgY29tcHJlc3NEYXRhLmltYWdlX2hlaWdodCA9IHNpemUuaGVpZ2h0KCk7
Ci0gICAgY29tcHJlc3NEYXRhLmlucHV0X2NvbXBvbmVudHMgPSAzOwotICAgIGNvbXByZXNzRGF0
YS5pbl9jb2xvcl9zcGFjZSA9IEpDU19SR0I7Ci0gICAganBlZ19zZXRfZGVmYXVsdHMoJmNvbXBy
ZXNzRGF0YSk7Ci0gICAganBlZ19zZXRfcXVhbGl0eSgmY29tcHJlc3NEYXRhLCA2NSwgRkFMU0Up
OwotCi0gICAgLy8gcm93QnVmZmVyIG11c3QgYmUgZGVmaW5lZCBoZXJlIHNvIHRoYXQgaXRzIGRl
c3RydWN0b3IgaXMgYWx3YXlzIGNhbGxlZCBldmVuIHdoZW4gInNldGptcCIgY2F0Y2hlcyBhbiBl
cnJvci4KLSAgICBWZWN0b3I8SlNBTVBMRSwgNjAwICogMz4gcm93QnVmZmVyOwotCi0gICAgaWYg
KHNldGptcChlcnIubV9zZXRqbXBCdWZmZXIpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KLSAg
ICBqcGVnX3N0YXJ0X2NvbXByZXNzKCZjb21wcmVzc0RhdGEsIFRSVUUpOwotICAgIHJvd0J1ZmZl
ci5yZXNpemUoY29tcHJlc3NEYXRhLmltYWdlX3dpZHRoICogMyk7Ci0KLSAgICBjb25zdCB1bnNp
Z25lZCBjaGFyKiBwaXhlbCA9IHJnYmFCaWdFbmRpYW5EYXRhOwotICAgIGNvbnN0IHVuc2lnbmVk
IGNoYXIqIHBpeGVsRW5kID0gcGl4ZWwgKyBjb21wcmVzc0RhdGEuaW1hZ2Vfd2lkdGggKiBjb21w
cmVzc0RhdGEuaW1hZ2VfaGVpZ2h0ICogNDsKLSAgICB3aGlsZSAocGl4ZWwgPCBwaXhlbEVuZCkg
ewotICAgICAgICBKU0FNUExFKiBvdXRwdXQgPSByb3dCdWZmZXIuZGF0YSgpOwotICAgICAgICBm
b3IgKGNvbnN0IHVuc2lnbmVkIGNoYXIqIHJvd0VuZCA9IHBpeGVsICsgY29tcHJlc3NEYXRhLmlt
YWdlX3dpZHRoICogNDsgcGl4ZWwgPCByb3dFbmQ7KSB7Ci0gICAgICAgICAgICAqb3V0cHV0Kysg
PSBzdGF0aWNfY2FzdDxKU0FNUExFPigqcGl4ZWwrKyAmIDB4RkYpOyAvLyByZWQKLSAgICAgICAg
ICAgICpvdXRwdXQrKyA9IHN0YXRpY19jYXN0PEpTQU1QTEU+KCpwaXhlbCsrICYgMHhGRik7IC8v
IGdyZWVuCi0gICAgICAgICAgICAqb3V0cHV0KysgPSBzdGF0aWNfY2FzdDxKU0FNUExFPigqcGl4
ZWwrKyAmIDB4RkYpOyAvLyBibHVlCi0gICAgICAgICAgICArK3BpeGVsOyAvLyBza2lwIGFscGhh
Ci0gICAgICAgIH0KLSAgICAgICAgb3V0cHV0ID0gcm93QnVmZmVyLmRhdGEoKTsKLSAgICAgICAg
anBlZ193cml0ZV9zY2FubGluZXMoJmNvbXByZXNzRGF0YSwgJm91dHB1dCwgMSk7Ci0gICAgfQot
Ci0gICAganBlZ19maW5pc2hfY29tcHJlc3MoJmNvbXByZXNzRGF0YSk7Ci0gICAgcmV0dXJuIHRy
dWU7Ci19Ci0KLX0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD
b3JlL3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL0pQRUdJbWFnZUVuY29kZXIuaCBiL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL0pQRUdJbWFnZUVuY29kZXIuaApkZWxldGVk
IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggYTM3M2M0ZjNlZWE3MDZmMThlODBlZTQyZWJlMzQ1M2Nk
MGRkZDE2My4uMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1lbmNvZGVycy9KUEVHSW1hZ2VFbmNvZGVyLmgK
KysrIC9kZXYvbnVsbApAQCAtMSwzMyArMCwwIEBACi0vKgotICogQ29weXJpZ2h0IChDKSAyMDA5
IFRvcmNoIE1vYmlsZSwgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgotICogQ29weXJpZ2h0IChD
KSBSZXNlYXJjaCBJbiBNb3Rpb24gTGltaXRlZCAyMDA5LTIwMTAuIEFsbCByaWdodHMgcmVzZXJ2
ZWQuCi0gKgotICogIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlz
dHJpYnV0ZSBpdCBhbmQvb3IKLSAqICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBH
TlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYwotICogIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5IHRo
ZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgotICogIHZlcnNpb24gMiBvZiB0aGUg
TGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KLSAqCi0gKiAg
VGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1
c2VmdWwsCi0gKiAgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhlIGlt
cGxpZWQgd2FycmFudHkgb2YKLSAqICBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQ
QVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlIEdOVQotICogIExpYnJhcnkgR2VuZXJhbCBQdWJs
aWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgotICoKLSAqICBZb3Ugc2hvdWxkIGhhdmUgcmVj
ZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlCi0g
KiAgYWxvbmcgd2l0aCB0aGlzIGxpYnJhcnk7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJQi4gIElm
IG5vdCwgd3JpdGUgdG8KLSAqICB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuLCA1
MSBGcmFua2xpbiBTdHJlZXQsIEZpZnRoIEZsb29yLAotICogIEJvc3RvbiwgTUEgMDIxMTAtMTMw
MSwgVVNBLgotICovCi0KLSNpZm5kZWYgSlBFR0ltYWdlRW5jb2Rlcl9oCi0jZGVmaW5lIEpQRUdJ
bWFnZUVuY29kZXJfaAotCi0jaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgotCi1uYW1lc3BhY2UgV2Vi
Q29yZSB7Ci0KLWNsYXNzIEludFNpemU7Ci1ib29sIGNvbXByZXNzUkdCQUJpZ0VuZGlhblRvSlBF
Ryh1bnNpZ25lZCBjaGFyKiByZ2JhQmlnRW5kaWFuRGF0YSwgY29uc3QgSW50U2l6ZSYgc2l6ZSwg
VmVjdG9yPGNoYXI+JiBqcGVnRGF0YSk7Ci0KLX0KLQotI2VuZGlmIC8vIEpQRUdJbWFnZUVuY29k
ZXJfaAo=
</data>
<flag name="review"
          id="75013"
          type_id="1"
          status="-"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>