54908 2011-02-21 14:38:02 -0800 'load' and 'error' events fired for @poster 2011-02-25 12:21:43 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson eric oldest_to_newest 354810 0 eric.carlson 2011-02-21 14:38:02 -0800 The test attached to https://bugs.webkit.org/show_bug.cgi?id=54685 relies on 'load' and 'error' events being fired when a poster loads or fails to load. As per the spec a <video> element should not fire any events for poster loading or failing, WebKit does so as a side effect of using HTMLImageLoader to load the poster. 355719 1 83418 eric.carlson 2011-02-22 17:15:16 -0800 Created attachment 83418 proposed patch 355727 2 eric.carlson 2011-02-22 17:36:02 -0800 <rdar://problem/9039962> 356824 3 83418 eric 2011-02-24 03:01:23 -0800 Comment on attachment 83418 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=83418&action=review > Source/WebCore/html/HTMLImageLoader.cpp:54 > + // HTMLVideoElement uses this class to load the poster image, but it should not fire events for loading or failure. > + if (element()->hasTagName(HTMLNames::videoTag)) > + return; Should it just use a subclass of this class? dispatchLoadEvent can't be too hot, so making it virtual should be easy. 356825 4 eric 2011-02-24 03:01:52 -0800 I'm not sure what the correct design here. I'm not sure it makes sense to bake this knowledge into HTMLImageLoader, but I also don't think it's that bad either. 358115 5 eric.carlson 2011-02-25 12:21:27 -0800 http://trac.webkit.org/changeset/79718 83418 2011-02-22 17:15:16 -0800 2011-02-25 12:21:43 -0800 proposed patch patch_2.txt text/plain 3183 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5Mzc0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDItMjIgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgJ2xvYWQnIGFuZCAnZXJyb3InIGV2ZW50cyBmaXJlZCBm b3IgQHBvc3RlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTQ5MDgKKworICAgICAgICAqIGh0bWwvSFRNTEltYWdlTG9hZGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkhUTUxJbWFnZUxvYWRlcjo6ZGlzcGF0Y2hMb2FkRXZlbnQpOiBEb24ndCBmaXJl IGV2ZW50cyB3aGVuIGJlaW5nIHVzZWQKKyAgICAgICAgYnkgYSB2aWRlbyBlbGVtZW50LgorCiAy MDExLTAyLTIyICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxJbWFnZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M SW1hZ2VMb2FkZXIuY3BwCShyZXZpc2lvbiA3OTMyOCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTEltYWdlTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDksNiArNDksMTAgQEAgSFRN TEltYWdlTG9hZGVyOjp+SFRNTEltYWdlTG9hZGVyKCkKIAogdm9pZCBIVE1MSW1hZ2VMb2FkZXI6 OmRpc3BhdGNoTG9hZEV2ZW50KCkKIHsKKyAgICAvLyBIVE1MVmlkZW9FbGVtZW50IHVzZXMgdGhp cyBjbGFzcyB0byBsb2FkIHRoZSBwb3N0ZXIgaW1hZ2UsIGJ1dCBpdCBzaG91bGQgbm90IGZpcmUg ZXZlbnRzIGZvciBsb2FkaW5nIG9yIGZhaWx1cmUuCisgICAgaWYgKGVsZW1lbnQoKS0+aGFzVGFn TmFtZShIVE1MTmFtZXM6OnZpZGVvVGFnKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgYm9vbCBl cnJvck9jY3VycmVkID0gaW1hZ2UoKS0+ZXJyb3JPY2N1cnJlZCgpOwogICAgIGlmICghZXJyb3JP Y2N1cnJlZCAmJiBpbWFnZSgpLT5yZXNwb25zZSgpLmh0dHBTdGF0dXNDb2RlKCkgPj0gNDAwKQog ICAgICAgICBlcnJvck9jY3VycmVkID0gZWxlbWVudCgpLT5oYXNUYWdOYW1lKEhUTUxOYW1lczo6 b2JqZWN0VGFnKTsgLy8gQW4gPG9iamVjdD4gY29uc2lkZXJzIGEgNDA0IHRvIGJlIGFuIGVycm9y IGFuZCBzaG91bGQgZmlyZSBvbmVycm9yLgpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNzkzNzQpCisrKyBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAx MS0wMi0yMiAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAnbG9hZCcgYW5kICdlcnJv cicgZXZlbnRzIGZpcmVkIGZvciBAcG9zdGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01NDkwOAorCisgICAgICAgICogbWVkaWEvdmlkZW8tcG9zdGVy Lmh0bWw6IFJlZ2lzdGVyIGxpc3RlbmVycyBmb3IgJ2xvYWQnIGFuZCAnZXJyb3InIGV2ZW50cyBz byB0aGUgdGVzdCB3aWxsCisgICAgICAgIGZhaWwgaWYgdGhleSBldmVyIGZpcmUuCisKIDIwMTEt MDItMjIgIEFtaSBGaXNjaG1hbiAgPGZpc2NobWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBQZXRlciBLYXN0aW5nLgpJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8t cG9zdGVyLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tcG9zdGVy Lmh0bWwJKHJldmlzaW9uIDc5MzYzKQorKysgTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tcG9zdGVy Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTg5LDE1ICs4OSwyNiBAQAogICAgICAgICAgICAgICAg IGNvbnNvbGVXcml0ZShkZXNjKTsKICAgICAgICAgICAgICAgICB2aWRlby5wb3N0ZXIgPSB1cmw7 CiAgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIHVuZXhwZWN0ZWRFdmVudChl dnQpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgY29uc29sZVdyaXRlKCIiKTsKKyAg ICAgICAgICAgICAgICBmYWlsVGVzdCgiVW5leHBlY3RlZCAnIiArIGV2dC50eXBlICsgIicgZXZl bnQgZmlyZWQhIik7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIHNldHVw KCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBkb2N1bWVudC5hZGRFdmVudExpc3Rl bmVyKCJlcnJvciIsIHVuZXhwZWN0ZWRFdmVudCk7CisgICAgICAgICAgICAgICAgZG9jdW1lbnQu YWRkRXZlbnRMaXN0ZW5lcigibG9hZCIsIHVuZXhwZWN0ZWRFdmVudCk7CisgICAgICAgICAgICAg ICAgZmluZE1lZGlhRWxlbWVudCgpOworICAgICAgICAgICAgICAgIHRlc3RQb3N0ZXIoKTsKKyAg ICAgICAgICAgIH0KICAgICAgICAgPC9zY3JpcHQ+CiAgICAgPC9oZWFkPgogCiAgICAgPGJvZHk+ CiAgICAgICAgIDx2aWRlbyBjb250cm9scyB3aWR0aD0zMjAgaGVpZ2h0PTI0MD48L3ZpZGVvPgog ICAgICAgICA8cD5UZXN0ICZsdDt2aWRlbyZndDsgZWxlbWVudCB3aXRoIGFuZCB3aXRob3V0IGEg cG9zdGVyLjwvcD4KLSAgICAgICAgPHNjcmlwdD4KLSAgICAgICAgICBmaW5kTWVkaWFFbGVtZW50 KCk7Ci0gICAgICAgICAgdGVzdFBvc3RlcigpOwotICAgICAgICA8L3NjcmlwdD4KKyAgICAgICAg PHNjcmlwdD5zZXR1cCgpOzwvc2NyaXB0PgogICAgIDwvYm9keT4KIDwvaHRtbD4K