54888 2011-02-21 09:34:27 -0800 Add regression test for clean shutdown during video playback. 2011-02-21 15:34:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 fischman webkit-unassigned commit-queue eric.carlson webkit.review.bot oldest_to_newest 354636 0 fischman 2011-02-21 09:34:27 -0800 Add regression test for clean shutdown during video playback. 354638 1 83173 fischman 2011-02-21 09:35:44 -0800 Created attachment 83173 Patch 354640 2 webkit.review.bot 2011-02-21 09:37:46 -0800 Attachment 83173 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/medi..." exit_code: 1 LayoutTests/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 354642 3 83175 fischman 2011-02-21 09:41:06 -0800 Created attachment 83175 Patch removed errant TAB from ChangeLog 354712 4 83175 eric.carlson 2011-02-21 11:32:59 -0800 Comment on attachment 83175 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83175&action=review Marking r- for the minor changes noted. > LayoutTests/ChangeLog:6 > + Add regression test for clean shutdown during video playback. > + This didn't always use to be the case (http://crbug.com/72730). It would be good to have more information about why this test is necessary, I didn't understand what "clean shutdown during video playback" meant until I read the chromium bug. > LayoutTests/media/video-plays-past-end-of-test.html:3 > +<!-- This test intentionally lets the video keep playing past endTest() to > + ensure that shutdown is clean. --> > + I really like to have information about what a test does in the markup so someone opening the test manually can figure out what is happening without having to view source. As above, "clean shutdown during video playback" didn't explain it for me. 354739 5 83203 fischman 2011-02-21 12:42:21 -0800 Created attachment 83203 Patch CR comments addressed 354742 6 83175 fischman 2011-02-21 12:44:40 -0800 Comment on attachment 83175 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83175&action=review >> LayoutTests/ChangeLog:6 >> + This didn't always use to be the case (http://crbug.com/72730). > > It would be good to have more information about why this test is necessary, I didn't understand what "clean shutdown during video playback" meant until I read the chromium bug. Expanded changelog & in-test text. >> LayoutTests/media/video-plays-past-end-of-test.html:3 >> + > > I really like to have information about what a test does in the markup so someone opening the test manually can figure out what is happening without having to view source. As above, "clean shutdown during video playback" didn't explain it for me. Done. (I used an HTML comment instead b/c in non-dumpAsText tests, this kind of explanatory text is often the sole reason for the need for per-platform expectations, as antialiasing/hinting cause minute differences; I realize now I should take it up with a larger group than just my local team if I want a change to SOP in this area; but anyway it's irrelevant to this test b/c it's a dumpAsText test, anyway) 354783 7 83203 eric.carlson 2011-02-21 13:37:02 -0800 Comment on attachment 83203 Patch Thanks! 354849 8 83203 commit-queue 2011-02-21 15:34:17 -0800 Comment on attachment 83203 Patch Clearing flags on attachment: 83203 Committed r79257: <http://trac.webkit.org/changeset/79257> 354850 9 commit-queue 2011-02-21 15:34:23 -0800 All reviewed patches have been landed. Closing bug. 83173 2011-02-21 09:35:44 -0800 2011-02-21 09:41:03 -0800 Patch bug-54888-20110221093543.patch text/plain 1953 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogNzkxMTEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5OTFlMjcxN2JlMDM1OWRiYTE0ZDJi ZGM1ZWRlYjBmNzBmNjZlMDc2Li43NmRhMDdmNTc3NDc2YmJmZjRiMzI4YTdiNmZlNDg2MDcxMjMw YjdhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDItMjEgIEFtaSBGaXNjaG1hbiAgPGZp c2NobWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgcmVncmVzc2lvbiB0ZXN0IGZvciBjbGVhbiBzaHV0ZG93biBkdXJp bmcgdmlkZW8gcGxheWJhY2suCisJVGhpcyBkaWRuJ3QgYWx3YXlzIHVzZSB0byBiZSB0aGUgY2Fz ZSAoaHR0cDovL2NyYnVnLmNvbS83MjczMCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD01NDg4OAorCisgICAgICAgICogbWVkaWEvdmlkZW8tcGxheXMt cGFzdC1lbmQtb2YtdGVzdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlhL3Zp ZGVvLXBsYXlzLXBhc3QtZW5kLW9mLXRlc3QuaHRtbDogQWRkZWQuCisKIDIwMTEtMDItMTkgIEFu ZHJldyBXaWxzb24gIDxhdHdpbHNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVXBkYXRlZCB0 ZXN0IGV4cGVjdGF0aW9ucyAobW9yZSBmYWxsb3V0IGZyb20gcjc4ODQ2KS4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBsYXlzLXBhc3QtZW5kLW9mLXRlc3QtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tcGxheXMtcGFzdC1lbmQtb2YtdGVzdC1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uYzZjMjdkZGFmOTI5NGZkMjY1NmI1ZjgyOGIwMGNmYmRhY2U3 ZGVmZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBsYXlzLXBh c3QtZW5kLW9mLXRlc3QtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorRVZFTlQocGxheWlu ZykKK0VORCBPRiBURVNUCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBs YXlzLXBhc3QtZW5kLW9mLXRlc3QuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBsYXlz LXBhc3QtZW5kLW9mLXRlc3QuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iZGE2YWY1NzliM2U2M2YxNDY1MTcw ZjQwM2FhN2Q0OWJlOTViNTc5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEv dmlkZW8tcGxheXMtcGFzdC1lbmQtb2YtdGVzdC5odG1sCkBAIC0wLDAgKzEsMTIgQEAKKzwhLS0g VGhpcyB0ZXN0IGludGVudGlvbmFsbHkgbGV0cyB0aGUgdmlkZW8ga2VlcCBwbGF5aW5nIHBhc3Qg ZW5kVGVzdCgpIHRvCisgICAgIGVuc3VyZSB0aGF0IHNodXRkb3duIGlzIGNsZWFuLiAtLT4KKwor PHZpZGVvIGF1dG9wbGF5IGlkPSJ2aWRlbyI+PC92aWRlbz4KKzxzY3JpcHQgc3JjPS4uL2h0dHAv dGVzdHMvbWVkaWEvbWVkaWEtZmlsZS5qcz48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPS4uL2h0dHAv dGVzdHMvbWVkaWEvdmlkZW8tdGVzdC5qcz48L3NjcmlwdD4KKzxzY3JpcHQgdHlwZT0idGV4dC9q YXZhc2NyaXB0Ij4KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgIGxheW91dFRl c3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKK3dhaXRGb3JFdmVudCgicGxheWluZyIsIG51bGws IHRydWUpOwordmlkZW8uc3JjID0gZmluZE1lZGlhRmlsZSgidmlkZW8iLCAiY29udGVudC90ZXN0 Iik7Cis8L3NjcmlwdD4K 83175 2011-02-21 09:41:06 -0800 2011-02-21 12:44:40 -0800 Patch bug-54888-20110221094104.patch text/plain 1960 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogNzkxMTEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5OTFlMjcxN2JlMDM1OWRiYTE0ZDJi ZGM1ZWRlYjBmNzBmNjZlMDc2Li44YzBhMzA5YTI1MTJjYTgyNzMzMGY5YjVmMjNjN2UwOTU4ZjBk ZDI3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDItMjEgIEFtaSBGaXNjaG1hbiAgPGZp c2NobWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgcmVncmVzc2lvbiB0ZXN0IGZvciBjbGVhbiBzaHV0ZG93biBkdXJp bmcgdmlkZW8gcGxheWJhY2suCisgICAgICAgIFRoaXMgZGlkbid0IGFsd2F5cyB1c2UgdG8gYmUg dGhlIGNhc2UgKGh0dHA6Ly9jcmJ1Zy5jb20vNzI3MzApLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ4ODgKKworICAgICAgICAqIG1lZGlhL3ZpZGVv LXBsYXlzLXBhc3QtZW5kLW9mLXRlc3QtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBt ZWRpYS92aWRlby1wbGF5cy1wYXN0LWVuZC1vZi10ZXN0Lmh0bWw6IEFkZGVkLgorCiAyMDExLTAy LTE5ICBBbmRyZXcgV2lsc29uICA8YXR3aWxzb25AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVw ZGF0ZWQgdGVzdCBleHBlY3RhdGlvbnMgKG1vcmUgZmFsbG91dCBmcm9tIHI3ODg0NikuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1wbGF5cy1wYXN0LWVuZC1vZi10ZXN0LWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBsYXlzLXBhc3QtZW5kLW9mLXRl c3QtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmM2YzI3ZGRhZjkyOTRmZDI2NTZiNWY4MjhiMDBj ZmJkYWNlN2RlZmQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1w bGF5cy1wYXN0LWVuZC1vZi10ZXN0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDMgQEAKK0VWRU5U KHBsYXlpbmcpCitFTkQgT0YgVEVTVAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS92 aWRlby1wbGF5cy1wYXN0LWVuZC1vZi10ZXN0Lmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRl by1wbGF5cy1wYXN0LWVuZC1vZi10ZXN0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYmRhNmFmNTc5YjNlNjNm MTQ2NTE3MGY0MDNhYTdkNDliZTk1YjU3OQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L21lZGlhL3ZpZGVvLXBsYXlzLXBhc3QtZW5kLW9mLXRlc3QuaHRtbApAQCAtMCwwICsxLDEyIEBA Cis8IS0tIFRoaXMgdGVzdCBpbnRlbnRpb25hbGx5IGxldHMgdGhlIHZpZGVvIGtlZXAgcGxheWlu ZyBwYXN0IGVuZFRlc3QoKSB0bworICAgICBlbnN1cmUgdGhhdCBzaHV0ZG93biBpcyBjbGVhbi4g LS0+CisKKzx2aWRlbyBhdXRvcGxheSBpZD0idmlkZW8iPjwvdmlkZW8+Cis8c2NyaXB0IHNyYz0u Li9odHRwL3Rlc3RzL21lZGlhL21lZGlhLWZpbGUuanM+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0u Li9odHRwL3Rlc3RzL21lZGlhL3ZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+Cis8c2NyaXB0IHR5cGU9 InRleHQvamF2YXNjcmlwdCI+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICBs YXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cit3YWl0Rm9yRXZlbnQoInBsYXlpbmci LCBudWxsLCB0cnVlKTsKK3ZpZGVvLnNyYyA9IGZpbmRNZWRpYUZpbGUoInZpZGVvIiwgImNvbnRl bnQvdGVzdCIpOworPC9zY3JpcHQ+Cg== 83203 2011-02-21 12:42:21 -0800 2011-02-21 15:34:17 -0800 Patch bug-54888-20110221124219.patch text/plain 2211 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogNzkxMTEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5OTFlMjcxN2JlMDM1OWRiYTE0ZDJi ZGM1ZWRlYjBmNzBmNjZlMDc2Li4zZjA2M2JlYjU5ZmVhN2I1ZDY0NWFlYmFjNWEyOGM1Yzk1MDhi NjJjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDItMjEgIEFtaSBGaXNjaG1hbiAgPGZp c2NobWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgcmVncmVzc2lvbiB0ZXN0IGZvciBjbGVhbiBzaHV0ZG93biBkdXJp bmcgdmlkZW8gcGxheWJhY2suCisgICAgICAgIER1bXBSZW5kZXJUcmVlIHVzZWQgdG8gY3Jhc2gg aWYgdGhlIHRlc3Qgd2FzIGVuZGVkIHdoaWxlIGEgdmlkZW8KKyAgICAgICAgd2FzIHN0aWxsIHBs YXlpbmcuICAoaHR0cDovL2NyYnVnLmNvbS83MjczMCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDg4OAorCisgICAgICAgICogbWVkaWEvdmlkZW8t cGxheXMtcGFzdC1lbmQtb2YtdGVzdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1l ZGlhL3ZpZGVvLXBsYXlzLXBhc3QtZW5kLW9mLXRlc3QuaHRtbDogQWRkZWQuCisKIDIwMTEtMDIt MTkgIEFuZHJldyBXaWxzb24gIDxhdHdpbHNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVXBk YXRlZCB0ZXN0IGV4cGVjdGF0aW9ucyAobW9yZSBmYWxsb3V0IGZyb20gcjc4ODQ2KS4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBsYXlzLXBhc3QtZW5kLW9mLXRlc3QtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tcGxheXMtcGFzdC1lbmQtb2YtdGVz dC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uN2EzMTkyZTA1NzA5OWE3NTk5OWNmYzc4NDUxMjg4 YzNmODQ0M2E3OAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBs YXlzLXBhc3QtZW5kLW9mLXRlc3QtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAorVGhpcyB0 ZXN0IGludGVudGlvbmFsbHkgbGV0cyB0aGUgdmlkZW8ga2VlcCBwbGF5aW5nIHBhc3QgZW5kVGVz dCgpIHRvIGVuc3VyZSB0aGF0IHNodXRkb3duIGlzIGNsZWFuLCBzaW5jZSBEdW1wUmVuZGVyVHJl ZSB1c2VkIHRvIGNyYXNoIGluIHRoaXMgY2FzZS4KKworRVZFTlQocGxheWluZykKK0VORCBPRiBU RVNUCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBsYXlzLXBhc3QtZW5k LW9mLXRlc3QuaHRtbCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBsYXlzLXBhc3QtZW5kLW9m LXRlc3QuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yMDA0MjE0YjUzNzUyOTExMGFlODA4NjU3YTY2NDc0OWI3 N2Y2YjNmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tcGxheXMt cGFzdC1lbmQtb2YtdGVzdC5odG1sCkBAIC0wLDAgKzEsMTIgQEAKKzxwPlRoaXMgdGVzdCBpbnRl bnRpb25hbGx5IGxldHMgdGhlIHZpZGVvIGtlZXAgcGxheWluZyBwYXN0IGVuZFRlc3QoKSB0byBl bnN1cmUKK3RoYXQgc2h1dGRvd24gaXMgY2xlYW4sIHNpbmNlIER1bXBSZW5kZXJUcmVlIHVzZWQg dG8gY3Jhc2ggaW4gdGhpcyBjYXNlLjwvcD4KKworPHZpZGVvIGF1dG9wbGF5IGlkPSJ2aWRlbyI+ PC92aWRlbz4KKzxzY3JpcHQgc3JjPS4uL2h0dHAvdGVzdHMvbWVkaWEvbWVkaWEtZmlsZS5qcz48 L3NjcmlwdD4KKzxzY3JpcHQgc3JjPS4uL2h0dHAvdGVzdHMvbWVkaWEvdmlkZW8tdGVzdC5qcz48 L3NjcmlwdD4KKzxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KK2lmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpCisgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsK K3dhaXRGb3JFdmVudCgicGxheWluZyIsIG51bGwsIHRydWUpOwordmlkZW8uc3JjID0gZmluZE1l ZGlhRmlsZSgidmlkZW8iLCAiY29udGVudC90ZXN0Iik7Cis8L3NjcmlwdD4K