54885 2011-02-21 09:06:22 -0800 Many tests started timing out on the chrome mac canaries around r79035 2011-02-23 19:42:12 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 54772 1 atwilson dpranke fishd jamesr kbr mihaip morrita rniwa oldest_to_newest 354623 0 atwilson 2011-02-21 09:06:22 -0800 It's a big list - here's the flakiness dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=editing%2Fdeleting%2Fdelete-3928305-fix.html%2Cediting%2Fdeleting%2Fdelete-3959464-fix.html%2Cediting%2Fdeleting%2Fdelete-and-undo.html%2Cediting%2Fdeleting%2Fdelete-block-contents-003.html%2Cediting%2Fdeleting%2Fdelete-contiguous-ws-001.html%2Cediting%2Fdeleting%2Fdelete-tab-002.html%2Cediting%2Fdeleting%2Fdelete-tab-003.html%2Cediting%2Fdeleting%2Fdelete-to-select-table.html%2Cediting%2Fdeleting%2Fdelete-trailing-ws-002.html%2Cediting%2Fdeleting%2Fdelete-ws-fixup-001.html%2Cediting%2Fdeleting%2Fdelete-ws-fixup-002.html%2Cediting%2FexecCommand%2F5569741.html%2Cediting%2FexecCommand%2Finsert-list-and-stitch.html%2Cediting%2FexecCommand%2FinsertHorizontalRule.html%2Cediting%2FexecCommand%2Foutdent-selection.html%2Cediting%2Finserting%2F5418891.html%2Cediting%2Finserting%2Fediting-empty-divs.html%2Cediting%2Finserting%2Finsert-3907422-fix.html%2Cediting%2Finserting%2Finsert-br-004.html%2Cediting%2Finserting%2Finsert-br-005.html%2Cediting%2Finserting%2Finsert-br-007.html%2Cediting%2Finserting%2Finsert-div-007.html%2Cediting%2Finserting%2Finsert-div-012.html%2Cediting%2Finserting%2Finsert-div-013.html%2Cediting%2Finserting%2Finsert-div-014.html%2Cediting%2Finserting%2Finsert-div-015.html%2Cediting%2Finserting%2Finsert-div-016.html%2Cediting%2Finserting%2Finsert-div-017.html%2Cediting%2Finserting%2Finsert-div-018.html%2Cediting%2Finserting%2Finsert-div-019.html%2Cediting%2Finserting%2Finsert-div-020.html%2Cediting%2Finserting%2Finsert-div-021.html%2Cediting%2Finserting%2Finsert-div-022.html%2Cediting%2Finserting%2Finsert-div-025.html%2Cediting%2Finserting%2Finsert-div-027.html%2Cediting%2Finserting%2Finsert-paragraph-02.html%2Cediting%2Finserting%2Finsert-paragraph-03.html%2Cediting%2Finserting%2Finsert-tab-002.html%2Cediting%2Finserting%2Finsert-tab-003.html%2Cediting%2Finserting%2Finsert-text-with-newlines.html%2Cediting%2Finserting%2Fparagraph-separator-01.html%2Cediting%2Finserting%2Fparagraph-separator-02.html%2Cediting%2Finserting%2Fparagraph-separator-03.html%2Cediting%2Finserting%2Freturn-key-with-selection-001.html%2Cediting%2Finserting%2Freturn-key-with-selection-002.html%2Cediting%2Finserting%2Freturn-key-with-selection-003.html%2Cediting%2Finserting%2Ftyping-002.html%2Cediting%2Finserting%2Ftyping-around-br-001.html%2Cediting%2Fpasteboard%2F4242293.html%2Cediting%2Fpasteboard%2F4944770-1.html%2Cediting%2Fpasteboard%2F8145-2.html%2Cediting%2Fpasteboard%2Fcopy-in-password-field.html%2Cediting%2Fpasteboard%2Fcut-text-001.html%2Cediting%2Fpasteboard%2Finterchange-newline-1.html%2Cediting%2Fpasteboard%2Fmerge-after-delete-1.html%2Cediting%2Fpasteboard%2Fmerge-after-delete-2.html%2Cediting%2Fpasteboard%2Fmerge-after-delete.html%2Cediting%2Fpasteboard%2Fmerge-end-4.html%2Cediting%2Fpasteboard%2Fmerge-end-blockquote.html%2Cediting%2Fpasteboard%2Fmerge-end-list.html%2Cediting%2Fpasteboard%2Fmerge-end-table.html%2Cediting%2Fpasteboard%2Fpaste-blockquote-3.html%2Cediting%2Fpasteboard%2Fpaste-text-001.html%2Cediting%2Fpasteboard%2Fpaste-text-012.html%2Cediting%2Fpasteboard%2Fpaste-text-013.html%2Cediting%2Fpasteboard%2Fpaste-text-014.html%2Cediting%2Fpasteboard%2Fpaste-text-019.html%2Cediting%2Fpasteboard%2Fpaste-xml.xhtml%2Cediting%2Fpasteboard%2Fundoable-fragment-removes.html%2Cediting%2Fselection%2F13804.html%2Cediting%2Fselection%2F5234383-1.html%2Cediting%2Fselection%2F5234383-2.html%2Cediting%2Fselection%2Fextend-by-word-001.html%2Cediting%2Fselection%2Fmove-backwords-by-word-001.html%2Cediting%2Fselection%2Fmove-by-character-001.html%2Cediting%2Fselection%2Fmove-by-line-001.html%2Cediting%2Fselection%2Fmove-by-word-001.html%2Cediting%2Fselection%2Fselect-from-textfield-outwards.html%2Cediting%2Fselection%2Funrendered-002.html%2Cediting%2Fspelling%2Finline_spelling_markers.html%2Cediting%2Fspelling%2Fspelling.html%2Cediting%2Fstyle%2F5046875-2.html%2Cediting%2Fstyle%2Fblock-styles-007.html%2Cediting%2Fstyle%2Fcreate-block-for-style-002.html%2Cediting%2Fstyle%2Fcreate-block-for-style-003.html%2Cediting%2Fstyle%2Fcreate-block-for-style-004.html%2Cediting%2Fstyle%2Fcreate-block-for-style-006.html%2Cediting%2Fstyle%2Fcreate-block-for-style-008.html%2Cediting%2Fstyle%2Fcreate-block-for-style-009.html%2Cediting%2Fstyle%2Fcreate-block-for-style-011.html%2Cediting%2Fstyle%2Fcreate-block-for-style-012.html%2Cediting%2Fstyle%2Fcreate-block-for-style-013.html%2Cfast%2Fdom%2Fblur-contenteditable.html%2Cfast%2Fdom%2Fobject-embed-plugin-scripting.html%2Cfast%2Fdom%2Fobject-plugin-hides-properties.html%2Cfast%2Fevents%2Fonchange-passwordfield.html%2Cfast%2Fevents%2Ftabindex-focus-blur-all.html%2Cfast%2Fforms%2Ffocus-control-to-page.html%2Cfast%2Fforms%2Ffocus2.html%2Cfast%2Fforms%2Fpassword-doubleclick-selection.html%2Cfast%2Fforms%2Fpassword-placeholder-text-security.html%2Cfast%2Fimages%2Fembed-image.html%2Cfast%2Fimages%2Fobject-image.html%2Cplugins%2Fembed-attributes-setting.html%2Cplugins%2Fembed-attributes-style.html%2Cplugins%2Fiframe-shims.html%2Cuserscripts%2Fuser-script-video-document.html Interestingly, it doesn't seem to affect the main chrome build tree, since we've already rolled past this revision, so it's probably test-infrastructure related. Not sure how 79035 could be related to this and I'm reluctant to roll it out because it includes a fix for the rebaselining tool, so I'm just going to mark these tests as TIMEOUT for now. 354784 1 dpranke 2011-02-21 13:37:24 -0800 Interesting that a lot of these tests seem to be editing-related. I wonder if there's something taking out some sort of system-wide global lock that is keeping the tests from running in parallel with other DRT tests. Something having to do with focus, maybe? This is wild speculation ... 354785 2 dpranke 2011-02-21 13:38:36 -0800 Seems much more likely to have been triggered by 79047/79062 (me enabling multiple processes). 354956 3 dpranke 2011-02-21 18:11:27 -0800 investigating ... I will also note that while I would expect additional flakiness on SL bots, if anything, I would've expected the Leopard bots to become *more* stable, because we stopped using threads completely. 354990 4 dpranke 2011-02-21 19:30:59 -0800 I am reverting the behavior on 10.5 (see bug 54925), so we'll see if this goes away ... 355106 5 morrita 2011-02-22 00:43:53 -0800 Tests pass on the Debug build, but timed-out on the Release. 355121 6 rniwa 2011-02-22 01:27:03 -0800 Editing tests are still timing out on WebKit Mac 10.5 (release). We've lost significant test coverage due to this bug :( 355160 7 dpranke 2011-02-22 03:06:46 -0800 It seems unlikely to me that its a NRWT thing at this point. Is it possible that something else changed in that timeframe that's causing this regression? 355187 8 rniwa 2011-02-22 04:56:48 -0800 Maybe http://trac.webkit.org/changeset/79038/ ? 355387 9 kbr 2011-02-22 10:42:22 -0800 It's possible that my change in http://trac.webkit.org/changeset/79038/ caused this breakage. With this change , if the minimum DOM timer interval isn't manually set then it may be set to a high value. I'll try to run these tests locally to reproduce. 355757 10 kbr 2011-02-22 18:56:03 -0800 I'm having difficulty reproducing these test timeouts locally. I've built DRT Release mode out of a Chromium checkout, reversed the timeout expected results in r79228 and ran the following: cat tests.txt | xargs src/webkit/tools/layout_tests/run_webkit_tests.sh --chromium with the attached tests.txt. None of the tests timed out. This is on Snow Leopard. Is anyone else able to reproduce the timeouts? 355758 11 83425 kbr 2011-02-22 18:56:30 -0800 Created attachment 83425 Test list 355759 12 83426 kbr 2011-02-22 19:09:21 -0800 Created attachment 83426 Revert of code changes from r79038 355760 13 kbr 2011-02-22 19:10:41 -0800 After talking with dpranke, let's try reverting the code changes from r79038 to see whether they clean up the flakiness dashboard. 355766 14 83426 jamesr 2011-02-22 19:14:19 -0800 Comment on attachment 83426 Revert of code changes from r79038 Worth a try. Feel free to land reverts unreviewed in the future if you prefer. 355772 15 kbr 2011-02-22 19:23:41 -0800 Committed r79387: <http://trac.webkit.org/changeset/79387> 355799 16 rniwa 2011-02-22 20:01:49 -0800 (In reply to comment #15) > Committed r79387: <http://trac.webkit.org/changeset/79387> It seems like this wasn't the cause :( http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5/builds/1482 355802 17 rniwa 2011-02-22 20:06:55 -0800 I sent out an email internally at Goole to look for a Leopard machine. 356170 18 kbr 2011-02-23 10:12:51 -0800 Since the code changes in r79038 weren't the root cause, I'm going to reapply them. 356172 19 kbr 2011-02-23 10:15:15 -0800 Committed r79456: <http://trac.webkit.org/changeset/79456> 356173 20 kbr 2011-02-23 10:15:35 -0800 Oops, accidentally closed the bug while landing that last patch. Reopening. 356347 21 mihaip 2011-02-23 13:06:47 -0800 I was not able to reproduce this on a Leopard machine (doing a release build with build-webkit --chromium). James and I also noticed that: - non-editing tests were strangely affected too (e.g. userscripts/user-script-video-document.html) - the debug canary bots were not affected: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=editing%2Fdeleting%2Fdelete-3928305-fix.html&showAllRuns=true - the DEPS bots are not affected: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=editing%2Fdeleting%2Fdelete-3928305-fix.html&showAllRuns=true We therefore suspect that the bot is in a weird state. When I ssh-ed into it, I noticed a 3 DRT processes that were hung (since February 6/7). I also couldn't start Terminal.app (it would hang with 100% CPU before showing me the shell). Nicolas restarted the bot, we'll see if this goes away. 356352 22 mihaip 2011-02-23 13:12:07 -0800 (In reply to comment #21) > Nicolas restarted the bot, we'll see if this goes away. Yes, the tests are passing now. From http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5/builds/1505/steps/webkit_tests/logs/stdio: 2011-02-23 13:11:14,603 706 worker_mixin.py:154 DEBUG worker-0 editing/deleting/delete-3928305-fix.html passed 2011-02-23 13:11:14,605 706 printing.py:541 INFO editing/deleting/delete-3928305-fix.html -> unexpected pass 2011-02-23 13:11:14,676 706 worker_mixin.py:154 DEBUG worker-0 editing/deleting/delete-3959464-fix.html passed 2011-02-23 13:11:14,686 706 printing.py:541 INFO editing/deleting/delete-3959464-fix.html -> unexpected pass 356360 23 mihaip 2011-02-23 13:26:22 -0800 Tests are now passing, TIMEOUT expectations removed with http://trac.webkit.org/changeset/79480. 356636 24 rniwa 2011-02-23 19:42:12 -0800 (In reply to comment #23) > Tests are now passing, TIMEOUT expectations removed with http://trac.webkit.org/changeset/79480. Great! Thanks for fixing this bug. 83425 2011-02-22 18:56:30 -0800 2011-02-22 18:56:30 -0800 Test list tests.txt text/plain 4347 kbr ZWRpdGluZy9wYXN0ZWJvYXJkL3Bhc3RlLXhtbC54aHRtbCBwbHVnaW5zL2lmcmFtZS1zaGltcy5o dG1sIGZhc3QvaW1hZ2VzL2VtYmVkLWltYWdlLmh0bWwgZmFzdC9pbWFnZXMvb2JqZWN0LWltYWdl Lmh0bWwgZmFzdC9mb3Jtcy9mb2N1czIuaHRtbCBlZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS10YWIt MDAzLmh0bWwgZWRpdGluZy9kZWxldGluZy9kZWxldGUtd3MtZml4dXAtMDAxLmh0bWwgZWRpdGlu Zy9pbnNlcnRpbmcvaW5zZXJ0LXRhYi0wMDMuaHRtbCBlZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3Qt ZnJvbS10ZXh0ZmllbGQtb3V0d2FyZHMuaHRtbCBlZGl0aW5nL3N0eWxlL2NyZWF0ZS1ibG9jay1m b3Itc3R5bGUtMDExLmh0bWwgZWRpdGluZy9zdHlsZS9jcmVhdGUtYmxvY2stZm9yLXN0eWxlLTAx Mi5odG1sIGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLTM5MjgzMDUtZml4Lmh0bWwgZWRpdGluZy9k ZWxldGluZy9kZWxldGUtMzk1OTQ2NC1maXguaHRtbCBlZGl0aW5nL2RlbGV0aW5nL2RlbGV0ZS1h bmQtdW5kby5odG1sIGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWJsb2NrLWNvbnRlbnRzLTAwMy5o dG1sIGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLWNvbnRpZ3VvdXMtd3MtMDAxLmh0bWwgZWRpdGlu Zy9kZWxldGluZy9kZWxldGUtdGFiLTAwMi5odG1sIGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLXRv LXNlbGVjdC10YWJsZS5odG1sIGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLXRyYWlsaW5nLXdzLTAw Mi5odG1sIGVkaXRpbmcvZGVsZXRpbmcvZGVsZXRlLXdzLWZpeHVwLTAwMi5odG1sIGVkaXRpbmcv ZXhlY0NvbW1hbmQvNTU2OTc0MS5odG1sIGVkaXRpbmcvZXhlY0NvbW1hbmQvaW5zZXJ0LWxpc3Qt YW5kLXN0aXRjaC5odG1sIGVkaXRpbmcvZXhlY0NvbW1hbmQvaW5zZXJ0SG9yaXpvbnRhbFJ1bGUu aHRtbCBlZGl0aW5nL2V4ZWNDb21tYW5kL291dGRlbnQtc2VsZWN0aW9uLmh0bWwgZWRpdGluZy9p bnNlcnRpbmcvNTQxODg5MS5odG1sIGVkaXRpbmcvaW5zZXJ0aW5nL2VkaXRpbmctZW1wdHktZGl2 cy5odG1sIGVkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC0zOTA3NDIyLWZpeC5odG1sIGVkaXRpbmcv aW5zZXJ0aW5nL2luc2VydC1ici0wMDQuaHRtbCBlZGl0aW5nL2luc2VydGluZy9pbnNlcnQtYnIt MDA1Lmh0bWwgZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWJyLTAwNy5odG1sIGVkaXRpbmcvaW5z ZXJ0aW5nL2luc2VydC1kaXYtMDA3Lmh0bWwgZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWRpdi0w MTIuaHRtbCBlZGl0aW5nL2luc2VydGluZy9pbnNlcnQtZGl2LTAxMy5odG1sIGVkaXRpbmcvaW5z ZXJ0aW5nL2luc2VydC1kaXYtMDE0Lmh0bWwgZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWRpdi0w MTUuaHRtbCBlZGl0aW5nL2luc2VydGluZy9pbnNlcnQtZGl2LTAxNi5odG1sIGVkaXRpbmcvaW5z ZXJ0aW5nL2luc2VydC1kaXYtMDE3Lmh0bWwgZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWRpdi0w MTguaHRtbCBlZGl0aW5nL2luc2VydGluZy9pbnNlcnQtZGl2LTAxOS5odG1sIGVkaXRpbmcvaW5z ZXJ0aW5nL2luc2VydC1kaXYtMDIwLmh0bWwgZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWRpdi0w MjEuaHRtbCBlZGl0aW5nL2luc2VydGluZy9pbnNlcnQtZGl2LTAyMi5odG1sIGVkaXRpbmcvaW5z ZXJ0aW5nL2luc2VydC1kaXYtMDI1Lmh0bWwgZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWRpdi0w MjcuaHRtbCBlZGl0aW5nL2luc2VydGluZy9pbnNlcnQtcGFyYWdyYXBoLTAyLmh0bWwgZWRpdGlu Zy9pbnNlcnRpbmcvaW5zZXJ0LXBhcmFncmFwaC0wMy5odG1sIGVkaXRpbmcvaW5zZXJ0aW5nL2lu c2VydC10YWItMDAyLmh0bWwgZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LXRleHQtd2l0aC1uZXds aW5lcy5odG1sIGVkaXRpbmcvaW5zZXJ0aW5nL3BhcmFncmFwaC1zZXBhcmF0b3ItMDEuaHRtbCBl ZGl0aW5nL2luc2VydGluZy9wYXJhZ3JhcGgtc2VwYXJhdG9yLTAyLmh0bWwgZWRpdGluZy9pbnNl cnRpbmcvcGFyYWdyYXBoLXNlcGFyYXRvci0wMy5odG1sIGVkaXRpbmcvaW5zZXJ0aW5nL3JldHVy bi1rZXktd2l0aC1zZWxlY3Rpb24tMDAxLmh0bWwgZWRpdGluZy9pbnNlcnRpbmcvcmV0dXJuLWtl eS13aXRoLXNlbGVjdGlvbi0wMDIuaHRtbCBlZGl0aW5nL2luc2VydGluZy9yZXR1cm4ta2V5LXdp dGgtc2VsZWN0aW9uLTAwMy5odG1sIGVkaXRpbmcvaW5zZXJ0aW5nL3R5cGluZy0wMDIuaHRtbCBl ZGl0aW5nL2luc2VydGluZy90eXBpbmctYXJvdW5kLWJyLTAwMS5odG1sIGVkaXRpbmcvcGFzdGVi b2FyZC80MjQyMjkzLmh0bWwgZWRpdGluZy9wYXN0ZWJvYXJkLzQ5NDQ3NzAtMS5odG1sIGVkaXRp bmcvcGFzdGVib2FyZC84MTQ1LTIuaHRtbCBlZGl0aW5nL3Bhc3RlYm9hcmQvY29weS1pbi1wYXNz d29yZC1maWVsZC5odG1sIGVkaXRpbmcvcGFzdGVib2FyZC9jdXQtdGV4dC0wMDEuaHRtbCBlZGl0 aW5nL3Bhc3RlYm9hcmQvaW50ZXJjaGFuZ2UtbmV3bGluZS0xLmh0bWwgZWRpdGluZy9wYXN0ZWJv YXJkL21lcmdlLWFmdGVyLWRlbGV0ZS0xLmh0bWwgZWRpdGluZy9wYXN0ZWJvYXJkL21lcmdlLWFm dGVyLWRlbGV0ZS0yLmh0bWwgZWRpdGluZy9wYXN0ZWJvYXJkL21lcmdlLWFmdGVyLWRlbGV0ZS5o dG1sIGVkaXRpbmcvcGFzdGVib2FyZC9tZXJnZS1lbmQtNC5odG1sIGVkaXRpbmcvcGFzdGVib2Fy ZC9tZXJnZS1lbmQtYmxvY2txdW90ZS5odG1sIGVkaXRpbmcvcGFzdGVib2FyZC9tZXJnZS1lbmQt bGlzdC5odG1sIGVkaXRpbmcvcGFzdGVib2FyZC9tZXJnZS1lbmQtdGFibGUuaHRtbCBlZGl0aW5n L3Bhc3RlYm9hcmQvcGFzdGUtYmxvY2txdW90ZS0zLmh0bWwgZWRpdGluZy9wYXN0ZWJvYXJkL3Bh c3RlLXRleHQtMDAxLmh0bWwgZWRpdGluZy9wYXN0ZWJvYXJkL3Bhc3RlLXRleHQtMDEyLmh0bWwg ZWRpdGluZy9wYXN0ZWJvYXJkL3Bhc3RlLXRleHQtMDEzLmh0bWwgZWRpdGluZy9wYXN0ZWJvYXJk L3Bhc3RlLXRleHQtMDE0Lmh0bWwgZWRpdGluZy9wYXN0ZWJvYXJkL3Bhc3RlLXRleHQtMDE5Lmh0 bWwgZWRpdGluZy9wYXN0ZWJvYXJkL3VuZG9hYmxlLWZyYWdtZW50LXJlbW92ZXMuaHRtbCBlZGl0 aW5nL3NlbGVjdGlvbi8xMzgwNC5odG1sIGVkaXRpbmcvc2VsZWN0aW9uLzUyMzQzODMtMS5odG1s IGVkaXRpbmcvc2VsZWN0aW9uLzUyMzQzODMtMi5odG1sIGVkaXRpbmcvc2VsZWN0aW9uL2V4dGVu ZC1ieS13b3JkLTAwMS5odG1sIGVkaXRpbmcvc2VsZWN0aW9uL21vdmUtYmFja3dvcmRzLWJ5LXdv cmQtMDAxLmh0bWwgZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1ieS1jaGFyYWN0ZXItMDAxLmh0bWwg ZWRpdGluZy9zZWxlY3Rpb24vbW92ZS1ieS1saW5lLTAwMS5odG1sIGVkaXRpbmcvc2VsZWN0aW9u L21vdmUtYnktd29yZC0wMDEuaHRtbCBlZGl0aW5nL3NlbGVjdGlvbi91bnJlbmRlcmVkLTAwMi5o dG1sIGVkaXRpbmcvc3BlbGxpbmcvaW5saW5lX3NwZWxsaW5nX21hcmtlcnMuaHRtbCBlZGl0aW5n L3NwZWxsaW5nL3NwZWxsaW5nLmh0bWwgZWRpdGluZy9zdHlsZS81MDQ2ODc1LTIuaHRtbCBlZGl0 aW5nL3N0eWxlL2Jsb2NrLXN0eWxlcy0wMDcuaHRtbCBlZGl0aW5nL3N0eWxlL2NyZWF0ZS1ibG9j ay1mb3Itc3R5bGUtMDAyLmh0bWwgZWRpdGluZy9zdHlsZS9jcmVhdGUtYmxvY2stZm9yLXN0eWxl LTAwMy5odG1sIGVkaXRpbmcvc3R5bGUvY3JlYXRlLWJsb2NrLWZvci1zdHlsZS0wMDQuaHRtbCBl ZGl0aW5nL3N0eWxlL2NyZWF0ZS1ibG9jay1mb3Itc3R5bGUtMDA2Lmh0bWwgZWRpdGluZy9zdHls ZS9jcmVhdGUtYmxvY2stZm9yLXN0eWxlLTAwOC5odG1sIGVkaXRpbmcvc3R5bGUvY3JlYXRlLWJs b2NrLWZvci1zdHlsZS0wMDkuaHRtbCBlZGl0aW5nL3N0eWxlL2NyZWF0ZS1ibG9jay1mb3Itc3R5 bGUtMDEzLmh0bWwgZmFzdC9kb20vYmx1ci1jb250ZW50ZWRpdGFibGUuaHRtbCBmYXN0L2RvbS9v YmplY3QtZW1iZWQtcGx1Z2luLXNjcmlwdGluZy5odG1sIGZhc3QvZG9tL29iamVjdC1wbHVnaW4t aGlkZXMtcHJvcGVydGllcy5odG1sIGZhc3QvZXZlbnRzL29uY2hhbmdlLXBhc3N3b3JkZmllbGQu aHRtbCBmYXN0L2V2ZW50cy90YWJpbmRleC1mb2N1cy1ibHVyLWFsbC5odG1sIGZhc3QvZm9ybXMv Zm9jdXMtY29udHJvbC10by1wYWdlLmh0bWwgZmFzdC9mb3Jtcy9wYXNzd29yZC1kb3VibGVjbGlj ay1zZWxlY3Rpb24uaHRtbCBmYXN0L2Zvcm1zL3Bhc3N3b3JkLXBsYWNlaG9sZGVyLXRleHQtc2Vj dXJpdHkuaHRtbCBwbHVnaW5zL2VtYmVkLWF0dHJpYnV0ZXMtc2V0dGluZy5odG1sIHBsdWdpbnMv ZW1iZWQtYXR0cmlidXRlcy1zdHlsZS5odG1sIHVzZXJzY3JpcHRzL3VzZXItc2NyaXB0LXZpZGVv LWRvY3VtZW50Lmh0bWwK 83426 2011-02-22 19:09:21 -0800 2011-02-22 19:14:19 -0800 Revert of code changes from r79038 bug-54885-20110222190920.patch text/plain 3505 kbr SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA3OTM4NSkKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDItMjIgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hbnkgdGVzdHMgc3Rh cnRlZCB0aW1pbmcgb3V0IG9uIHRoZSBjaHJvbWUgbWFjIGNhbmFyaWVzIGFyb3VuZCByNzkwMzUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0ODg1CisK KyAgICAgICAgUmV2ZXJ0IHRoZSBjb2RlIGNoYW5nZXMsIGJ1dCBub3QgdGhlIENocm9taXVtIERF UFMgcm9sbCwgZnJvbQorICAgICAgICByNzkwMzggdG8gc2VlIHdoZXRoZXIgdGhpcyBjbGVhcnMg dXAgdGhlIHRpbWluZy1vdXQgdGVzdHMuIFdhcyBub3QKKyAgICAgICAgYWJsZSB0byByZXByb2R1 Y2UgdGhlIHRpbWVvdXRzIGxvY2FsbHkgd2l0aCBhIFJlbGVhc2UgbW9kZSBidWlsZAorICAgICAg ICBvZiBEUlQgKG9uIFNub3cgTGVvcGFyZCkuCisKKyAgICAgICAgKiBzcmMvV2ViS2l0LmNwcDoK KyAgICAgICAgKFdlYktpdDo6aW5pdGlhbGl6ZSk6CisKIDIwMTEtMDItMjEgIE5pY28gV2ViZXIg IDx0aGFraXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJvYmlu c29uLgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViS2l0LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJLaXQuY3BwCShyZXZpc2lvbiA3 OTMzMCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYktpdC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTY2LDYgKzY2LDE1IEBAIHZvaWQgaW5pdGlhbGl6ZShXZWJLaXRDbGllbnQqIHdl YktpdENsaWUKICAgICBXVEY6OmluaXRpYWxpemVNYWluVGhyZWFkKCk7CiAgICAgV1RGOjpBdG9t aWNTdHJpbmc6OmluaXQoKTsKIAorICAgIC8vIENocm9taXVtIHNldHMgdGhlIG1pbmltdW0gaW50 ZXJ2YWwgdGltZW91dCB0byA0bXMsIG92ZXJyaWRpbmcgdGhlCisgICAgLy8gZGVmYXVsdCBvZiAx MG1zLiAgV2UnZCBsaWtlIHRvIGdvIGxvd2VyLCBob3dldmVyIHRoZXJlIGFyZSBwb29ybHkKKyAg ICAvLyBjb2RlZCB3ZWJzaXRlcyBvdXQgdGhlcmUgd2hpY2ggZG8gY3JlYXRlIENQVS1zcGlubmlu ZyBsb29wcy4gIFVzaW5nCisgICAgLy8gNG1zIHByZXZlbnRzIHRoZSBDUFUgZnJvbSBzcGlubmlu ZyB0b28gYnVzaWx5IGFuZCBwcm92aWRlcyBhIGJhbGFuY2UKKyAgICAvLyBiZXR3ZWVuIENQVSBz cGlubmluZyBhbmQgdGhlIHNtYWxsZXN0IHBvc3NpYmxlIGludGVydmFsIHRpbWVyLgorICAgIC8v IEZJWE1FOiByZW1vdmUgdGhpcyBjYWxsIG9uY2UgQ2hyb21pdW0gaGFzIGJlZW4gY2hhbmdlZCB0 byBzZXQKKyAgICAvLyB0aGlzIGZvciBhbGwgcGFnZXMgdXNpbmcgdGhlIG5ldyBXZWJTZXR0aW5n cyBBUEkuCisgICAgV2ViQ29yZTo6U2V0dGluZ3M6OnNldERlZmF1bHRNaW5ET01UaW1lckludGVy dmFsKDAuMDA0KTsKKwogICAgIC8vIFRoZXJlIGFyZSBzb21lIGNvZGUgcGF0aHMgKGZvciBleGFt cGxlLCBydW5uaW5nIFdlYktpdCBpbiB0aGUgYnJvd3NlcgogICAgIC8vIHByb2Nlc3MgYW5kIGNh bGxpbmcgaW50byBMb2NhbFN0b3JhZ2UgYmVmb3JlIGFueXRoaW5nIGVsc2UpIHdoZXJlIHRoZQog ICAgIC8vIFVURjggc3RyaW5nIGVuY29kaW5nIHRhYmxlcyBhcmUgdXNlZCBvbiBhIGJhY2tncm91 bmQgdGhyZWFkIGJlZm9yZQpJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL0NoYW5nZUxvZwkocmV2aXNpb24gNzkzODUpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0wMi0yMiAgS2VubmV0aCBSdXNzZWxsICA8 a2JyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTWFueSB0ZXN0cyBzdGFydGVkIHRpbWluZyBvdXQgb24gdGhlIGNocm9tZSBtYWMg Y2FuYXJpZXMgYXJvdW5kIHI3OTAzNQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTQ4ODUKKworICAgICAgICBSZXZlcnQgdGhlIGNvZGUgY2hhbmdlcywg YnV0IG5vdCB0aGUgQ2hyb21pdW0gREVQUyByb2xsLCBmcm9tCisgICAgICAgIHI3OTAzOCB0byBz ZWUgd2hldGhlciB0aGlzIGNsZWFycyB1cCB0aGUgdGltaW5nLW91dCB0ZXN0cy4gV2FzIG5vdAor ICAgICAgICBhYmxlIHRvIHJlcHJvZHVjZSB0aGUgdGltZW91dHMgbG9jYWxseSB3aXRoIGEgUmVs ZWFzZSBtb2RlIGJ1aWxkCisgICAgICAgIG9mIERSVCAob24gU25vdyBMZW9wYXJkKS4KKworICAg ICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcDoKKyAgICAgICAg KFdlYlZpZXdIb3N0OjpyZXNldCk6CisKIDIwMTEtMDItMjIgIERpcmsgUHJhbmtlICA8ZHByYW5r ZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCklu ZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCShy ZXZpc2lvbiA3OTMzMCkKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdI b3N0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTIxMCw3ICsxMjEwLDggQEAgdm9pZCBXZWJWaWV3 SG9zdDo6cmVzZXQoKQogCiAgICAgaWYgKG1fd2ViV2lkZ2V0KSB7CiAgICAgICAgIHdlYlZpZXco KS0+bWFpbkZyYW1lKCktPnNldE5hbWUoV2ViU3RyaW5nKCkpOwotICAgICAgICB3ZWJWaWV3KCkt PnNldHRpbmdzKCktPnNldE1pbmltdW1UaW1lckludGVydmFsKHdlYmtpdF9zdXBwb3J0OjpHZXRG b3JlZ3JvdW5kVGFiVGltZXJJbnRlcnZhbCgpKTsKKyAgICAgICAgLy8gRklYTUU6IGNoYW5nZSB0 byB1c2Ugd2Via2l0X3N1cHBvcnQ6OkZvcmVncm91bmRUYWJUaW1lckludGVydmFsIG9uY2UgdGhh dCBsYW5kcy4KKyAgICAgICAgd2ViVmlldygpLT5zZXR0aW5ncygpLT5zZXRNaW5pbXVtVGltZXJJ bnRlcnZhbCgwLjAwNCk7CiAgICAgfQogfQogCg==