54879 2011-02-21 07:35:24 -0800 Web Inspector: navigation does not work after reopening frontend 2011-02-22 02:08:54 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 podivilov pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr pnormand rik timothy yurys oldest_to_newest 354589 0 podivilov 2011-02-21 07:35:24 -0800 1. Open frontend 2. Close frontend 3. Open frontend 4. Navigate 5. Frontend looks like there was no navigation - elements panel displays the old document, scripts panel shows scripts from previous resource 354657 1 83177 pfeldman 2011-02-21 10:03:12 -0800 Created attachment 83177 [PATCH] Proposed fix. 354661 2 83177 yurys 2011-02-21 10:16:22 -0800 Comment on attachment 83177 [PATCH] Proposed fix. View in context: https://bugs.webkit.org/attachment.cgi?id=83177&action=review > LayoutTests/http/tests/inspector-enabled/open-close-open.html:24 > + layoutTestController.showWebInspector(); How can we be sure that the front-end has already closed? What if there are some unfinished tasks in the front-end? > LayoutTests/http/tests/inspector-enabled/open-close-open.html:52 > +Tests that Web Inspector is functional after the open - close - open sequence. Please include link to the bug in the test description. > Source/WebCore/inspector/InspectorState.h:53 > + void unmute(); Consider replacing these two methods with a setter. 354664 3 pfeldman 2011-02-21 10:29:57 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/http/tests/inspector-enabled/open-close-open-expected.txt A LayoutTests/http/tests/inspector-enabled/open-close-open.html M Source/WebCore/ChangeLog M Source/WebCore/inspector/InspectorAgent.cpp M Source/WebCore/inspector/InspectorState.cpp M Source/WebCore/inspector/InspectorState.h Committed r79234 355143 4 pnormand 2011-02-22 02:08:54 -0800 The new test has been crashing on GTK since checkin: http://webkit-bots.igalia.com/amd64/svn_79301.core-when_1298367632-_-who_DumpRenderTree-_-why_11.trace.html Thread 1 (Thread 30925): #0 0x00007fdf0cd2d9d5 in WebKit::InspectorFrontendClient::~InspectorFrontendClient (this=0x7fdefce44c50, __in_chrg=<value optimized out>) at ../../Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:211 #1 0x00007fdf0cd2e0df in WTF::deleteOwnedPtr<WebCore::InspectorFrontendClient> (ptr=0x7fdefce44c50) at ../../Source/JavaScriptCore/wtf/OwnPtrCommon.h:59 #2 0x00007fdf0d273dd3 in WTF::OwnPtr<WebCore::InspectorFrontendClient>::~OwnPtr (this=0x7fdefce38df0, __in_chrg=<value optimized out>) at ../../Source/JavaScriptCore/wtf/OwnPtr.h:57 #3 0x00007fdf0d2734e6 in WebCore::InspectorController::~InspectorController (this=0x7fdefce38de0, __in_chrg=<value optimized out>) at ../../Source/WebCore/inspector/InspectorController.cpp:62 #4 0x00007fdf0d404935 in WTF::deleteOwnedPtr<WebCore::InspectorController> (ptr=0x7fdefce38de0) at ../../Source/JavaScriptCore/wtf/OwnPtrCommon.h:59 #5 0x00007fdf0d403bad in WTF::OwnPtr<WebCore::InspectorController>::~OwnPtr (this=0x7fdefcb4f108, __in_chrg=<value optimized out>) at ../../Source/JavaScriptCore/wtf/OwnPtr.h:57 #6 0x00007fdf0d4003f6 in WebCore::Page::~Page (this=0x7fdefcb4f0e0, __in_chrg=<value optimized out>) at ../../Source/WebCore/page/Page.cpp:208 #7 0x00007fdf0cd4aed7 in webkit_web_view_dispose (object=0x1f66490) at ../../Source/WebKit/gtk/webkit/webkitwebview.cpp:1396 #8 0x00007fdf0a7b5c90 in g_object_run_dispose (object=0x1f66490) at /tmp/buildd/glib2.0-2.27.91/./gobject/gobject.c:941 #9 0x00007fdf0bdad639 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 #10 0x00007fdf0a7b333e in g_closure_invoke (closure=0x1f08a00, return_value=0x0, n_param_values=1, param_values=0x571ed40, invocation_hint=0x7fff5306fe60) at /tmp/buildd/glib2.0-2.27.91/./gobject/gclosure.c:767 #11 0x00007fdf0a7cc22b in signal_emit_unlocked_R (node=0x1f09070, detail=<value optimized out>, instance=<value optimized out>, emission_return=<value optimized out>, instance_and_params=<value optimized out>) at /tmp/buildd/glib2.0-2.27.91/./gobject/gsignal.c:3368 #12 0x00007fdf0a7cdb36 in g_signal_emit_valist (instance=0x28169f0, signal_id=<value optimized out>, detail=0, var_args=0x7fff53070050) at /tmp/buildd/glib2.0-2.27.91/./gobject/gsignal.c:2983 #13 0x00007fdf0a7ce363 in g_signal_emit (instance=0x7fff5306f2d0, signal_id=0, detail=148278784) at /tmp/buildd/glib2.0-2.27.91/./gobject/gsignal.c:3040 #14 0x00007fdf0be56540 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 #15 0x00007fdf0a7b5c90 in g_object_run_dispose (object=0x28169f0) at /tmp/buildd/glib2.0-2.27.91/./gobject/gobject.c:941 #16 0x000000000041ed0e in webInspectorCloseWindow (data=0x0) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:968 #17 0x00007fdf0cd5dbae in webkit_marshal_BOOLEAN__VOID (closure=0x1ff2430, return_value=0x7fff53070360, n_param_values=1, param_values=0x5137300, invocation_hint=0x7fff53070320, marshal_data=0x0) at DerivedSources/webkit/webkitmarshal.cpp:642 #18 0x00007fdf0a7b333e in g_closure_invoke (closure=0x1ff2430, return_value=0x7fff53070360, n_param_values=1, param_values=0x5137300, invocation_hint=0x7fff53070320) at /tmp/buildd/glib2.0-2.27.91/./gobject/gclosure.c:767 #19 0x00007fdf0a7cc3b9 in signal_emit_unlocked_R (node=0x1f69570, detail=<value optimized out>, instance=<value optimized out>, emission_return=<value optimized out>, instance_and_params=<value optimized out>) at /tmp/buildd/glib2.0-2.27.91/./gobject/gsignal.c:3252 #20 0x00007fdf0a7cd97c in g_signal_emit_valist (instance=0x1f59540, signal_id=<value optimized out>, detail=0, var_args=0x7fff53070540) at /tmp/buildd/glib2.0-2.27.91/./gobject/gsignal.c:2993 #21 0x00007fdf0a7cde32 in g_signal_emit_by_name (instance=0x1f59540, detailed_signal=<value optimized out>) at /tmp/buildd/glib2.0-2.27.91/./gobject/gsignal.c:3077 #22 0x00007fdf0cd2dae6 in WebKit::InspectorFrontendClient::destroyInspectorWindow (this=0x58661f0, notifyInspectorController=false) at ../../Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:231 #23 0x00007fdf0cd2dd01 in WebKit::InspectorFrontendClient::disconnectFromBackend (this=0x58661f0) at ../../Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:272 #24 0x00007fdf0d2ad5d8 in WebCore::InspectorFrontendHost::disconnectFromBackend (this=0x7fdefc0ba9d0) at ../../Source/WebCore/inspector/InspectorFrontendHost.cpp:173 #25 0x00007fdf0d993218 in WebCore::jsInspectorFrontendHostPrototypeFunctionDisconnectFromBackend (exec=0x7fdebb7bb140) at DerivedSources/WebCore/JSInspectorFrontendHost.cpp:224 83177 2011-02-21 10:03:12 -0800 2011-02-21 10:16:22 -0800 [PATCH] Proposed fix. open_close text/plain 5086 pfeldman ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2ZWUwYTVlLi4zNTA4NWZmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDIt MjEgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogbmF2aWdh dGlvbiBkb2VzIG5vdCB3b3JrIGFmdGVyIHJlb3BlbmluZyBmcm9udGVuZC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0ODc5CisKKyAgICAgICAgKiBo dHRwL3Rlc3RzL2luc3BlY3Rvci1lbmFibGVkL29wZW4tY2xvc2Utb3Blbi1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvaW5zcGVjdG9yLWVuYWJsZWQvb3Blbi1jbG9z ZS1vcGVuLmh0bWw6IEFkZGVkLgorCiAyMDExLTAyLTE4ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5v cm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24u CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci1lbmFibGVkL29w ZW4tY2xvc2Utb3Blbi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3Bl Y3Rvci1lbmFibGVkL29wZW4tY2xvc2Utb3Blbi1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMC4uYjYxNWM3NAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9yLWVuYWJsZWQvb3Blbi1jbG9zZS1vcGVuLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxLDUgQEAKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAxMzogT3BlbmluZyBX ZWIgSW5zcGVjdG9yLgorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDIwOiBDbG9zaW5nIFdlYiBJbnNw ZWN0b3IuCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMjM6IFJlLW9wZW5kaW5nIFdlYiBJbnNwZWN0 b3IuCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMzI6IENvbXBsZXRpbmcgdGhlIHRlc3QuCitUZXN0 cyB0aGF0IFdlYiBJbnNwZWN0b3IgaXMgZnVuY3Rpb25hbCBhZnRlciB0aGUgb3BlbiAtIGNsb3Nl IC0gb3BlbiBzZXF1ZW5jZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5z cGVjdG9yLWVuYWJsZWQvb3Blbi1jbG9zZS1vcGVuLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL2luc3BlY3Rvci1lbmFibGVkL29wZW4tY2xvc2Utb3Blbi5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAuLjA1YzE3ZTcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci1lbmFibGVkL29wZW4tY2xvc2Utb3Blbi5odG1sCkBA IC0wLDAgKzEsNTUgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwv L0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgorCitmdW5jdGlvbiBvbmxvYWQoKQorewor ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53 YWl0VW50aWxEb25lKCk7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLnNob3dXZWJJbnNw ZWN0b3IoKTsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZXZhbHVhdGVJbldlYkluc3Bl Y3RvcigwLCAidHJ1ZSIpOworICAgICAgICBjb25zb2xlLmxvZygiT3BlbmluZyBXZWIgSW5zcGVj dG9yLiIpOworICAgIH0KK30KKworZnVuY3Rpb24gZGlkRXZhbHVhdGVGb3JUZXN0SW5Gcm9udGVu ZChjYWxsSWQpCit7CisgICAgaWYgKGNhbGxJZCA9PT0gMCkgeworICAgICAgICBjb25zb2xlLmxv ZygiQ2xvc2luZyBXZWIgSW5zcGVjdG9yLiIpOworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5jbG9zZVdlYkluc3BlY3RvcigpOworCisgICAgICAgIGNvbnNvbGUubG9nKCJSZS1vcGVuZGlu ZyBXZWIgSW5zcGVjdG9yLiIpOworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zaG93V2Vi SW5zcGVjdG9yKCk7CisKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZXZhbHVhdGVJbldl Ykluc3BlY3RvcigxLCAiKCIgKyBmcm9udGVuZF90ZXN0Q29tbXVudWNhdGlvbldpdGhTZXJ2ZXIg KyAiKSgpIik7CisgICAgfQorfQorCitmdW5jdGlvbiBjb21wbGV0ZVRlc3QoKQoreworICAgIGNv bnNvbGUubG9nKCJDb21wbGV0aW5nIHRoZSB0ZXN0LiIpOworCisgICAgLy8gUmVsZWFzZSAnZXZh bHVhdGUnIGNvbnRyb2wsIHJlcG9ydCByZXN1bHQgYW5kIG9uIGNsb3NlIGFmdGVyd2FyZHMuCisg ICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu Y2xvc2VXZWJJbnNwZWN0b3IoKTsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5 RG9uZSgpOworICAgIH0sIDApOworfQorCitmdW5jdGlvbiBmcm9udGVuZF90ZXN0Q29tbXVudWNh dGlvbldpdGhTZXJ2ZXIoKQoreworICAgIFJ1bnRpbWVBZ2VudC5ldmFsdWF0ZSgiY29tcGxldGVU ZXN0KCkiLCAiY29uc29sZSIsIGZhbHNlKTsKK30KKworPC9zY3JpcHQ+CisKKzwvaGVhZD4KKwor PGJvZHkgb25sb2FkPSJvbmxvYWQoKSI+Cis8cD4KK1Rlc3RzIHRoYXQgV2ViIEluc3BlY3RvciBp cyBmdW5jdGlvbmFsIGFmdGVyIHRoZSBvcGVuIC0gY2xvc2UgLSBvcGVuIHNlcXVlbmNlLgorPC9w PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDA0MDNhY2UuLmQ2NWMwMzcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0wMi0yMSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxk bWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBuYXZpZ2F0aW9uIGRvZXMgbm90IHdvcmsgYWZ0ZXIg cmVvcGVuaW5nIGZyb250ZW5kLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NTQ4NzkKKworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL2luc3BlY3Rvci1l bmFibGVkL29wZW4tY2xvc2Utb3Blbi5odG1sCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVj dG9yQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQWdlbnQ6OnNldEZyb250 ZW5kKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yU3RhdGUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SW5zcGVjdG9yU3RhdGU6OnVubXV0ZSk6CisgICAgICAgICogaW5zcGVjdG9yL0lu c3BlY3RvclN0YXRlLmg6CisKIDIwMTEtMDItMjEgIEFuZG9uaSBNb3JhbGVzIEFsYXN0cnVleSAg PGFtb3JhbGVzQGZsdW1vdGlvbi5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJv Ymluc29uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckFn ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JBZ2VudC5jcHAKaW5k ZXggNmZlYzQzZC4uOGUxNzhhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvckFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVj dG9yQWdlbnQuY3BwCkBAIC0zMzUsNiArMzM1LDkgQEAgdm9pZCBJbnNwZWN0b3JBZ2VudDo6c2V0 U2VhcmNoaW5nRm9yTm9kZShib29sIGVuYWJsZWQsIGJvb2wqIG5ld1N0YXRlKQogCiB2b2lkIElu c3BlY3RvckFnZW50OjpzZXRGcm9udGVuZChJbnNwZWN0b3JGcm9udGVuZCogaW5zcGVjdG9yRnJv bnRlbmQpCiB7CisgICAgLy8gV2UgY2FuIHJlY29ubmVjdCB0byBleGlzdGluZyBmcm9udC1lbmQg LT4gdW5tdXRlIHN0YXRlLgorICAgIG1fc3RhdGUtPnVubXV0ZSgpOworCiAgICAgbV9mcm9udGVu ZCA9IGluc3BlY3RvckZyb250ZW5kOwogICAgIGNyZWF0ZUZyb250ZW5kTGlmZXRpbWVBZ2VudHMo KTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0YXRl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdGF0ZS5jcHAKaW5kZXgg MjkwZmZjMi4uODk3NzI0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvclN0YXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y U3RhdGUuY3BwCkBAIC01OSw2ICs1OSwxMSBAQCB2b2lkIEluc3BlY3RvclN0YXRlOjptdXRlKCkK ICAgICBtX2lzT25NdXRlID0gdHJ1ZTsKIH0KIAordm9pZCBJbnNwZWN0b3JTdGF0ZTo6dW5tdXRl KCkKK3sKKyAgICBtX2lzT25NdXRlID0gZmFsc2U7Cit9CisKIHZvaWQgSW5zcGVjdG9yU3RhdGU6 OnVwZGF0ZUNvb2tpZSgpCiB7CiAgICAgaWYgKCFtX2lzT25NdXRlKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclN0YXRlLmggYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yU3RhdGUuaAppbmRleCAzYTljM2VkLi4xY2FlOWFkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3RhdGUuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3RhdGUuaApAQCAtNTAsNiArNTAsNyBAQCBw dWJsaWM6CiAgICAgdmlydHVhbCB+SW5zcGVjdG9yU3RhdGUoKSB7fQogCiAgICAgdm9pZCBtdXRl KCk7CisgICAgdm9pZCB1bm11dGUoKTsKIAogICAgIGJvb2wgZ2V0Qm9vbGVhbihjb25zdCBTdHJp bmcmIHByb3BlcnR5TmFtZSk7CiAgICAgU3RyaW5nIGdldFN0cmluZyhjb25zdCBTdHJpbmcmIHBy b3BlcnR5TmFtZSk7Cg==