54871 2011-02-21 04:44:01 -0800 [Qt][V8]REGRESSION(r79157): Fix build 2011-02-23 04:58:04 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 1 ossy webkit-unassigned kling menard oldest_to_newest 354522 0 ossy 2011-02-21 04:44:01 -0800 http://trac.webkit.org/changeset/79209 broke Qt-V8 build on Linux, because Success is a macro from SerializedScriptValue.cpp -> config.h -> npruntime_internal.h -> nptypes.h ->npapi.h -> X11/xlib.h -> X11/X.h : Status { Success, InputError, JSException, JSFailure }; We should undef Success before using it. Patch is coming soon. 354530 1 83151 ossy 2011-02-21 04:59:33 -0800 Created attachment 83151 propsed patch See http://trac.webkit.org/changeset/67323 for similar fix. 354531 2 83151 kling 2011-02-21 05:01:21 -0800 Comment on attachment 83151 propsed patch Sigh. r=me 354533 3 ossy 2011-02-21 05:05:41 -0800 Landed in http://trac.webkit.org/changeset/79210 356031 4 menard 2011-02-23 04:58:04 -0800 Landed in http://trac.webkit.org/changeset/79210 so we can close the bug. 83151 2011-02-21 04:59:33 -0800 2011-02-21 05:06:06 -0800 propsed patch 1.patch text/plain 933 ossy SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc5MjA5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDItMjEgIENzYWJhIE9z enRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdW1Y4XVJFR1JFU1NJT04ocjc5MTU3KTogRml4IGJ1 aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDg3 MQorCisgICAgICAgICogYnJpZGdlL25wcnVudGltZV9pbnRlcm5hbC5oOiBBZGQgb25lIG1vcmUg dW5kZWYgYmVjYXVzZSBvZiBldmlsIFgxMSBtYWNyby4KKwogMjAxMS0wMi0xNiAgVml0YWx5IFJl cGVzaGtvICA8dml0YWx5ckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWlo YWkgUGFycGFyaXRhLgpJbmRleDogU291cmNlL1dlYkNvcmUvYnJpZGdlL25wcnVudGltZV9pbnRl cm5hbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JyaWRnZS9ucHJ1bnRpbWVfaW50 ZXJuYWwuaAkocmV2aXNpb24gNzkyMDkpCisrKyBTb3VyY2UvV2ViQ29yZS9icmlkZ2UvbnBydW50 aW1lX2ludGVybmFsLmgJKHdvcmtpbmcgY29weSkKQEAgLTUwLDQgKzUwLDUgQEAKICAgICAjdW5k ZWYgTm9ybWFsU3RhdGUKICAgICAjdW5kZWYgVHJ1ZQogICAgICN1bmRlZiBGYWxzZQorICAgICN1 bmRlZiBTdWNjZXNzCiAjZW5kaWYK