54866 2011-02-21 04:12:50 -0800 Web Inspector: [Text editor] Optimize editing updates in gutter panel 2011-02-21 07:03:52 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 53588 0 aandrey webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr podivilov rik timothy yurys oldest_to_newest 354513 0 aandrey 2011-02-21 04:12:50 -0800 Optimize editing updates in the gutter panel. Instead of rebuilding all chunks, now we update only the very last chunk and delete/create others as necessary. 354514 1 83145 aandrey 2011-02-21 04:17:30 -0800 Created attachment 83145 Patch 354576 2 83145 podivilov 2011-02-21 07:03:43 -0800 Comment on attachment 83145 Patch Clearing flags on attachment: 83145 Committed r79221: <http://trac.webkit.org/changeset/79221> 354577 3 podivilov 2011-02-21 07:03:52 -0800 All reviewed patches have been landed. Closing bug. 83145 2011-02-21 04:17:30 -0800 2011-02-21 07:03:43 -0800 Patch bug-54866-20110221151728.patch text/plain 6805 aandrey ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NTQ5MjkxZGVkYmI4NmJmYjcxYjRlZDlmZWUxZDQzZDg2YTU1OWY4Li4z YmFhNGJlMmEyNTY5MDVjNWFjNmRiODk4N2I3MTA3MGM1MWI5Mjk0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjEgQEAKKzIwMTEtMDItMjEgIEFuZHJleSBBZGFpa2luICA8YWFuZHJleUBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl YiBJbnNwZWN0b3I6IFtUZXh0IGVkaXRvcl0gT3B0aW1pemUgZWRpdGluZyB1cGRhdGVzIGluIGd1 dHRlciBwYW5lbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTQ4NjYKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0Vmlld2VyLnByb3RvdHlwZS5zZXQgc3RhcnRFZGl0 aW5nTGlzdGVuZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRWaWV3ZXIucHJvdG90eXBl LnNldCBlbmRFZGl0aW5nTGlzdGVuZXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRWaWV3 ZXIucHJvdG90eXBlLmVuZFVwZGF0ZXMpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRWaWV3 ZXIucHJvdG90eXBlLl9lbnRlckludGVybmFsVGV4dENoYW5nZU1vZGUpOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlRleHRWaWV3ZXIucHJvdG90eXBlLl9leGl0SW50ZXJuYWxUZXh0Q2hhbmdlTW9k ZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRvckNodW5rZWRQYW5lbC5wcm90b3R5 cGUuX2NodW5rTnVtYmVyRm9yTGluZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRv ckd1dHRlclBhbmVsLnByb3RvdHlwZS5fZXhwYW5kQ2h1bmtzKToKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5UZXh0RWRpdG9yR3V0dGVyUGFuZWwucHJvdG90eXBlLnRleHRDaGFuZ2VkKToKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZS5fdXBkYXRlQ2h1 bmtzRm9yUmFuZ2VzKToKKwogMjAxMS0wMi0xOCAgQW5kcmV5IEFkYWlraW4gIDxhYW5kcmV5QGdv b2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qcyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qcwppbmRleCAxMWE3 NTQ1NDE3YTgyYzU1ZmM1MDM2ZTk1YzJjZjE5NDNmNTRkMjQ0Li5jZGNiMjcxOGNiNmIxZDRhOTAx Y2YyMzE5MzEwMWIyMDg0MWJjMWYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RleHRWaWV3ZXIuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9UZXh0Vmlld2VyLmpzCkBAIC01OCw2ICs1OCwxNiBAQCBXZWJJbnNwZWN0b3Iu VGV4dFZpZXdlci5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX21haW5QYW5lbC5yZWFkT25s eSA9IHJlYWRPbmx5OwogICAgIH0sCiAKKyAgICBzZXQgc3RhcnRFZGl0aW5nTGlzdGVuZXIoc3Rh cnRFZGl0aW5nTGlzdGVuZXIpCisgICAgeworICAgICAgICB0aGlzLl9zdGFydEVkaXRpbmdMaXN0 ZW5lciA9IHN0YXJ0RWRpdGluZ0xpc3RlbmVyOworICAgIH0sCisKKyAgICBzZXQgZW5kRWRpdGlu Z0xpc3RlbmVyKGVuZEVkaXRpbmdMaXN0ZW5lcikKKyAgICB7CisgICAgICAgIHRoaXMuX2VuZEVk aXRpbmdMaXN0ZW5lciA9IGVuZEVkaXRpbmdMaXN0ZW5lcjsKKyAgICB9LAorCiAgICAgZ2V0IHRl eHRNb2RlbCgpCiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fdGV4dE1vZGVsOwpAQCAtMTM2 LDYgKzE0Niw3IEBAIFdlYkluc3BlY3Rvci5UZXh0Vmlld2VyLnByb3RvdHlwZSA9IHsKICAgICB7 CiAgICAgICAgIHRoaXMuX21haW5QYW5lbC5lbmRVcGRhdGVzKCk7CiAgICAgICAgIHRoaXMuX2d1 dHRlclBhbmVsLmVuZFVwZGF0ZXMoKTsKKyAgICAgICAgdGhpcy5fdXBkYXRlUGFuZWxPZmZzZXRz KCk7CiAgICAgfSwKIAogICAgIHJlc2l6ZTogZnVuY3Rpb24oKQpAQCAtMTU4LDE1ICsxNjksMjEg QEAgV2ViSW5zcGVjdG9yLlRleHRWaWV3ZXIucHJvdG90eXBlID0gewogICAgIF9lbnRlckludGVy bmFsVGV4dENoYW5nZU1vZGU6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIHRoaXMuX2ludGVy bmFsVGV4dENoYW5nZU1vZGUgPSB0cnVlOworCisgICAgICAgIGlmICh0aGlzLl9zdGFydEVkaXRp bmdMaXN0ZW5lcikKKyAgICAgICAgICAgIHRoaXMuX3N0YXJ0RWRpdGluZ0xpc3RlbmVyKCk7CiAg ICAgfSwKIAogICAgIF9leGl0SW50ZXJuYWxUZXh0Q2hhbmdlTW9kZTogZnVuY3Rpb24ob2xkUmFu Z2UsIG5ld1JhbmdlKQogICAgIHsKICAgICAgICAgdGhpcy5faW50ZXJuYWxUZXh0Q2hhbmdlTW9k ZSA9IGZhbHNlOwogCi0gICAgICAgIC8vIEZJWE1FOiBVcGRhdGUgZ3V0dGVyIHNtYXJ0bHkhCisg ICAgICAgIC8vIFVwZGF0ZSB0aGUgZ3V0dGVyIHBhbmVsLgogICAgICAgICB0aGlzLl9ndXR0ZXJQ YW5lbC50ZXh0Q2hhbmdlZChvbGRSYW5nZSwgbmV3UmFuZ2UpOwogICAgICAgICB0aGlzLl91cGRh dGVQYW5lbE9mZnNldHMoKTsKKworICAgICAgICBpZiAodGhpcy5fZW5kRWRpdGluZ0xpc3RlbmVy KQorICAgICAgICAgICAgdGhpcy5fZW5kRWRpdGluZ0xpc3RlbmVyKG9sZFJhbmdlLCBuZXdSYW5n ZSk7CiAgICAgfSwKIAogICAgIF91cGRhdGVQYW5lbE9mZnNldHM6IGZ1bmN0aW9uKCkKQEAgLTM3 MCwxMiArMzg3LDE3IEBAIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yQ2h1bmtlZFBhbmVsLnByb3Rv dHlwZSA9IHsKIAogICAgIF9jaHVua051bWJlckZvckxpbmU6IGZ1bmN0aW9uKGxpbmVOdW1iZXIp CiAgICAgewotICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMuX3RleHRDaHVua3MubGVu Z3RoOyArK2kpIHsKLSAgICAgICAgICAgIHZhciBsaW5lID0gdGhpcy5fdGV4dENodW5rc1tpXS5z dGFydExpbmU7Ci0gICAgICAgICAgICBpZiAobGluZU51bWJlciA+PSBsaW5lICYmIGxpbmVOdW1i ZXIgPCBsaW5lICsgdGhpcy5fdGV4dENodW5rc1tpXS5saW5lc0NvdW50KQotICAgICAgICAgICAg ICAgIHJldHVybiBpOworICAgICAgICAvLyBCaXNlY3QuCisgICAgICAgIHZhciBmcm9tID0gMDsK KyAgICAgICAgdmFyIHRvID0gdGhpcy5fdGV4dENodW5rcy5sZW5ndGggLSAxOworICAgICAgICB3 aGlsZSAoZnJvbSA8IHRvKSB7CisgICAgICAgICAgICB2YXIgbWlkID0gTWF0aC5mbG9vcigoZnJv bSArIHRvICsgMSkgLyAyKTsKKyAgICAgICAgICAgIGlmICh0aGlzLl90ZXh0Q2h1bmtzW21pZF0u c3RhcnRMaW5lIDw9IGxpbmVOdW1iZXIpCisgICAgICAgICAgICAgICAgZnJvbSA9IG1pZDsKKyAg ICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICB0byA9IG1pZCAtIDE7CiAgICAgICAgIH0K LSAgICAgICAgcmV0dXJuIHRoaXMuX3RleHRDaHVua3MubGVuZ3RoIC0gMTsKKyAgICAgICAgcmV0 dXJuIGZyb207CiAgICAgfSwKIAogICAgIGNodW5rRm9yTGluZTogZnVuY3Rpb24obGluZU51bWJl cikKQEAgLTQ3MSw2ICs0OTMsNDAgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JHdXR0ZXJQYW5l bC5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMu X3RleHRDaHVua3MubGVuZ3RoOyArK2kpCiAgICAgICAgICAgICB0aGlzLl90ZXh0Q2h1bmtzW2ld LmV4cGFuZGVkID0gKGZyb21JbmRleCA8PSBpICYmIGkgPCB0b0luZGV4KTsKKyAgICB9LAorCisg ICAgdGV4dENoYW5nZWQ6IGZ1bmN0aW9uKG9sZFJhbmdlLCBuZXdSYW5nZSkKKyAgICB7CisgICAg ICAgIGlmICghdGhpcy5fdGV4dENodW5rcykgeworICAgICAgICAgICAgdGhpcy5fYnVpbGRDaHVu a3MoKTsKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgfQorCisgICAgICAgIHZhciBsaW5l c0RpZmYgPSBuZXdSYW5nZS5saW5lc0NvdW50IC0gb2xkUmFuZ2UubGluZXNDb3VudDsKKyAgICAg ICAgaWYgKGxpbmVzRGlmZikgeworICAgICAgICAgICAgLy8gUmVtb3ZlIG9sZCBjaHVua3MgKGlm IG5lZWRlZCkuCisgICAgICAgICAgICBmb3IgKHZhciBjaHVua051bWJlciA9IHRoaXMuX3RleHRD aHVua3MubGVuZ3RoIC0gMTsgY2h1bmtOdW1iZXIgPj0gMCA7IC0tY2h1bmtOdW1iZXIpIHsKKyAg ICAgICAgICAgICAgICB2YXIgY2h1bmsgPSB0aGlzLl90ZXh0Q2h1bmtzW2NodW5rTnVtYmVyXTsK KyAgICAgICAgICAgICAgICBpZiAoY2h1bmsuc3RhcnRMaW5lICsgY2h1bmsubGluZXNDb3VudCA8 PSB0aGlzLl90ZXh0TW9kZWwubGluZXNDb3VudCkKKyAgICAgICAgICAgICAgICAgICAgYnJlYWs7 CisgICAgICAgICAgICAgICAgY2h1bmsuZXhwYW5kZWQgPSBmYWxzZTsKKyAgICAgICAgICAgICAg ICB0aGlzLmVsZW1lbnQucmVtb3ZlQ2hpbGQoY2h1bmsuZWxlbWVudCk7CisgICAgICAgICAgICB9 CisgICAgICAgICAgICB0aGlzLl90ZXh0Q2h1bmtzLmxlbmd0aCA9IGNodW5rTnVtYmVyICsgMTsK KworICAgICAgICAgICAgLy8gQWRkIG5ldyBjaHVua3MgKGlmIG5lZWRlZCkuCisgICAgICAgICAg ICB2YXIgdG90YWxMaW5lcyA9IDA7CisgICAgICAgICAgICBpZiAodGhpcy5fdGV4dENodW5rcy5s ZW5ndGgpIHsKKyAgICAgICAgICAgICAgICB2YXIgbGFzdENodW5rID0gdGhpcy5fdGV4dENodW5r c1t0aGlzLl90ZXh0Q2h1bmtzLmxlbmd0aCAtIDFdOworICAgICAgICAgICAgICAgIHRvdGFsTGlu ZXMgPSBsYXN0Q2h1bmsuc3RhcnRMaW5lICsgbGFzdENodW5rLmxpbmVzQ291bnQ7CisgICAgICAg ICAgICB9CisgICAgICAgICAgICBmb3IgKHZhciBpID0gdG90YWxMaW5lczsgaSA8IHRoaXMuX3Rl eHRNb2RlbC5saW5lc0NvdW50OyBpICs9IHRoaXMuX2RlZmF1bHRDaHVua1NpemUpIHsKKyAgICAg ICAgICAgICAgICB2YXIgY2h1bmsgPSB0aGlzLl9jcmVhdGVOZXdDaHVuayhpLCBpICsgdGhpcy5f ZGVmYXVsdENodW5rU2l6ZSk7CisgICAgICAgICAgICAgICAgdGhpcy5fdGV4dENodW5rcy5wdXNo KGNodW5rKTsKKyAgICAgICAgICAgICAgICB0aGlzLmVsZW1lbnQuYXBwZW5kQ2hpbGQoY2h1bmsu ZWxlbWVudCk7CisgICAgICAgICAgICB9CisgICAgICAgICAgICB0aGlzLl9yZXBhaW50QWxsKCk7 CisgICAgICAgIH0KICAgICB9CiB9CiAKQEAgLTEyNTcsNyArMTMxMywxMiBAQCBXZWJJbnNwZWN0 b3IuVGV4dEVkaXRvck1haW5QYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciBzY3JvbGxM ZWZ0ID0gdGhpcy5lbGVtZW50LnNjcm9sbExlZnQ7CiAKICAgICAgICAgLy8gRGVsZXRlIGFsbCBE T00gZWxlbWVudHMgdGhhdCB3ZXJlIGVpdGhlciBjb250cm9sbGVkIGJ5IHRoZSBvbGQgY2h1bmtz LCBvciBoYXZlIGp1c3QgYmVlbiBpbnNlcnRlZC4KLSAgICAgICAgd2hpbGUgKGZpcnN0TGluZVJv dyAmJiAodHlwZW9mIGZpcnN0TGluZVJvdy5saW5lTnVtYmVyICE9PSAibnVtYmVyIiB8fCBmaXJz dExpbmVSb3cubGluZU51bWJlciA8IHN0YXJ0TGluZSArIGxpbmVzQ291bnQgfHwgZmlyc3RMaW5l Um93LmxpbmVOdW1iZXIgPj0gdGhpcy5fdGV4dE1vZGVsLmxpbmVzQ291bnQpKSB7CisgICAgICAg IHZhciBmaXJzdFVubW9kaWZpZWRMaW5lUm93ID0gbnVsbDsKKyAgICAgICAgdmFyIGNodW5rID0g dGhpcy5fdGV4dENodW5rc1tsYXN0Q2h1bmtOdW1iZXIgKyAxXTsKKyAgICAgICAgaWYgKGNodW5r KSB7CisgICAgICAgICAgICBmaXJzdFVubW9kaWZpZWRMaW5lUm93ID0gY2h1bmsuZXhwYW5kZWQg PyBjaHVuay5nZXRFeHBhbmRlZExpbmVSb3coY2h1bmsuc3RhcnRMaW5lKSA6IGNodW5rLmVsZW1l bnQ7CisgICAgICAgIH0KKyAgICAgICAgd2hpbGUgKGZpcnN0TGluZVJvdyAmJiBmaXJzdExpbmVS b3cgIT09IGZpcnN0VW5tb2RpZmllZExpbmVSb3cpIHsKICAgICAgICAgICAgIHZhciBsaW5lUm93 ID0gZmlyc3RMaW5lUm93OwogICAgICAgICAgICAgZmlyc3RMaW5lUm93ID0gZmlyc3RMaW5lUm93 Lm5leHRTaWJsaW5nOwogICAgICAgICAgICAgdGhpcy5lbGVtZW50LnJlbW92ZUNoaWxkKGxpbmVS b3cpOwpAQCAtMTI2Nyw3ICsxMzI4LDcgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFu ZWwucHJvdG90eXBlID0gewogICAgICAgICBmb3IgKHZhciBjaHVua051bWJlciA9IGZpcnN0Q2h1 bmtOdW1iZXI7IGxpbmVzQ291bnQgPiAwOyArK2NodW5rTnVtYmVyKSB7CiAgICAgICAgICAgICB2 YXIgY2h1bmtMaW5lc0NvdW50ID0gTWF0aC5taW4odGhpcy5fZGVmYXVsdENodW5rU2l6ZSwgbGlu ZXNDb3VudCk7CiAgICAgICAgICAgICB2YXIgbmV3Q2h1bmsgPSB0aGlzLl9jcmVhdGVOZXdDaHVu ayhzdGFydExpbmUsIHN0YXJ0TGluZSArIGNodW5rTGluZXNDb3VudCk7Ci0gICAgICAgICAgICB0 aGlzLmVsZW1lbnQuaW5zZXJ0QmVmb3JlKG5ld0NodW5rLmVsZW1lbnQsIGZpcnN0TGluZVJvdyk7 CisgICAgICAgICAgICB0aGlzLmVsZW1lbnQuaW5zZXJ0QmVmb3JlKG5ld0NodW5rLmVsZW1lbnQs IGZpcnN0VW5tb2RpZmllZExpbmVSb3cpOwogCiAgICAgICAgICAgICBpZiAoY2h1bmtOdW1iZXIg PD0gbGFzdENodW5rTnVtYmVyKQogICAgICAgICAgICAgICAgIHRoaXMuX3RleHRDaHVua3NbY2h1 bmtOdW1iZXJdID0gbmV3Q2h1bms7Cg==