54860 2011-02-21 01:55:24 -0800 [GTK] [REGRESSION] After r79130, spell tests did not work 2011-02-21 06:30:25 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 alex webkit-unassigned ryuan.choi xan.lopez oldest_to_newest 354465 0 alex 2011-02-21 01:55:24 -0800 Apparently the dicts are not correctly set during initialization. http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r79193%20(19546)/results.html 354469 1 83139 alex 2011-02-21 02:04:08 -0800 Created attachment 83139 Proposed patch 354503 2 83139 xan.lopez 2011-02-21 03:11:58 -0800 Comment on attachment 83139 Proposed patch I think you are missing carrying the setting in webkit_web_settings_copy, but looks good otherwise. 354505 3 xan.lopez 2011-02-21 03:14:27 -0800 (In reply to comment #2) > (From update of attachment 83139 [details]) > I think you are missing carrying the setting in webkit_web_settings_copy, but looks good otherwise. Nevermind, it's there but I didn't see it. 354563 4 alex 2011-02-21 06:30:25 -0800 Landed http://trac.webkit.org/changeset/79215 83139 2011-02-21 02:04:08 -0800 2011-02-21 03:11:58 -0800 Proposed patch spell.patch text/plain 3943 alex ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCBkZWVkODY2Li5jMDg1OGMzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMjEgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGln YWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dUS10gW1JFR1JFU1NJT05dIEFmdGVyIHI3OTEzMCwgc3BlbGwgdGVzdHMgZGlkIG5vdCB3 b3JrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDg2 MAorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvVGV4dENoZWNrZXJDbGllbnRFbmNoYW50LmNw cDoKKyAgICAgICAgKFdlYktpdDo6VGV4dENoZWNrZXJDbGllbnRFbmNoYW50OjpjaGVja1NwZWxs aW5nT2ZTdHJpbmcpOiBBdm9pZGVkCisgICAgICAgIGZyZWVpbmcgdGhlIGRlZmF1bHQgUGFuZ29M YW5ndWFnZS4KKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CisgICAgICAgICh3 ZWJraXRfd2ViX3ZpZXdfdXBkYXRlX3NldHRpbmdzKTogSW5pdGlhbGl6ZWQgbGlzdCBvZiBkaWN0 aW9uYXJpZXMuCisKIDIwMTEtMDItMTkgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L1RleHRDaGVja2VyQ2xpZW50RW5jaGFu dC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9UZXh0Q2hlY2tlckNsaWVu dEVuY2hhbnQuY3BwCmluZGV4IGVlMWIxMWEuLjc0ZTgxMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L1RleHRDaGVja2VyQ2xpZW50RW5jaGFudC5jcHAKKysr IGIvU291cmNlL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvVGV4dENoZWNrZXJDbGllbnRFbmNo YW50LmNwcApAQCAtODAsMTEgKzgwLDExIEBAIHZvaWQgVGV4dENoZWNrZXJDbGllbnRFbmNoYW50 OjpjaGVja1NwZWxsaW5nT2ZTdHJpbmcoY29uc3QgVUNoYXIqIHRleHQsIGludCBsZW5nCiAgICAg Z2NoYXIqIGN0ZXh0ID0gZ191dGYxNl90b191dGY4KGNvbnN0X2Nhc3Q8Z3VuaWNoYXIyKj4odGV4 dCksIGxlbmd0aCwgMCwgMCwgMCk7CiAgICAgaW50IHV0ZmxlbiA9IGdfdXRmOF9zdHJsZW4oY3Rl eHQsIC0xKTsKIAotICAgIEdPd25QdHI8UGFuZ29MYW5ndWFnZT4gbGFuZ3VhZ2UocGFuZ29fbGFu Z3VhZ2VfZ2V0X2RlZmF1bHQoKSk7CisgICAgUGFuZ29MYW5ndWFnZSogbGFuZ3VhZ2UocGFuZ29f bGFuZ3VhZ2VfZ2V0X2RlZmF1bHQoKSk7CiAgICAgR093blB0cjxQYW5nb0xvZ0F0dHI+IGF0dHJz KGdfbmV3KFBhbmdvTG9nQXR0ciwgdXRmbGVuKzEpKTsKIAogICAgIC8vIHBhbmdvX2dldF9sb2df YXR0cnMgdXNlcyBhbiBhZGl0aW9uYWwgcG9zaXRpb24gYXQgdGhlIGVuZCBvZiB0aGUgdGV4dC4K LSAgICBwYW5nb19nZXRfbG9nX2F0dHJzKGN0ZXh0LCAtMSwgLTEsIGxhbmd1YWdlLmdldCgpLCBh dHRycy5nZXQoKSwgdXRmbGVuKzEpOworICAgIHBhbmdvX2dldF9sb2dfYXR0cnMoY3RleHQsIC0x LCAtMSwgbGFuZ3VhZ2UsIGF0dHJzLmdldCgpLCB1dGZsZW4rMSk7CiAKICAgICBmb3IgKGludCBp ID0gMDsgaSA8IGxlbmd0aCsxOyBpKyspIHsKICAgICAgICAgLy8gV2UgZ28gdGhyb3VnaCBlYWNo IGNoYXJhY3RlciB1bnRpbCB3ZSBmaW5kIGFuIGlzX3dvcmRfc3RhcnQsCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggYmJmNmMyNC4uYzU5MTFkYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtMzI4Myw3ICsz MjgzLDcgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3VwZGF0ZV9zZXR0aW5ncyhXZWJL aXRXZWJWaWV3KiB3ZWJWaWV3KQogICAgIFdlYktpdFdlYlNldHRpbmdzKiB3ZWJTZXR0aW5ncyA9 IHByaXYtPndlYlNldHRpbmdzLmdldCgpOwogICAgIFNldHRpbmdzKiBzZXR0aW5ncyA9IGNvcmUo d2ViVmlldyktPnNldHRpbmdzKCk7CiAKLSAgICBnY2hhciogZGVmYXVsdEVuY29kaW5nLCAqY3Vy c2l2ZUZvbnRGYW1pbHksICpkZWZhdWx0Rm9udEZhbWlseSwgKmZhbnRhc3lGb250RmFtaWx5LCAq bW9ub3NwYWNlRm9udEZhbWlseSwgKnNhbnNTZXJpZkZvbnRGYW1pbHksICpzZXJpZkZvbnRGYW1p bHksICp1c2VyU3R5bGVzaGVldFVyaTsKKyAgICBnY2hhciogZGVmYXVsdEVuY29kaW5nLCAqY3Vy c2l2ZUZvbnRGYW1pbHksICpkZWZhdWx0Rm9udEZhbWlseSwgKmZhbnRhc3lGb250RmFtaWx5LCAq bW9ub3NwYWNlRm9udEZhbWlseSwgKnNhbnNTZXJpZkZvbnRGYW1pbHksICpzZXJpZkZvbnRGYW1p bHksICp1c2VyU3R5bGVzaGVldFVyaSwgKmRlZmF1bHRTcGVsbENoZWNraW5nTGFuZ3VhZ2VzOwog ICAgIGdib29sZWFuIGF1dG9Mb2FkSW1hZ2VzLCBhdXRvU2hyaW5rSW1hZ2VzLCBwcmludEJhY2tn cm91bmRzLAogICAgICAgICBlbmFibGVTY3JpcHRzLCBlbmFibGVQbHVnaW5zLCBlbmFibGVEZXZl bG9wZXJFeHRyYXMsIHJlc2l6YWJsZVRleHRBcmVhcywKICAgICAgICAgZW5hYmxlUHJpdmF0ZUJy b3dzaW5nLCBlbmFibGVDYXJldEJyb3dzaW5nLCBlbmFibGVIVE1MNURhdGFiYXNlLCBlbmFibGVI VE1MNUxvY2FsU3RvcmFnZSwKQEAgLTMzMzAsNiArMzMzMCw3IEBAIHN0YXRpYyB2b2lkIHdlYmtp dF93ZWJfdmlld191cGRhdGVfc2V0dGluZ3MoV2ViS2l0V2ViVmlldyogd2ViVmlldykKICAgICAg ICAgICAgICAgICAgImVuYWJsZS1wYWdlLWNhY2hlIiwgJnVzZVBhZ2VDYWNoZSwKICAgICAgICAg ICAgICAgICAgImVuYWJsZS1qYXZhLWFwcGxldCIsICZlbmFibGVKYXZhQXBwbGV0LAogICAgICAg ICAgICAgICAgICAiZW5hYmxlLWh5cGVybGluay1hdWRpdGluZyIsICZlbmFibGVIeXBlcmxpbmtB dWRpdGluZywKKyAgICAgICAgICAgICAgICAgInNwZWxsLWNoZWNraW5nLWxhbmd1YWdlcyIsICZk ZWZhdWx0U3BlbGxDaGVja2luZ0xhbmd1YWdlcywKICAgICAgICAgICAgICAgICAgImVuYWJsZS1m dWxsc2NyZWVuIiwgJmVuYWJsZUZ1bGxzY3JlZW4sCiAgICAgICAgICAgICAgICAgIE5VTEwpOwog CkBAIC0zMzcxLDYgKzMzNzIsMTEgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X3VwZGF0 ZV9zZXR0aW5ncyhXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQogI2lmIEVOQUJMRShGVUxMU0NSRUVO X0FQSSkKICAgICBzZXR0aW5ncy0+c2V0RnVsbFNjcmVlbkVuYWJsZWQoZW5hYmxlRnVsbHNjcmVl bik7CiAjZW5kaWYKKyNpZiBFTkFCTEUoU1BFTExDSEVDSykKKyAgICBXZWJLaXQ6OkVkaXRvckNs aWVudCogY2xpZW50ID0gc3RhdGljX2Nhc3Q8V2ViS2l0OjpFZGl0b3JDbGllbnQqPihjb3JlKHdl YlZpZXcpLT5lZGl0b3JDbGllbnQoKSk7CisgICAgc3RhdGljX2Nhc3Q8V2ViS2l0OjpUZXh0Q2hl Y2tlckNsaWVudEVuY2hhbnQqPihjbGllbnQtPnRleHRDaGVja2VyKCkpLT51cGRhdGVTcGVsbENo ZWNraW5nTGFuZ3VhZ2UoZGVmYXVsdFNwZWxsQ2hlY2tpbmdMYW5ndWFnZXMpOworI2VuZGlmCisK ICAgICBQYWdlKiBwYWdlID0gY29yZSh3ZWJWaWV3KTsKICAgICBpZiAocGFnZSkKICAgICAgICAg cGFnZS0+c2V0VGFiS2V5Q3ljbGVzVGhyb3VnaEVsZW1lbnRzKHRhYktleUN5Y2xlc1Rocm91Z2hF bGVtZW50cyk7Cg==