54849 2011-02-20 21:57:21 -0800 [codereviewtool] use keydown instead of keypress 2011-02-20 22:40:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth oldest_to_newest 354413 0 ojan 2011-02-20 21:57:21 -0800 [codereviewtool] use keydown instead of keypress 354414 1 83128 ojan 2011-02-20 21:58:17 -0800 Created attachment 83128 Patch 354422 2 ojan 2011-02-20 22:40:05 -0800 Committed r79183: <http://trac.webkit.org/changeset/79183> 83128 2011-02-20 21:58:17 -0800 2011-02-20 22:37:14 -0800 Patch bug-54849-20110221165814.patch text/plain 4548 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogNzkxODAKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Vi a2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmlu ZGV4IGVmN2M2ZDBkMWYyNmRiMTE4ZDhlNzY0NDk2NGI3ZDE3M2VlZTNhOTguLjY4MjA3OTRlYzJh NTA2NWE2NmZjMThlNmEyMTUxYzkyMWE3ODU2YjkgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mu d2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5n ZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDExLTAyLTIwICBPamFuIFZhZmFpICA8b2phbkBjaHJv bWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW2NvZGVyZXZpZXd0b29sXSB1c2Uga2V5ZG93biBpbnN0ZWFkIG9mIGtleXByZXNzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDg0OQorCisgICAg ICAgIFRoZXJlIGlzIG5vIGZ1bmN0aW9uYWwgY2hhbmdlLiBUaGlzIGlzIGp1c3QgYSBjbGVhbnVw CisgICAgICAgIHRvIG1ha2UgZnV0dXJlIHBhdGNoZXMgKGUuZy4gaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTU0NjEyKQorICAgICAgICBjbGVhbmVyLgorCisgICAgICAg ICogY29kZS1yZXZpZXcuanM6CisKKzIwMTEtMDItMjAgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9t aXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgogCiAgICAgICAgIFtj b2RlcmV2aWV3dG9vbF0gbWFrZSBlc2NhcGUgaGlkZSB0aGUgcHJldmlldyBmb3JtCmRpZmYgLS1n aXQgYS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMgYi9XZWJzaXRlcy9i dWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKaW5kZXggOGNhMzY1OTc5Yjc1MTFjZTI3MDJk Mzk5ZTg4NzMxM2FiYzZlMzU1MS4uODQzYWI3NTc5MGRkMjczN2VkNTIzNjVhZmU1OTdhMDA5NzM2 MmZkNCAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3Lmpz CisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJldmlldy5qcwpAQCAtNzAsOCAr NzAsMTQgQEAgdmFyIENPREVfUkVWSUVXX1VOSVRURVNUOwogICB2YXIgV0VCS0lUX0JBU0VfRElS ID0gImh0dHA6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0b3J5L3dlYmtpdC90cnVuay8iOwogICB2 YXIgU0lERV9CWV9TSURFX0RJRkZTX0tFWSA9ICdzaWRlYnlzaWRlZGlmZnMnOwogICB2YXIgZ19k aXNwbGF5ZWRfZHJhZnRfY29tbWVudHMgPSBmYWxzZTsKLSAgdmFyIEVTQ0FQRV9LRVlfQ09ERSA9 IDI3OwotCisgIHZhciBLRVlfQ09ERSA9IHsKKyAgICBlbnRlcjogMTMsCisgICAgZXNjYXBlOiAy NywKKyAgICBqOiA3NCwKKyAgICBrOiA3NSwKKyAgICBuOiA3OCwKKyAgICBwOiA4MCAgICAKKyAg fQogCiAgIGZ1bmN0aW9uIGlkRm9yTGluZShudW1iZXIpIHsKICAgICByZXR1cm4gJ2xpbmUnICsg bnVtYmVyOwpAQCAtMTA4Niw3ICsxMDkyLDcgQEAgdmFyIENPREVfUkVWSUVXX1VOSVRURVNUOwog ICAgIHZhciByZXZpZXdfZm9ybV9jb250ZW50cyA9ICQoJyNyZXZpZXdmb3JtJykuY29udGVudHMo KTsKICAgICBpZiAocmV2aWV3X2Zvcm1fY29udGVudHNbMF0ucXVlcnlTZWxlY3RvcignI2Zvcm0t Y29udHJvbHMgI2ZsYWdzJykpIHsKICAgICAgIHJldmlld19mb3JtX2NvbnRlbnRzLmJpbmQoJ2tl eWRvd24nLCBmdW5jdGlvbihlKSB7Ci0gICAgICAgIGlmIChlLmtleUNvZGUgPT0gRVNDQVBFX0tF WV9DT0RFKQorICAgICAgICBpZiAoZS5rZXlDb2RlID09IEtFWV9DT0RFLmVzY2FwZSkKICAgICAg ICAgICBoaWRlQ29tbWVudEZvcm0oKTsKICAgICAgIH0pOwogCkBAIC0xMzc5LDE0ICsxMzg1LDYg QEAgdmFyIENPREVfUkVWSUVXX1VOSVRURVNUOwogCiAgIHZhciBESVJFQ1RJT04gPSB7Rk9SV0FS RDogMSwgQkFDS1dBUkQ6IDJ9OwogCi0gIHZhciBrQ2hhckNvZGVGb3JOID0gJ24nLmNoYXJDb2Rl QXQoMCk7Ci0gIHZhciBrQ2hhckNvZGVGb3JQID0gJ3AnLmNoYXJDb2RlQXQoMCk7Ci0gIHZhciBr Q2hhckNvZGVGb3JKID0gJ2onLmNoYXJDb2RlQXQoMCk7Ci0gIHZhciBrQ2hhckNvZGVGb3JLID0g J2snLmNoYXJDb2RlQXQoMCk7Ci0gIHZhciBrQ2hhckNvZGVGb3JDYXBpdGFsSiA9ICdKJy5jaGFy Q29kZUF0KDApOwotICB2YXIga0NoYXJDb2RlRm9yQ2FwaXRhbEsgPSAnSycuY2hhckNvZGVBdCgw KTsKLSAgdmFyIGtDaGFyQ29kZUZvckVudGVyID0gJ1xyJy5jaGFyQ29kZUF0KDApOwotCiAgIGZ1 bmN0aW9uIGlzQ29tbWVudChub2RlKSB7CiAgICAgcmV0dXJuIG5vZGUuaGFzQ2xhc3MoJ2Zyb3pl bkNvbW1lbnQnKSB8fCBub2RlLmhhc0NsYXNzKCdwcmV2aW91c0NvbW1lbnQnKSB8fCBub2RlLmhh c0NsYXNzKCdvdmVyYWxsQ29tbWVudHMnKTsKICAgfQpAQCAtMTQwMCwxMSArMTM5OCwxMSBAQCB2 YXIgQ09ERV9SRVZJRVdfVU5JVFRFU1Q7CiAgIH0KIAogICAkKCd0ZXh0YXJlYScpLmxpdmUoJ2tl eWRvd24nLCBmdW5jdGlvbihlKSB7Ci0gICAgaWYgKGUua2V5Q29kZSA9PSBFU0NBUEVfS0VZX0NP REUpCi0gICAgICBoYW5kbGVFc2NhcGVLZXlEb3duSW5UZXh0YXJlYSh0aGlzKTsKKyAgICBpZiAo ZS5rZXlDb2RlID09IEtFWV9DT0RFLmVzY2FwZSkKKyAgICAgIGhhbmRsZUVzY2FwZUtleUluVGV4 dGFyZWEodGhpcyk7CiAgIH0pOwogCi0gICQoJ2JvZHknKS5saXZlKCdrZXlwcmVzcycsIGZ1bmN0 aW9uKGUpIHsKKyAgJCgnYm9keScpLmxpdmUoJ2tleWRvd24nLCBmdW5jdGlvbihlKSB7CiAgICAg Ly8gRklYTUU6IFRoZXJlJ3MgZ290IHRvIGJlIGEgYmV0dGVyIHdheSB0byBhdm9pZCBzZWVpbmcg dGhlc2Uga2V5cHJlc3MKICAgICAvLyBldmVudHMuCiAgICAgaWYgKGUudGFyZ2V0Lm5vZGVOYW1l ID09ICdURVhUQVJFQScpCkBAIC0xNDEyLDMyICsxNDEwLDMwIEBAIHZhciBDT0RFX1JFVklFV19V TklUVEVTVDsKICAgICAKICAgICB2YXIgaGFuZGxlZCA9IGZhbHNlOwogCi0gICAgc3dpdGNoIChl LmNoYXJDb2RlKSB7Ci0gICAgY2FzZSBrQ2hhckNvZGVGb3JOOgorICAgIHN3aXRjaCAoZS5rZXlD b2RlKSB7CisgICAgY2FzZSBLRVlfQ09ERS5uOgogICAgICAgaGFuZGxlZCA9IGZvY3VzTmV4dChp c0NvbW1lbnQsIERJUkVDVElPTi5GT1JXQVJEKTsKICAgICAgIGJyZWFrOwogCi0gICAgY2FzZSBr Q2hhckNvZGVGb3JQOgorICAgIGNhc2UgS0VZX0NPREUucDoKICAgICAgIGhhbmRsZWQgPSBmb2N1 c05leHQoaXNDb21tZW50LCBESVJFQ1RJT04uQkFDS1dBUkQpOwogICAgICAgYnJlYWs7CiAKLSAg ICBjYXNlIGtDaGFyQ29kZUZvcko6Ci0gICAgICBoYW5kbGVkID0gZm9jdXNOZXh0KGlzRGlmZkJs b2NrLCBESVJFQ1RJT04uRk9SV0FSRCk7CisgICAgY2FzZSBLRVlfQ09ERS5qOgorICAgICAgaWYg KGUuc2hpZnRLZXkpCisgICAgICAgIGhhbmRsZWQgPSBmb2N1c05leHQoaXNMaW5lLCBESVJFQ1RJ T04uRk9SV0FSRCk7CisgICAgICBlbHNlCisgICAgICAgIGhhbmRsZWQgPSBmb2N1c05leHQoaXNE aWZmQmxvY2ssIERJUkVDVElPTi5GT1JXQVJEKTsKICAgICAgIGJyZWFrOwogCi0gICAgY2FzZSBr Q2hhckNvZGVGb3JLOgotICAgICAgaGFuZGxlZCA9IGZvY3VzTmV4dChpc0RpZmZCbG9jaywgRElS RUNUSU9OLkJBQ0tXQVJEKTsKKyAgICBjYXNlIEtFWV9DT0RFLms6CisgICAgICBpZiAoZS5zaGlm dEtleSkKKyAgICAgICAgaGFuZGxlZCA9IGZvY3VzTmV4dChpc0xpbmUsIERJUkVDVElPTi5CQUNL V0FSRCk7CisgICAgICBlbHNlCisgICAgICAgIGhhbmRsZWQgPSBmb2N1c05leHQoaXNEaWZmQmxv Y2ssIERJUkVDVElPTi5CQUNLV0FSRCk7CiAgICAgICBicmVhazsKICAgICAgIAotICAgIGNhc2Ug a0NoYXJDb2RlRm9yQ2FwaXRhbEo6Ci0gICAgICBoYW5kbGVkID0gZm9jdXNOZXh0KGlzTGluZSwg RElSRUNUSU9OLkZPUldBUkQpOwotICAgICAgYnJlYWs7Ci0KLSAgICBjYXNlIGtDaGFyQ29kZUZv ckNhcGl0YWxLOgotICAgICAgaGFuZGxlZCA9IGZvY3VzTmV4dChpc0xpbmUsIERJUkVDVElPTi5C QUNLV0FSRCk7Ci0gICAgICBicmVhazsKLSAgICAKLSAgICBjYXNlIGtDaGFyQ29kZUZvckVudGVy OgorICAgIGNhc2UgS0VZX0NPREUuZW50ZXI6CiAgICAgICBoYW5kbGVkID0gaGFuZGxlRW50ZXJL ZXlQcmVzcygpOwogICAgICAgYnJlYWs7CiAgICAgfQpAQCAtMTQ0Niw3ICsxNDQyLDcgQEAgdmFy IENPREVfUkVWSUVXX1VOSVRURVNUOwogICAgICAgZS5wcmV2ZW50RGVmYXVsdCgpOwogICB9KTsK ICAgCi0gIGZ1bmN0aW9uIGhhbmRsZUVzY2FwZUtleURvd25JblRleHRhcmVhKHRleHRhcmVhKSB7 CisgIGZ1bmN0aW9uIGhhbmRsZUVzY2FwZUtleUluVGV4dGFyZWEodGV4dGFyZWEpIHsKICAgICB2 YXIgY29tbWVudCA9ICQodGV4dGFyZWEpLnBhcmVudHMoJy5jb21tZW50Jyk7CiAgICAgaWYgKGNv bW1lbnQuc2l6ZSgpKQogICAgICAgYWNjZXB0Q29tbWVudChjb21tZW50KTsK