54847 2011-02-20 20:42:57 -0800 [codereviewtool] add more help information 2011-02-20 23:04:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth oldest_to_newest 354397 0 ojan 2011-02-20 20:42:57 -0800 [codereviewtool] add more help information 354398 1 83126 ojan 2011-02-20 20:44:33 -0800 Created attachment 83126 Patch 354401 2 83126 abarth 2011-02-20 20:55:59 -0800 Comment on attachment 83126 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83126&action=review > Websites/bugs.webkit.org/code-review.js:1058 > + '<div class="winter"></div>' + Winter! 354430 3 ojan 2011-02-20 23:04:23 -0800 Committed r79189: <http://trac.webkit.org/changeset/79189> 83126 2011-02-20 20:44:33 -0800 2011-02-20 20:55:59 -0800 Patch bug-54847-20110221154430.patch text/plain 3563 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogNzkxNjYKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Vi a2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmlu ZGV4IGJlMDI2N2NhYjBhMGFmM2IxMjU3M2IzMjE4MDEyZDhmOTI2NjhkYzYuLjJmY2E2MTQzMmFi NTllM2JiZjI1OTFlOGMyMzAwYzcxODFhZmJhYzMgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mu d2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTAyLTIwICBPamFuIFZhZmFpICA8b2phbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW2NvZGVyZXZpZXd0b29sXSBhZGQgbW9yZSBoZWxwIGluZm9ybWF0aW9uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDg0NworCisgICAgICAgICog Y29kZS1yZXZpZXcuanM6CisKIDIwMTEtMDItMTcgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2Vi c2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzIGIvV2Vic2l0ZXMvYnVncy53ZWJr aXQub3JnL2NvZGUtcmV2aWV3LmpzCmluZGV4IGQzMWFkZjNiZjlmOGUxNWJmMzVkODUzN2FlMzg3 ZTczMTQ4YTQ4YjUuLjIzNWZmNTU3NzI0MTU5MDViMmI4MzZiN2M4OGRjMTU2NjcwNGM5YzIgMTAw NjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJldmlldy5qcworKysgYi9X ZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKQEAgLTQxNiw3ICs0MTYsMTUg QEAgdmFyIENPREVfUkVWSUVXX1VOSVRURVNUOwogICAgIGRlc2NyaXB0b3IgPSBjb21tZW50cy5s ZW5ndGggKyAnIGNvbW1lbnQnOwogICAgIGlmIChjb21tZW50cy5sZW5ndGggPiAxKQogICAgICAg ZGVzY3JpcHRvciArPSAncyc7Ci0gICAgJCgnLmhlbHAnKS5hcHBlbmQoJyBUaGlzIHBhdGNoIGhh cyAnICsgZGVzY3JpcHRvciArICcuICBTY3JvbGwgdGhyb3VnaCB0aGVtIHdpdGggdGhlICJuIiBh bmQgInAiIGtleXMuJyk7CisgICAgJCgnLmhlbHAgLm1vcmUnKS5iZWZvcmUoJyBUaGlzIHBhdGNo IGhhcyAnICsgZGVzY3JpcHRvciArICcuICBTY3JvbGwgdGhyb3VnaCB0aGVtIHdpdGggdGhlICJu IiBhbmQgInAiIGtleXMuICcpOworICB9CisgIAorICBmdW5jdGlvbiBzaG93TW9yZUhlbHAoKSB7 CisgICAgJCgnLm1vcmUtaGVscCcpLnJlbW92ZUNsYXNzKCdpbmFjdGl2ZScpOworICB9CisgIAor ICBmdW5jdGlvbiBoaWRlTW9yZUhlbHAoKSB7CisgICAgJCgnLm1vcmUtaGVscCcpLmFkZENsYXNz KCdpbmFjdGl2ZScpOwogICB9CiAKICAgZnVuY3Rpb24gc2NhbkZvclN0eWxlUXVldWVDb21tZW50 cyh0ZXh0KSB7CkBAIC0xMDQ1LDYgKzEwNTMsMjEgQEAgdmFyIENPREVfUkVWSUVXX1VOSVRURVNU OwogICAgICQoZG9jdW1lbnQuYm9keSkucHJlcGVuZCgnPGRpdiBpZD0ibWVzc2FnZSI+JyArCiAg ICAgICAgICc8ZGl2IGNsYXNzPSJoZWxwIj5TZWxlY3QgbGluZSBudW1iZXJzIHRvIGFkZCBhIGNv bW1lbnQuIFNjcm9sbCB0aG91Z2ggZGlmZnMgd2l0aCB0aGUgImoiIGFuZCAiayIga2V5cy4nICsK ICAgICAgICAgICAnPGRpdiBjbGFzcz0iRGlmZkxpbmtzIExpbmtDb250YWluZXIiPicgKyBkaWZm TGlua3NIdG1sKCkgKyAnPC9kaXY+JyArCisgICAgICAgICAgJzxhIGhyZWY9ImphdmFzY3JpcHQ6 IiBjbGFzcz0ibW9yZSI+W21vcmVdPC9hPicgKworICAgICAgICAgICc8ZGl2IGNsYXNzPSJtb3Jl LWhlbHAgaW5hY3RpdmUiPicgKworICAgICAgICAgICAgJzxkaXYgY2xhc3M9IndpbnRlciI+PC9k aXY+JyArCisgICAgICAgICAgICAnPGRpdiBjbGFzcz0ibGlnaHRib3giPjx0YWJsZT4nICsKKyAg ICAgICAgICAgICAgJzx0cj48dGQ+ZW50ZXI8L3RkPjx0ZD5hZGQvZWRpdCBjb21tZW50IGZvciBm b2N1c2VkIGl0ZW08L3RkPjwvdHI+JyArCisgICAgICAgICAgICAgICc8dHI+PHRkPmVzY2FwZTwv dGQ+PHRkPmFjY2VwdCBjdXJyZW50IGNvbW1lbnQgLyBjbG9zZSBwcmV2aWV3IGFuZCBoZWxwIHBv cHVwczwvdGQ+PC90cj4nICsKKyAgICAgICAgICAgICAgJzx0cj48dGQ+ajwvdGQ+PHRkPmZvY3Vz IG5leHQgZGlmZjwvdGQ+PC90cj4nICsKKyAgICAgICAgICAgICAgJzx0cj48dGQ+azwvdGQ+PHRk PmZvY3VzIHByZXZpb3VzIGRpZmY8L3RkPjwvdHI+JyArCisgICAgICAgICAgICAgICc8dHI+PHRk PnNoaWZ0ICsgajwvdGQ+PHRkPmZvY3VzIG5leHQgbGluZTwvdGQ+PC90cj4nICsKKyAgICAgICAg ICAgICAgJzx0cj48dGQ+c2hpZnQgKyBrPC90ZD48dGQ+Zm9jdXMgcHJldmlvdXMgbGluZTwvdGQ+ PC90cj4nICsKKyAgICAgICAgICAgICAgJzx0cj48dGQ+bjwvdGQ+PHRkPmZvY3VzIG5leHQgY29t bWVudDwvdGQ+PC90cj4nICsKKyAgICAgICAgICAgICAgJzx0cj48dGQ+cDwvdGQ+PHRkPmZvY3Vz IHByZXZpb3VzIGNvbW1lbnQ8L3RkPjwvdHI+JyArCisgICAgICAgICAgICAgICc8dHI+PHRkPnI8 L3RkPjx0ZD5mb2N1cyByZXZpZXcgc2VsZWN0IGVsZW1lbnQ8L3RkPjwvdHI+JyArCisgICAgICAg ICAgICAnPC90YWJsZT48L2Rpdj4nICsKKyAgICAgICAgICAnPC9kaXY+JyArCiAgICAgICAgICc8 L2Rpdj4nICsKICAgICAgICAgJzwvZGl2PicpOwogICAgICQoZG9jdW1lbnQuYm9keSkuYXBwZW5k KCc8ZGl2IGlkPSJ0b29sYmFyIj4nICsKQEAgLTEzMjUsNiArMTM0OCw4IEBAIHZhciBDT0RFX1JF VklFV19VTklUVEVTVDsKICAgJCgnLmZyb3plbkNvbW1lbnQnKS5saXZlKCdjbGljaycsIGhhbmRs ZVVuZnJlZXplQ29tbWVudCk7CiAgICQoJy5jb21tZW50IC5kaXNjYXJkJykubGl2ZSgnY2xpY2sn LCBoYW5kbGVEaXNjYXJkQ29tbWVudCk7CiAgICQoJy5jb21tZW50IC5vaycpLmxpdmUoJ2NsaWNr JywgaGFuZGxlQWNjZXB0Q29tbWVudCk7CisgICQoJy5tb3JlJykubGl2ZSgnY2xpY2snLCBzaG93 TW9yZUhlbHApOworICAkKCcubW9yZS1oZWxwIC53aW50ZXInKS5saXZlKCdjbGljaycsIGhpZGVN b3JlSGVscCk7CiAKICAgZnVuY3Rpb24gZnJlZXplQ29tbWVudChjb21tZW50X2Jsb2NrKSB7CiAg ICAgdmFyIGNvbW1lbnRfdGV4dGFyZWEgPSBjb21tZW50X2Jsb2NrLmZpbmQoJ3RleHRhcmVhJyk7 CkBAIC0xMzk5LDYgKzE0MjQsNyBAQCB2YXIgQ09ERV9SRVZJRVdfVU5JVFRFU1Q7CiAgIH0pOwog CiAgICQoJ2JvZHknKS5saXZlKCdrZXlwcmVzcycsIGZ1bmN0aW9uKGUpIHsKKyAgICAvLyBGSVhN RTogb25jZSB3ZSB1c2Uga2V5ZG93biBoZXJlLCBoaWRlIHRoZSBtb3JlLWhlbHAgcG9wdXAgb24g ZXNjYXBlLgogICAgIC8vIEZJWE1FOiBUaGVyZSdzIGdvdCB0byBiZSBhIGJldHRlciB3YXkgdG8g YXZvaWQgc2VlaW5nIHRoZXNlIGtleXByZXNzCiAgICAgLy8gZXZlbnRzLgogICAgIGlmIChlLnRh cmdldC5ub2RlTmFtZSA9PSAnVEVYVEFSRUEnKQo=