54844 2011-02-20 19:57:27 -0800 [codereviewtool] make escape hide the preview form 2011-02-20 21:44:34 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth mihaip oldest_to_newest 354385 0 ojan 2011-02-20 19:57:27 -0800 [codereviewtool] make escape hide the preview form 354388 1 83121 ojan 2011-02-20 20:02:55 -0800 Created attachment 83121 Patch 354392 2 83124 ojan 2011-02-20 20:13:40 -0800 Created attachment 83124 Patch 354400 3 83124 abarth 2011-02-20 20:54:21 -0800 Comment on attachment 83124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83124&action=review > Websites/bugs.webkit.org/code-review.js:1087 > + var escape_key_code = 27; Don't we already have a constant for this? We should share. 354410 4 ojan 2011-02-20 21:44:34 -0800 Committed r79180: <http://trac.webkit.org/changeset/79180> 83121 2011-02-20 20:02:55 -0800 2011-02-20 20:13:34 -0800 Patch bug-54844-20110221150253.patch text/plain 1984 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogNzkxNjYKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Vi a2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmlu ZGV4IGJlMDI2N2NhYjBhMGFmM2IxMjU3M2IzMjE4MDEyZDhmOTI2NjhkYzYuLjcwYjdiNGJhYzkw ZjUwYmEwODY3OGI0MmIyNDdlMDQzY2JhYjk2ZTQgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mu d2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTAyLTIwICBPamFuIFZhZmFpICA8b2phbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW2NvZGVyZXZpZXd0b29sXSBtYWtlIGVzY2FwZSBoaWRlIHRoZSBwcmV2aWV3IGZvcm0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0ODQ0CisKKyAg ICAgICAgKiBjb2RlLXJldmlldy5qczoKKwogMjAxMS0wMi0xNyAgT2phbiBWYWZhaSAgPG9qYW5A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1n aXQgYS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMgYi9XZWJzaXRlcy9i dWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKaW5kZXggZDMxYWRmM2JmOWY4ZTE1YmYzNWQ4 NTM3YWUzODdlNzMxNDhhNDhiNS4uMDhlNzNhNTliYzkzYjU3NjBjNDE3ZmRkYzAxMjMxN2VhMzdh NmU3ZCAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3Lmpz CisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJldmlldy5qcwpAQCAtMTA4Myw2 ICsxMDgzLDEyIEBAIHZhciBDT0RFX1JFVklFV19VTklUVEVTVDsKICAgZnVuY3Rpb24gaGFuZGxl UmV2aWV3Rm9ybUxvYWQoKSB7CiAgICAgdmFyIHJldmlld19mb3JtX2NvbnRlbnRzID0gJCgnI3Jl dmlld2Zvcm0nKS5jb250ZW50cygpOwogICAgIGlmIChyZXZpZXdfZm9ybV9jb250ZW50c1swXS5x dWVyeVNlbGVjdG9yKCcjZm9ybS1jb250cm9scyAjZmxhZ3MnKSkgeworICAgICAgcmV2aWV3X2Zv cm1fY29udGVudHMuYmluZCgna2V5ZG93bicsIGZ1bmN0aW9uKGUpIHsKKyAgICAgICAgdmFyIGVz Y2FwZV9rZXlfY29kZSA9IDI3OworICAgICAgICBpZiAoZS5rZXlDb2RlID09IGVzY2FwZV9rZXlf Y29kZSkKKyAgICAgICAgICBoaWRlQ29tbWVudEZvcm0oKTsKKyAgICAgIH0pOworCiAgICAgICAv LyBUaGlzIGlzIHRoZSBpbnRpYWwgbG9hZCBvZiB0aGUgcmV2aWV3IGZvcm0gaWZyYW1lLgogICAg ICAgdmFyIGZvcm0gPSByZXZpZXdfZm9ybV9jb250ZW50cy5maW5kKCdmb3JtJylbMF07CiAgICAg ICBmb3JtLmFkZEV2ZW50TGlzdGVuZXIoJ3N1Ym1pdCcsIGVyYXNlRHJhZnRDb21tZW50cyk7CkBA IC0xNzYzLDYgKzE3NjksMTUgQEAgdmFyIENPREVfUkVWSUVXX1VOSVRURVNUOwogCiAgIGZ1bmN0 aW9uIHNob3dDb21tZW50Rm9ybSgpIHsKICAgICAkKCcjY29tbWVudF9mb3JtJykucmVtb3ZlQ2xh c3MoJ2luYWN0aXZlJyk7CisgICAgJCgnI3Jldmlld2Zvcm0nKS5jb250ZW50cygpLmZpbmQoJyNz dWJtaXRCdG4nKS5mb2N1cygpOworICB9CisgIAorICBmdW5jdGlvbiBoaWRlQ29tbWVudEZvcm0o KSB7CisgICAgJCgnI2NvbW1lbnRfZm9ybScpLmFkZENsYXNzKCdpbmFjdGl2ZScpOworICAgIAor ICAgIC8vIE1ha2Ugc3VyZSB0aGUgdG9wIGRvY3VtZW50IGhhcyBmb2N1cyBzbyBrZXkgZXZlbnRz IGRvbid0IGtlZXAgZ29pbmcgdG8gdGhlIHJldmlldyBmb3JtLgorICAgIGRvY3VtZW50LmJvZHku dGFiSW5kZXggPSAtMTsKKyAgICBkb2N1bWVudC5ib2R5LmZvY3VzKCk7CiAgIH0KIAogICAkKCcj cHJldmlld19jb21tZW50cycpLmxpdmUoJ2NsaWNrJywgZnVuY3Rpb24oKSB7Cg== 83124 2011-02-20 20:13:40 -0800 2011-02-20 20:54:21 -0800 Patch bug-54844-20110221151337.patch text/plain 2320 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogNzkxNjYKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Vi a2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmlu ZGV4IGJlMDI2N2NhYjBhMGFmM2IxMjU3M2IzMjE4MDEyZDhmOTI2NjhkYzYuLjcwYjdiNGJhYzkw ZjUwYmEwODY3OGI0MmIyNDdlMDQzY2JhYjk2ZTQgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mu d2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTAyLTIwICBPamFuIFZhZmFpICA8b2phbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW2NvZGVyZXZpZXd0b29sXSBtYWtlIGVzY2FwZSBoaWRlIHRoZSBwcmV2aWV3IGZvcm0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0ODQ0CisKKyAg ICAgICAgKiBjb2RlLXJldmlldy5qczoKKwogMjAxMS0wMi0xNyAgT2phbiBWYWZhaSAgPG9qYW5A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1n aXQgYS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMgYi9XZWJzaXRlcy9i dWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKaW5kZXggZDMxYWRmM2JmOWY4ZTE1YmYzNWQ4 NTM3YWUzODdlNzMxNDhhNDhiNS4uZjM2ZDQwMmFiODFlNDA4YTZmNGMxNmExOTJhNjk3NGM0Y2Ux ZmU2OCAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3Lmpz CisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJldmlldy5qcwpAQCAtMTA4Myw2 ICsxMDgzLDEyIEBAIHZhciBDT0RFX1JFVklFV19VTklUVEVTVDsKICAgZnVuY3Rpb24gaGFuZGxl UmV2aWV3Rm9ybUxvYWQoKSB7CiAgICAgdmFyIHJldmlld19mb3JtX2NvbnRlbnRzID0gJCgnI3Jl dmlld2Zvcm0nKS5jb250ZW50cygpOwogICAgIGlmIChyZXZpZXdfZm9ybV9jb250ZW50c1swXS5x dWVyeVNlbGVjdG9yKCcjZm9ybS1jb250cm9scyAjZmxhZ3MnKSkgeworICAgICAgcmV2aWV3X2Zv cm1fY29udGVudHMuYmluZCgna2V5ZG93bicsIGZ1bmN0aW9uKGUpIHsKKyAgICAgICAgdmFyIGVz Y2FwZV9rZXlfY29kZSA9IDI3OworICAgICAgICBpZiAoZS5rZXlDb2RlID09IGVzY2FwZV9rZXlf Y29kZSkKKyAgICAgICAgICBoaWRlQ29tbWVudEZvcm0oKTsKKyAgICAgIH0pOworCiAgICAgICAv LyBUaGlzIGlzIHRoZSBpbnRpYWwgbG9hZCBvZiB0aGUgcmV2aWV3IGZvcm0gaWZyYW1lLgogICAg ICAgdmFyIGZvcm0gPSByZXZpZXdfZm9ybV9jb250ZW50cy5maW5kKCdmb3JtJylbMF07CiAgICAg ICBmb3JtLmFkZEV2ZW50TGlzdGVuZXIoJ3N1Ym1pdCcsIGVyYXNlRHJhZnRDb21tZW50cyk7CkBA IC0xNzIzLDkgKzE3MjksNyBAQCB2YXIgQ09ERV9SRVZJRVdfVU5JVFRFU1Q7CiAgICAgcmV0dXJu IHF1b3RlZF9jb21tZW50cy5qb2luKCdcbicpOwogICB9CiAKLSAgJCgnI2NvbW1lbnRfZm9ybSAu d2ludGVyJykubGl2ZSgnY2xpY2snLCBmdW5jdGlvbigpIHsKLSAgICAkKCcjY29tbWVudF9mb3Jt JykuYWRkQ2xhc3MoJ2luYWN0aXZlJyk7Ci0gIH0pOworICAkKCcjY29tbWVudF9mb3JtIC53aW50 ZXInKS5saXZlKCdjbGljaycsIGhpZGVDb21tZW50Rm9ybSk7CiAKICAgZnVuY3Rpb24gZmlsbElu UmV2aWV3Rm9ybSgpIHsKICAgICB2YXIgY29tbWVudHNfaW5fY29udGV4dCA9IFtdCkBAIC0xNzYz LDYgKzE3NjcsMTUgQEAgdmFyIENPREVfUkVWSUVXX1VOSVRURVNUOwogCiAgIGZ1bmN0aW9uIHNo b3dDb21tZW50Rm9ybSgpIHsKICAgICAkKCcjY29tbWVudF9mb3JtJykucmVtb3ZlQ2xhc3MoJ2lu YWN0aXZlJyk7CisgICAgJCgnI3Jldmlld2Zvcm0nKS5jb250ZW50cygpLmZpbmQoJyNzdWJtaXRC dG4nKS5mb2N1cygpOworICB9CisgIAorICBmdW5jdGlvbiBoaWRlQ29tbWVudEZvcm0oKSB7Cisg ICAgJCgnI2NvbW1lbnRfZm9ybScpLmFkZENsYXNzKCdpbmFjdGl2ZScpOworICAgIAorICAgIC8v IE1ha2Ugc3VyZSB0aGUgdG9wIGRvY3VtZW50IGhhcyBmb2N1cyBzbyBrZXkgZXZlbnRzIGRvbid0 IGtlZXAgZ29pbmcgdG8gdGhlIHJldmlldyBmb3JtLgorICAgIGRvY3VtZW50LmJvZHkudGFiSW5k ZXggPSAtMTsKKyAgICBkb2N1bWVudC5ib2R5LmZvY3VzKCk7CiAgIH0KIAogICAkKCcjcHJldmll d19jb21tZW50cycpLmxpdmUoJ2NsaWNrJywgZnVuY3Rpb24oKSB7Cg==