54801 2011-02-19 04:29:37 -0800 Make WinCE a core builder 2011-02-21 09:56:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 paroga paroga abarth commit-queue wsiegrist oldest_to_newest 354129 0 paroga 2011-02-19 04:29:37 -0800 Make WinCE a core builder 354130 1 83070 paroga 2011-02-19 04:30:44 -0800 Created attachment 83070 Patch 354131 2 paroga 2011-02-19 04:35:22 -0800 Most of the people don't care about non-core builders, so make WinCE one. WinCE was only red, when people broke it. I didn't see any problem with the machine since it's online. 354139 3 83070 kling 2011-02-19 05:20:07 -0800 Comment on attachment 83070 Patch r=me, let's see how this goes! :) 354151 4 83070 commit-queue 2011-02-19 07:17:41 -0800 Comment on attachment 83070 Patch Clearing flags on attachment: 83070 Committed r79120: <http://trac.webkit.org/changeset/79120> 354152 5 commit-queue 2011-02-19 07:17:46 -0800 All reviewed patches have been landed. Closing bug. 354201 6 abarth 2011-02-19 11:41:32 -0800 Scrolling back though the history of <http://build.webkit.org/builders/WinCE%20Release%20%28Build%29> this morning, the builder appears to be red more often than its green. We'd like core builders to be green much more often than they're red. Hopefully the builder will remain green in the future. 354204 7 paroga 2011-02-19 11:46:45 -0800 (In reply to comment #6) > Scrolling back though the history of <http://build.webkit.org/builders/WinCE%20Release%20%28Build%29> this morning, the builder appears to be red more often than its green. We'd like core builders to be green much more often than they're red. Hopefully the builder will remain green in the future. I've been one week on vacation and didn't fixed the build problems. That's also the reason why I didn't created this patch earlier. IMHO the problem is that most of the people don't care about non core builder. 354205 8 abarth 2011-02-19 11:55:18 -0800 Ok. My point is more that being a core builder is descriptive rather than proscriptive. They're not intended to force people to care about a particular builder. They're intended to describe which builders people care about. In any case, it's purely an empirical list. If the builder remains green, no problem. If the builder is often red, then we can remove it from the list. Note: You'll need to ask wms to restart the buildbot master so that the bot shows up on the core builder page. 354206 9 paroga 2011-02-19 12:05:13 -0800 (In reply to comment #8) > Ok. My point is more that being a core builder is descriptive rather than proscriptive. They're not intended to force people to care about a particular builder. They're intended to describe which builders people care about. When you get responses like "ohh, WinCE has a buildbot?", it seams to me that many people don't know about working non core builder. See also the "At times, people have mentioned to me that they left a failure in only because the bot is non-core and they didn't notice." from mjs in https://lists.webkit.org/pipermail/webkit-dev/2011-February/015894.html > In any case, it's purely an empirical list. If the builder remains green, no problem. If the builder is often red, then we can remove it from the list. So let's try it. :-) 354207 10 abarth 2011-02-19 12:07:32 -0800 > So let's try it. :-) Yep. :) 354651 11 wsiegrist 2011-02-21 09:56:27 -0800 Buildbot master updated. 83070 2011-02-19 04:30:44 -0800 2011-02-19 07:17:41 -0800 Patch bug-54801-20110219133040.patch text/plain 1983 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogNzkxMTQKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmMmI1OTg2ZDNhMjQ3YjFjNDRlY2YyY2JjODkyOTQ3YWQx OTgyYWQ1Li45Mzg2NmI5MmI1NGFhOTUwYmFmODc2OGRmZjY4OGZkZDVlNmQzNWNiIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDItMTkgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBXaW5D RSBhIGNvcmUgYnVpbGRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTQ4MDEKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9i dWlsZGJvdC9idWlsZGJvdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u ZXQvYnVpbGRib3QvYnVpbGRib3RfdW5pdHRlc3QucHk6CisKIDIwMTEtMDItMTkgIEx1a2FzeiBT bGFjaGNpYWsgIDxsLnNsYWNoY2lha0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vbmV0L2J1aWxkYm90L2J1aWxkYm90LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vbmV0L2J1aWxkYm90L2J1aWxkYm90LnB5CmluZGV4IGFiOGRkZjgwZGYzOGRkMGI0OWZiMDY4 ZDUxZDM1M2NhNWU5YTlhZTUuLjlkZDE2NWM0YzdjMGZmNGQ1YWExOTlmNGY5NTkxNjVkNTVmMzVm MWUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJv dC9idWlsZGJvdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVp bGRib3QvYnVpbGRib3QucHkKQEAgLTI3MCw2ICsyNzAsNyBAQCBjbGFzcyBCdWlsZEJvdChvYmpl Y3QpOgogICAgICAgICAgICAgIlNub3dMZW9wYXJkLipcKFdlYktpdDIgVGVzdCIsCiAgICAgICAg ICAgICAiTGVvcGFyZC4qUmVsZWFzZSIsCiAgICAgICAgICAgICAiV2luZG93cy4qQnVpbGQiLAor ICAgICAgICAgICAgIldpbkNFIiwKICAgICAgICAgICAgICJFRkwiLAogICAgICAgICAgICAgIkdU Sy4qMzIiLAogICAgICAgICAgICAgIkdUSy4qNjQuKkRlYnVnIiwgICMgRGlzYWxsb3cgdGhlIDY0 LWJpdCBSZWxlYXNlIGJvdCB3aGljaCBpcyBicm9rZW4uCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QvYnVpbGRib3RfdW5pdHRlc3QucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QvYnVpbGRib3RfdW5pdHRl c3QucHkKaW5kZXggZjFkZjg5NTVkOGRhN2M2MDNmYTBhODc1ZmQ4YTQ4MWQ5NGI2YmQ4Ny4uNWVk YWQ0YWZkMWRlZDJhYWVkM2EyYTA1MjI3ZWNiZGFkMzgxZTJlNSAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90L2J1aWxkYm90X3VuaXR0ZXN0LnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC9idWlsZGJv dF91bml0dGVzdC5weQpAQCAtMjU4LDYgKzI1OCw3IEBAIGNsYXNzIEJ1aWxkQm90VGVzdCh1bml0 dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICAgICAiU25vd0xlb3BhcmQuKlwoV2ViS2l0MiBUZXN0 IiwKICAgICAgICAgICAgICJMZW9wYXJkLipSZWxlYXNlIiwKICAgICAgICAgICAgICJXaW5kb3dz LipCdWlsZCIsCisgICAgICAgICAgICAiV2luQ0UiLAogICAgICAgICAgICAgIkVGTCIsCiAgICAg ICAgICAgICAiR1RLLiozMiIsCiAgICAgICAgICAgICAiR1RLLio2NC4qRGVidWciLCAgIyBEaXNh bGxvdyB0aGUgNjQtYml0IFJlbGVhc2UgYm90IHdoaWNoIGlzIGJyb2tlbi4K