54771 2011-02-18 14:02:25 -0800 WebKit2: Media document videos play only sound, no video (affects trailers.apple.com) 2011-02-21 15:51:43 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED http://jhepple.com/SampleMovies/AVI_to_MPEG-4.avi InRadar, PlatformOnly P1 Normal --- 1 jer.noble jer.noble oldest_to_newest 353816 0 jer.noble 2011-02-18 14:02:25 -0800 Videos played in a media document don't display video (just audio) under WebKit2. 353817 1 jer.noble 2011-02-18 14:02:48 -0800 rdar://problem/8492085 353824 2 83007 jer.noble 2011-02-18 14:21:41 -0800 Created attachment 83007 Patch 354007 3 83007 sam 2011-02-18 19:29:00 -0800 Comment on attachment 83007 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83007&action=review > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1533 > // Also don't claim to support accelerated rendering when in the media document, as we will then render > // via QTMovieView which is already accelerated. > - return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil && !m_player->inMediaDocument(); > + return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil; The comment here seems incorrect now. 354051 4 jer.noble 2011-02-18 21:29:35 -0800 (In reply to comment #3) > (From update of attachment 83007 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=83007&action=review > > > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:1533 > > // Also don't claim to support accelerated rendering when in the media document, as we will then render > > // via QTMovieView which is already accelerated. > > - return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil && !m_player->inMediaDocument(); > > + return isReadyForVideoSetup() && getQTMovieLayerClass() != Nil; > > The comment here seems incorrect now. I'll delete it. Thanks! 354862 5 jer.noble 2011-02-21 15:51:43 -0800 Committed r79259: <http://trac.webkit.org/changeset/79259> 83007 2011-02-18 14:21:41 -0800 2011-02-18 19:29:00 -0800 Patch 0001-2011-02-18-Jer-Noble-jer.noble-apple.com.patch text/plain 3140 jer.noble RnJvbSA0ZDdiOGYzMjg5MWFiNWY1ODI0NDJlYzQ4ZDk3ZTBhZmU3ZTIyMGNkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZXIgTm9ibGUgPGplci5ub2JsZUBhcHBsZS5jb20+CkRhdGU6 IEZyaSwgMTggRmViIDIwMTEgMTQ6MDQ6MjMgLTA4MDAKU3ViamVjdDogW1BBVENIXSAgMjAxMS0w Mi0xOCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KClJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgoKV2ViS2l0MjogTWVkaWEgZG9jdW1lbnQgdmlkZW9zIHBsYXkgb25seSBzb3Vu ZCwgbm8gdmlkZW8gKGFmZmVjdHMgdHJhaWxlcnMuYXBwbGUuY29tKQpodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ3NzEKCk5vdyB0aGF0IHZpZGVvIGlzIGFjY2VsZXJh dGVkLCB3ZSBubyBsb25nZXIgbmVlZCB0byBzcGVjaWFsIGNhc2UKdmlkZW8gcGxheWluZyB3aXRo aW4gYSBtZWRpYSBkb2N1bWVudC4KCiogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVy UHJpdmF0ZVFUS2l0Lm1tOgooV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQ6OnByZWZl cnJlZFJlbmRlcmluZ01vZGUpOgooV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQ6OnN1 cHBvcnRzQWNjZWxlcmF0ZWRSZW5kZXJpbmcpOgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogLi4uL2dy YXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5tbSAgICAgICAgfCAgICA4ICsrKyst LS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDBlOTlhNzguLjAzNWIzMTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBA QAorIDIwMTEtMDItMTggIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViS2l0MjogTWVkaWEg ZG9jdW1lbnQgdmlkZW9zIHBsYXkgb25seSBzb3VuZCwgbm8gdmlkZW8gKGFmZmVjdHMgdHJhaWxl cnMuYXBwbGUuY29tKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTQ3NzEKKworICAgICAgICBOb3cgdGhhdCB2aWRlbyBpcyBhY2NlbGVyYXRlZCwgd2Ug bm8gbG9uZ2VyIG5lZWQgdG8gc3BlY2lhbCBjYXNlCisgICAgICAgIHZpZGVvIHBsYXlpbmcgd2l0 aGluIGEgbWVkaWEgZG9jdW1lbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMv TWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW06CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXll clByaXZhdGVRVEtpdDo6cHJlZmVycmVkUmVuZGVyaW5nTW9kZSk6CisgICAgICAgIChXZWJDb3Jl OjpNZWRpYVBsYXllclByaXZhdGVRVEtpdDo6c3VwcG9ydHNBY2NlbGVyYXRlZFJlbmRlcmluZyk6 CisKIDIwMTEtMDItMTYgIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEtlbm5ldGggUnVzc2VsbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5tbSBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9NZWRpYVBsYXllclByaXZhdGVRVEtpdC5t bQppbmRleCA4YjFmYjkyLi5hNTkyOGZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9tYWMvTWVkaWFQbGF5ZXJQcml2YXRlUVRLaXQubW0KKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL01lZGlhUGxheWVyUHJpdmF0ZVFUS2l0Lm1t CkBAIC01NTIsMTQgKzU1MiwxNCBAQCBNZWRpYVBsYXllclByaXZhdGVRVEtpdDo6TWVkaWFSZW5k ZXJpbmdNb2RlIE1lZGlhUGxheWVyUHJpdmF0ZVFUS2l0OjpwcmVmZXJyZWRSZQogICAgIGlmICgh bV9wbGF5ZXItPmZyYW1lVmlldygpIHx8ICFtX3F0TW92aWUpCiAgICAgICAgIHJldHVybiBNZWRp YVJlbmRlcmluZ05vbmU7CiAKLSAgICBpZiAobV9wbGF5ZXItPmluTWVkaWFEb2N1bWVudCgpIHx8 ICFRVFZpZGVvUmVuZGVyZXJDbGFzcygpKQotICAgICAgICByZXR1cm4gTWVkaWFSZW5kZXJpbmdN b3ZpZVZpZXc7Ci0KICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAgICAgaWYgKHN1 cHBvcnRzQWNjZWxlcmF0ZWRSZW5kZXJpbmcoKSAmJiBtX3BsYXllci0+bWVkaWFQbGF5ZXJDbGll bnQoKS0+bWVkaWFQbGF5ZXJSZW5kZXJpbmdDYW5CZUFjY2VsZXJhdGVkKG1fcGxheWVyKSkKICAg ICAgICAgcmV0dXJuIE1lZGlhUmVuZGVyaW5nTW92aWVMYXllcjsKICNlbmRpZgogCisgICAgaWYg KCFRVFZpZGVvUmVuZGVyZXJDbGFzcygpKQorICAgICAgICByZXR1cm4gTWVkaWFSZW5kZXJpbmdN b3ZpZVZpZXc7CisgICAgCiAgICAgcmV0dXJuIE1lZGlhUmVuZGVyaW5nU29mdHdhcmVSZW5kZXJl cjsKIH0KIApAQCAtMTUzMCw3ICsxNTMwLDcgQEAgYm9vbCBNZWRpYVBsYXllclByaXZhdGVRVEtp dDo6c3VwcG9ydHNBY2NlbGVyYXRlZFJlbmRlcmluZygpIGNvbnN0CiB7CiAgICAgLy8gQWxzbyBk b24ndCBjbGFpbSB0byBzdXBwb3J0IGFjY2VsZXJhdGVkIHJlbmRlcmluZyB3aGVuIGluIHRoZSBt ZWRpYSBkb2N1bWVudCwgYXMgd2Ugd2lsbCB0aGVuIHJlbmRlciAKICAgICAvLyB2aWEgUVRNb3Zp ZVZpZXcgd2hpY2ggaXMgYWxyZWFkeSBhY2NlbGVyYXRlZC4KLSAgICByZXR1cm4gaXNSZWFkeUZv clZpZGVvU2V0dXAoKSAmJiBnZXRRVE1vdmllTGF5ZXJDbGFzcygpICE9IE5pbCAmJiAhbV9wbGF5 ZXItPmluTWVkaWFEb2N1bWVudCgpOworICAgIHJldHVybiBpc1JlYWR5Rm9yVmlkZW9TZXR1cCgp ICYmIGdldFFUTW92aWVMYXllckNsYXNzKCkgIT0gTmlsOwogfQogCiB2b2lkIE1lZGlhUGxheWVy UHJpdmF0ZVFUS2l0OjphY2NlbGVyYXRlZFJlbmRlcmluZ1N0YXRlQ2hhbmdlZCgpCi0tIAoxLjcu My40Cgo=