54769 2011-02-18 13:37:23 -0800 check-webkit-style: Misses brace style error when the line with the { has a } in it. 2011-02-18 22:52:36 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin webkit-unassigned commit-queue eric hamaji oldest_to_newest 353801 0 levin 2011-02-18 13:37:23 -0800 For example, https://bugs.webkit.org/show_bug.cgi?id=54688#c2 353803 1 83005 levin 2011-02-18 13:40:57 -0800 Created attachment 83005 Patch 353814 2 83005 eric 2011-02-18 13:59:11 -0800 Comment on attachment 83005 Patch Thanks! 354064 3 83005 commit-queue 2011-02-18 22:52:33 -0800 Comment on attachment 83005 Patch Clearing flags on attachment: 83005 Committed r79102: <http://trac.webkit.org/changeset/79102> 354065 4 commit-queue 2011-02-18 22:52:36 -0800 All reviewed patches have been landed. Closing bug. 83005 2011-02-18 13:40:57 -0800 2011-02-18 22:52:32 -0800 Patch bug-54769-20110218134056.patch text/plain 3162 levin U3VidmVyc2lvbiBSZXZpc2lvbjogNzkwMTIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhOWU0YjgwMzQ4NzAzMDc5NmEyYWVhZWU2ZjFiOWFhMDk3 NTc2ODRiLi4zNDA0NmJmMjlhZjc5YzBjZGY5ODJhZmZkYWQyODU3OTdhNzIzNDEwIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDItMTggIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1z dHlsZTogTWlzc2VzIGJyYWNlIHN0eWxlIGVycm9yIHdoZW4gdGhlIGxpbmUgd2l0aCB0aGUgeyBo YXMgYSB9IGluIGl0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NTQ3NjkKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwLnB5OiBGaXhlZCB0aGUgY2hlY2sgZm9yIHRoZSBjbG9zZSBicmFjZQorICAgICAgICAgIHRv IG9ubHkgbG9vayBhZnRlciB0aGUgbGFzdCBvcGVuIGJyYWNlLCBzbyB0aGF0IHRoZSBvcGVuIGJy YWNlIGluIHRoaXMgbGluZQorICAgICAgICAgICJ9IGVsc2UgeyIgd2lsbCBzdGlsbCBiZSBhYmxl IHRvIHRyaWdnZXIgdGhlIGVycm9yLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OiBBZGRlZCByZWxhdGVkIHVuaXQgdGVzdHMuCisKIDIw MTEtMDItMTYgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwLnB5CmluZGV4IGYxNmZmZmYzMjNmYjkyOTVhOTgxYzBiNzM1MWVkNjM4NWJm NmQwYjcuLjVhMGQ1Y2I1MmIwNzYzN2Y5ZGI5YTVjNWViNDE3OTE4MDUwOTBjMDcgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0yMTI3LDcgKzIx MjcsOCBAQCBkZWYgY2hlY2tfYnJhY2VzKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3Ip OgogICAgICAgICAjIFdlIGNoZWNrIGlmIGEgY2xvc2VkIGJyYWNlIGhhcyBzdGFydGVkIGEgbGlu ZSB0byBzZWUgaWYgYQogICAgICAgICAjIG9uZSBsaW5lIGNvbnRyb2wgc3RhdGVtZW50IHdhcyBw cmV2aW91cy4KICAgICAgICAgcHJldmlvdXNfbGluZSA9IGNsZWFuX2xpbmVzLmVsaWRlZFtsaW5l X251bWJlciAtIDJdCi0gICAgICAgIGlmIChwcmV2aW91c19saW5lLmZpbmQoJ3snKSA+IDAgYW5k IHByZXZpb3VzX2xpbmUuZmluZCgnfScpIDwgMAorICAgICAgICBsYXN0X29wZW5fYnJhY2UgPSBw cmV2aW91c19saW5lLnJmaW5kKCd7JykKKyAgICAgICAgaWYgKGxhc3Rfb3Blbl9icmFjZSAhPSAt MSBhbmQgcHJldmlvdXNfbGluZS5maW5kKCd9JywgbGFzdF9vcGVuX2JyYWNlKSA9PSAtMQogICAg ICAgICAgICAgYW5kIHNlYXJjaChyJ1xiKGlmfGZvcnxmb3JlYWNofHdoaWxlfGVsc2UpXGInLCBw cmV2aW91c19saW5lKSk6CiAgICAgICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ3doaXRlc3Bh Y2UvYnJhY2VzJywgNCwKICAgICAgICAgICAgICAgICAgICdPbmUgbGluZSBjb250cm9sIGNsYXVz ZXMgc2hvdWxkIG5vdCB1c2UgYnJhY2VzLicpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IDg3N2E2MmRkMmI0MDFh NWRiZDFiMDViNDkwZDZmZWYyNjFiZDc5Y2QuLmM5ZGJlYjRlZGU5MjYwYTMwMjUzN2EwMDgzNjBj NjcxODQyNjhmNWEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC0zNjE2LDYgKzM2MTYsMjEgQEAgY2xhc3MgV2Vi S2l0U3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAgICAgWydNb3JlIHRoYW4g b25lIGNvbW1hbmQgb24gdGhlIHNhbWUgbGluZSBpbiBpZiAgW3doaXRlc3BhY2UvcGFyZW5zXSBb NF0nLAogICAgICAgICAgICAgICdPbmUgbGluZSBjb250cm9sIGNsYXVzZXMgc2hvdWxkIG5vdCB1 c2UgYnJhY2VzLiAgW3doaXRlc3BhY2UvYnJhY2VzXSBbNF0nXSkKICAgICAgICAgc2VsZi5hc3Nl cnRfbXVsdGlfbGluZV9saW50KAorICAgICAgICAgICAgJ2lmIChjb25kaXRpb24pXG4nCisgICAg ICAgICAgICAnICAgIGRvU29tZXRoaW5nKCk7XG4nCisgICAgICAgICAgICAnZWxzZSB7XG4nCisg ICAgICAgICAgICAnICAgIGRvU29tZXRoaW5nRWxzZSgpO1xuJworICAgICAgICAgICAgJ31cbics CisgICAgICAgICAgICAnT25lIGxpbmUgY29udHJvbCBjbGF1c2VzIHNob3VsZCBub3QgdXNlIGJy YWNlcy4gIFt3aGl0ZXNwYWNlL2JyYWNlc10gWzRdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbXVs dGlfbGluZV9saW50KAorICAgICAgICAgICAgJ2lmIChjb25kaXRpb24pIHtcbicKKyAgICAgICAg ICAgICcgICAgZG9Tb21ldGhpbmcxKCk7XG4nCisgICAgICAgICAgICAnICAgIGRvU29tZXRoaW5n MigpO1xuJworICAgICAgICAgICAgJ30gZWxzZSB7XG4nCisgICAgICAgICAgICAnICAgIGRvU29t ZXRoaW5nRWxzZSgpO1xuJworICAgICAgICAgICAgJ31cbicsCisgICAgICAgICAgICAnT25lIGxp bmUgY29udHJvbCBjbGF1c2VzIHNob3VsZCBub3QgdXNlIGJyYWNlcy4gIFt3aGl0ZXNwYWNlL2Jy YWNlc10gWzRdJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAogICAgICAg ICAgICAgJ3ZvaWQgZnVuYygpXG4nCiAgICAgICAgICAgICAne1xuJwogICAgICAgICAgICAgJyAg ICB3aGlsZSAoY29uZGl0aW9uKSB7IH1cbicK