54762 2011-02-18 11:55:02 -0800 [Gtk] Re-enable meter tag support 2011-02-18 21:53:47 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 zan webkit-unassigned commit-queue oldest_to_newest 353720 0 zan 2011-02-18 11:55:02 -0800 After r78981 [1] the meter tag (HTMLMeterElement) was disabled by default in the GNUmakefile. We should re-enable its compilation by modifying build-webkit script properly. [1] http://trac.webkit.org/changeset/78981 353725 1 82991 zan 2011-02-18 11:57:35 -0800 Created attachment 82991 Enable Meter Tag by default in build-webkit Enables the Meter Tag so it compiles. Resolves failing tests that fail because HTMLMeterElement is not included in compilation. 353735 2 82992 zan 2011-02-18 12:09:24 -0800 Created attachment 82992 Updated patch This patch also enables meter tag support in the configure script. The support was previously enabled in the makefile, so it should now be enabled in configure.ac. 353737 3 82992 mrobinson 2011-02-18 12:14:20 -0800 Comment on attachment 82992 Updated patch Thanks! This may require a full rebuild on the bots. Let's see. 354058 4 82992 commit-queue 2011-02-18 21:53:43 -0800 Comment on attachment 82992 Updated patch Clearing flags on attachment: 82992 Committed r79096: <http://trac.webkit.org/changeset/79096> 354059 5 commit-queue 2011-02-18 21:53:47 -0800 All reviewed patches have been landed. Closing bug. 82991 2011-02-18 11:57:35 -0800 2011-02-18 12:09:24 -0800 Enable Meter Tag by default in build-webkit b.diff text/plain 1268 zan ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhOWU0 YjgwLi5lMjcyY2NiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDItMTggIFphbiBEb2JlcnNlayAgPHphbmRv YmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbR3RrXSBSZS1lbmFibGUgbWV0ZXIgdGFnIHN1cHBvcnQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0NzYyCisKKyAgICAgICAgTWV0 ZXIgdGFnIGlzIHN1cHBvcnRlZCBvbiB0aGUgR3RrIHBvcnQsIGVuYWJsZSBpdCBieSBkZWZhdWx0 LgorCisgICAgICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6CisKIDIwMTEtMDItMTYgIE1PUklU QSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2Vu dCBUYW11cmEuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xz L1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IDVjZTUxYzAuLjNkNmE4YzIgMTAwNzU1Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Vi a2l0CkBAIC0yMDAsNyArMjAwLDcgQEAgbXkgQGZlYXR1cmVzID0gKAogICAgICAgZGVmaW5lID0+ ICJFTkFCTEVfTUVESUFfU1RBVElTVElDUyIsIGRlZmF1bHQgPT4gMCwgdmFsdWUgPT4gXCRtZWRp YVN0YXRpc3RpY3NTdXBwb3J0IH0sCiAKICAgICB7IG9wdGlvbiA9PiAibWV0ZXItdGFnIiwgZGVz YyA9PiAiTWV0ZXIgVGFnIHN1cHBvcnQiLAotICAgICAgZGVmaW5lID0+ICJFTkFCTEVfTUVURVJf VEFHIiwgZGVmYXVsdCA9PiAhaXNHdGsoKSAmJiAhaXNBcHBsZVdpbldlYktpdCgpLCB2YWx1ZSA9 PiBcJG1ldGVyVGFnU3VwcG9ydCB9LAorICAgICAgZGVmaW5lID0+ICJFTkFCTEVfTUVURVJfVEFH IiwgZGVmYXVsdCA9PiAhaXNBcHBsZVdpbldlYktpdCgpLCB2YWx1ZSA9PiBcJG1ldGVyVGFnU3Vw cG9ydCB9LAogCiAgICAgeyBvcHRpb24gPT4gIm5ldHNjYXBlLXBsdWdpbiIsIGRlc2MgPT4gIk5l dHNjYXBlIFBsdWdpbiBzdXBwb3J0IiwKICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX05FVFNDQVBF X1BMVUdJTl9BUEkiLCBkZWZhdWx0ID0+ICFpc0VmbCgpLCB2YWx1ZSA9PiBcJG5ldHNjYXBlUGx1 Z2luU3VwcG9ydCB9LAo= 82992 2011-02-18 12:09:24 -0800 2011-02-18 21:53:43 -0800 Updated patch b.diff text/plain 2493 zan ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5OTc3NzlmLi4wY2YwNGRj IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDItMTggIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBSZS1lbmFi bGUgbWV0ZXIgdGFnIHN1cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTU0NzYyCisKKyAgICAgICAgRW5hYmxlIG1ldGVyIHRhZyBzdXBwb3J0IGlu IHRoZSBjb25maWd1cmUuYWMuIFRoaXMgZmVhdHVyZSB3YXMKKyAgICAgICAgcHJldmlvdXNseSBl bmFibGVkIGJ5IGRlZmF1bHQgaW4gdGhlIG1ha2VmaWxlLCBidXQgc2hvdWxkIGJlCisgICAgICAg IGVuYWJsZWQgaGVyZSBhZnRlciBjaGFuZ2VzIGluIHI3ODk4MS4KKworICAgICAgICAqIGNvbmZp Z3VyZS5hYzoKKwogMjAxMS0wMi0xOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxp YS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYnVpbGQgZml4IGFmdGVyIHI3ODk4MQpkaWZm IC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGE5ZTRiODAu LmUyNzJjY2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wMi0xOCAgWmFuIERvYmVyc2VrICA8emFuZG9iZXJz ZWtAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtHdGtdIFJlLWVuYWJsZSBtZXRlciB0YWcgc3VwcG9ydAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ3NjIKKworICAgICAgICBNZXRlciB0 YWcgaXMgc3VwcG9ydGVkIG9uIHRoZSBHdGsgcG9ydCwgZW5hYmxlIGl0IGJ5IGRlZmF1bHQuCisK KyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKwogMjAxMS0wMi0xNiAgTU9SSVRBIEhh amltZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRh bXVyYS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IGIvVG9vbHMvU2Ny aXB0cy9idWlsZC13ZWJraXQKaW5kZXggNWNlNTFjMC4uM2Q2YThjMiAxMDA3NTUKLS0tIGEvVG9v bHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQK QEAgLTIwMCw3ICsyMDAsNyBAQCBteSBAZmVhdHVyZXMgPSAoCiAgICAgICBkZWZpbmUgPT4gIkVO QUJMRV9NRURJQV9TVEFUSVNUSUNTIiwgZGVmYXVsdCA9PiAwLCB2YWx1ZSA9PiBcJG1lZGlhU3Rh dGlzdGljc1N1cHBvcnQgfSwKIAogICAgIHsgb3B0aW9uID0+ICJtZXRlci10YWciLCBkZXNjID0+ ICJNZXRlciBUYWcgc3VwcG9ydCIsCi0gICAgICBkZWZpbmUgPT4gIkVOQUJMRV9NRVRFUl9UQUci LCBkZWZhdWx0ID0+ICFpc0d0aygpICYmICFpc0FwcGxlV2luV2ViS2l0KCksIHZhbHVlID0+IFwk bWV0ZXJUYWdTdXBwb3J0IH0sCisgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9NRVRFUl9UQUciLCBk ZWZhdWx0ID0+ICFpc0FwcGxlV2luV2ViS2l0KCksIHZhbHVlID0+IFwkbWV0ZXJUYWdTdXBwb3J0 IH0sCiAKICAgICB7IG9wdGlvbiA9PiAibmV0c2NhcGUtcGx1Z2luIiwgZGVzYyA9PiAiTmV0c2Nh cGUgUGx1Z2luIHN1cHBvcnQiLAogICAgICAgZGVmaW5lID0+ICJFTkFCTEVfTkVUU0NBUEVfUExV R0lOX0FQSSIsIGRlZmF1bHQgPT4gIWlzRWZsKCksIHZhbHVlID0+IFwkbmV0c2NhcGVQbHVnaW5T dXBwb3J0IH0sCmRpZmYgLS1naXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1cmUuYWMKaW5kZXgg ZjYxNjNlYS4uY2Y2YWM3NiAxMDA2NDQKLS0tIGEvY29uZmlndXJlLmFjCisrKyBiL2NvbmZpZ3Vy ZS5hYwpAQCAtMzgzLDggKzM4Myw4IEBAIEFDX01TR19SRVNVTFQoWyRlbmFibGVfbm90aWZpY2F0 aW9uc10pCiBBQ19NU0dfQ0hFQ0tJTkcoW3doZXRoZXIgdG8gZW5hYmxlIEhUTUw1IG1ldGVyIHRh Z10pCiBBQ19BUkdfRU5BQkxFKG1ldGVyX3RhZywKICAgICAgICAgICAgICAgQUNfSEVMUF9TVFJJ TkcoWy0tZW5hYmxlLW1ldGVyLXRhZ10sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIFtl bmFibGUgSFRNTDUgbWV0ZXIgW2RlZmF1bHQ9bm9dXSksCi0gICAgICAgICAgICAgIFtdLFtlbmFi bGVfbWV0ZXJfdGFnPSJubyJdKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBbZW5hYmxl IEhUTUw1IG1ldGVyIFtkZWZhdWx0PXllc11dKSwKKyAgICAgICAgICAgICAgW10sW2VuYWJsZV9t ZXRlcl90YWc9InllcyJdKQogQUNfTVNHX1JFU1VMVChbJGVuYWJsZV9tZXRlcl90YWddKQogCiAj IGNoZWNrIHdoZXRoZXIgdG8gZW5hYmxlIHRoZSBwcm9ncmVzcyB0YWcK