54753 2011-02-18 09:18:04 -0800 REGRESSION(r79003): It broke tests on GTK bots (Requested by Ossy on #webkit). 2012-02-27 06:30:13 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED INVALID P2 Normal --- 1 webkit.review.bot webkit.review.bot kbalazs ossy oldest_to_newest 353620 0 webkit.review.bot 2011-02-18 09:18:04 -0800 http://trac.webkit.org/changeset/79003 broke the build: It broke tests on GTK bots (Requested by Ossy on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 353622 1 82968 webkit.review.bot 2011-02-18 09:18:24 -0800 Created attachment 82968 ROLLOUT of r79003 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 353624 2 82968 ossy 2011-02-18 09:21:38 -0800 Comment on attachment 82968 ROLLOUT of r79003 Rollout patch landed in http://trac.webkit.org/changeset/79005 I have no idea what happened on GTK bots ... I leave the bug open and will check it on monday. 353903 3 kbalazs 2011-02-18 15:54:30 -0800 (In reply to comment #2) > (From update of attachment 82968 [details]) > Rollout patch landed in http://trac.webkit.org/changeset/79005 > > I have no idea what happened on GTK bots ... Ok, but at least tell us what was the symptom? :) Was it a crash, a layout failure, or a compile error? 353904 4 ossy 2011-02-18 15:56:23 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 82968 [details] [details]) > > Rollout patch landed in http://trac.webkit.org/changeset/79005 > > > > I have no idea what happened on GTK bots ... > > Ok, but at least tell us what was the symptom? :) > Was it a crash, a layout failure, or a compile error? Feel free to check it yourself: http://build.webkit.org . ;) 353906 5 kbalazs 2011-02-18 16:00:29 -0800 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 82968 [details] [details]) > > Rollout patch landed in http://trac.webkit.org/changeset/79005 > > > > I have no idea what happened on GTK bots ... > > Ok, but at least tell us what was the symptom? :) > Was it a crash, a layout failure, or a compile error? Ok, I have just realized that it was your patch, so it was not so rude rolling it out and it's your business to fixing it ;) 82968 2011-02-18 09:18:24 -0800 2011-02-18 09:21:38 -0800 ROLLOUT of r79003 bug-54753-20110218171745.patch text/plain 3042 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogNzkwMDMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMDkyMWI3M2U4MWVkNmQ4 YzRiYzFkZGU0N2FkNWFjNzQ2ZDJlNmZjLi41MzhmZWU5ODMyZGEwMzdiMjY1ZjM3MGJiOTI4ZGJj NmM5YTQxZGZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDItMTggIFNoZXJp ZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgorCisgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHI3OTAwMy4KKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9j aGFuZ2VzZXQvNzkwMDMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTU0NzUzCisKKyAgICAgICAgSXQgYnJva2UgdGVzdHMgb24gR1RLIGJvdHMgKFJlcXVl c3RlZCBieSBPc3N5IG9uICN3ZWJraXQpLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omxhc3RDaGlsZENv bnNpZGVyaW5nQ29udGludWF0aW9uKToKKyAgICAgICAgKiBkb20vTm9kZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpOb2RlOjpyZW1vdmVFdmVudExpc3RlbmVyKToKKyAgICAgICAgKiBodG1sL0Rh dGVDb21wb25lbnRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGVDb21wb25lbnRzOjpwYXJz ZVRpbWUpOgorCiAyMDExLTAyLTE4ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5v cmc+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJP YmplY3QuY3BwCmluZGV4IGRiYTQ0OGU4OTdjYzg5NGIyMTExZjE1YjQzOWZhNmQ3MTcwNDA0ZGQu LjI2NDFjYThkOGIzNTFkOWIyYThmOGQxYWMxNjg3OGNmOGE3YTdhMWQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0LmNwcApAQCAtMTgyLDcgKzE4Miw3IEBAIHN0YXRpYyBpbmxpbmUgUmVuZGVyT2JqZWN0KiBs YXN0Q2hpbGRDb25zaWRlcmluZ0NvbnRpbnVhdGlvbihSZW5kZXJPYmplY3QqIHJlbmRlCiAKICAg ICAgICAgaWYgKGN1ci0+aXNSZW5kZXJJbmxpbmUoKSkgewogICAgICAgICAgICAgY3VyID0gdG9S ZW5kZXJJbmxpbmUoY3VyKS0+aW5saW5lRWxlbWVudENvbnRpbnVhdGlvbigpOwotICAgICAgICAg ICAgQVNTRVJUX1VOVVNFRChwcmV2LCBjdXIgfHwgIXRvUmVuZGVySW5saW5lKHByZXYpLT5jb250 aW51YXRpb24oKSk7CisgICAgICAgICAgICBBU1NFUlQoY3VyIHx8ICF0b1JlbmRlcklubGluZShw cmV2KS0+Y29udGludWF0aW9uKCkpOwogICAgICAgICB9IGVsc2UKICAgICAgICAgICAgIGN1ciA9 IHRvUmVuZGVyQmxvY2soY3VyKS0+aW5saW5lRWxlbWVudENvbnRpbnVhdGlvbigpOwogICAgIH0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9Ob2RlLmNwcAppbmRleCAyMjE0ZjU5NmU2NDBlNzdkNmEwMjAzNmQyYzFiYzE5NmJkZmY2 YTA2Li5iMDI5YTc1ZGVhMTU1NGMxY2IwNzUwZjY2MzIyOTJjZGQwYTQzYTVjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL05v ZGUuY3BwCkBAIC0yNDgzLDkgKzI0ODMsOSBAQCBib29sIE5vZGU6OnJlbW92ZUV2ZW50TGlzdGVu ZXIoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIEV2ZW50TGlzdGVuZXIqIGxpcwogICAg ICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KIAotICAgICAgICBBU1NFUlRfVU5VU0VEKGZvdW5k TGlzdGVuZXIsIGZvdW5kTGlzdGVuZXIpOworICAgICAgICBBU1NFUlQoZm91bmRMaXN0ZW5lcik7 CiAKLSAgICAgICAgaWYgKGVudHJ5LT5pc0VtcHR5KCkpIHsKKyAgICAgICAgaWYgKGVudHJ5LT5p c0VtcHR5KCkpIHsgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICBkZWxldGUgZW50cnk7CiAg ICAgICAgICAgICBkYXRhLT5ldmVudExpc3RlbmVyTWFwLnJlbW92ZShyZXN1bHQpOwogICAgICAg ICB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0RhdGVDb21wb25lbnRzLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvRGF0ZUNvbXBvbmVudHMuY3BwCmluZGV4IDYyODhkYTVlY2Fi ZTQ3ODFlZTZjZWI4YzBhNzYwM2Y1ZjkyOGY3NWEuLjhkY2VkMWQ1YjlkMGEyZDNiZDAwMDBjYTAy ODdhYzZhMTM5ZDA4MjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvRGF0ZUNvbXBv bmVudHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvRGF0ZUNvbXBvbmVudHMuY3BwCkBA IC00NDQsNyArNDQ0LDcgQEAgYm9vbCBEYXRlQ29tcG9uZW50czo6cGFyc2VUaW1lKGNvbnN0IFVD aGFyKiBzcmMsIHVuc2lnbmVkIGxlbmd0aCwgdW5zaWduZWQgc3RhcnQKICAgICAgICAgICAgICAg ICAgICAgICAgIG1pbGxpc2Vjb25kICo9IDEwOwogICAgICAgICAgICAgICAgICAgICB9IGVsc2Ug Ly8gZGlnaXRzTGVuZ3RoID49IDMKICAgICAgICAgICAgICAgICAgICAgICAgIG9rID0gdG9JbnQo c3JjLCBsZW5ndGgsIGluZGV4LCAzLCBtaWxsaXNlY29uZCk7Ci0gICAgICAgICAgICAgICAgICAg IEFTU0VSVF9VTlVTRUQob2ssIG9rKTsKKyAgICAgICAgICAgICAgICAgICAgQVNTRVJUKG9rKTsK ICAgICAgICAgICAgICAgICAgICAgaW5kZXggKz0gZGlnaXRzTGVuZ3RoOwogICAgICAgICAgICAg ICAgIH0KICAgICAgICAgICAgIH0K