54746 2011-02-18 06:57:34 -0800 QtWebKit fails to compile on Windows XP with msvc-2008 2011-02-21 05:10:34 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Windows XP RESOLVED FIXED P1 Blocker --- 0 kristian.amlie webkit-unassigned commit-queue darin kling oldest_to_newest 353580 0 kristian.amlie 2011-02-18 06:57:34 -0800 It fails because of a missing friend declaration. A check for the Qt platform is needed to enable the declaration. 353583 1 82957 kristian.amlie 2011-02-18 07:00:08 -0800 Created attachment 82957 Patch 353587 2 82957 kling 2011-02-18 07:45:16 -0800 Comment on attachment 82957 Patch r=me 354030 3 82957 commit-queue 2011-02-18 19:53:10 -0800 Comment on attachment 82957 Patch Clearing flags on attachment: 82957 Committed r79083: <http://trac.webkit.org/changeset/79083> 354031 4 commit-queue 2011-02-18 19:53:15 -0800 All reviewed patches have been landed. Closing bug. 354345 5 darin 2011-02-20 17:38:53 -0800 This was an incorrect fix. The correct way to do this would be to make it conditional on the compiler, which is where the limitation lies, instead of PLATFORM. The fix should be redone correctly. 354495 6 kristian.amlie 2011-02-21 02:53:53 -0800 Reopening to fix properly. 354496 7 83143 kristian.amlie 2011-02-21 02:54:58 -0800 Created attachment 83143 Proper-fix 354510 8 kling 2011-02-21 03:27:39 -0800 (In reply to comment #5) > This was an incorrect fix. The correct way to do this would be to make it conditional on the compiler, which is where the limitation lies, instead of PLATFORM. The fix should be redone correctly. Yes indeed, that's my bad. 354534 9 83143 commit-queue 2011-02-21 05:10:29 -0800 Comment on attachment 83143 Proper-fix Clearing flags on attachment: 83143 Committed r79211: <http://trac.webkit.org/changeset/79211> 354535 10 commit-queue 2011-02-21 05:10:34 -0800 All reviewed patches have been landed. Closing bug. 82957 2011-02-18 07:00:08 -0800 2011-02-18 19:53:10 -0800 Patch 0001-Added-friend-exception-to-Qt-platform-which-also-com.patch text/plain 2197 kristian.amlie RnJvbSBlNmQ0ZTE1NzNlZWY5MjFiNjAxOTFiZjJiMWQwNmU4ZjcyMWY4MWZmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLcmlzdGlhbiBBbWxpZSA8a3Jpc3RpYW4uYW1saWVAbm9raWEu Y29tPgpEYXRlOiBGcmksIDE4IEZlYiAyMDExIDE1OjI5OjIyICswMTAwClN1YmplY3Q6IFtQQVRD SF0gQWRkZWQgZnJpZW5kIGV4Y2VwdGlvbiB0byBRdCBwbGF0Zm9ybSwgd2hpY2ggYWxzbyBjb21w aWxlcyBXaW5kb3dzLgoKLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAg ICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUvQ29kZUJsb2NrLmggICB8ICAgIDIgKy0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1JlZ0V4cE9iamVjdC5oIHwgICAgMiArLQogMyBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGJjYzQwOWQu LjVhYjY3YTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEx LTAyLTE4ICBLcmlzdGlhbiBBbWxpZSAgPGtyaXN0aWFuLmFtbGllQG5va2lhLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBmcmllbmQg ZXhjZXB0aW9uIHRvIFF0IHBsYXRmb3JtLCB3aGljaCBhbHNvIGNvbXBpbGVzIFdpbmRvd3MuCisK KyAgICAgICAgUXRXZWJLaXQgZmFpbHMgdG8gY29tcGlsZSBvbiBXaW5kb3dzIFhQIHdpdGggbXN2 Yy0yMDA4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NDc0NgorCisgICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrLmg6CisgICAgICAgICogcnVudGlt ZS9SZWdFeHBPYmplY3QuaDoKKwogMjAxMS0wMi0xNyAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5A YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmggYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgKaW5kZXggZjg0OThiNC4uMWM2N2ViYyAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaApAQCAtNjAzLDcg KzYwMyw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAgICAgVmVjdG9yPENhbGxSZXR1cm5P ZmZzZXRUb0J5dGVjb2RlT2Zmc2V0PiBtX2NhbGxSZXR1cm5JbmRleFZlY3RvcjsKICNlbmRpZgog ICAgICAgICB9OwotI2lmIFBMQVRGT1JNKFdJTikKKyNpZiBQTEFURk9STShXSU4pIHx8IFBMQVRG T1JNKFFUKQogICAgICAgICBmcmllbmQgdm9pZCBXVEY6OmRlbGV0ZU93bmVkUHRyPFJhcmVEYXRh PihSYXJlRGF0YSopOwogI2VuZGlmCiAgICAgICAgIE93blB0cjxSYXJlRGF0YT4gbV9yYXJlRGF0 YTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cE9iamVj dC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwT2JqZWN0LmgKaW5kZXgg OTljODRkYS4uZmU3MmEyNSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvUmVnRXhwT2JqZWN0LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVn RXhwT2JqZWN0LmgKQEAgLTcwLDcgKzcwLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgICAg ICBSZWZQdHI8UmVnRXhwPiByZWdFeHA7CiAgICAgICAgICAgICBkb3VibGUgbGFzdEluZGV4Owog ICAgICAgICB9OwotI2lmIFBMQVRGT1JNKFdJTikKKyNpZiBQTEFURk9STShXSU4pIHx8IFBMQVRG T1JNKFFUKQogICAgICAgICBmcmllbmQgdm9pZCBXVEY6OmRlbGV0ZU93bmVkUHRyPFJlZ0V4cE9i amVjdERhdGE+KFJlZ0V4cE9iamVjdERhdGEqKTsKICNlbmRpZgogICAgICAgICBPd25QdHI8UmVn RXhwT2JqZWN0RGF0YT4gZDsKLS0gCjEuNy4yLjIKCg== 83143 2011-02-21 02:54:58 -0800 2011-02-21 05:10:29 -0800 Proper-fix 0001-Switched-to-compiler-based-detection-where-the-error.patch text/plain 2350 kristian.amlie RnJvbSAzMTk4ODI1MGY1ZDE0NDVlYjYwODE3NGE3YjcxYTA0NTA5OTY5YzFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLcmlzdGlhbiBBbWxpZSA8a3Jpc3RpYW4uYW1saWVAbm9raWEu Y29tPgpEYXRlOiBNb24sIDIxIEZlYiAyMDExIDExOjQ4OjA4ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gU3dpdGNoZWQgdG8gY29tcGlsZXIgYmFzZWQgZGV0ZWN0aW9uLCB3aGVyZSB0aGUgZXJyb3Ig YWN0dWFsbHkgaXMuCgpJdCBpcyBub3QgdGhlIHBsYXRmb3JtIHRoYXQgbmVlZHMgdGhlIHdvcmth cm91bmQsIGl0IGlzIHRoZSBjb21waWxlci4KLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaCAgIHwgICAgMiArLQogU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvUmVnRXhwT2JqZWN0LmggfCAgICAyICstCiAzIGZpbGVzIGNoYW5nZWQs IDE2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cK aW5kZXggYmNjNDA5ZC4uYWFmN2YyOCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTcgQEAKKzIwMTEtMDItMjEgIEtyaXN0aWFuIEFtbGllICA8a3Jpc3RpYW4uYW1saWVAbm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFN3aXRjaGVkIHRvIGNvbXBpbGVyIGJhc2VkIGRldGVjdGlvbiwgd2hlcmUgdGhlIGVycm9yIGFj dHVhbGx5IGlzLgorCisgICAgICAgIEl0IGlzIG5vdCB0aGUgcGxhdGZvcm0gdGhhdCBuZWVkcyB0 aGUgd29ya2Fyb3VuZCwgaXQgaXMgdGhlIGNvbXBpbGVyLgorCisgICAgICAgIFF0V2ViS2l0IGZh aWxzIHRvIGNvbXBpbGUgb24gV2luZG93cyBYUCB3aXRoIG1zdmMtMjAwOAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ3NDYKKworICAgICAgICAqIGJ5 dGVjb2RlL0NvZGVCbG9jay5oOgorICAgICAgICAqIHJ1bnRpbWUvUmVnRXhwT2JqZWN0Lmg6CisK IDIwMTEtMDItMTcgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2Rl L0NvZGVCbG9jay5oCmluZGV4IDFjNjdlYmMuLmJlZjQ1NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgKQEAgLTYwMyw3ICs2MDMsNyBAQCBuYW1lc3BhY2Ug SlNDIHsKICAgICAgICAgICAgIFZlY3RvcjxDYWxsUmV0dXJuT2Zmc2V0VG9CeXRlY29kZU9mZnNl dD4gbV9jYWxsUmV0dXJuSW5kZXhWZWN0b3I7CiAjZW5kaWYKICAgICAgICAgfTsKLSNpZiBQTEFU Rk9STShXSU4pIHx8IFBMQVRGT1JNKFFUKQorI2lmIENPTVBJTEVSKE1TVkMpCiAgICAgICAgIGZy aWVuZCB2b2lkIFdURjo6ZGVsZXRlT3duZWRQdHI8UmFyZURhdGE+KFJhcmVEYXRhKik7CiAjZW5k aWYKICAgICAgICAgT3duUHRyPFJhcmVEYXRhPiBtX3JhcmVEYXRhOwpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwT2JqZWN0LmggYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9SZWdFeHBPYmplY3QuaAppbmRleCBmZTcyYTI1Li4zNmZlZjQ4IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBPYmplY3QuaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHBPYmplY3QuaApAQCAtNzAs NyArNzAsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIFJlZlB0cjxSZWdFeHA+IHJl Z0V4cDsKICAgICAgICAgICAgIGRvdWJsZSBsYXN0SW5kZXg7CiAgICAgICAgIH07Ci0jaWYgUExB VEZPUk0oV0lOKSB8fCBQTEFURk9STShRVCkKKyNpZiBDT01QSUxFUihNU1ZDKQogICAgICAgICBm cmllbmQgdm9pZCBXVEY6OmRlbGV0ZU93bmVkUHRyPFJlZ0V4cE9iamVjdERhdGE+KFJlZ0V4cE9i amVjdERhdGEqKTsKICNlbmRpZgogICAgICAgICBPd25QdHI8UmVnRXhwT2JqZWN0RGF0YT4gZDsK LS0gCjEuNy4yLjIKCg==