54743 2011-02-18 06:46:22 -0800 Minimal build broken 2011-02-22 21:22:43 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned commit-queue mrobinson romaxa oldest_to_newest 353569 0 pnormand 2011-02-18 06:46:22 -0800 Final link complains about missing symbols: InspectorController::setInspectorExtensionAPI InspectorController::dispatchMessageFromFrontend In the InspectorController.cpp they are ifdef'd ENABLE(JAVASCRIPT_DEBUGGER) whereas they are not conditionally defined in the header file. See patch :) 353573 1 82954 pnormand 2011-02-18 06:48:14 -0800 Created attachment 82954 proposed patch 355672 2 romaxa 2011-02-22 16:03:15 -0800 Works, good, can anyone push this patch? 355829 3 82954 commit-queue 2011-02-22 21:22:38 -0800 Comment on attachment 82954 proposed patch Clearing flags on attachment: 82954 Committed r79394: <http://trac.webkit.org/changeset/79394> 355830 4 commit-queue 2011-02-22 21:22:43 -0800 All reviewed patches have been landed. Closing bug. 82954 2011-02-18 06:48:14 -0800 2011-02-22 21:22:38 -0800 proposed patch proposed-patch.patch text/plain 2654 pnormand RnJvbSAyYTI0YzQ1OWMzNmRhZDBjNGIyODJlNDY2YWNlYzI3ZWM4MjI2ZGEzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDE4IEZlYiAyMDExIDE1OjQ5OjM0ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcCB8ICAgMjAgKysrKysrKysrKy0tLS0tLS0tLS0K IDIgZmlsZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCmluZGV4IDAzZDAyMzEuLmIwYTgyNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAor MjAxMS0wMi0xOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWluaW1hbCBidWls ZCBicm9rZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTU0NzQzCisKKyAgICAgICAgTW92ZWQgdGhlIGNvZGUgb2Ygc2V0SW5zcGVjdG9yRXh0ZW5zaW9u QVBJIGFuZAorICAgICAgICBkaXNwYXRjaE1lc3NhZ2VGcm9tRnJvbnRlbmQgb3V0IG9mICNpZgor ICAgICAgICBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikgdG8gZml4IGxpbmsgZXJyb3Igb2Yg dGhlIG1pbmltYWwgYnVpbGQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJv bGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjpzZXRJbnNw ZWN0b3JFeHRlbnNpb25BUEkpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ29udHJvbGxl cjo6ZGlzcGF0Y2hNZXNzYWdlRnJvbUZyb250ZW5kKToKKwogMjAxMS0wMi0xOCAgU3RldmUgQmxv Y2sgIDxzdGV2ZWJsb2NrQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVh cyBLbGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNv bnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xs ZXIuY3BwCmluZGV4IDMyN2Q4MzQuLjljM2ZiNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKQEAgLTE5Miw2ICsxOTIsMTYgQEAgYm9v bCBJbnNwZWN0b3JDb250cm9sbGVyOjp0aW1lbGluZVByb2ZpbGVyRW5hYmxlZCgpCiAgICAgcmV0 dXJuIG1faW5zcGVjdG9yQWdlbnQtPnRpbWVsaW5lQWdlbnQoKTsKIH0KIAordm9pZCBJbnNwZWN0 b3JDb250cm9sbGVyOjpzZXRJbnNwZWN0b3JFeHRlbnNpb25BUEkoY29uc3QgU3RyaW5nJiBzb3Vy Y2UpCit7CisgICAgbV9pbnNwZWN0b3JBZ2VudC0+c2V0SW5zcGVjdG9yRXh0ZW5zaW9uQVBJKHNv dXJjZSk7Cit9CisKK3ZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlzcGF0Y2hNZXNzYWdlRnJv bUZyb250ZW5kKGNvbnN0IFN0cmluZyYgbWVzc2FnZSkKK3sKKyAgICBtX2luc3BlY3RvckJhY2tl bmREaXNwYXRjaGVyLT5kaXNwYXRjaChtZXNzYWdlKTsKK30KKwogI2lmIEVOQUJMRShKQVZBU0NS SVBUX0RFQlVHR0VSKQogdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjplbmFibGVQcm9maWxlcigp CiB7CkBAIC0yNDQsMTEgKzI1NCw2IEBAIGJvb2wgSW5zcGVjdG9yQ29udHJvbGxlcjo6aXNSZWNv cmRpbmdVc2VySW5pdGlhdGVkUHJvZmlsZSgpIGNvbnN0CiAgICAgcmV0dXJuIG1faW5zcGVjdG9y QWdlbnQtPmlzUmVjb3JkaW5nVXNlckluaXRpYXRlZFByb2ZpbGUoKTsKIH0KIAotdm9pZCBJbnNw ZWN0b3JDb250cm9sbGVyOjpzZXRJbnNwZWN0b3JFeHRlbnNpb25BUEkoY29uc3QgU3RyaW5nJiBz b3VyY2UpCi17Ci0gICAgbV9pbnNwZWN0b3JBZ2VudC0+c2V0SW5zcGVjdG9yRXh0ZW5zaW9uQVBJ KHNvdXJjZSk7Ci19Ci0KIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6cmVzdW1lKCkKIHsKICAg ICBpZiAoSW5zcGVjdG9yRGVidWdnZXJBZ2VudCogZGVidWdnZXJBZ2VudCA9IG1faW5zcGVjdG9y QWdlbnQtPmRlYnVnZ2VyQWdlbnQoKSkKQEAgLTI2MCwxMSArMjY1LDYgQEAgdm9pZCBJbnNwZWN0 b3JDb250cm9sbGVyOjpoaWRlSGlnaGxpZ2h0KCkKICAgICBtX2luc3BlY3RvckFnZW50LT5oaWRl SGlnaGxpZ2h0KCk7CiB9CiAKLXZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6ZGlzcGF0Y2hNZXNz YWdlRnJvbUZyb250ZW5kKGNvbnN0IFN0cmluZyYgbWVzc2FnZSkKLXsKLSAgICBtX2luc3BlY3Rv ckJhY2tlbmREaXNwYXRjaGVyLT5kaXNwYXRjaChtZXNzYWdlKTsKLX0KLQogI2VuZGlmCiAKIH0g Ly8gbmFtZXNwYWNlIFdlYkNvcmUKLS0gCjEuNy40LjE=