54741 2011-02-18 04:57:23 -0800 [Qt] Regression : on www.gmail.com a strange rendering issue appears on the menu bar due to flash. 2011-02-18 19:31:40 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Linux RESOLVED FIXED Qt, QtTriaged P1 Critical --- 1 menard menard ariya.hidayat commit-queue hausmann yael oldest_to_newest 353533 0 menard 2011-02-18 04:57:23 -0800 The patch ( http://trac.webkit.org/changeset/67516 ) introduce the "regression". Actually to me it was not working before but the bug fixed by the patch reveals it. On GMail.com there is a flash plugin loaded to play the sound of the chat. <embed id="flash_object" src="im/chatsound.swf" style="position:absolute;top:0px;left:0px;height:0px;width:0px;" quality="high" pluginspage="http://www.macromedia.com/go/getflashplayer" type="application/x-shockwave-flash"> The height and the width are 0. There is nothing to render and QX11EmbedContainer and all the X plumbing we have seem to be very confuse about that. My patch propose to not show the plugins with a height or a width null. Anyway even before 67516 you could see flicker on the menu bar and now with the patch it's totally clean. I've tested that the sound is still played :). 353536 1 82945 menard 2011-02-18 05:04:34 -0800 Created attachment 82945 Patch to fix the plugin rendering issues. Please give me feedback on that one and add to commit queue. 353538 2 menard 2011-02-18 05:07:40 -0800 *** Bug 52658 has been marked as a duplicate of this bug. *** 353539 3 82945 kling 2011-02-18 05:19:57 -0800 Comment on attachment 82945 Patch to fix the plugin rendering issues. View in context: https://bugs.webkit.org/attachment.cgi?id=82945&action=review r=me, but my inner kenneth has some complaints :) > Source/WebCore/ChangeLog:5 > + [Qt] Regression : on www.gmail.com a strange rendering issue appears on the If you know which commit caused the regression, we typically put something like "REGRESSION(r12345): Bla bla bla." > Source/WebCore/ChangeLog:6 > + menu bar due to flash. <kenneth>Extra space before "menu"!</kenneth> > Source/WebCore/ChangeLog:10 > + Only show plugins with a valid size. We then avoid X in the game if there is > + nothing to see anyway. s/X/involving X11/ for clarity. > Source/WebCore/plugins/qt/PluginViewQt.cpp:144 > + // The plugin had a zero width or height before but was resized, we need to show it again <kenneth>Needs period at end of sentence.</kenneth> > Source/WebCore/plugins/qt/PluginViewQt.cpp:949 > + // If the width and the height are not zero we show the pluginView <kenneth>Needs period at end of sentence.</kenneth> Also, s/pluginView/PluginView/ 353543 4 82947 menard 2011-02-18 05:30:59 -0800 Created attachment 82947 Updated version which try to make kenneth(patch) == true 354008 5 82947 commit-queue 2011-02-18 19:31:35 -0800 Comment on attachment 82947 Updated version which try to make kenneth(patch) == true Clearing flags on attachment: 82947 Committed r79074: <http://trac.webkit.org/changeset/79074> 354009 6 commit-queue 2011-02-18 19:31:40 -0800 All reviewed patches have been landed. Closing bug. 82945 2011-02-18 05:04:34 -0800 2011-02-18 05:30:59 -0800 Patch to fix the plugin rendering issues. patch.diff text/plain 1813 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkZTdiOWUwLi5hMDIxODFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDItMTggIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBSZWdyZXNzaW9uIDogb24gd3d3LmdtYWlsLmNvbSBhIHN0cmFuZ2UgcmVuZGVyaW5nIGlzc3Vl IGFwcGVhcnMgb24gdGhlCisgICAgICAgICBtZW51IGJhciBkdWUgdG8gZmxhc2guCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDc0MQorCisgICAgICAg IE9ubHkgc2hvdyBwbHVnaW5zIHdpdGggYSB2YWxpZCBzaXplLiBXZSB0aGVuIGF2b2lkIFggaW4g dGhlIGdhbWUgaWYgdGhlcmUgaXMKKyAgICAgICAgbm90aGluZyB0byBzZWUgYW55d2F5LgorCisg ICAgICAgICogcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UGx1Z2luVmlldzo6dXBkYXRlUGx1Z2luV2lkZ2V0KToKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdp blZpZXc6OnBsYXRmb3JtU3RhcnQpOgorCiAyMDExLTAyLTE3ICBIdWkgSHVhbmcgIDxodWkuMi5o dWFuZ0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTGFzemxvIEdvbWJvcy4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcAppbmRleCAyNTYxZTU0Li4w YzQxNmNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdR dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCkBA IC0xNDEsNiArMTQxLDEwIEBAIHZvaWQgUGx1Z2luVmlldzo6dXBkYXRlUGx1Z2luV2lkZ2V0KCkK ICAgICBpZiAobV93aW5kb3dSZWN0ID09IG9sZFdpbmRvd1JlY3QgJiYgbV9jbGlwUmVjdCA9PSBv bGRDbGlwUmVjdCkKICAgICAgICAgcmV0dXJuOwogCisgICAgLy8gVGhlIHBsdWdpbiBoYWQgYSB6 ZXJvIHdpZHRoIG9yIGhlaWdodCBiZWZvcmUgYnV0IHdhcyByZXNpemVkLCB3ZSBuZWVkIHRvIHNo b3cgaXQgYWdhaW4KKyAgICBpZiAob2xkV2luZG93UmVjdC5pc0VtcHR5KCkpCisgICAgICAgIHNo b3coKTsKKwogICAgIGlmICghbV9pc1dpbmRvd2VkICYmIG1fd2luZG93UmVjdC5zaXplKCkgIT0g b2xkV2luZG93UmVjdC5zaXplKCkpIHsKICNpZiBkZWZpbmVkKE1PWl9QTEFURk9STV9NQUVNTykg JiYgKE1PWl9QTEFURk9STV9NQUVNTyA+PSA1KQogICAgICAgICAvLyBPbiBNYWVtbzUsIEZsYXNo IGFsd2F5cyByZW5kZXJzIHRvIDE2LWJpdCBidWZmZXIKQEAgLTk0Miw3ICs5NDYsOSBAQCBib29s IFBsdWdpblZpZXc6OnBsYXRmb3JtU3RhcnQoKQogI2VuZGlmCiAgICAgfQogCi0gICAgc2hvdygp OworICAgIC8vIElmIHRoZSB3aWR0aCBhbmQgdGhlIGhlaWdodCBhcmUgbm90IHplcm8gd2Ugc2hv dyB0aGUgcGx1Z2luVmlldworICAgIGlmICghZnJhbWVSZWN0KCkuaXNFbXB0eSgpKQorICAgICAg ICBzaG93KCk7CiAKICAgICBOUFNldFdpbmRvd0NhbGxiYWNrU3RydWN0KiB3c2kgPSBuZXcgTlBT ZXRXaW5kb3dDYWxsYmFja1N0cnVjdCgpOwogICAgIHdzaS0+dHlwZSA9IDA7Cg== 82947 2011-02-18 05:30:59 -0800 2011-02-18 19:31:35 -0800 Updated version which try to make kenneth(patch) == true patch.diff text/plain 1820 menard ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkZTdiOWUwLi5jMjYxMmVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMDItMTggIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXMubWVuYXJkQG9wZW5ib3NzYS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBSRUdSRVNTSU9OKHI2NzUxNikgOiBvbiB3d3cuZ21haWwuY29tIGEgc3RyYW5nZSByZW5kZXJp bmcgaXNzdWUgYXBwZWFycyBvbiB0aGUKKyAgICAgICAgbWVudSBiYXIgZHVlIHRvIGZsYXNoLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ3NDEKKwor ICAgICAgICBPbmx5IHNob3cgcGx1Z2lucyB3aXRoIGEgdmFsaWQgc2l6ZS4gV2UgdGhlbiBkb24n dCBpbnZvbHZlIFgxMSBpZiB0aGVyZSBpcworICAgICAgICBub3RoaW5nIHRvIHNlZSBhbnl3YXku CisKKyAgICAgICAgKiBwbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpQbHVnaW5WaWV3Ojp1cGRhdGVQbHVnaW5XaWRnZXQpOgorICAgICAgICAoV2ViQ29yZTo6 UGx1Z2luVmlldzo6cGxhdGZvcm1TdGFydCk6CisKIDIwMTEtMDItMTcgIEh1aSBIdWFuZyAgPGh1 aS4yLmh1YW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBMYXN6bG8gR29tYm9z LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCmluZGV4IDI1NjFl NTQuLmExMjcwYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2lu Vmlld1F0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5j cHAKQEAgLTE0MSw2ICsxNDEsMTAgQEAgdm9pZCBQbHVnaW5WaWV3Ojp1cGRhdGVQbHVnaW5XaWRn ZXQoKQogICAgIGlmIChtX3dpbmRvd1JlY3QgPT0gb2xkV2luZG93UmVjdCAmJiBtX2NsaXBSZWN0 ID09IG9sZENsaXBSZWN0KQogICAgICAgICByZXR1cm47CiAKKyAgICAvLyBUaGUgcGx1Z2luIGhh ZCBhIHplcm8gd2lkdGggb3IgaGVpZ2h0IGJlZm9yZSBidXQgd2FzIHJlc2l6ZWQsIHdlIG5lZWQg dG8gc2hvdyBpdCBhZ2Fpbi4KKyAgICBpZiAob2xkV2luZG93UmVjdC5pc0VtcHR5KCkpCisgICAg ICAgIHNob3coKTsKKwogICAgIGlmICghbV9pc1dpbmRvd2VkICYmIG1fd2luZG93UmVjdC5zaXpl KCkgIT0gb2xkV2luZG93UmVjdC5zaXplKCkpIHsKICNpZiBkZWZpbmVkKE1PWl9QTEFURk9STV9N QUVNTykgJiYgKE1PWl9QTEFURk9STV9NQUVNTyA+PSA1KQogICAgICAgICAvLyBPbiBNYWVtbzUs IEZsYXNoIGFsd2F5cyByZW5kZXJzIHRvIDE2LWJpdCBidWZmZXIKQEAgLTk0Miw3ICs5NDYsOSBA QCBib29sIFBsdWdpblZpZXc6OnBsYXRmb3JtU3RhcnQoKQogI2VuZGlmCiAgICAgfQogCi0gICAg c2hvdygpOworICAgIC8vIElmIHRoZSB3aWR0aCBhbmQgdGhlIGhlaWdodCBhcmUgbm90IHplcm8g d2Ugc2hvdyB0aGUgUGx1Z2luVmlldy4KKyAgICBpZiAoIWZyYW1lUmVjdCgpLmlzRW1wdHkoKSkK KyAgICAgICAgc2hvdygpOwogCiAgICAgTlBTZXRXaW5kb3dDYWxsYmFja1N0cnVjdCogd3NpID0g bmV3IE5QU2V0V2luZG93Q2FsbGJhY2tTdHJ1Y3QoKTsKICAgICB3c2ktPnR5cGUgPSAwOwo=