54738 2011-02-18 03:20:06 -0800 Web Inspector: [Audits] Image dimensions in inline style not checked 2011-02-21 06:42:24 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik rniwa timothy yurys oldest_to_newest 353511 0 apavlov 2011-02-18 03:20:06 -0800 1. Create a page that contains an image with dimensions in the style attribute. <img style="width: 16px; height: 16px" src="http://someurl/file.gif"> 2. Audit the page in chrome A warning appears that the image file.gif does not have its width and/or height specified. Upstreaming Chromium issue http://code.google.com/p/chromium/issues/detail?id=58067 353512 1 82939 apavlov 2011-02-18 03:31:22 -0800 Created attachment 82939 [PATCH] Suggested fix 354569 2 82939 commit-queue 2011-02-21 06:40:52 -0800 Comment on attachment 82939 [PATCH] Suggested fix Clearing flags on attachment: 82939 Committed r79218: <http://trac.webkit.org/changeset/79218> 354570 3 commit-queue 2011-02-21 06:40:57 -0800 All reviewed patches have been landed. Closing bug. 354571 4 rniwa 2011-02-21 06:42:24 -0800 Committed r79219: <http://trac.webkit.org/changeset/79219> 82939 2011-02-18 03:31:22 -0800 2011-02-21 06:40:52 -0800 [PATCH] Suggested fix imagedimsaudit.patch text/plain 3723 apavlov Y29tbWl0IDY3Y2EwMDk4OTg1MDZhNjY4ZDkyZmQwNmI2OGQyMDgxMzk5Yjg0MzIKQXV0aG9yOiBB bGV4YW5kZXIgUGF2bG92IDxhcGF2bG92QGNocm9taXVtLm9yZz4KRGF0ZTogICBGcmkgRmViIDE4 IDE0OjIyOjAwIDIwMTEgKzAzMDAKCiAgICBGaXgKCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmM3MjFkMy4uM2JjMTg3MSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTAyLTE4ICBBbGV4YW5kZXIgUGF2bG92ICA8YXBh dmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogW0F1ZGl0c10gSW1hZ2UgZGltZW5zaW9ucyBpbiBp bmxpbmUgc3R5bGUgbm90IGNoZWNrZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTU0NzM4CisKKyAgICAgICAgKiBpbnNwZWN0b3IvYXVkaXRzL2F1ZGl0 cy1wYW5lbC1mdW5jdGlvbmFsLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBpbnNwZWN0b3IvYXVk aXRzL2F1ZGl0cy1wYW5lbC1mdW5jdGlvbmFsLmh0bWw6CisKIDIwMTEtMDItMTcgIEhhbnMgV2Vu bmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkg T3Jsb3cuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvYXVkaXRzL2F1ZGl0cy1w YW5lbC1mdW5jdGlvbmFsLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9hdWRp dHMvYXVkaXRzLXBhbmVsLWZ1bmN0aW9uYWwtZXhwZWN0ZWQudHh0CmluZGV4IGJmZDQ5ZDguLjQ1 ZTU1Y2EgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9hdWRpdHMvYXVkaXRzLXBh bmVsLWZ1bmN0aW9uYWwtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9h dWRpdHMvYXVkaXRzLXBhbmVsLWZ1bmN0aW9uYWwtZXhwZWN0ZWQudHh0CkBAIC0xLDQgKzEsNCBA QAotVGVzdHMgYXVkaXQgcnVsZXMuICAgIAorVGVzdHMgYXVkaXQgcnVsZXMuICAgICAKIFBhZ2Ug cmVsb2FkZWQuCiAgIE5ldHdvcmsgVXRpbGl6YXRpb24KICAgICBDb21iaW5lIGV4dGVybmFsIEph dmFTY3JpcHQgKDQpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvYXVkaXRzL2F1 ZGl0cy1wYW5lbC1mdW5jdGlvbmFsLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvYXVkaXRz L2F1ZGl0cy1wYW5lbC1mdW5jdGlvbmFsLmh0bWwKaW5kZXggNTExYzA4Yy4uNjk2ZDNmMSAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2F1ZGl0cy9hdWRpdHMtcGFuZWwtZnVuY3Rp b25hbC5odG1sCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9hdWRpdHMvYXVkaXRzLXBhbmVs LWZ1bmN0aW9uYWwuaHRtbApAQCAtNTEsNiArNTEsNyBAQCBUZXN0cyBhdWRpdCBydWxlcy4KIDxp bWcgc3JjPSJmb28xLmpwZyI+CiA8aW1nIHNyYz0iZm9vMi5qcGciIHdpZHRoPTEwMD4KIDxpbWcg c3JjPSJmb28zLmpwZyIgc3R5bGU9InBvc2l0aW9uOiBhYnNvbHV0ZSI+Cis8aW1nIHNyYz0iZm9v NC5qcGciIHN0eWxlPSJ3aWR0aDogMTZweDsgaGVpZ2h0OiAxNnB4Ij4KIAogPC9ib2R5PgogPC9o dG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCmluZGV4IDIyYjAzNzEuLjA2ZDdkMGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMyBAQAorMjAxMS0wMi0xOCAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl YiBJbnNwZWN0b3I6IFtBdWRpdHNdIEltYWdlIGRpbWVuc2lvbnMgaW4gaW5saW5lIHN0eWxlIG5v dCBjaGVja2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NDczOAorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9BdWRpdFJ1bGVzLmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLkF1ZGl0UnVsZXMuSW1hZ2VEaW1lbnNpb25zUnVsZS5wcm90 b3R5cGUuZG9SdW4pOgorCiAyMDExLTAyLTE4ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRA aWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0UnVsZXMuanMg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0UnVsZXMuanMKaW5kZXgg N2Q0YjhhNS4uOTdmYzljZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zy b250LWVuZC9BdWRpdFJ1bGVzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvQXVkaXRSdWxlcy5qcwpAQCAtNjgwLDYgKzY4MCwxNCBAQCBXZWJJbnNwZWN0b3IuQXVk aXRSdWxlcy5JbWFnZURpbWVuc2lvbnNSdWxlLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHZh ciB3aWR0aEZvdW5kID0gIndpZHRoIiBpbiBzdHlsZXMuc3R5bGVBdHRyaWJ1dGVzOwogICAgICAg ICAgICAgdmFyIGhlaWdodEZvdW5kID0gImhlaWdodCIgaW4gc3R5bGVzLnN0eWxlQXR0cmlidXRl czsKIAorICAgICAgICAgICAgdmFyIGlubGluZVN0eWxlID0gc3R5bGVzLmlubGluZVN0eWxlOwor ICAgICAgICAgICAgaWYgKGlubGluZVN0eWxlKSB7CisgICAgICAgICAgICAgICAgaWYgKGlubGlu ZVN0eWxlLmdldFByb3BlcnR5VmFsdWUoIndpZHRoIikgIT09ICIiKQorICAgICAgICAgICAgICAg ICAgICB3aWR0aEZvdW5kID0gdHJ1ZTsKKyAgICAgICAgICAgICAgICBpZiAoaW5saW5lU3R5bGUu Z2V0UHJvcGVydHlWYWx1ZSgiaGVpZ2h0IikgIT09ICIiKQorICAgICAgICAgICAgICAgICAgICBo ZWlnaHRGb3VuZCA9IHRydWU7CisgICAgICAgICAgICB9CisKICAgICAgICAgICAgIGZvciAodmFy IGkgPSBzdHlsZXMubWF0Y2hlZENTU1J1bGVzLmxlbmd0aCAtIDE7IGkgPj0gMCAmJiAhKHdpZHRo Rm91bmQgJiYgaGVpZ2h0Rm91bmQpOyAtLWkpIHsKICAgICAgICAgICAgICAgICB2YXIgc3R5bGUg PSBzdHlsZXMubWF0Y2hlZENTU1J1bGVzW2ldLnN0eWxlOwogICAgICAgICAgICAgICAgIGlmIChz dHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCJ3aWR0aCIpICE9PSAiIikKQEAgLTY4Nyw3ICs2OTUsNyBA QCBXZWJJbnNwZWN0b3IuQXVkaXRSdWxlcy5JbWFnZURpbWVuc2lvbnNSdWxlLnByb3RvdHlwZSA9 IHsKICAgICAgICAgICAgICAgICBpZiAoc3R5bGUuZ2V0UHJvcGVydHlWYWx1ZSgiaGVpZ2h0Iikg IT09ICIiKQogICAgICAgICAgICAgICAgICAgICBoZWlnaHRGb3VuZCA9IHRydWU7CiAgICAgICAg ICAgICB9Ci0gICAgICAgICAgICAKKwogICAgICAgICAgICAgaWYgKCF3aWR0aEZvdW5kIHx8ICFo ZWlnaHRGb3VuZCkgewogICAgICAgICAgICAgICAgIGlmIChzcmMgaW4gY29udGV4dC51cmxUb05v RGltZW5zaW9uQ291bnQpCiAgICAgICAgICAgICAgICAgICAgICsrY29udGV4dC51cmxUb05vRGlt ZW5zaW9uQ291bnRbc3JjXTsK