54728 2011-02-18 00:24:24 -0800 checkSelector*Value functions used in fastCheckSelector fail to inline 2011-06-18 12:02:42 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned darin oldest_to_newest 353459 0 koivisto 2011-02-18 00:24:24 -0800 They should be inlined for performance. 353461 1 82930 koivisto 2011-02-18 00:30:26 -0800 Created attachment 82930 patch 353466 2 82930 mjs 2011-02-18 00:55:32 -0800 Comment on attachment 82930 patch r=me 82930 2011-02-18 00:30:26 -0800 2011-02-18 00:55:32 -0800 patch fast-path-inline.patch text/plain 4621 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4OTcxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDItMTggIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01NDcyOAorICAgICAgICBjaGVja1NlbGVjdG9yKlZhbHVlIGZ1bmN0aW9ucyB1c2VkIGluIGZh c3RDaGVja1NlbGVjdG9yIGZhaWwgdG8gaW5saW5lCisgICAgICAgIAorICAgICAgICBXcmFwIHRo ZSBmdW5jdGlvbnMgdXNlZCBhcyB0ZW1wbGF0ZSBhcmd1bWVudHMgdG8gY2xhc3Nlcy4KKworICAg ICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmZhc3RD aGVja1NpbmdsZVNlbGVjdG9yKToKKyAgICAgICAgKFdlYkNvcmU6OkNsYXNzQ2hlY2s6OmNoZWNr VmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6SWRDaGVjazo6Y2hlY2tWYWx1ZSk6CisgICAgICAg IChXZWJDb3JlOjpUYWdDaGVjazo6Y2hlY2tWYWx1ZSk6CisgICAgICAgIChXZWJDb3JlOjpDU1NT dHlsZVNlbGVjdG9yOjpTZWxlY3RvckNoZWNrZXI6OmZhc3RDaGVja1NlbGVjdG9yKToKKwogMjAx MS0wMi0xNyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0 eWxlU2VsZWN0b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHls ZVNlbGVjdG9yLmNwcAkocmV2aXNpb24gNzg3MjUpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NT U3R5bGVTZWxlY3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwODEsMTIgKzIwODEsMTIgQEAg c3RhdGljIGlubGluZSBib29sIGlzRmFzdENoZWNrYWJsZVNlbGVjdAogICAgIHJldHVybiB0cnVl OwogfQogICAgIAotdGVtcGxhdGUgPHR5cGVuYW1lIENoZWNrVmFsdWVGdW5jdGlvbj4KLWlubGlu ZSBib29sIGZhc3RDaGVja1NpbmdsZVNlbGVjdG9yKGNvbnN0IENTU1NlbGVjdG9yKiYgc2VsZWN0 b3IsIGNvbnN0IEVsZW1lbnQqJiBlbGVtZW50LCBjb25zdCBDU1NTZWxlY3RvciomIHRvcENoaWxk T3JTdWJzZWxlY3RvciwgY29uc3QgRWxlbWVudComIHRvcENoaWxkT3JTdWJzZWxlY3Rvck1hdGNo RWxlbWVudCwgQ2hlY2tWYWx1ZUZ1bmN0aW9uIGNoZWNrVmFsdWUpCit0ZW1wbGF0ZSA8dHlwZW5h bWUgVmFsdWVDaGVja2VyPgoraW5saW5lIGJvb2wgZmFzdENoZWNrU2luZ2xlU2VsZWN0b3IoY29u c3QgQ1NTU2VsZWN0b3IqJiBzZWxlY3RvciwgY29uc3QgRWxlbWVudComIGVsZW1lbnQsIGNvbnN0 IENTU1NlbGVjdG9yKiYgdG9wQ2hpbGRPclN1YnNlbGVjdG9yLCBjb25zdCBFbGVtZW50KiYgdG9w Q2hpbGRPclN1YnNlbGVjdG9yTWF0Y2hFbGVtZW50KQogewogICAgIEF0b21pY1N0cmluZ0ltcGwq IHZhbHVlID0gc2VsZWN0b3ItPnZhbHVlKCkuaW1wbCgpOwogICAgIGZvciAoOyBlbGVtZW50OyBl bGVtZW50ID0gZWxlbWVudC0+cGFyZW50RWxlbWVudCgpKSB7Ci0gICAgICAgIGlmIChjaGVja1Zh bHVlKGVsZW1lbnQsIHZhbHVlKSAmJiBzZWxlY3RvclRhZ01hdGNoZXMoZWxlbWVudCwgc2VsZWN0 b3IpKSB7CisgICAgICAgIGlmIChWYWx1ZUNoZWNrZXI6OmNoZWNrVmFsdWUoZWxlbWVudCwgdmFs dWUpICYmIHNlbGVjdG9yVGFnTWF0Y2hlcyhlbGVtZW50LCBzZWxlY3RvcikpIHsKICAgICAgICAg ICAgIGlmIChzZWxlY3Rvci0+cmVsYXRpb24oKSA9PSBDU1NTZWxlY3Rvcjo6RGVzY2VuZGFudCkK ICAgICAgICAgICAgICAgICB0b3BDaGlsZE9yU3Vic2VsZWN0b3IgPSAwOwogICAgICAgICAgICAg ZWxzZSBpZiAoIXRvcENoaWxkT3JTdWJzZWxlY3RvcikgewpAQCAtMjExNSwyMSArMjExNSwyNSBA QCBpbmxpbmUgYm9vbCBmYXN0Q2hlY2tTaW5nbGVTZWxlY3Rvcihjb25zCiAgICAgfQogICAgIHJl dHVybiBmYWxzZTsKIH0KLSAgICAKLXN0YXRpYyBpbmxpbmUgYm9vbCBjaGVja1NlbGVjdG9yQ2xh c3NWYWx1ZShjb25zdCBFbGVtZW50KiBlbGVtZW50LCBBdG9taWNTdHJpbmdJbXBsKiB2YWx1ZSkg Ci17Ci0gICAgcmV0dXJuIGVsZW1lbnQtPmhhc0NsYXNzKCkgJiYgc3RhdGljX2Nhc3Q8Y29uc3Qg U3R5bGVkRWxlbWVudCo+KGVsZW1lbnQpLT5jbGFzc05hbWVzKCkuY29udGFpbnModmFsdWUpOwot fQotCi1zdGF0aWMgaW5saW5lIGJvb2wgY2hlY2tTZWxlY3RvcklkVmFsdWUoY29uc3QgRWxlbWVu dCogZWxlbWVudCwgQXRvbWljU3RyaW5nSW1wbCogdmFsdWUpIAotewotICAgIHJldHVybiBlbGVt ZW50LT5oYXNJRCgpICYmIGVsZW1lbnQtPmlkRm9yU3R5bGVSZXNvbHV0aW9uKCkuaW1wbCgpID09 IHZhbHVlOwotfQogCi1zdGF0aWMgaW5saW5lIGJvb2wgY2hlY2tTZWxlY3RvclRhZ1ZhbHVlKGNv bnN0IEVsZW1lbnQqLCBBdG9taWNTdHJpbmdJbXBsKikKLXsKLSAgICByZXR1cm4gdHJ1ZTsKLX0K K3N0cnVjdCBDbGFzc0NoZWNrIHsKKyAgICBzdGF0aWMgYm9vbCBjaGVja1ZhbHVlKGNvbnN0IEVs ZW1lbnQqIGVsZW1lbnQsIEF0b21pY1N0cmluZ0ltcGwqIHZhbHVlKSAKKyAgICB7CisgICAgICAg IHJldHVybiBlbGVtZW50LT5oYXNDbGFzcygpICYmIHN0YXRpY19jYXN0PGNvbnN0IFN0eWxlZEVs ZW1lbnQqPihlbGVtZW50KS0+Y2xhc3NOYW1lcygpLmNvbnRhaW5zKHZhbHVlKTsKKyAgICB9Cit9 Oworc3RydWN0IElkQ2hlY2sgeworICAgIHN0YXRpYyBib29sIGNoZWNrVmFsdWUoY29uc3QgRWxl bWVudCogZWxlbWVudCwgQXRvbWljU3RyaW5nSW1wbCogdmFsdWUpIAorICAgIHsKKyAgICAgICAg cmV0dXJuIGVsZW1lbnQtPmhhc0lEKCkgJiYgZWxlbWVudC0+aWRGb3JTdHlsZVJlc29sdXRpb24o KS5pbXBsKCkgPT0gdmFsdWU7CisgICAgfQorfTsKK3N0cnVjdCBUYWdDaGVjayB7CisgICAgc3Rh dGljIGJvb2wgY2hlY2tWYWx1ZShjb25zdCBFbGVtZW50KiwgQXRvbWljU3RyaW5nSW1wbCopCisg ICAgeworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9Cit9OwogCiBib29sIENTU1N0eWxlU2Vs ZWN0b3I6OlNlbGVjdG9yQ2hlY2tlcjo6ZmFzdENoZWNrU2VsZWN0b3IoY29uc3QgQ1NTU2VsZWN0 b3IqIHNlbGVjdG9yLCBjb25zdCBFbGVtZW50KiBlbGVtZW50KQogewpAQCAtMjE1MywxNSArMjE1 NywxNSBAQCBib29sIENTU1N0eWxlU2VsZWN0b3I6OlNlbGVjdG9yQ2hlY2tlcjo6CiAgICAgd2hp bGUgKHNlbGVjdG9yKSB7CiAgICAgICAgIHN3aXRjaCAoc2VsZWN0b3ItPm1fbWF0Y2gpIHsKICAg ICAgICAgY2FzZSBDU1NTZWxlY3Rvcjo6Q2xhc3M6Ci0gICAgICAgICAgICBpZiAoIWZhc3RDaGVj a1NpbmdsZVNlbGVjdG9yKHNlbGVjdG9yLCBlbGVtZW50LCB0b3BDaGlsZE9yU3Vic2VsZWN0b3Is IHRvcENoaWxkT3JTdWJzZWxlY3Rvck1hdGNoRWxlbWVudCwgY2hlY2tTZWxlY3RvckNsYXNzVmFs dWUpKQorICAgICAgICAgICAgaWYgKCFmYXN0Q2hlY2tTaW5nbGVTZWxlY3RvcjxDbGFzc0NoZWNr PihzZWxlY3RvciwgZWxlbWVudCwgdG9wQ2hpbGRPclN1YnNlbGVjdG9yLCB0b3BDaGlsZE9yU3Vi c2VsZWN0b3JNYXRjaEVsZW1lbnQpKQogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIENTU1NlbGVjdG9yOjpJZDoKLSAgICAgICAg ICAgIGlmICghZmFzdENoZWNrU2luZ2xlU2VsZWN0b3Ioc2VsZWN0b3IsIGVsZW1lbnQsIHRvcENo aWxkT3JTdWJzZWxlY3RvciwgdG9wQ2hpbGRPclN1YnNlbGVjdG9yTWF0Y2hFbGVtZW50LCBjaGVj a1NlbGVjdG9ySWRWYWx1ZSkpCisgICAgICAgICAgICBpZiAoIWZhc3RDaGVja1NpbmdsZVNlbGVj dG9yPElkQ2hlY2s+KHNlbGVjdG9yLCBlbGVtZW50LCB0b3BDaGlsZE9yU3Vic2VsZWN0b3IsIHRv cENoaWxkT3JTdWJzZWxlY3Rvck1hdGNoRWxlbWVudCkpCiAgICAgICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgQ1NTU2VsZWN0b3I6Ok5v bmU6Ci0gICAgICAgICAgICBpZiAoIWZhc3RDaGVja1NpbmdsZVNlbGVjdG9yKHNlbGVjdG9yLCBl bGVtZW50LCB0b3BDaGlsZE9yU3Vic2VsZWN0b3IsIHRvcENoaWxkT3JTdWJzZWxlY3Rvck1hdGNo RWxlbWVudCwgY2hlY2tTZWxlY3RvclRhZ1ZhbHVlKSkKKyAgICAgICAgICAgIGlmICghZmFzdENo ZWNrU2luZ2xlU2VsZWN0b3I8VGFnQ2hlY2s+KHNlbGVjdG9yLCBlbGVtZW50LCB0b3BDaGlsZE9y U3Vic2VsZWN0b3IsIHRvcENoaWxkT3JTdWJzZWxlY3Rvck1hdGNoRWxlbWVudCkpCiAgICAgICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGRlZmF1 bHQ6Cg==