54727 2011-02-17 23:38:53 -0800 elements remain focusable after tabindex is removed 2011-02-21 17:27:29 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan webkit-unassigned arv commit-queue tkent oldest_to_newest 353447 0 82928 ojan 2011-02-17 23:38:53 -0800 Created attachment 82928 test case An element with tabindex is focusable. But if tabindex is removed it should return to not being focusable. I've confirmed gecko removes focusability. See the test case. 353448 1 ojan 2011-02-17 23:39:19 -0800 FWIW, this is causing some annoying UI issues for the code review tool. 354373 2 83117 koz 2011-02-20 19:16:19 -0800 Created attachment 83117 Patch 354404 3 83117 tkent 2011-02-20 21:18:47 -0800 Comment on attachment 83117 Patch Looks good. 354776 4 83117 webkit.review.bot 2011-02-21 13:29:54 -0800 Comment on attachment 83117 Patch Rejecting attachment 83117 from commit-queue. koz@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 354926 5 83117 commit-queue 2011-02-21 17:27:24 -0800 Comment on attachment 83117 Patch Clearing flags on attachment: 83117 Committed r79269: <http://trac.webkit.org/changeset/79269> 354927 6 commit-queue 2011-02-21 17:27:29 -0800 All reviewed patches have been landed. Closing bug. 82928 2011-02-17 23:38:53 -0800 2011-02-17 23:38:53 -0800 test case repro.html text/html 165 ojan PGRpdiBpZD1mb28gdGFiaW5kZXg9LTE+U2hvdWxkIG5vdCBiZSBmb2N1c2FibGUuPC9kaXY+Cgo8 c2NyaXB0PgoJdmFyIGZvbyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdmb28nKTsKCWZvby5y ZW1vdmVBdHRyaWJ1dGUoJ3RhYmluZGV4Jyk7Cglmb28uZm9jdXMoKTsKPC9zY3JpcHQ+ 83117 2011-02-20 19:16:19 -0800 2011-02-21 17:27:24 -0800 Patch bug-54727-20110221141617.patch text/plain 5200 koz U3VidmVyc2lvbiBSZXZpc2lvbjogNzkxMTEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5OTFlMjcxN2JlMDM1OWRiYTE0ZDJi ZGM1ZWRlYjBmNzBmNjZlMDc2Li4wYTgzNDQyZGY1MGE5MGVlMjczOTI5ZmQ5MzA0ZDQ3ODY1MWJl ZDc3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMjAgIEphbWVzIEtvemlhbnNraSAg PGtvekBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2F1c2VzIGVsZW1lbnRzIHRvIGJlIHVuZm9jdXNhYmxlIGFmdGVyIHRhYmlu ZGV4IHByb3BlcnR5IGlzIHJlbW92ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD01NDcyNworCisgICAgICAgICogZmFzdC9odG1sL3RhYmluZGV4LXJl bW92YWwtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2h0bWwvdGFiaW5kZXgt cmVtb3ZhbC5odG1sOiBBZGRlZC4KKwogMjAxMS0wMi0xOSAgQW5kcmV3IFdpbHNvbiAgPGF0d2ls c29uQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVcGRhdGVkIHRlc3QgZXhwZWN0YXRpb25zICht b3JlIGZhbGxvdXQgZnJvbSByNzg4NDYpLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9o dG1sL3RhYmluZGV4LXJlbW92YWwtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9odG1s L3RhYmluZGV4LXJlbW92YWwtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjdlZjIyZTlhNDMxYWQw MjcyNzEzYjcxZmRjODc5NDAxNmM4ZWYxMmYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2h0bWwvdGFiaW5kZXgtcmVtb3ZhbC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAor UEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9odG1sL3RhYmluZGV4LXJlbW92YWwu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvaHRtbC90YWJpbmRleC1yZW1vdmFsLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uZjY0YTU0M2I2MzA3ZDY3NmYxN2IwNTVkZDA3ZGM1NzM2MWI1Yzg1OQotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaHRtbC90YWJpbmRleC1yZW1vdmFsLmh0bWwKQEAg LTAsMCArMSwxMyBAQAorPGRpdiBpZD0iYSIgdGFiaW5kZXg9IjEiPlBBU1M8L2Rpdj4KKworPHNj cmlwdD4KKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgIGxh eW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICB9CisgICAgdmFyIGEgPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgnYScpOworICAgIGEucmVtb3ZlQXR0cmlidXRlKCd0YWJpbmRl eCcpOworICAgIGEuYWRkRXZlbnRMaXN0ZW5lcignZm9jdXMnLCBmdW5jdGlvbiAoZSkgeworICAg ICAgICBhLmlubmVyVGV4dCA9ICdGQUlMJzsKKyAgICB9LCBmYWxzZSk7CisgICAgYS5mb2N1cygp OworPC9zY3JpcHQ+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjVmYjlkOWVjMzIyYmI4NTFmMjA0OTVjOTk0N2Rk Nzg4OWM1YTFlNi4uMWJlNmY1ZmE4ZmNlMmJkMmQwOTIzYTI1N2Y4Mjg0NzQzZGZiYTg3MiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDExLTAyLTIwICBKYW1lcyBLb3ppYW5za2kgIDxr b3pAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIENhdXNlcyBlbGVtZW50cyB0byBiZSB1bmZvY3VzYWJsZSBhZnRlciB0YWJpbmRl eCBwcm9wZXJ0eSBpcyByZW1vdmVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTQ3MjcKKworICAgICAgICBUZXN0OiBmYXN0L2h0bWwvdGFiaW5kZXgt cmVtb3ZhbC5odG1sCisKKyAgICAgICAgKiBkb20vTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpOb2RlOjpjbGVhclRhYkluZGV4RXhwbGljaXRseSk6CisgICAgICAgICogZG9tL05vZGUuaDoK KyAgICAgICAgKiBkb20vTm9kZVJhcmVEYXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpOb2RlUmFy ZURhdGE6OmNsZWFyVGFiSW5kZXhFeHBsaWNpdGx5KToKKyAgICAgICAgKiBodG1sL0hUTUxFbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxFbGVtZW50OjpwYXJzZU1hcHBlZEF0dHJp YnV0ZSk6CisKIDIwMTEtMDItMTkgIEJpbGwgQnVkZ2UgIDxiYnVkZ2VAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZG9tL05vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCmluZGV4IGIw MjlhNzVkZWExNTU0YzFjYjA3NTBmNjYzMjI5MmNkZDBhNDNhNWMuLjBjMDExN2M2NGZiYmU5NjZl YmRhYWJkMWIxNmRhZGMwNzQwZGE2M2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9O b2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKQEAgLTUxMSw2ICs1MTEs MTEgQEAgdm9pZCBOb2RlOjpzZXRUYWJJbmRleEV4cGxpY2l0bHkoc2hvcnQgaSkKICAgICBlbnN1 cmVSYXJlRGF0YSgpLT5zZXRUYWJJbmRleEV4cGxpY2l0bHkoaSk7CiB9CiAKK3ZvaWQgTm9kZTo6 Y2xlYXJUYWJJbmRleEV4cGxpY2l0bHkoKQoreworICAgIGVuc3VyZVJhcmVEYXRhKCktPmNsZWFy VGFiSW5kZXhFeHBsaWNpdGx5KCk7Cit9CisKIFN0cmluZyBOb2RlOjpub2RlVmFsdWUoKSBjb25z dAogewogICAgIHJldHVybiBTdHJpbmcoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9Ob2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5oCmluZGV4IDQ4NGYzNDU3N2RlNTVk MmNjMzA3Y2I0Yjk2Njk2OTM4NTYxYzg1NGUuLjM1Y2U3MThjMGZkNTg1YzU2ZjAxMzkzY2JlZWE3 ZGY1MzhjNmMyM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmgKKysrIGIv U291cmNlL1dlYkNvcmUvZG9tL05vZGUuaApAQCAtNjQwLDYgKzY0MCw3IEBAIHByb3RlY3RlZDoK ICAgICAKICAgICB2aXJ0dWFsIHZvaWQgYWRkU3VicmVzb3VyY2VBdHRyaWJ1dGVVUkxzKExpc3RI YXNoU2V0PEtVUkw+JikgY29uc3QgeyB9CiAgICAgdm9pZCBzZXRUYWJJbmRleEV4cGxpY2l0bHko c2hvcnQpOworICAgIHZvaWQgY2xlYXJUYWJJbmRleEV4cGxpY2l0bHkoKTsKICAgICAKICAgICBi b29sIGhhc1JhcmVEYXRhKCkgY29uc3QgeyByZXR1cm4gZ2V0RmxhZyhIYXNSYXJlRGF0YUZsYWcp OyB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlUmFyZURhdGEuaCBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9Ob2RlUmFyZURhdGEuaAppbmRleCA3MzUwZjgwMzkxMWMyY2E3MWZi ZTQ2ZWNjNmY0YmRkNGQ5ZmM5NjliLi5iYWRjNGUxNzdlNzJiNzRlNDVlZThlOTUwN2U1ZDQ1OGJi ZGY2NWFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZVJhcmVEYXRhLmgKKysr IGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGVSYXJlRGF0YS5oCkBAIC0xMDQsNiArMTA0LDcgQEAg cHVibGljOgogICAgIHNob3J0IHRhYkluZGV4KCkgY29uc3QgeyByZXR1cm4gbV90YWJJbmRleDsg fQogICAgIHZvaWQgc2V0VGFiSW5kZXhFeHBsaWNpdGx5KHNob3J0IGluZGV4KSB7IG1fdGFiSW5k ZXggPSBpbmRleDsgbV90YWJJbmRleFdhc1NldEV4cGxpY2l0bHkgPSB0cnVlOyB9CiAgICAgYm9v bCB0YWJJbmRleFNldEV4cGxpY2l0bHkoKSBjb25zdCB7IHJldHVybiBtX3RhYkluZGV4V2FzU2V0 RXhwbGljaXRseTsgfQorICAgIHZvaWQgY2xlYXJUYWJJbmRleEV4cGxpY2l0bHkoKSB7IG1fdGFi SW5kZXggPSAwOyBtX3RhYkluZGV4V2FzU2V0RXhwbGljaXRseSA9IGZhbHNlOyB9CiAKICAgICBF dmVudFRhcmdldERhdGEqIGV2ZW50VGFyZ2V0RGF0YSgpIHsgcmV0dXJuIG1fZXZlbnRUYXJnZXRE YXRhLmdldCgpOyB9CiAgICAgRXZlbnRUYXJnZXREYXRhKiBlbnN1cmVFdmVudFRhcmdldERhdGEo KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmNwcAppbmRleCBjODY4MzkyMGEzMGI4ZTg1YWFj ZjQwYzJjNzI3MjJkOTI5ZWQyNjU1Li44ODZmMDQwNGZhMTk2YjI4YzVhZGZkMzBkNTBmZWJhMWIx ZWQxZjE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50LmNwcApAQCAtMTQ4LDcgKzE0OCw5 IEBAIHZvaWQgSFRNTEVsZW1lbnQ6OnBhcnNlTWFwcGVkQXR0cmlidXRlKEF0dHJpYnV0ZSogYXR0 cikKICAgICB9IGVsc2UgaWYgKGF0dHItPm5hbWUoKSA9PSB0YWJpbmRleEF0dHIpIHsKICAgICAg ICAgaW5kZXhzdHJpbmcgPSBnZXRBdHRyaWJ1dGUodGFiaW5kZXhBdHRyKTsKICAgICAgICAgaW50 IHRhYmluZGV4ID0gMDsKLSAgICAgICAgaWYgKHBhcnNlSFRNTEludGVnZXIoaW5kZXhzdHJpbmcs IHRhYmluZGV4KSkgeworICAgICAgICBpZiAoIWluZGV4c3RyaW5nLmxlbmd0aCgpKSB7CisgICAg ICAgICAgICBjbGVhclRhYkluZGV4RXhwbGljaXRseSgpOworICAgICAgICB9IGVsc2UgaWYgKHBh cnNlSFRNTEludGVnZXIoaW5kZXhzdHJpbmcsIHRhYmluZGV4KSkgewogICAgICAgICAgICAgLy8g Q2xhbXAgdGFiaW5kZXggdG8gdGhlIHJhbmdlIG9mICdzaG9ydCcgdG8gbWF0Y2ggRmlyZWZveCdz IGJlaGF2aW9yLgogICAgICAgICAgICAgc2V0VGFiSW5kZXhFeHBsaWNpdGx5KG1heChzdGF0aWNf Y2FzdDxpbnQ+KHN0ZDo6bnVtZXJpY19saW1pdHM8c2hvcnQ+OjptaW4oKSksIG1pbih0YWJpbmRl eCwgc3RhdGljX2Nhc3Q8aW50PihzdGQ6Om51bWVyaWNfbGltaXRzPHNob3J0Pjo6bWF4KCkpKSkp OwogICAgICAgICB9Cg==