54726 2011-02-17 23:32:27 -0800 use actual browser focus in the code review tool 2011-02-20 18:29:32 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth oldest_to_newest 353444 0 ojan 2011-02-17 23:32:27 -0800 use actual browser focus in the code review tool 353445 1 82927 ojan 2011-02-17 23:34:20 -0800 Created attachment 82927 Patch 353709 2 82927 abarth 2011-02-18 11:37:54 -0800 Comment on attachment 82927 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82927&action=review > Websites/bugs.webkit.org/code-review.js:1342 > + // Give a tabindex so the element can receive actual browser focus. > + // -1 makes the element focusable without actually putting in in the tab order. > + node.attr('tabindex', -1); Crazy! 354357 3 ojan 2011-02-20 18:29:32 -0800 Committed r79163: <http://trac.webkit.org/changeset/79163> 82927 2011-02-17 23:34:20 -0800 2011-02-18 11:37:54 -0800 Patch bug-54726-20110218183417.patch text/plain 3515 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogNzg5NTMKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Vi a2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmlu ZGV4IGM4Zjg5MjkxYzk4NDc2YjY2YWQzYTZjZjQyNmJjZDAxYTBlNzlkZGMuLjY3ZWE3NTRiZWY5 MWJmMGEwNzIzOWNkMDg1MjA1MmRmNWZhNjA5NzYgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mu d2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5n ZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDExLTAyLTE3ICBPamFuIFZhZmFpICA8b2phbkBjaHJv bWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgdXNlIGFjdHVhbCBicm93c2VyIGZvY3VzIGluIHRoZSBjb2RlIHJldmlldyB0b29sCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDcyNgorCisgICAg ICAgIFRoaXMgbWFrZXMga2V5Ym9hcmQgaGFuZGxpbmcgcGxheSBiZXR0ZXIgd2l0aCBmb2N1c2Fi bGUgZWxlbWVudAorICAgICAgICAoaS5lLiBsaW5rcy90ZXh0YXJlYXMvYnV0dG9ucykuIEFsc28s IGluIHRoZW9yeSwgdGhpcyBtYWtlcworICAgICAgICB0aGUgcmV2aWV3IHRvb2wgbW9yZSBhbWVu YWJsZSB0byBzY3JlZW4gcmVhZGVycyAoSSB0aGluaykuCisKKyAgICAgICAgKiBQcmV0dHlQYXRj aC9QcmV0dHlQYXRjaC5yYjoKKyAgICAgICAgKiBjb2RlLXJldmlldy5qczoKKworMjAxMS0wMi0x NyAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5 IEFudG9uaW8gR29tZXMuCiAKICAgICAgICAgbWFrZSBldmVudCBoYW5kbGluZyB3b3JrIGluIEdl Y2tvCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvUHJldHR5UGF0Y2gvUHJl dHR5UGF0Y2gucmIgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvUHJldHR5UGF0Y2gvUHJldHR5 UGF0Y2gucmIKaW5kZXggYzMzMDU0ZTcwMDc2ODlhNjg4MWI2ZWMyYTc4MWU3MTA5ZWE0NTUyOS4u MTcxODI2OGIxMmE0YzljMjU1MTE3N2Y5MWU1YTlmOGFhZDdmODRjMyAxMDA2NDQKLS0tIGEvV2Vi c2l0ZXMvYnVncy53ZWJraXQub3JnL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCisrKyBiL1dl YnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9QcmV0dHlQYXRjaC9QcmV0dHlQYXRjaC5yYgpAQCAtMzk5 LDcgKzM5OSw3IEBAIGJvZHkgewogICB3aWR0aDogNmVtOwogfQogCi0uZm9jdXNlZCB7CitkaXY6 Zm9jdXMgewogICBvdXRsaW5lOiAxcHggc29saWQgYmx1ZTsKICAgb3V0bGluZS1vZmZzZXQ6IC0x cHg7CiB9CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcu anMgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKaW5kZXggOTM4NjQ5 M2EwYzVjODQzMGQ4YjYxMGMxNTJmMWY5Mzg2NDRiZjAyNi4uYjkyMDAwYmMxYjQ3YWYwMzRhMDNk NmQ3NWViOGY4OTIzY2FlMjhjZCAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3Jn L2NvZGUtcmV2aWV3LmpzCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJldmll dy5qcwpAQCAtMTA3NCw5ICsxMDc0LDYgQEAgdmFyIENPREVfUkVWSUVXX1VOSVRURVNUOwogCiAg ICAgdXBkYXRlVG9vbGJhckFuY2hvclN0YXRlKCk7CiAgICAgbG9hZERpZmZTdGF0ZSgpOwotCi0g ICAgLy8gRW5zdXJlIHRoZSBib2R5IGhhcyBmb2N1cyBzbyB0aGF0IGl0IHJlY2VpdmVzIGtleSBl dmVudHMuCi0gICAgZG9jdW1lbnQuYm9keS5mb2N1cygpOwogICB9KTsKIAogICBmdW5jdGlvbiBo YW5kbGVSZXZpZXdGb3JtTG9hZCgpIHsKQEAgLTEzMzcsMjAgKzEzMzQsMjMgQEAgdmFyIENPREVf UkVWSUVXX1VOSVRURVNUOwogICB9CiAKICAgZnVuY3Rpb24gZm9jdXNPbihub2RlKSB7Ci0gICAg Ly8gRklYTUU6IFdlIHNob3VsZCBwcm9iYWJseSBnaXZlIHByb3BlcnkgYnJvd3NlciBmb2N1cyBo ZXJlLgotICAgICQoJy5mb2N1c2VkJykucmVtb3ZlQ2xhc3MoJ2ZvY3VzZWQnKTsKICAgICBpZiAo bm9kZS5sZW5ndGggPT0gMCkKICAgICAgIHJldHVybjsKLSAgICAkKGRvY3VtZW50KS5zY3JvbGxU b3Aobm9kZS5hZGRDbGFzcygnZm9jdXNlZCcpLnBvc2l0aW9uKCkudG9wIC0gd2luZG93LmlubmVy SGVpZ2h0IC8gMik7CisKKyAgICAvLyBHaXZlIGEgdGFiaW5kZXggc28gdGhlIGVsZW1lbnQgY2Fu IHJlY2VpdmUgYWN0dWFsIGJyb3dzZXIgZm9jdXMuCisgICAgLy8gLTEgbWFrZXMgdGhlIGVsZW1l bnQgZm9jdXNhYmxlIHdpdGhvdXQgYWN0dWFsbHkgcHV0dGluZyBpbiBpbiB0aGUgdGFiIG9yZGVy LgorICAgIG5vZGUuYXR0cigndGFiaW5kZXgnLCAtMSk7CisgICAgbm9kZS5mb2N1cygpOworICAg ICQoZG9jdW1lbnQpLnNjcm9sbFRvcChub2RlLnBvc2l0aW9uKCkudG9wIC0gd2luZG93LmlubmVy SGVpZ2h0IC8gMik7CiAgIH0KIAogICBmdW5jdGlvbiBmb2N1c05leHQoZmlsdGVyLCBkaXJlY3Rp b24pIHsKLSAgICB2YXIgZm9jdXNhYmxlX25vZGVzID0gJCgnLmZyb3plbkNvbW1lbnQsLnByZXZp b3VzQ29tbWVudCwuRGlmZkJsb2NrLC5vdmVyYWxsQ29tbWVudHMnKS5maWx0ZXIoZnVuY3Rpb24o KSB7CisgICAgdmFyIGZvY3VzYWJsZV9ub2RlcyA9ICQoJ2EsLmZyb3plbkNvbW1lbnQsLnByZXZp b3VzQ29tbWVudCwuRGlmZkJsb2NrLC5vdmVyYWxsQ29tbWVudHMnKS5maWx0ZXIoZnVuY3Rpb24o KSB7CiAgICAgICByZXR1cm4gISQodGhpcykuaGFzQ2xhc3MoJ0RpZmZCbG9jaycpIHx8ICQoJy5h ZGQsLnJlbW92ZScsIHRoaXMpLnNpemUoKTsKICAgICB9KTsKIAogICAgIHZhciBpc19iYWNrd2Fy ZCA9IGRpcmVjdGlvbiA9PSBESVJFQ1RJT04uQkFDS1dBUkQ7Ci0gICAgdmFyIGluZGV4ID0gZm9j dXNhYmxlX25vZGVzLmluZGV4KCQoJy5mb2N1c2VkJykpOworICAgIHZhciBpbmRleCA9IGZvY3Vz YWJsZV9ub2Rlcy5pbmRleCgkKGRvY3VtZW50LmFjdGl2ZUVsZW1lbnQpKTsKICAgICBpZiAoaW5k ZXggPT0gLTEgJiYgaXNfYmFja3dhcmQpCiAgICAgICBpbmRleCA9IGZvY3VzYWJsZV9ub2Rlcy5s ZW5ndGg7CiAKQEAgLTE0MzIsOSArMTQzMiwxMCBAQCB2YXIgQ09ERV9SRVZJRVdfVU5JVFRFU1Q7 CiAgIH0KICAgCiAgIGZ1bmN0aW9uIGhhbmRsZUVudGVyS2V5UHJlc3MoKSB7Ci0gICAgdmFyIGZv Y3VzZWQgPSAkKCcuZm9jdXNlZCcpOwotICAgIGlmICghZm9jdXNlZC5zaXplKCkpCi0gICAgICBy ZXR1cm4gZmFsc2U7CisgICAgaWYgKGRvY3VtZW50LmFjdGl2ZUVsZW1lbnQubm9kZU5hbWUgPT0g J0JPRFknKQorICAgICAgcmV0dXJuOworCisgICAgdmFyIGZvY3VzZWQgPSAkKGRvY3VtZW50LmFj dGl2ZUVsZW1lbnQpOwogCiAgICAgaWYgKGZvY3VzZWQuaGFzQ2xhc3MoJ2Zyb3plbkNvbW1lbnQn KSkgewogICAgICAgdW5mcmVlemVDb21tZW50KGZvY3VzZWQpOwo=