54719 2011-02-17 21:45:55 -0800 create comments when hitting enter with a focused diff 2011-02-20 18:36:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth oldest_to_newest 353409 0 ojan 2011-02-17 21:45:55 -0800 create comments when hitting enter with a focused diff 353410 1 82918 ojan 2011-02-17 21:47:09 -0800 Created attachment 82918 Patch 354360 2 ojan 2011-02-20 18:36:51 -0800 Committed r79164: <http://trac.webkit.org/changeset/79164> 82918 2011-02-17 21:47:09 -0800 2011-02-18 11:34:56 -0800 Patch bug-54719-20110218164707.patch text/plain 3154 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogNzg5NTMKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Vi a2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmlu ZGV4IGM4Zjg5MjkxYzk4NDc2YjY2YWQzYTZjZjQyNmJjZDAxYTBlNzlkZGMuLmViYzUyNzU4MTU1 OTE0MWQwM2ZhM2YyZGMwNmJmZmExZTI3MjkxNDggMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mu d2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5n ZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDExLTAyLTE3ICBPamFuIFZhZmFpICA8b2phbkBjaHJv bWl1bS5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgY3JlYXRlIGNvbW1lbnRzIHdoZW4gaGl0dGluZyBlbnRlciB3aXRoIGEgZm9jdXNlZCBkaWZm CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDcxOQor CisgICAgICAgICogY29kZS1yZXZpZXcuanM6CisKKzIwMTEtMDItMTcgIE9qYW4gVmFmYWkgIDxv amFuQGNocm9taXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgog CiAgICAgICAgIG1ha2UgZXZlbnQgaGFuZGxpbmcgd29yayBpbiBHZWNrbwpkaWZmIC0tZ2l0IGEv V2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzIGIvV2Vic2l0ZXMvYnVncy53 ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzCmluZGV4IDkzODY0OTNhMGM1Yzg0MzBkOGI2MTBjMTUy ZjFmOTM4NjQ0YmYwMjYuLjAzY2U4YjI5Yjc5NDZkNzk5NmE2YTc2ZGVmOGM5NDFlNWQ1YzkwODEg MTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJldmlldy5qcworKysg Yi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKQEAgLTMzMSwxMiArMzMx LDE2IEBAIHZhciBDT0RFX1JFVklFV19VTklUVEVTVDsKICAgICBlbHNlCiAgICAgICBjb250YWlu ZXIucmVtb3ZlQ2xhc3MoJ3NhdmluZycpOwogICB9Ci0KLSAgZnVuY3Rpb24gY3JlYXRlQ29tbWVu dEZvcihsaW5lKSB7Ci0gICAgaWYgKGxpbmUuYXR0cignZGF0YS1oYXMtY29tbWVudCcpKSB7Cisg IAorICBmdW5jdGlvbiB1bmZyZWV6ZUNvbW1lbnRGb3IobGluZSkgewogICAgICAgLy8gRklYTUU6 IFRoaXMgcXVlcnkgaXMgb3Zlcmx5IGNvbXBsZXggYmVjYXVzZSB3ZSBwbGFjZSBjb21tZW50IGJs b2NrcwogICAgICAgLy8gYWZ0ZXIgTGluZXMuICBJbnN0ZWFkLCBjb21tZW50IGJsb2NrcyBzaG91 bGQgYmUgY2hpbGRyZW4gb2YgTGluZXMuCiAgICAgICBmaW5kQ29tbWVudFBvc2l0aW9uRm9yKGxp bmUpLm5leHQoKS5uZXh0KCkuZmlsdGVyKCcuZnJvemVuQ29tbWVudCcpLmVhY2goaGFuZGxlVW5m cmVlemVDb21tZW50KTsKKyAgfQorCisgIGZ1bmN0aW9uIGNyZWF0ZUNvbW1lbnRGb3IobGluZSkg eworICAgIGlmIChsaW5lLmF0dHIoJ2RhdGEtaGFzLWNvbW1lbnQnKSkgeworICAgICAgdW5mcmVl emVDb21tZW50Rm9yKGxpbmUpOwogICAgICAgcmV0dXJuOwogICAgIH0KICAgICBsaW5lLmF0dHIo J2RhdGEtaGFzLWNvbW1lbnQnLCAndHJ1ZScpOwpAQCAtMTQ1Miw3ICsxNDU2LDE1IEBAIHZhciBD T0RFX1JFVklFV19VTklUVEVTVDsKICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KIAotICAgIHJl dHVybiBmYWxzZTsKKyAgICB2YXIgbGluZXMgPSAkKCcuTGluZScsIGZvY3VzZWQpOworICAgIHZh ciBsYXN0ID0gbGluZXMubGFzdCgpOworICAgIGlmIChsYXN0LmF0dHIoJ2RhdGEtaGFzLWNvbW1l bnQnKSkgeworICAgICAgdW5mcmVlemVDb21tZW50Rm9yKGxhc3QpOworICAgICAgcmV0dXJuIHRy dWU7CisgICAgfQorCisgICAgYWRkQ29tbWVudEZvckxpbmVzKGxpbmVzKTsKKyAgICByZXR1cm4g dHJ1ZTsKICAgfQogCiAgIGZ1bmN0aW9uIGNvbnRleHRMaW5lc0Zvcihjb21tZW50X2Jhc2VfbGlu ZXMsIGZpbGVfZGlmZikgewpAQCAtMTU5MSwyNCArMTYwMywyNiBAQCB2YXIgQ09ERV9SRVZJRVdf VU5JVFRFU1Q7CiAKICAgZnVuY3Rpb24gcHJvY2Vzc1NlbGVjdGVkTGluZXMoKSB7CiAgICAgZHJh Z19zZWxlY3Rfc3RhcnRfaW5kZXggPSAtMTsKLQotICAgIHZhciBzZWxlY3RlZCA9ICQoJy5zZWxl Y3RlZCcpOwotICAgIGlmICghc2VsZWN0ZWQuc2l6ZSgpKQorICAgIGFkZENvbW1lbnRGb3JMaW5l cygkKCcuc2VsZWN0ZWQnKSk7CisgIH0KKyAgCisgIGZ1bmN0aW9uIGFkZENvbW1lbnRGb3JMaW5l cyhsaW5lcykgeyAgICAKKyAgICBpZiAoIWxpbmVzLnNpemUoKSkKICAgICAgIHJldHVybjsKLSAg ICAKLSAgICB2YXIgYWxyZWFkeV9oYXNfY29tbWVudCA9IHNlbGVjdGVkLmxhc3QoKS5oYXNDbGFz cygnY29tbWVudENvbnRleHQnKTsKLSAgICBzZWxlY3RlZC5hZGRDbGFzcygnY29tbWVudENvbnRl eHQnKTsKKworICAgIHZhciBhbHJlYWR5X2hhc19jb21tZW50ID0gbGluZXMubGFzdCgpLmhhc0Ns YXNzKCdjb21tZW50Q29udGV4dCcpOworICAgIGxpbmVzLmFkZENsYXNzKCdjb21tZW50Q29udGV4 dCcpOwogCiAgICAgdmFyIGNvbW1lbnRfYmFzZV9saW5lOwogICAgIGlmIChhbHJlYWR5X2hhc19j b21tZW50KQotICAgICAgY29tbWVudF9iYXNlX2xpbmUgPSBzZWxlY3RlZC5sYXN0KCkuYXR0cign ZGF0YS1jb21tZW50LWJhc2UtbGluZScpOworICAgICAgY29tbWVudF9iYXNlX2xpbmUgPSBsaW5l cy5sYXN0KCkuYXR0cignZGF0YS1jb21tZW50LWJhc2UtbGluZScpOwogICAgIGVsc2UgewotICAg ICAgdmFyIGxhc3QgPSBsaW5lRnJvbUxpbmVEZXNjZW5kYW50KHNlbGVjdGVkLmxhc3QoKSk7Cisg ICAgICB2YXIgbGFzdCA9IGxpbmVGcm9tTGluZURlc2NlbmRhbnQobGluZXMubGFzdCgpKTsKICAg ICAgIGFkZENvbW1lbnRGb3IoJChsYXN0KSk7CiAgICAgICBjb21tZW50X2Jhc2VfbGluZSA9IGxh c3QuYXR0cignaWQnKTsKICAgICB9CiAKLSAgICBzZWxlY3RlZC5lYWNoKGZ1bmN0aW9uKCkgewor ICAgIGxpbmVzLmVhY2goZnVuY3Rpb24oKSB7CiAgICAgICBhZGREYXRhQ29tbWVudEJhc2VMaW5l KHRoaXMsIGNvbW1lbnRfYmFzZV9saW5lKTsKICAgICAgICQodGhpcykucmVtb3ZlQ2xhc3MoJ3Nl bGVjdGVkJyk7CiAgICAgfSk7Cg==