54717 2011-02-17 21:36:42 -0800 Fixed some math errors when when using variable-sized cells 2011-02-17 21:49:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ggaren ggaren oldest_to_newest 353402 0 ggaren 2011-02-17 21:36:42 -0800 Fixed some math errors when when using variable-sized cells 353403 1 82916 ggaren 2011-02-17 21:40:27 -0800 Created attachment 82916 Patch 353406 2 82916 sam 2011-02-17 21:42:48 -0800 Comment on attachment 82916 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82916&action=review > Source/JavaScriptCore/ChangeLog:262 > + Weird new line. 353411 3 ggaren 2011-02-17 21:49:47 -0800 Committed r78957: <http://trac.webkit.org/changeset/78957> 82916 2011-02-17 21:40:27 -0800 2011-02-17 21:42:48 -0800 Patch bug-54717-20110217214026.patch text/plain 4618 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzg5NTUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAK KzIwMTEtMDItMTcgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCBzb21lIG1hdGgg ZXJyb3JzIHdoZW4gd2hlbiB1c2luZyB2YXJpYWJsZS1zaXplZCBjZWxscworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ3MTcKKyAgICAgICAgCisgICAg ICAgIFN1blNwaWRlciByZXBvcnRzIG5vIGNoYW5nZS4KKworICAgICAgICAqIHJ1bnRpbWUvSlND ZWxsLmg6CisgICAgICAgIChKU0M6OkpTQ2VsbDo6TWFya2VkQmxvY2s6OmFsbG9jYXRlKTogUm91 bmQgdXAgd2hlbiBjYWxjdWxhdGluZyB0aGUKKyAgICAgICAgbWluaW11bSBudW1iZXIgb2YgYXRv bXMgcmVxdWlyZWQgZm9yIGEgY2VsbCwgc2luY2Ugcm91bmRpbmcgZG93bgorICAgICAgICB3aWxs IGdldCB5b3Ugc3BsaW5jaGVkLgorCisgICAgICAgICogcnVudGltZS9NYXJrZWRCbG9jay5jcHA6 CisgICAgICAgIChKU0M6Ok1hcmtlZEJsb2NrOjpNYXJrZWRCbG9jayk6CisgICAgICAgIChKU0M6 Ok1hcmtlZEJsb2NrOjpzd2VlcCk6CisgICAgICAgICogcnVudGltZS9NYXJrZWRCbG9jay5oOgor ICAgICAgICAoSlNDOjpNYXJrZWRCbG9jazo6Zm9yRWFjaCk6IENoYW5nZWQgYSBidW5jaCBvZiAh PSB0ZXN0cyB0byA8IHRlc3RzCisgICAgICAgIGJlY2F1c2UgbV9lbmRBdG9tIGlzIGFjdHVhbGx5 IGEgZnV6enkgZW5kIC0tIGl0ZXJhdGluZyBmcm9tIGZpcnN0QXRvbSgpCisgICAgICAgIG1heSBu b3QgaGl0IG1fZW5kQXRvbSBleGFjdGx5LgorCiAyMDExLTAyLTE3ICBHZW9mZnJleSBHYXJlbiAg PGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KQEAg LTIzNywzICsyNTksNCBAQAogICAgICAgICBnbG9iYWwgb2JqZWN0J3MgcmVnaXN0ZXIgc3RvcmFn ZSwgYW5kIGluaXRpYWxpemluZyBuZXcgcmVnaXN0ZXJzLgogCiA9PSBSb2xsZWQgb3ZlciB0byBD aGFuZ2VMb2ctMjAxMS0wMi0xNiA9PQorCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU0NlbGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU0NlbGwuaAkocmV2aXNpb24gNzg5NTUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU0NlbGwuaAkod29ya2luZyBjb3B5KQpAQCAtNDA0LDggKzQwNCw3IEBAIG5hbWVzcGFj ZSBKU0MgewogCiAgICAgaW5saW5lIHZvaWQqIE1hcmtlZEJsb2NrOjphbGxvY2F0ZShzaXplX3Qm IG5leHRBdG9tKQogICAgIHsKLSAgICAgICAgd2hpbGUgKG5leHRBdG9tICE9IG1fZW5kQXRvbSkg ewotICAgICAgICAgICAgQVNTRVJUKG5leHRBdG9tIDwgbV9lbmRBdG9tKTsKKyAgICAgICAgd2hp bGUgKG5leHRBdG9tIDwgbV9lbmRBdG9tKSB7CiAgICAgICAgICAgICBpZiAoIW1fbWFya3MudGVz dEFuZFNldChuZXh0QXRvbSkpIHsKICAgICAgICAgICAgICAgICBKU0NlbGwqIGNlbGwgPSByZWlu dGVycHJldF9jYXN0PEpTQ2VsbCo+KCZhdG9tcygpW25leHRBdG9tXSk7CiAgICAgICAgICAgICAg ICAgbmV4dEF0b20gKz0gbV9hdG9tc1BlckNlbGw7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9NYXJrZWRCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvTWFya2VkQmxvY2suY3BwCShyZXZpc2lvbiA3ODk1NSkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcmtlZEJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDYsMTQgKzQ2LDE0IEBAIHZvaWQgTWFya2VkQmxvY2s6OmRlc3Ryb3koTWFya2VkQmxvY2sq IGIKIH0KIAogTWFya2VkQmxvY2s6Ok1hcmtlZEJsb2NrKGNvbnN0IFBhZ2VBbGxvY2F0aW9uQWxp Z25lZCYgYWxsb2NhdGlvbiwgSlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRhLCBzaXplX3QgY2VsbFNp emUpCi0gICAgOiBtX2F0b21zUGVyQ2VsbChjZWxsU2l6ZSAvIGF0b21TaXplKQotICAgICwgbV9l bmRBdG9tKChhbGxvY2F0aW9uLnNpemUoKSAtIHNpemVvZihNYXJrZWRCbG9jaykpIC8gY2VsbFNp emUpIC8vIEludGVudGlvbmFsbHkgcm91bmRzIGRvd24uCisgICAgOiBtX2F0b21zUGVyQ2VsbCgo Y2VsbFNpemUgKyBhdG9tU2l6ZSAtIDEpIC8gYXRvbVNpemUpCisgICAgLCBtX2VuZEF0b20oYXRv bXNQZXJCbG9jayAtIG1fYXRvbXNQZXJDZWxsICsgMSkKICAgICAsIG1fYWxsb2NhdGlvbihhbGxv Y2F0aW9uKQogICAgICwgbV9oZWFwKCZnbG9iYWxEYXRhLT5oZWFwKQogewogICAgIEFTU0VSVChj ZWxsU2l6ZSA8PSBhdG9tU2l6ZSk7CiAgICAgU3RydWN0dXJlKiBkdW1teU1hcmthYmxlQ2VsbFN0 cnVjdHVyZSA9IGdsb2JhbERhdGEtPmR1bW15TWFya2FibGVDZWxsU3RydWN0dXJlLmdldCgpOwot ICAgIGZvciAoc2l6ZV90IGkgPSBmaXJzdEF0b20oKTsgaSAhPSBtX2VuZEF0b207IGkgKz0gbV9h dG9tc1BlckNlbGwpCisgICAgZm9yIChzaXplX3QgaSA9IGZpcnN0QXRvbSgpOyBpIDwgbV9lbmRB dG9tOyBpICs9IG1fYXRvbXNQZXJDZWxsKQogICAgICAgICBuZXcgKCZhdG9tcygpW2ldKSBKU0Nl bGwoZHVtbXlNYXJrYWJsZUNlbGxTdHJ1Y3R1cmUpOwogfQogCkBAIC02Myw3ICs2Myw3IEBAIHZv aWQgTWFya2VkQmxvY2s6OnN3ZWVwKCkKICAgICBTdHJ1Y3R1cmUqIGR1bW15TWFya2FibGVDZWxs U3RydWN0dXJlID0gbV9oZWFwLT5nbG9iYWxEYXRhKCktPmR1bW15TWFya2FibGVDZWxsU3RydWN0 dXJlLmdldCgpOwogI2VuZGlmCiAKLSAgICBmb3IgKHNpemVfdCBpID0gZmlyc3RBdG9tKCk7IGkg IT0gbV9lbmRBdG9tOyBpICs9IG1fYXRvbXNQZXJDZWxsKSB7CisgICAgZm9yIChzaXplX3QgaSA9 IGZpcnN0QXRvbSgpOyBpIDwgbV9lbmRBdG9tOyBpICs9IG1fYXRvbXNQZXJDZWxsKSB7CiAgICAg ICAgIGlmIChtX21hcmtzLmdldChpKSkKICAgICAgICAgICAgIGNvbnRpbnVlOwogCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrZWRCbG9jay5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcmtlZEJsb2NrLmgJKHJldmlzaW9uIDc4 OTU1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWFya2VkQmxvY2suaAkod29y a2luZyBjb3B5KQpAQCAtODUsNiArODUsOCBAQCBuYW1lc3BhY2UgSlNDIHsKIAogICAgICAgICBz dGF0aWMgY29uc3Qgc2l6ZV90IGF0b21TaXplID0gNjQ7CiAgICAgICAgIHN0YXRpYyBjb25zdCBz aXplX3QgYXRvbU1hc2sgPSB+KGF0b21TaXplIC0gMSk7IC8vIGF0b21TaXplIG11c3QgYmUgYSBw b3dlciBvZiB0d28uCisgICAgICAgIAorICAgICAgICBzdGF0aWMgY29uc3Qgc2l6ZV90IGF0b21z UGVyQmxvY2sgPSBibG9ja1NpemUgLyBhdG9tU2l6ZTsKIAogICAgICAgICB0eXBlZGVmIGNoYXIg QXRvbVthdG9tU2l6ZV07CiAKQEAgLTkyLDcgKzk0LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAg ICAgIEF0b20qIGF0b21zKCk7CiAKICAgICAgICAgc2l6ZV90IG1fYXRvbXNQZXJDZWxsOwotICAg ICAgICBzaXplX3QgbV9lbmRBdG9tOworICAgICAgICBzaXplX3QgbV9lbmRBdG9tOyAvLyBUaGlz IGlzIGEgZnV6enkgZW5kLiBBbHdheXMgdGVzdCBmb3IgPCBtX2VuZEF0b20uCiAgICAgICAgIFdU Rjo6Qml0bWFwPGJsb2NrU2l6ZSAvIGF0b21TaXplPiBtX21hcmtzOwogICAgICAgICBQYWdlQWxs b2NhdGlvbkFsaWduZWQgbV9hbGxvY2F0aW9uOwogICAgICAgICBIZWFwKiBtX2hlYXA7CkBAIC0x ODEsNyArMTgzLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAKICAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUg RnVuY3Rvcj4gaW5saW5lIHZvaWQgTWFya2VkQmxvY2s6OmZvckVhY2goRnVuY3RvciYgZnVuY3Rv cikKICAgICB7Ci0gICAgICAgIGZvciAoc2l6ZV90IGkgPSBmaXJzdEF0b20oKTsgaSAhPSBtX2Vu ZEF0b207IGkgKz0gbV9hdG9tc1BlckNlbGwpIHsKKyAgICAgICAgZm9yIChzaXplX3QgaSA9IGZp cnN0QXRvbSgpOyBpIDwgbV9lbmRBdG9tOyBpICs9IG1fYXRvbXNQZXJDZWxsKSB7CiAgICAgICAg ICAgICBpZiAoIW1fbWFya3MuZ2V0KGkpKQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAg ICAgICAgICAgZnVuY3RvcihyZWludGVycHJldF9jYXN0PEpTQ2VsbCo+KCZhdG9tcygpW2ldKSk7 Cg==