54703 2011-02-17 18:14:39 -0800 webkitpy.layout_tests.port.config_unittest fails on Win32 2011-02-18 15:39:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 48728 1 dpranke dpranke abarth aroben eric ojan oldest_to_newest 353299 0 dpranke 2011-02-17 18:14:39 -0800 webkitpy.layout_tests.port.config_unittest fails on Win32 because $HOME isn't defined. 353331 1 82900 dpranke 2011-02-17 19:16:52 -0800 Created attachment 82900 Patch 353339 2 82900 aroben 2011-02-17 19:28:52 -0800 Comment on attachment 82900 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82900&action=review > Tools/Scripts/webkitpy/layout_tests/port/config_unittest.py:195 > + if sys.platform == 'win32': > + os.chdir(os.environ['USERPROFILE']) > + else: > + os.chdir(os.environ['HOME']) I wonder if we should come up with our own abstraction for this? Maybe not if it's only needed by test code. 353349 3 dpranke 2011-02-17 19:44:51 -0800 (In reply to comment #2) > (From update of attachment 82900 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=82900&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/config_unittest.py:195 > > + if sys.platform == 'win32': > > + os.chdir(os.environ['USERPROFILE']) > > + else: > > + os.chdir(os.environ['HOME']) > > I wonder if we should come up with our own abstraction for this? Maybe not if it's only needed by test code. Yeah, I'd just as soon have it show up in at least two other places before we bother. Anyway, there's no significance to $HOME in this test, it's just known to be outside (or at least above) the tree. 353888 4 dpranke 2011-02-18 15:39:44 -0800 Committed r79042: <http://trac.webkit.org/changeset/79042> 82900 2011-02-17 19:16:52 -0800 2011-02-17 19:28:52 -0800 Patch bug-54703-20110217191651.patch text/plain 1567 dpranke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3MDEy NmIxMWIzMDRiZjNhNzU3NDkwMWVmMGRmNDk3NjU0ODE4MDUyLi44MGU0Mzg0MjI5YmQ1NjFmZWFk YThiZTc1MzUyMzNkNTViMTE2ZTM3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTYgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBGaXggd2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQu Y29uZmlnX3VuaXR0ZXN0IHRvIHdvcmsgb24gV2luMzIuCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0NzAzCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2NvbmZpZ191bml0dGVzdC5weToKKworMjAxMS0wMi0x NyAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBGaXggdmFyaW91cyBidWdzIHJlbGF0ZWQg dG8gaGFuZGxpbmcgb2YgZGlyIHNlcGFyYXRvcnMgYW5kIHJlYWwKICAgICAgICAgdnMuIGZha2Ug ZmlsZXN5c3RlbXMgdGhhdCB3ZXJlIGNhdXNpbmcgdGVzdC13ZWJraXRweSB0byBmYWlsCiAgICAg ICAgIHRlc3RzIG9uIHdpbjMyLiBUaGVzZSBidWdzIGhhdmUgYSB2YXJpZXR5IG9mIGNhdXNlcyBi dXQgYXJlCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L2NvbmZpZ191bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvY29uZmlnX3VuaXR0ZXN0LnB5CmluZGV4IDJjY2UzY2M0MDA1Njk4MGU5ZWIyYzM0 OWZhMTcwMGY2MThjZTk4NWEuLjhmMWUwZDQxNjZmYTUxMDFkYjVkZGJmNTBiODUwNzM1ZmU3Zjlm ODMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv Y29uZmlnX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvY29uZmlnX3VuaXR0ZXN0LnB5CkBAIC0xODksNyArMTg5LDEwIEBAIGNsYXNzIENv bmZpZ1Rlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBzZWxmLmFzc2VydE5vdEVxdWFs KGJhc2VfZGlyWy0xXSwgJy8nKQogCiAgICAgICAgIG9yaWdfY3dkID0gb3MuZ2V0Y3dkKCkKLSAg ICAgICAgb3MuY2hkaXIob3MuZW52aXJvblsnSE9NRSddKQorICAgICAgICBpZiBzeXMucGxhdGZv cm0gPT0gJ3dpbjMyJzoKKyAgICAgICAgICAgIG9zLmNoZGlyKG9zLmVudmlyb25bJ1VTRVJQUk9G SUxFJ10pCisgICAgICAgIGVsc2U6CisgICAgICAgICAgICBvcy5jaGRpcihvcy5lbnZpcm9uWydI T01FJ10pCiAgICAgICAgIGMgPSBjb25maWcuQ29uZmlnKGV4ZWN1dGl2ZS5FeGVjdXRpdmUoKSwg ZmlsZXN5c3RlbS5GaWxlU3lzdGVtKCkpCiAgICAgICAgIHRyeToKICAgICAgICAgICAgIGJhc2Vf ZGlyXzIgPSBjLndlYmtpdF9iYXNlX2RpcigpCg==