54698 2011-02-17 17:43:39 -0800 we should skip webkitpy.layout_tests.port.mac_unittest's test_skipped_file_path on win32, because it fails otherwise 2011-02-18 15:42:48 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth aroben eric ojan oldest_to_newest 353278 0 dpranke 2011-02-17 17:43:39 -0800 we should skip webkitpy.layout_tests.port.mac_unittest's test_skipped_file_path on win32, because it fails due to hardcoded '/' as dir separators and there's no point in rewriting the test just for win32. 353341 1 82904 dpranke 2011-02-17 19:32:11 -0800 Created attachment 82904 Patch 353344 2 82904 aroben 2011-02-17 19:36:37 -0800 Comment on attachment 82904 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82904&action=review > Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py:53 > + if sys.platform == 'win32': > + return None Maybe add a comment about why we're skipping this? 353894 3 dpranke 2011-02-18 15:42:48 -0800 Committed r79045: <http://trac.webkit.org/changeset/79045> 82904 2011-02-17 19:32:11 -0800 2011-02-17 19:36:37 -0800 Patch bug-54698-20110217193210.patch text/plain 1862 dpranke ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhN2Q2 MjAxMDFiMjlmMjBmMWFlZWU2YTQxZTE3MzhhYTMyNGYyZGI3Li43NGI5YTNlMWJiZjdlZjBhZTZm ZDA0Mjg0MTliZGQ2ZmM0ZDc4NjBjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTkgQEAKIAogICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBTa2lwIG1hYy50ZXN0X3NraXBwZWRfZmlsZV9wYXRo cygpIHdoZW4gcnVubmluZyBvbiB3aW4zMjsgdGhlCisgICAgICAgIHRlc3QgaGFzIGhhcmRjb2Rl ZCAnLycgZGlyZWN0b3J5IHNlcGFyYXRvcnMgYW5kIHNpbmNlIGl0J3MgYQorICAgICAgICBwb3J0 LXNwZWNpZmljIHRlc3QgYW5kIHdlIGhhdmUgY292ZXJhZ2Ugb24gb3RoZXIgcG9ydHMgaXQncyBu b3QKKyAgICAgICAgd29ydGggaXQgdG8gbWFrZSB0aGUgdGVzdCBtb3JlIGdlbmVyaWMuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0Njk4CisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L21hY191bml0dGVzdC5w eToKKworMjAxMS0wMi0xNyAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAgICAgICBGaXggdmVyc2lv biwgYmFzZWxpbmVfc2VhcmNoX3BhdGggZm9yIGNocm9taXVtLXdpbi13aW43LiBBbHNvCiAgICAg ICAgIGZpeCBjaHJvbWl1bV93aW5fdW5pdHRlc3RzLgogICAgICAgICBvciBjeWd3aW4sIHNvIHdl IHNraXAgaXQgZm9yIG5vdy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvbWFjX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9tYWNfdW5pdHRlc3QucHkKaW5kZXggZjY5ZWQ2ZWI0OTYwNWQ1NDkw NzNiMmM5YjdhOTRjYjJkNWM0YjY2ZC4uNjQzNTE1YjQzYjdkZDFhOTQ5NjJjZDY2NzAzNDdjYWRh YTM5ZWY4ZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9tYWNfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9tYWNfdW5pdHRlc3QucHkKQEAgLTI3LDYgKzI3LDcgQEAKICMgT0YgVEhJUyBT T0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFH RS4KIAogaW1wb3J0IFN0cmluZ0lPCitpbXBvcnQgc3lzCiBpbXBvcnQgdW5pdHRlc3QKIAogZnJv bSB3ZWJraXRweS5sYXlvdXRfdGVzdHMucG9ydCBpbXBvcnQgbWFjCkBAIC00OCw2ICs0OSw5IEBA IGNsYXNzIE1hY1Rlc3QocG9ydF90ZXN0Y2FzZS5Qb3J0VGVzdENhc2UpOgogICAgICAgICBzZWxm LmFzc2VydEVxdWFsKHJlbGF0aXZlX3BhdGhzLCBleHBlY3RlZF9wYXRocykKIAogICAgIGRlZiB0 ZXN0X3NraXBwZWRfZmlsZV9wYXRocyhzZWxmKToKKyAgICAgICAgaWYgc3lzLnBsYXRmb3JtID09 ICd3aW4zMic6CisgICAgICAgICAgICByZXR1cm4gTm9uZQorCiAgICAgICAgIHNlbGYuYXNzZXJ0 X3NraXBwZWRfZmlsZXNfZm9yX3ZlcnNpb24oJ21hYy1zbm93bGVvcGFyZCcsCiAgICAgICAgICAg ICBbJy9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtc25vd2xlb3BhcmQvU2tpcHBlZCcsICcvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQnXSkKICAgICAgICAgc2VsZi5hc3NlcnRfc2tp cHBlZF9maWxlc19mb3JfdmVyc2lvbignbWFjLWxlb3BhcmQnLAo=