54693 2011-02-17 15:42:45 -0800 [EFL] Fix coding style errors in RenderThemeEfl.h 2011-02-18 19:44:16 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 54392 1 gyuyoung.kim gyuyoung.kim antognolli+webkit commit-queue kenneth leandro lucas.de.marchi tonikitoo oldest_to_newest 353214 0 gyuyoung.kim 2011-02-17 15:42:45 -0800 When I run check-webkit-style script with RenderThemeEfl.h, there are many style erros like ewk_view.h. Source/WebCore/platform/efl/RenderThemeEfl.h:37: Ecore_Evas is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/efl/RenderThemeEfl.h:38: Evas_Object is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/efl/RenderThemeEfl.h:104: The parameter name "style" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:104: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:149: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:181: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:182: The parameter name "o" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:182: The parameter name "states" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:183: The parameter name "o" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:183: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:183: The parameter name "i" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:183: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:208: The parameter name "desc" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:209: The parameter name "o" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:209: The parameter name "desc" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:226: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:226: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:231: The parameter name "ce" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:231: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:232: The parameter name "ce" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:233: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:233: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:234: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:234: The parameter name "ce" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:235: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:235: The parameter name "size" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/efl/RenderThemeEfl.h:235: The parameter name "ce" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 27 in 1 files 353238 1 82874 gyuyoung.kim 2011-02-17 16:19:21 -0800 Created attachment 82874 Patch I make a patch for this. If parameter type represents parameter's meaning well, I think we don't need to add parameter unnecessarily. Other port add just parameter type to function definition. (See also RenderThemeGtk.h, RenderThemeQt.h) However, there are still style errors regarding underscore. Source/WebCore/platform/efl/RenderThemeEfl.h:37: Ecore_Evas is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebCore/platform/efl/RenderThemeEfl.h:38: Evas_Object is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] I don't know how to fix this errors yet. 353247 2 82874 gyuyoung.kim 2011-02-17 16:54:08 -0800 Comment on attachment 82874 Patch There was problem in eflews 353253 3 82880 gyuyoung.kim 2011-02-17 17:11:34 -0800 Created attachment 82880 Patch 354026 4 82880 commit-queue 2011-02-18 19:44:10 -0800 Comment on attachment 82880 Patch Clearing flags on attachment: 82880 Committed r79080: <http://trac.webkit.org/changeset/79080> 354027 5 commit-queue 2011-02-18 19:44:16 -0800 All reviewed patches have been landed. Closing bug. 82874 2011-02-17 16:19:21 -0800 2011-02-17 17:11:34 -0800 Patch patch-renderthemeefl.txt text/plain 4051 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYzg5MzE2Li42ZmVhOGFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDItMTcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBG aXggY29kaW5nIHN0eWxlIGVycm9ycyBpbiBSZW5kZXJUaGVtZUVmbC5oCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDY5MworCisgICAgICAgIEZpeCBz dHlsZSBlcnJvcnMgaW4gUmVuZGVyVGhlbWVFZmwuaAorCisgICAgICAgICogcGxhdGZvcm0vZWZs L1JlbmRlclRoZW1lRWZsLmg6CisKIDIwMTEtMDItMTYgIEJyaWFuIFJ5bmVyICA8YnJ5bmVyQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCmluZGV4IGQ0ODg3Y2YuLjk5 NzAwOTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVt ZUVmbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5o CkBAIC0xMDEsNyArMTAxLDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0RW50cnlUZXh0Q29sb3Io aW50IGZvcmVSLCBpbnQgZm9yZUcsIGludCBmb3JlQiwgaW50IGZvcmVBLCBpbnQgYmFja1IsIGlu dCBiYWNrRywgaW50IGJhY2tCLCBpbnQgYmFja0EpOwogICAgIHZvaWQgc2V0U2VhcmNoVGV4dENv bG9yKGludCBmb3JlUiwgaW50IGZvcmVHLCBpbnQgZm9yZUIsIGludCBmb3JlQSwgaW50IGJhY2tS LCBpbnQgYmFja0csIGludCBiYWNrQiwgaW50IGJhY2tBKTsKIAotICAgIHZvaWQgYWRqdXN0U2l6 ZUNvbnN0cmFpbnRzKFJlbmRlclN0eWxlKiBzdHlsZSwgRm9ybVR5cGUgdHlwZSkgY29uc3Q7Cisg ICAgdm9pZCBhZGp1c3RTaXplQ29uc3RyYWludHMoUmVuZGVyU3R5bGUqLCBGb3JtVHlwZSkgY29u c3Q7CiAKIAogICAgIC8vIFN5c3RlbSBmb250cy4KQEAgLTE0Niw3ICsxNDYsNyBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCB2b2lkIGFkanVzdFNsaWRlclRodW1iU3R5bGUoQ1NTU3R5bGVTZWxlY3Rv ciosIFJlbmRlclN0eWxlKiwgRWxlbWVudCopIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBwYWlu dFNsaWRlclRodW1iKFJlbmRlck9iamVjdCosIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IEludFJl Y3QmKTsKIAotICAgIHN0YXRpYyB2b2lkIHNldERlZmF1bHRGb250U2l6ZShpbnQgc2l6ZSk7Cisg ICAgc3RhdGljIHZvaWQgc2V0RGVmYXVsdEZvbnRTaXplKGludCBmb250c2l6ZSk7CiAKICNpZiBF TkFCTEUoUFJPR1JFU1NfVEFHKQogICAgIHZpcnR1YWwgdm9pZCBhZGp1c3RQcm9ncmVzc0JhclN0 eWxlKENTU1N0eWxlU2VsZWN0b3IqLCBSZW5kZXJTdHlsZSosIEVsZW1lbnQqKSBjb25zdDsKQEAg LTE3OCw5ICsxNzgsOSBAQCBwcml2YXRlOgogICAgIHZvaWQgY3JlYXRlRWRqZSgpOwogICAgIHZv aWQgYXBwbHlFZGplQ29sb3JzKCk7CiAgICAgdm9pZCBhcHBseVBhcnREZXNjcmlwdGlvbnMoKTsK LSAgICBjb25zdCBjaGFyKiBlZGplR3JvdXBGcm9tRm9ybVR5cGUoRm9ybVR5cGUgdHlwZSkgY29u c3Q7Ci0gICAgdm9pZCBhcHBseUVkamVTdGF0ZUZyb21Gb3JtKEV2YXNfT2JqZWN0KiBvLCBDb250 cm9sU3RhdGVzIHN0YXRlcyk7Ci0gICAgYm9vbCBwYWludFRoZW1lUGFydChSZW5kZXJPYmplY3Qq IG8sIEZvcm1UeXBlIHR5cGUsIGNvbnN0IFBhaW50SW5mbyYgaSwgY29uc3QgSW50UmVjdCYgcmVj dCk7CisgICAgY29uc3QgY2hhciogZWRqZUdyb3VwRnJvbUZvcm1UeXBlKEZvcm1UeXBlKSBjb25z dDsKKyAgICB2b2lkIGFwcGx5RWRqZVN0YXRlRnJvbUZvcm0oRXZhc19PYmplY3QqLCBDb250cm9s U3RhdGVzKTsKKyAgICBib29sIHBhaW50VGhlbWVQYXJ0KFJlbmRlck9iamVjdCosIEZvcm1UeXBl LCBjb25zdCBQYWludEluZm8mLCBjb25zdCBJbnRSZWN0Jik7CiAKICAgICBQYWdlKiBtX3BhZ2U7 CiAgICAgQ29sb3IgbV9hY3RpdmVTZWxlY3Rpb25CYWNrZ3JvdW5kQ29sb3I7CkBAIC0yMDUsOCAr MjA1LDggQEAgcHJpdmF0ZToKICAgICAgICAgTGVuZ3RoU2l6ZSBtYXg7CiAgICAgICAgIExlbmd0 aEJveCBwYWRkaW5nOwogICAgIH07Ci0gICAgdm9pZCBhcHBseVBhcnREZXNjcmlwdGlvbkZhbGxi YWNrKHN0cnVjdCBUaGVtZVBhcnREZXNjKiBkZXNjKTsKLSAgICB2b2lkIGFwcGx5UGFydERlc2Ny aXB0aW9uKEV2YXNfT2JqZWN0KiBvLCBzdHJ1Y3QgVGhlbWVQYXJ0RGVzYyogZGVzYyk7CisgICAg dm9pZCBhcHBseVBhcnREZXNjcmlwdGlvbkZhbGxiYWNrKHN0cnVjdCBUaGVtZVBhcnREZXNjKik7 CisgICAgdm9pZCBhcHBseVBhcnREZXNjcmlwdGlvbihFdmFzX09iamVjdCosIHN0cnVjdCBUaGVt ZVBhcnREZXNjKik7CiAKICAgICBzdHJ1Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSB7CiAgICAgICAg IEZvcm1UeXBlIHR5cGU7CkBAIC0yMjMsMTYgKzIyMywxNiBAQCBwcml2YXRlOgogICAgIFZlY3Rv cjxzdHJ1Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSAqPiBtX3BhcnRDYWNoZTsKIAogICAgIC8vIGdl dCAodXNlLCBjcmVhdGUgb3IgcmVwbGFjZSkgZW50cnkgZnJvbSBjYWNoZQotICAgIHN0cnVjdCBU aGVtZVBhcnRDYWNoZUVudHJ5KiBjYWNoZVRoZW1lUGFydEdldChGb3JtVHlwZSB0eXBlLCBjb25z dCBJbnRTaXplJiBzaXplKTsKKyAgICBzdHJ1Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSogY2FjaGVU aGVtZVBhcnRHZXQoRm9ybVR5cGUsIGNvbnN0IEludFNpemUmKTsKICAgICAvLyBmbHVzaCBjYWNo ZSwgZGVsZXRpbmcgYWxsIGVudHJpZXMKICAgICB2b2lkIGNhY2hlVGhlbWVQYXJ0Rmx1c2goKTsK IAogICAgIC8vIGludGVybmFsLCB1c2VkIGJ5IGNhY2hlVGhlbWVQYXJ0R2V0KCkKLSAgICBib29s IHRoZW1lUGFydENhY2hlRW50cnlSZXNldChzdHJ1Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSogY2Us IEZvcm1UeXBlIHR5cGUpOwotICAgIGJvb2wgdGhlbWVQYXJ0Q2FjaGVFbnRyeVN1cmZhY2VDcmVh dGUoc3RydWN0IFRoZW1lUGFydENhY2hlRW50cnkqIGNlKTsKLSAgICBzdHJ1Y3QgVGhlbWVQYXJ0 Q2FjaGVFbnRyeSogY2FjaGVUaGVtZVBhcnROZXcoRm9ybVR5cGUgdHlwZSwgY29uc3QgSW50U2l6 ZSYgc2l6ZSk7Ci0gICAgc3RydWN0IFRoZW1lUGFydENhY2hlRW50cnkqIGNhY2hlVGhlbWVQYXJ0 UmVzZXQoRm9ybVR5cGUgdHlwZSwgc3RydWN0IFRoZW1lUGFydENhY2hlRW50cnkqIGNlKTsKLSAg ICBzdHJ1Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSogY2FjaGVUaGVtZVBhcnRSZXNpemVBbmRSZXNl dChGb3JtVHlwZSB0eXBlLCBjb25zdCBJbnRTaXplJiBzaXplLCBzdHJ1Y3QgVGhlbWVQYXJ0Q2Fj aGVFbnRyeSogY2UpOworICAgIGJvb2wgdGhlbWVQYXJ0Q2FjaGVFbnRyeVJlc2V0KHN0cnVjdCBU aGVtZVBhcnRDYWNoZUVudHJ5KiwgRm9ybVR5cGUpOworICAgIGJvb2wgdGhlbWVQYXJ0Q2FjaGVF bnRyeVN1cmZhY2VDcmVhdGUoc3RydWN0IFRoZW1lUGFydENhY2hlRW50cnkqKTsKKyAgICBzdHJ1 Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSogY2FjaGVUaGVtZVBhcnROZXcoRm9ybVR5cGUsIGNvbnN0 IEludFNpemUmKTsKKyAgICBzdHJ1Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSogY2FjaGVUaGVtZVBh cnRSZXNldChGb3JtVHlwZSwgc3RydWN0IFRoZW1lUGFydENhY2hlRW50cnkqKTsKKyAgICBzdHJ1 Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSogY2FjaGVUaGVtZVBhcnRSZXNpemVBbmRSZXNldChGb3Jt VHlwZSwgY29uc3QgSW50U2l6ZSYsIHN0cnVjdCBUaGVtZVBhcnRDYWNoZUVudHJ5Kik7CiAKIH07 CiB9Cg== 82880 2011-02-17 17:11:34 -0800 2011-02-18 19:44:10 -0800 Patch patch-renderthemeefl.txt text/plain 4051 gyuyoung.kim ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYzg5MzE2Li42ZmVhOGFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDItMTcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBG aXggY29kaW5nIHN0eWxlIGVycm9ycyBpbiBSZW5kZXJUaGVtZUVmbC5oCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDY5MworCisgICAgICAgIEZpeCBz dHlsZSBlcnJvcnMgaW4gUmVuZGVyVGhlbWVFZmwuaAorCisgICAgICAgICogcGxhdGZvcm0vZWZs L1JlbmRlclRoZW1lRWZsLmg6CisKIDIwMTEtMDItMTYgIEJyaWFuIFJ5bmVyICA8YnJ5bmVyQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oCmluZGV4IGQ0ODg3Y2YuLjk5 NzAwOTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVt ZUVmbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5o CkBAIC0xMDEsNyArMTAxLDcgQEAgcHVibGljOgogICAgIHZvaWQgc2V0RW50cnlUZXh0Q29sb3Io aW50IGZvcmVSLCBpbnQgZm9yZUcsIGludCBmb3JlQiwgaW50IGZvcmVBLCBpbnQgYmFja1IsIGlu dCBiYWNrRywgaW50IGJhY2tCLCBpbnQgYmFja0EpOwogICAgIHZvaWQgc2V0U2VhcmNoVGV4dENv bG9yKGludCBmb3JlUiwgaW50IGZvcmVHLCBpbnQgZm9yZUIsIGludCBmb3JlQSwgaW50IGJhY2tS LCBpbnQgYmFja0csIGludCBiYWNrQiwgaW50IGJhY2tBKTsKIAotICAgIHZvaWQgYWRqdXN0U2l6 ZUNvbnN0cmFpbnRzKFJlbmRlclN0eWxlKiBzdHlsZSwgRm9ybVR5cGUgdHlwZSkgY29uc3Q7Cisg ICAgdm9pZCBhZGp1c3RTaXplQ29uc3RyYWludHMoUmVuZGVyU3R5bGUqLCBGb3JtVHlwZSkgY29u c3Q7CiAKIAogICAgIC8vIFN5c3RlbSBmb250cy4KQEAgLTE0Niw3ICsxNDYsNyBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCB2b2lkIGFkanVzdFNsaWRlclRodW1iU3R5bGUoQ1NTU3R5bGVTZWxlY3Rv ciosIFJlbmRlclN0eWxlKiwgRWxlbWVudCopIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBwYWlu dFNsaWRlclRodW1iKFJlbmRlck9iamVjdCosIGNvbnN0IFBhaW50SW5mbyYsIGNvbnN0IEludFJl Y3QmKTsKIAotICAgIHN0YXRpYyB2b2lkIHNldERlZmF1bHRGb250U2l6ZShpbnQgc2l6ZSk7Cisg ICAgc3RhdGljIHZvaWQgc2V0RGVmYXVsdEZvbnRTaXplKGludCBmb250c2l6ZSk7CiAKICNpZiBF TkFCTEUoUFJPR1JFU1NfVEFHKQogICAgIHZpcnR1YWwgdm9pZCBhZGp1c3RQcm9ncmVzc0JhclN0 eWxlKENTU1N0eWxlU2VsZWN0b3IqLCBSZW5kZXJTdHlsZSosIEVsZW1lbnQqKSBjb25zdDsKQEAg LTE3OCw5ICsxNzgsOSBAQCBwcml2YXRlOgogICAgIHZvaWQgY3JlYXRlRWRqZSgpOwogICAgIHZv aWQgYXBwbHlFZGplQ29sb3JzKCk7CiAgICAgdm9pZCBhcHBseVBhcnREZXNjcmlwdGlvbnMoKTsK LSAgICBjb25zdCBjaGFyKiBlZGplR3JvdXBGcm9tRm9ybVR5cGUoRm9ybVR5cGUgdHlwZSkgY29u c3Q7Ci0gICAgdm9pZCBhcHBseUVkamVTdGF0ZUZyb21Gb3JtKEV2YXNfT2JqZWN0KiBvLCBDb250 cm9sU3RhdGVzIHN0YXRlcyk7Ci0gICAgYm9vbCBwYWludFRoZW1lUGFydChSZW5kZXJPYmplY3Qq IG8sIEZvcm1UeXBlIHR5cGUsIGNvbnN0IFBhaW50SW5mbyYgaSwgY29uc3QgSW50UmVjdCYgcmVj dCk7CisgICAgY29uc3QgY2hhciogZWRqZUdyb3VwRnJvbUZvcm1UeXBlKEZvcm1UeXBlKSBjb25z dDsKKyAgICB2b2lkIGFwcGx5RWRqZVN0YXRlRnJvbUZvcm0oRXZhc19PYmplY3QqLCBDb250cm9s U3RhdGVzKTsKKyAgICBib29sIHBhaW50VGhlbWVQYXJ0KFJlbmRlck9iamVjdCosIEZvcm1UeXBl LCBjb25zdCBQYWludEluZm8mLCBjb25zdCBJbnRSZWN0Jik7CiAKICAgICBQYWdlKiBtX3BhZ2U7 CiAgICAgQ29sb3IgbV9hY3RpdmVTZWxlY3Rpb25CYWNrZ3JvdW5kQ29sb3I7CkBAIC0yMDUsOCAr MjA1LDggQEAgcHJpdmF0ZToKICAgICAgICAgTGVuZ3RoU2l6ZSBtYXg7CiAgICAgICAgIExlbmd0 aEJveCBwYWRkaW5nOwogICAgIH07Ci0gICAgdm9pZCBhcHBseVBhcnREZXNjcmlwdGlvbkZhbGxi YWNrKHN0cnVjdCBUaGVtZVBhcnREZXNjKiBkZXNjKTsKLSAgICB2b2lkIGFwcGx5UGFydERlc2Ny aXB0aW9uKEV2YXNfT2JqZWN0KiBvLCBzdHJ1Y3QgVGhlbWVQYXJ0RGVzYyogZGVzYyk7CisgICAg dm9pZCBhcHBseVBhcnREZXNjcmlwdGlvbkZhbGxiYWNrKHN0cnVjdCBUaGVtZVBhcnREZXNjKik7 CisgICAgdm9pZCBhcHBseVBhcnREZXNjcmlwdGlvbihFdmFzX09iamVjdCosIHN0cnVjdCBUaGVt ZVBhcnREZXNjKik7CiAKICAgICBzdHJ1Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSB7CiAgICAgICAg IEZvcm1UeXBlIHR5cGU7CkBAIC0yMjMsMTYgKzIyMywxNiBAQCBwcml2YXRlOgogICAgIFZlY3Rv cjxzdHJ1Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSAqPiBtX3BhcnRDYWNoZTsKIAogICAgIC8vIGdl dCAodXNlLCBjcmVhdGUgb3IgcmVwbGFjZSkgZW50cnkgZnJvbSBjYWNoZQotICAgIHN0cnVjdCBU aGVtZVBhcnRDYWNoZUVudHJ5KiBjYWNoZVRoZW1lUGFydEdldChGb3JtVHlwZSB0eXBlLCBjb25z dCBJbnRTaXplJiBzaXplKTsKKyAgICBzdHJ1Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSogY2FjaGVU aGVtZVBhcnRHZXQoRm9ybVR5cGUsIGNvbnN0IEludFNpemUmKTsKICAgICAvLyBmbHVzaCBjYWNo ZSwgZGVsZXRpbmcgYWxsIGVudHJpZXMKICAgICB2b2lkIGNhY2hlVGhlbWVQYXJ0Rmx1c2goKTsK IAogICAgIC8vIGludGVybmFsLCB1c2VkIGJ5IGNhY2hlVGhlbWVQYXJ0R2V0KCkKLSAgICBib29s IHRoZW1lUGFydENhY2hlRW50cnlSZXNldChzdHJ1Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSogY2Us IEZvcm1UeXBlIHR5cGUpOwotICAgIGJvb2wgdGhlbWVQYXJ0Q2FjaGVFbnRyeVN1cmZhY2VDcmVh dGUoc3RydWN0IFRoZW1lUGFydENhY2hlRW50cnkqIGNlKTsKLSAgICBzdHJ1Y3QgVGhlbWVQYXJ0 Q2FjaGVFbnRyeSogY2FjaGVUaGVtZVBhcnROZXcoRm9ybVR5cGUgdHlwZSwgY29uc3QgSW50U2l6 ZSYgc2l6ZSk7Ci0gICAgc3RydWN0IFRoZW1lUGFydENhY2hlRW50cnkqIGNhY2hlVGhlbWVQYXJ0 UmVzZXQoRm9ybVR5cGUgdHlwZSwgc3RydWN0IFRoZW1lUGFydENhY2hlRW50cnkqIGNlKTsKLSAg ICBzdHJ1Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSogY2FjaGVUaGVtZVBhcnRSZXNpemVBbmRSZXNl dChGb3JtVHlwZSB0eXBlLCBjb25zdCBJbnRTaXplJiBzaXplLCBzdHJ1Y3QgVGhlbWVQYXJ0Q2Fj aGVFbnRyeSogY2UpOworICAgIGJvb2wgdGhlbWVQYXJ0Q2FjaGVFbnRyeVJlc2V0KHN0cnVjdCBU aGVtZVBhcnRDYWNoZUVudHJ5KiwgRm9ybVR5cGUpOworICAgIGJvb2wgdGhlbWVQYXJ0Q2FjaGVF bnRyeVN1cmZhY2VDcmVhdGUoc3RydWN0IFRoZW1lUGFydENhY2hlRW50cnkqKTsKKyAgICBzdHJ1 Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSogY2FjaGVUaGVtZVBhcnROZXcoRm9ybVR5cGUsIGNvbnN0 IEludFNpemUmKTsKKyAgICBzdHJ1Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSogY2FjaGVUaGVtZVBh cnRSZXNldChGb3JtVHlwZSwgc3RydWN0IFRoZW1lUGFydENhY2hlRW50cnkqKTsKKyAgICBzdHJ1 Y3QgVGhlbWVQYXJ0Q2FjaGVFbnRyeSogY2FjaGVUaGVtZVBhcnRSZXNpemVBbmRSZXNldChGb3Jt VHlwZSwgY29uc3QgSW50U2l6ZSYsIHN0cnVjdCBUaGVtZVBhcnRDYWNoZUVudHJ5Kik7CiAKIH07 CiB9Cg==