54689 2011-02-17 14:14:45 -0800 HTML Fragment parsing bug in HTMLHtmlElement. 2011-03-14 14:36:18 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 michaeln webkit-unassigned abarth aestes michaeln oldest_to_newest 353167 0 michaeln 2011-02-17 14:14:45 -0800 Looks like the test for fragment'ness when a synthesized <html> element for an innerHtml fragment no longer functions properly in HTMLHtmlElement::insertedByParser(). void HTMLHtmlElement::insertedByParser() { // When parsing a fragment, its dummy document has a null parser. if (!document()->parser() || !document()->parser()->documentWasLoadedAsPartOfNavigation()) return; That test no longer weeds out these elements so the method continues when it shouldn't. This has bad consequences for the appcache system. See http://code.google.com/p/chromium/issues/detail?id=72986 for some history. 353266 1 aestes 2011-02-17 17:30:47 -0800 Working on it. I actually think this will be fixed by the patch I'm uploading to https://bugs.webkit.org/show_bug.cgi?id=48719, which will not create an HTML element during fragment parsing. 353267 2 michaeln 2011-02-17 17:31:57 -0800 Thank you! 361986 3 aestes 2011-03-03 15:03:28 -0800 Michael, can you verify that this assertion is no longer hit in a build with r80231? 361987 4 aestes 2011-03-03 15:03:53 -0800 Sorry, I had assertions on the mind. I meant to say bug. 361997 5 michaeln 2011-03-03 15:22:39 -0800 Sure, when we roll this revision into view for chrome i'll take a look. 367238 6 michaeln 2011-03-14 14:35:45 -0700 Looks good to me. I'm no longer seeing multiple invocations of selectCache() for html fragments. 367239 7 aestes 2011-03-14 14:36:18 -0700 (In reply to comment #6) > Looks good to me. I'm no longer seeing multiple invocations of selectCache() for html fragments. Thanks for checking Michael!