54681 2011-02-17 12:45:41 -0800 [v8] Change expectations for plugins/netscape-plugin-poperty-access-exception test 2011-04-08 01:47:24 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 antonm antonm abarth commit-queue dglazkov dpranke morrita oldest_to_newest 353109 0 antonm 2011-02-17 12:45:41 -0800 [v8] Change expectations for plugins/netscape-plugin-poperty-access-exception test 353115 1 antonm 2011-02-17 12:49:11 -0800 Guys, sorry for shooting in the dark: I hope at least you can point out other people who can review this patch or ideally review it yourselves. I am fixing some issues with the way v8 process exceptions and that changes the way NPPlugins report exceptions. I hope my changes are ok---after all Safari, Chromium and FF apparently all behave differently. But if you have any concerns, I'd be happy to here and address them. 353120 2 82851 antonm 2011-02-17 12:54:12 -0800 Created attachment 82851 Patch 353122 3 abarth 2011-02-17 12:55:37 -0800 Sorry, I don't know much about these tests. It's too bad that everyone does something different... 353499 4 antonm 2011-02-18 02:34:07 -0800 (In reply to comment #3) > Sorry, I don't know much about these tests. It's too bad that everyone does something different... With which I definitely agree. But I strongly suspect current Chromium's expectations just capture the erroneous behaviour of current v8's exception handling. 353710 5 82851 abarth 2011-02-18 11:40:16 -0800 Comment on attachment 82851 Patch ok. I'm not super confident in this review, but it's probably ok. 354647 6 antonm 2011-02-21 09:47:49 -0800 Thanks a lot, Adam. I'll submit when v8 with my patch gets rolled. (In reply to comment #5) > (From update of attachment 82851 [details]) > ok. I'm not super confident in this review, but it's probably ok. 382079 7 82851 commit-queue 2011-04-08 01:47:17 -0700 Comment on attachment 82851 Patch Clearing flags on attachment: 82851 Committed r83269: <http://trac.webkit.org/changeset/83269> 382080 8 commit-queue 2011-04-08 01:47:24 -0700 All reviewed patches have been landed. Closing bug. 82851 2011-02-17 12:54:12 -0800 2011-04-08 01:47:17 -0700 Patch bug-54681-20110217235410.patch text/plain 3353 antonm U3VidmVyc2lvbiBSZXZpc2lvbjogNzg4MzkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmMWExYmNlNTc3OTNmYTZlOWQ3YzRl MTc2NTI5MTM1MTI0OGMwZTVlLi42NmQwMzY4MWFjZWFkZmI2Y2YzMjM1ODE5NjJiMmM3MjZjMzlh OTZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMTcgIEFudG9uIE11aGluICA8YW50 b25tQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbdjhdIENoYW5nZSBleHBlY3RhdGlvbnMgZm9yIHBsdWdpbnMvbmV0c2NhcGUt cGx1Z2luLXBvcGVydHktYWNjZXNzLWV4Y2VwdGlvbiB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDY4MQorCisgICAgICAgIFRoaXMgYSBwYXRj aCB3aGljaCBzaG91bGQgYmUgbGFuZGVkIHdoZW4gZml4IGZvciBleGNlcHRpb24gaGFuZGxpbmcg aW4gdjggaXMgbGFuZGVkCisgICAgICAgIChzZWUgaHR0cDovL2NvZGVyZXZpZXcuY2hyb21pdW0u b3JnLzYzOTcwMTEvKQorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0tbWFjL3BsdWdpbnMv bmV0c2NhcGUtcGx1Z2luLXByb3BlcnR5LWFjY2Vzcy1leGNlcHRpb24tZXhwZWN0ZWQudHh0Ogor ICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtLXdpbi9wbHVnaW5zL25ldHNjYXBlLXBsdWdpbi1w cm9wZXJ0eS1hY2Nlc3MtZXhjZXB0aW9uLWV4cGVjdGVkLnR4dDoKKwogMjAxMS0wMi0xNyAgU2Vy Z2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbWFjL3BsdWdp bnMvbmV0c2NhcGUtcGx1Z2luLXByb3BlcnR5LWFjY2Vzcy1leGNlcHRpb24tZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbWFjL3BsdWdpbnMvbmV0c2NhcGUtcGx1 Z2luLXByb3BlcnR5LWFjY2Vzcy1leGNlcHRpb24tZXhwZWN0ZWQudHh0CmluZGV4IDM2ZTljYmE5 MDcwZjBhNWEzZTczNzM2Y2JiZTNkZWQyMDgwYzA1MzUuLjU2ZjQyNTA3NDRjZTJiNTczNzA0OGFh ZjI5MzM1NmFjODM2NTcwZjcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9t aXVtLW1hYy9wbHVnaW5zL25ldHNjYXBlLXBsdWdpbi1wcm9wZXJ0eS1hY2Nlc3MtZXhjZXB0aW9u LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS1tYWMvcGx1 Z2lucy9uZXRzY2FwZS1wbHVnaW4tcHJvcGVydHktYWNjZXNzLWV4Y2VwdGlvbi1leHBlY3RlZC50 eHQKQEAgLTYsNSArNiw1IEBAIFNVQ0NFU1M6IEV4Y2VwdGlvbiBjYXVnaHQ6IEVycm9yOiBwbHVn aW4gb2JqZWN0IHRlc3RUaHJvd0V4Y2VwdGlvblByb3BlcnR5IFNVQ0NFCiBPbmUgY291bGQgZXhw ZWN0IGV4Y2VwdGlvbnMgdG8gYmUgcmFpc2VkIGluIHRoZSBiZWxvdyBjYXNlcywgdG9vIC0gYnV0 IEZpcmVmb3ggZG9lc24ndCBkbyB0aGF0IGluIG1vc3Qgb2YgdGhlc2UgKEkgZG8gZ2V0IGFuIGV4 Y2VwdGlvbiBpbiB0aGUgZmlyc3QgY2FzZSwgYnV0IHRoYXQncyBpbmNvbnNpc3RlbnQgd2l0aCBu b3QgZ2V0dGluZyBpdCBpbiB0aGUgc2Vjb25mZCBvbmUpLgogRXhjZXB0aW9uIGNhdWdodDogRXJy b3I6IEVycm9yIGNhbGxpbmcgbWV0aG9kIG9uIE5QT2JqZWN0LgogRXhjZXB0aW9uIGNhdWdodDog RXJyb3I6IEVycm9yIGNhbGxpbmcgbWV0aG9kIG9uIE5QT2JqZWN0LgotRXhjZXB0aW9uIGNhdWdo dDogRXJyb3I6IHBsdWdpbiBvYmplY3QgdGVzdFRocm93RXhjZXB0aW9uUHJvcGVydHkgU1VDQ0VT UwotRXhjZXB0aW9uIGNhdWdodDogRXJyb3I6IHBsdWdpbiBvYmplY3QgdGVzdFRocm93RXhjZXB0 aW9uUHJvcGVydHkgU1VDQ0VTUworTm8gZXhjZXB0aW9uIGNhdWdodCBvbiBnZXR0aW5nIHZpYSB0 ZXN0R2V0QnJvd3NlclByb3BlcnR5LgorTm8gZXhjZXB0aW9uIGNhdWdodCBvbiBzZXR0aW5nIHZp YSB0ZXN0U2V0QnJvd3NlclByb3BlcnR5LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0td2luL3BsdWdpbnMvbmV0c2NhcGUtcGx1Z2luLXByb3BlcnR5LWFjY2Vzcy1l eGNlcHRpb24tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0td2lu L3BsdWdpbnMvbmV0c2NhcGUtcGx1Z2luLXByb3BlcnR5LWFjY2Vzcy1leGNlcHRpb24tZXhwZWN0 ZWQudHh0CmluZGV4IDM2ZTljYmE5MDcwZjBhNWEzZTczNzM2Y2JiZTNkZWQyMDgwYzA1MzUuLjU2 ZjQyNTA3NDRjZTJiNTczNzA0OGFhZjI5MzM1NmFjODM2NTcwZjcgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtLXdpbi9wbHVnaW5zL25ldHNjYXBlLXBsdWdpbi1wcm9w ZXJ0eS1hY2Nlc3MtZXhjZXB0aW9uLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9jaHJvbWl1bS13aW4vcGx1Z2lucy9uZXRzY2FwZS1wbHVnaW4tcHJvcGVydHktYWNjZXNz LWV4Y2VwdGlvbi1leHBlY3RlZC50eHQKQEAgLTYsNSArNiw1IEBAIFNVQ0NFU1M6IEV4Y2VwdGlv biBjYXVnaHQ6IEVycm9yOiBwbHVnaW4gb2JqZWN0IHRlc3RUaHJvd0V4Y2VwdGlvblByb3BlcnR5 IFNVQ0NFCiBPbmUgY291bGQgZXhwZWN0IGV4Y2VwdGlvbnMgdG8gYmUgcmFpc2VkIGluIHRoZSBi ZWxvdyBjYXNlcywgdG9vIC0gYnV0IEZpcmVmb3ggZG9lc24ndCBkbyB0aGF0IGluIG1vc3Qgb2Yg dGhlc2UgKEkgZG8gZ2V0IGFuIGV4Y2VwdGlvbiBpbiB0aGUgZmlyc3QgY2FzZSwgYnV0IHRoYXQn cyBpbmNvbnNpc3RlbnQgd2l0aCBub3QgZ2V0dGluZyBpdCBpbiB0aGUgc2Vjb25mZCBvbmUpLgog RXhjZXB0aW9uIGNhdWdodDogRXJyb3I6IEVycm9yIGNhbGxpbmcgbWV0aG9kIG9uIE5QT2JqZWN0 LgogRXhjZXB0aW9uIGNhdWdodDogRXJyb3I6IEVycm9yIGNhbGxpbmcgbWV0aG9kIG9uIE5QT2Jq ZWN0LgotRXhjZXB0aW9uIGNhdWdodDogRXJyb3I6IHBsdWdpbiBvYmplY3QgdGVzdFRocm93RXhj ZXB0aW9uUHJvcGVydHkgU1VDQ0VTUwotRXhjZXB0aW9uIGNhdWdodDogRXJyb3I6IHBsdWdpbiBv YmplY3QgdGVzdFRocm93RXhjZXB0aW9uUHJvcGVydHkgU1VDQ0VTUworTm8gZXhjZXB0aW9uIGNh dWdodCBvbiBnZXR0aW5nIHZpYSB0ZXN0R2V0QnJvd3NlclByb3BlcnR5LgorTm8gZXhjZXB0aW9u IGNhdWdodCBvbiBzZXR0aW5nIHZpYSB0ZXN0U2V0QnJvd3NlclByb3BlcnR5Lgo=