54669 2011-02-17 09:26:57 -0800 IndexedDB: Populate indexes created for object stores with data 2011-02-18 01:56:50 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hans hans andreip dgrogan jorlow oldest_to_newest 352972 0 hans 2011-02-17 09:26:57 -0800 IndexedDB: Populate indexes created for object stores with data 352973 1 82821 hans 2011-02-17 09:28:30 -0800 Created attachment 82821 Patch 352988 2 82821 jorlow 2011-02-17 09:50:23 -0800 Comment on attachment 82821 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82821&action=review great stuff! > Source/WebCore/storage/IDBIndexBackendImpl.h:-32 > - Isnt this space typical? > Source/WebCore/storage/IDBObjectStoreBackendImpl.cpp:328 > + if (!it->second->hasValidId()) Probably worth a comment 353485 3 hans 2011-02-18 01:56:50 -0800 Committed r78980: <http://trac.webkit.org/changeset/78980> 82821 2011-02-17 09:28:30 -0800 2011-02-17 09:50:23 -0800 Patch bug-54669-20110217172828.patch text/plain 7487 hans U3VidmVyc2lvbiBSZXZpc2lvbjogNzg4MDcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyZDI4M2U3NGE0YTAzMjViMTAwOGZk NWE4OGMyMzlhNWNiOWZiNWNkLi5hZjRiNGM0ZDkxYjA1YjMxM2U4ODQ2ODYwZDYxNDNhOTgxZjdh NzhkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDItMTcgIEhhbnMgV2VubmJvcmcgIDxo YW5zQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJbmRleGVkREI6IFBvcHVsYXRlIGluZGV4ZXMgY3JlYXRlZCBmb3Igb2JqZWN0 IHN0b3JlcyB3aXRoIGRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTU0NjY5CisKKyAgICAgICAgVGVzdCB0aGF0IGNyZWF0aW5nIGFuIGluZGV4IGZv ciBhbiBvYmplY3Qgc3RvcmUgdGhhdCBhbHJlYWR5IGhvbGRzCisgICAgICAgIGRhdGEgd29ya3Mu CisKKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9pbmRleC1iYXNpY3MtZXhwZWN0ZWQudHh0 OgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL2luZGV4LWJhc2ljcy5odG1sOgorCiAyMDEx LTAyLTE3ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERpcmsgU2NodWx6ZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0 b3JhZ2UvaW5kZXhlZGRiL2luZGV4LWJhc2ljcy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9z dG9yYWdlL2luZGV4ZWRkYi9pbmRleC1iYXNpY3MtZXhwZWN0ZWQudHh0CmluZGV4IGZhZDdjMGFk MzMwMmZmYTliNGM3MDAxYjU0Y2Y4Y2ZlMjRhMTgzMTYuLmEwOTBhODViZjJjZWRlMWZkNTg5ZGE2 OTExNGMxZWNkYmZhMTg3NTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhl ZGRiL2luZGV4LWJhc2ljcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9p bmRleGVkZGIvaW5kZXgtYmFzaWNzLWV4cGVjdGVkLnR4dApAQCAtMjgsNiArMjgsNyBAQCBQQVNT ICdnZXRLZXknIGluIGluZGV4T2JqZWN0IGlzIHRydWUKIFBBU1MgJ2dldCcgaW4gaW5kZXhPYmpl Y3QgaXMgdHJ1ZQogc3RvcmUuYWRkKHt4OiAndmFsdWUnLCB5OiAnenp6JywgejogMi43Mn0sICdr ZXknKQogZXZlbnQudGFyZ2V0LnNvdXJjZS5hZGQoe3g6ICd2YWx1ZTInLCB5OiAnenp6MicsIHo6 IDIuNzF9LCAna2V5MicpCitzdG9yZS5jcmVhdGVJbmRleCgnaW5kZXhXaGlsZUFkZElzSW5GbGln aHQnLCAneCcpCiBpbmRleE9iamVjdC5nZXRLZXkoJ3ZhbHVlJykKIFBBU1MgZXZlbnQudGFyZ2V0 LnJlc3VsdCBpcyAia2V5IgogaW5kZXhPYmplY3QyLmdldEtleSgnenp6JykKQEAgLTQzLDYgKzQ0 LDggQEAgZXZlbnQucHJldmVudERlZmF1bHQoKQogaW5kZXhPYmplY3QuZ2V0KCdkb2VzIG5vdCBl eGlzdCcpCiBQQVNTIGV2ZW50LnRhcmdldC5lcnJvckNvZGUgaXMgd2Via2l0SURCRGF0YWJhc2VF eGNlcHRpb24uTk9UX0ZPVU5EX0VSUgogZXZlbnQucHJldmVudERlZmF1bHQoKQoraW5kZXhPYmpl Y3Q0LmdldEtleSgndmFsdWUyJykKK1BBU1MgZXZlbnQudGFyZ2V0LnJlc3VsdCBpcyAia2V5MiIK IGluZGV4T2JqZWN0Lm9wZW5LZXlDdXJzb3IoKQogUEFTUyBldmVudC50YXJnZXQucmVzdWx0ID09 PSBudWxsIGlzIGZhbHNlCiBQQVNTIGV2ZW50LnRhcmdldC5yZXN1bHQua2V5IGlzICJ2YWx1ZSIK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2luZGV4LWJhc2ljcy5o dG1sIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvaW5kZXgtYmFzaWNzLmh0bWwKaW5k ZXggZDQ2ZDVjYzM2MWQzMWJiZWRjMDllODcwMzJmZGI3OTUxMjBlOGY0Mi4uMTkyYmUyYTMwNzFh OTgyNGVjYmQwNzQxODAyMjc4NzhmYzdiM2JiZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3Rv cmFnZS9pbmRleGVkZGIvaW5kZXgtYmFzaWNzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFn ZS9pbmRleGVkZGIvaW5kZXgtYmFzaWNzLmh0bWwKQEAgLTcxLDYgKzcxLDcgQEAgZnVuY3Rpb24g YWRkTW9yZSgpCiAgICAgcmVxdWVzdCA9IGV2YWxBbmRMb2coImV2ZW50LnRhcmdldC5zb3VyY2Uu YWRkKHt4OiAndmFsdWUyJywgeTogJ3p6ejInLCB6OiAyLjcxfSwgJ2tleTInKSIpOwogICAgIHJl cXVlc3Qub25zdWNjZXNzID0gZ2V0RGF0YTsKICAgICByZXF1ZXN0Lm9uZXJyb3IgPSB1bmV4cGVj dGVkRXJyb3JDYWxsYmFjazsKKyAgICB3aW5kb3cuaW5kZXhPYmplY3Q0ID0gZXZhbEFuZExvZygi c3RvcmUuY3JlYXRlSW5kZXgoJ2luZGV4V2hpbGVBZGRJc0luRmxpZ2h0JywgJ3gnKSIpOwogfQog CiBmdW5jdGlvbiBnZXREYXRhKCkKQEAgLTEyNSwxNSArMTI2LDIzIEBAIGZ1bmN0aW9uIGdldE9i amVjdERhdGFGYWlsKCkKIAogICAgIHJlcXVlc3QgPSBldmFsQW5kTG9nKCJpbmRleE9iamVjdC5n ZXQoJ2RvZXMgbm90IGV4aXN0JykiKTsKICAgICByZXF1ZXN0Lm9uc3VjY2VzcyA9IHVuZXhwZWN0 ZWRTdWNjZXNzQ2FsbGJhY2s7Ci0gICAgcmVxdWVzdC5vbmVycm9yID0gb3BlbktleUN1cnNvcjsK KyAgICByZXF1ZXN0Lm9uZXJyb3IgPSBnZXRPYmplY3REYXRhNDsKIH0KIAotZnVuY3Rpb24gb3Bl bktleUN1cnNvcigpCitmdW5jdGlvbiBnZXRPYmplY3REYXRhNCgpCiB7CiAgICAgc2hvdWxkQmUo ImV2ZW50LnRhcmdldC5lcnJvckNvZGUiLCAid2Via2l0SURCRGF0YWJhc2VFeGNlcHRpb24uTk9U X0ZPVU5EX0VSUiIpOwotCiAgICAgZXZhbEFuZExvZygiZXZlbnQucHJldmVudERlZmF1bHQoKSIp OwogCisgICAgcmVxdWVzdCA9IGV2YWxBbmRMb2coImluZGV4T2JqZWN0NC5nZXRLZXkoJ3ZhbHVl MicpIik7CisgICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBvcGVuS2V5Q3Vyc29yOworICAgIHJlcXVl c3Qub25lcnJvciA9ICB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKK30KKworZnVuY3Rpb24gb3Bl bktleUN1cnNvcigpCit7CisgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJldmVudC50YXJnZXQu cmVzdWx0IiwgImtleTIiKTsKKwogICAgIHdpbmRvdy5yZXF1ZXN0ID0gZXZhbEFuZExvZygiaW5k ZXhPYmplY3Qub3BlbktleUN1cnNvcigpIik7CiAgICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBjdXJz b3IxQ29udGludWU7CiAgICAgcmVxdWVzdC5vbmVycm9yID0gdW5leHBlY3RlZEVycm9yQ2FsbGJh Y2s7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggMDQxZTM2ZTgxMzViMGY5Nzk3Zjc2YzM4OGFmZTBiNGRlYjY2N2M5 NC4uNTEwZmEwZTM1OWQwZGNjYzI4YzEwMWE4ZjhiN2Y3MTNlZGI4YTZhYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDIwIEBACisyMDExLTAyLTE3ICBIYW5zIFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW5kZXhlZERCOiBQb3B1bGF0ZSBpbmRleGVzIGNyZWF0ZWQgZm9yIG9iamVjdCBzdG9yZXMgd2l0 aCBkYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 NDY2OQorCisgICAgICAgIE1ha2Ugc3VyZSB0aGF0IGluZGljZXMgZm9yIG9iamVjdCBzdG9yZXMg dGhhdCBhbHJlYWR5IGhvbGQgZGF0YSBnZXQKKyAgICAgICAgcG9wdWxhdGVkLgorCisgICAgICAg ICogc3RvcmFnZS9JREJJbmRleEJhY2tlbmRJbXBsLmg6CisgICAgICAgIChXZWJDb3JlOjpJREJJ bmRleEJhY2tlbmRJbXBsOjpoYXNWYWxpZElkKToKKyAgICAgICAgKiBzdG9yYWdlL0lEQk9iamVj dFN0b3JlQmFja2VuZEltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCT2JqZWN0U3RvcmVC YWNrZW5kSW1wbDo6cHV0SW50ZXJuYWwpOgorICAgICAgICAoV2ViQ29yZTo6cG9wdWxhdGVJbmRl eCk6CisgICAgICAgIChXZWJDb3JlOjpJREJPYmplY3RTdG9yZUJhY2tlbmRJbXBsOjpjcmVhdGVJ bmRleEludGVybmFsKToKKwogMjAxMS0wMi0xNyAgTmlrb2xhcyBaaW1tZXJtYW5uICA8bnppbW1l cm1hbm5AcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaXJrIFNjaHVsemUuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lEQkluZGV4QmFja2VuZEltcGwuaCBiL1Nv dXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURCSW5kZXhCYWNrZW5kSW1wbC5oCmluZGV4IGU2NDBiNWE2 NTdkNWNhMzFiYWNmYjFhM2MxMmJiOGQyMzJlN2JjZjIuLjkzMjMzODMwOTBmNTQ0OWU1ZjNlZDQ2 NWI1OTBlNWM1YzY0Zjc5NDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURC SW5kZXhCYWNrZW5kSW1wbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURCSW5kZXhC YWNrZW5kSW1wbC5oCkBAIC0yOSw3ICsyOSw2IEBACiAjaW5jbHVkZSAiSURCSW5kZXhCYWNrZW5k SW50ZXJmYWNlLmgiCiAKICNpZiBFTkFCTEUoSU5ERVhFRF9EQVRBQkFTRSkKLQogbmFtZXNwYWNl IFdlYkNvcmUgewogCiBjbGFzcyBJREJLZXk7CkBAIC01Niw2ICs1NSw3IEBAIHB1YmxpYzoKICAg ICAgICAgcmV0dXJuIG1faWQ7CiAgICAgfQogICAgIHZvaWQgc2V0SWQoaW50NjRfdCBpZCkgeyBt X2lkID0gaWQ7IH0KKyAgICBib29sIGhhc1ZhbGlkSWQoKSBjb25zdCB7IHJldHVybiBtX2lkICE9 IEludmFsaWRJZDsgfTsKIAogICAgIGJvb2wgYWRkaW5nS2V5QWxsb3dlZChJREJLZXkqKTsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJPYmplY3RTdG9yZUJhY2tlbmRJ bXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvSURCT2JqZWN0U3RvcmVCYWNrZW5kSW1w bC5jcHAKaW5kZXggNTQxYWIwNGVlZDEyYjU4MDY0NGFmOTNhM2JkYTQwNmY4ODhkZDJhZi4uZjZi YjVjMDdkNzI5ODBhY2YwZDJkMWJhYjNlNTFkNzE3NDY3NDQ4NSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvc3RvcmFnZS9JREJPYmplY3RTdG9yZUJhY2tlbmRJbXBsLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9zdG9yYWdlL0lEQk9iamVjdFN0b3JlQmFja2VuZEltcGwuY3BwCkBAIC0zMjUs NiArMzI1LDggQEAgdm9pZCBJREJPYmplY3RTdG9yZUJhY2tlbmRJbXBsOjpwdXRJbnRlcm5hbChT Y3JpcHRFeGVjdXRpb25Db250ZXh0KiwgUGFzc1JlZlB0cjwKIAogICAgIGludCBpID0gMDsKICAg ICBmb3IgKEluZGV4TWFwOjppdGVyYXRvciBpdCA9IG9iamVjdFN0b3JlLT5tX2luZGV4ZXMuYmVn aW4oKTsgaXQgIT0gb2JqZWN0U3RvcmUtPm1faW5kZXhlcy5lbmQoKTsgKytpdCwgKytpKSB7Cisg ICAgICAgIGlmICghaXQtPnNlY29uZC0+aGFzVmFsaWRJZCgpKQorICAgICAgICAgICAgY29udGlu dWU7CiAgICAgICAgIGlmICghcHV0SW5kZXhEYXRhKG9iamVjdFN0b3JlLT5zcWxpdGVEYXRhYmFz ZSgpLCBpbmRleEtleXNbaV0uZ2V0KCksIGl0LT5zZWNvbmQtPmlkKCksIGRhdGFSb3dJZCkpIHsK ICAgICAgICAgICAgIC8vIEZJWE1FOiBUaGUgSW5kZXhlZCBEYXRhYmFzZSBzcGVjaWZpY2F0aW9u IGRvZXMgbm90IGhhdmUgYW4gZXJyb3IgY29kZSBkZWRpY2F0ZWQgdG8gSS9PIGVycm9ycy4KICAg ICAgICAgICAgIGNhbGxiYWNrcy0+b25FcnJvcihJREJEYXRhYmFzZUVycm9yOjpjcmVhdGUoSURC RGF0YWJhc2VFeGNlcHRpb246OlVOS05PV05fRVJSLCAiRXJyb3Igd3JpdGluZyBkYXRhIHRvIHN0 YWJsZSBzdG9yYWdlLiIpKTsKQEAgLTQxNyw2ICs0MTksMjQgQEAgdm9pZCBJREJPYmplY3RTdG9y ZUJhY2tlbmRJbXBsOjpjbGVhckludGVybmFsKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqLCBQYXNz UmVmUHQKICAgICBjYWxsYmFja3MtPm9uU3VjY2VzcyhTZXJpYWxpemVkU2NyaXB0VmFsdWU6OnVu ZGVmaW5lZFZhbHVlKCkpOwogfQogCitzdGF0aWMgYm9vbCBwb3B1bGF0ZUluZGV4KFNRTGl0ZURh dGFiYXNlJiBkYiwgaW50NjRfdCBvYmplY3RTdG9yZUlkLCBpbnQ2NF90IGluZGV4SWQsIGNvbnN0 IFN0cmluZyYgaW5kZXhLZXlQYXRoKQoreworICAgIFNRTGl0ZVN0YXRlbWVudCBzZWxlY3QoZGIs ICJTRUxFQ1QgaWQsIHZhbHVlIEZST00gT2JqZWN0U3RvcmVEYXRhIFdIRVJFIG9iamVjdFN0b3Jl SWQgPSA/Iik7CisgICAgaWYgKHNlbGVjdC5wcmVwYXJlKCkgIT0gU1FMUmVzdWx0T2spCisgICAg ICAgIHJldHVybiBmYWxzZTsKKworICAgIHNlbGVjdC5iaW5kSW50NjQoMSwgb2JqZWN0U3RvcmVJ ZCk7CisgICAgd2hpbGUgKHNlbGVjdC5zdGVwKCkgPT0gU1FMUmVzdWx0Um93KSB7CisgICAgICAg IGludDY0X3Qgb2JqZWN0U3RvcmVEYXRhSWQgPSBzZWxlY3QuZ2V0Q29sdW1uSW50NjQoMCk7Cisg ICAgICAgIFJlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IG9iamVjdFZhbHVlID0gU2VyaWFs aXplZFNjcmlwdFZhbHVlOjpjcmVhdGVGcm9tV2lyZShzZWxlY3QuZ2V0Q29sdW1uQmxvYkFzU3Ry aW5nKDEpKTsKKyAgICAgICAgUmVmUHRyPElEQktleT4gaW5kZXhLZXkgPSBmZXRjaEtleUZyb21L ZXlQYXRoKG9iamVjdFZhbHVlLmdldCgpLCBpbmRleEtleVBhdGgpOworICAgICAgICBpZiAoIXB1 dEluZGV4RGF0YShkYiwgaW5kZXhLZXkuZ2V0KCksIGluZGV4SWQsIG9iamVjdFN0b3JlRGF0YUlk KSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisKKyAgICByZXR1cm4gdHJ1ZTsK K30KKwogUGFzc1JlZlB0cjxJREJJbmRleEJhY2tlbmRJbnRlcmZhY2U+IElEQk9iamVjdFN0b3Jl QmFja2VuZEltcGw6OmNyZWF0ZUluZGV4KGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3QgU3RyaW5n JiBrZXlQYXRoLCBib29sIHVuaXF1ZSwgSURCVHJhbnNhY3Rpb25CYWNrZW5kSW50ZXJmYWNlKiB0 cmFuc2FjdGlvbiwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7CiAgICAgaWYgKG1faW5kZXhlcy5jb250 YWlucyhuYW1lKSkgewpAQCAtNDYwLDYgKzQ4MCwxMiBAQCB2b2lkIElEQk9iamVjdFN0b3JlQmFj a2VuZEltcGw6OmNyZWF0ZUluZGV4SW50ZXJuYWwoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIFBh cwogICAgIH0KICAgICBpbnQ2NF90IGlkID0gb2JqZWN0U3RvcmUtPnNxbGl0ZURhdGFiYXNlKCku bGFzdEluc2VydFJvd0lEKCk7CiAgICAgaW5kZXgtPnNldElkKGlkKTsKKworICAgIGlmICghcG9w dWxhdGVJbmRleChvYmplY3RTdG9yZS0+c3FsaXRlRGF0YWJhc2UoKSwgb2JqZWN0U3RvcmUtPm1f aWQsIGlkLCBpbmRleC0+a2V5UGF0aCgpKSkgeworICAgICAgICB0cmFuc2FjdGlvbi0+YWJvcnQo KTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKwogICAgIHRyYW5zYWN0aW9uLT5kaWRDb21wbGV0 ZVRhc2tFdmVudHMoKTsKIH0KIAo=