54652 2011-02-17 06:54:02 -0800 REGRESSION (r78522): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_setup_environ_for_server_register_cygwin failing on Apple's Windows port 2011-02-18 14:58:26 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/9468/steps/webkitpy-test/logs/stdio InRadar, PlatformOnly P2 Normal --- 1 aroben dpranke abarth dpranke eric jberlin ojan oldest_to_newest 352826 0 aroben 2011-02-17 06:54:02 -0800 webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_setup_environ_for_server_register_cygwin is failing on Apple's Windows port. See the URL for an example. 352827 1 aroben 2011-02-17 06:55:14 -0800 Looks like this started failing in r78522. Here's the first test run where it failed: http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/25257 352829 2 aroben 2011-02-17 06:57:50 -0800 <rdar://problem/9016939> 353091 3 dpranke 2011-02-17 12:32:28 -0800 I have a patch for this somewhere. I'll try to get it landed this afternoon. 353347 4 82905 dpranke 2011-02-17 19:40:31 -0800 Created attachment 82905 Patch 353348 5 dpranke 2011-02-17 19:41:16 -0800 Note that I'm kinda hijacking this bug. I believe the change in port_testcase fixes this issue, but the fixes to the baseline path are needed somewhere in here as well. 353355 6 82905 aroben 2011-02-17 19:56:14 -0800 Comment on attachment 82905 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82905&action=review > Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py:102 > + def baseline_path(self): > + if self.version() == 'win7': > + return self._webkit_baseline_path('chromium-win') > + return self._webkit_baseline_path(self.name()) Why does win7 need a special case? Seems worth a comment. > Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:44 > + self.results_directory = '/' What effect does this have? Can you explain in the ChangeLog? 353361 7 82908 dpranke 2011-02-17 20:21:15 -0800 Created attachment 82908 Patch 353362 8 dpranke 2011-02-17 20:21:51 -0800 Committed r78943: <http://trac.webkit.org/changeset/78943> 353364 9 dpranke 2011-02-17 20:23:22 -0800 (In reply to comment #6) > (From update of attachment 82905 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=82905&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py:102 > > + def baseline_path(self): > > + if self.version() == 'win7': > > + return self._webkit_baseline_path('chromium-win') > > + return self._webkit_baseline_path(self.name()) > > Why does win7 need a special case? Seems worth a comment. > Done (this is confusingly written in this version, but if version is win7, name is 'chromium-win-win7' and we don't want to use the version-specific directory, since win7 is the newest version. This gets cleaned up in a later patch so I'm not going to sweat it here. > > Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:44 > > + self.results_directory = '/' > > What effect does this have? Can you explain in the ChangeLog? Turns out this didn't need to be set, but the code in port_testcase that was using it was doing something unnecessary that triggered it. I fixed that code instead. 353374 10 82908 ojan 2011-02-17 20:40:39 -0800 Comment on attachment 82908 Patch Clearing review flag since this has been committed. 353771 11 jberlin 2011-02-18 12:55:48 -0800 This test is still failing: http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/9507/steps/webkitpy-test/logs/stdio 353823 12 dpranke 2011-02-18 14:20:07 -0800 so it is ... maybe I only fixed it for win32, and not cygwin. Looking now ... 353851 13 83015 dpranke 2011-02-18 14:51:41 -0800 Created attachment 83015 Patch 353858 14 dpranke 2011-02-18 14:58:26 -0800 Committed r79036: <http://trac.webkit.org/changeset/79036> 82905 2011-02-17 19:40:31 -0800 2011-02-17 20:21:12 -0800 Patch bug-54652-20110217194030.patch text/plain 3554 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogNzg5MzAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2Zjc4MmUyNTM3MDM3NDJjMGUwMGRmMDhhYzVlMDg1MTgz YThkYWE3Li5lMzRjOTRlMmUzYzVlMzYwYWJjOWJlY2U1YTMyNmFhZWI0YWJmNjNiIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTEtMDItMTcgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHZlcnNpb24s IGJhc2VsaW5lX3NlYXJjaF9wYXRoIGZvciBjaHJvbWl1bS13aW4td2luNy4gQWxzbworICAgICAg ICBmaXggY2hyb21pdW1fd2luX3VuaXR0ZXN0cywgYW5kIGZpeCBwb3J0X3Rlc3RjYXNlLm1ha2Vf cG9ydCgpCisgICAgICAgIHRvIGNvcnJlY3RseSB1c2UgdGhlIG9wdGlvbnMgcGFzc2VkIGludG8g aXQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0 NjUyCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9t aXVtX3dpbi5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2Nocm9taXVtX3dpbl91bml0dGVzdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L3BvcnRfdGVzdGNhc2UucHk6CisKKzIwMTEtMDItMTcgIERpcmsgUHJh bmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBW YWZhaS4KIAogICAgICAgICBGaXggYSBoYW5nIGluIG5ldy1ydW4td2Via2l0LXRlc3RzIHdoZW4g cnVuIHdpdGgKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvY2hyb21pdW1fd2luLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9jaHJvbWl1bV93aW4ucHkKaW5kZXggODJkNTIxZjFjZWMyODM4ODY5NjNkMTdiMjYy OWRjMmMyYjg1ZWQxYy4uZGE3Mjk5NDFkYWQzODA1OWMxMjE4MzE1ZGQ0ODRkZDRkZWQ1NGViMiAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJv bWl1bV93aW4ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9jaHJvbWl1bV93aW4ucHkKQEAgLTk2LDYgKzk2LDExIEBAIGNsYXNzIENocm9taXVtV2luUG9y dChjaHJvbWl1bS5DaHJvbWl1bVBvcnQpOgogICAgICAgICAgICAgc2VsZi5fZXhlY3V0aXZlLnJ1 bl9jb21tYW5kKFtzZXR1cF9tb3VudF0pCiAgICAgICAgIHJldHVybiBlbnYKIAorICAgIGRlZiBi YXNlbGluZV9wYXRoKHNlbGYpOgorICAgICAgICBpZiBzZWxmLnZlcnNpb24oKSA9PSAnd2luNyc6 CisgICAgICAgICAgICByZXR1cm4gc2VsZi5fd2Via2l0X2Jhc2VsaW5lX3BhdGgoJ2Nocm9taXVt LXdpbicpCisgICAgICAgIHJldHVybiBzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aChzZWxmLm5h bWUoKSkKKwogICAgIGRlZiBiYXNlbGluZV9zZWFyY2hfcGF0aChzZWxmKToKICAgICAgICAgcG9y dF9uYW1lcyA9IHNlbGYuRkFMTEJBQ0tfUEFUSFNbc2VsZi52ZXJzaW9uKCldCiAgICAgICAgIHJl dHVybiBtYXAoc2VsZi5fd2Via2l0X2Jhc2VsaW5lX3BhdGgsIHBvcnRfbmFtZXMpCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dp bl91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv Y2hyb21pdW1fd2luX3VuaXR0ZXN0LnB5CmluZGV4IDkwYmMzOGFiZGUyMzk0YTkyOGEzZWNhNDA0 ZGQ0ZTZkNjhkNmI4NmEuLjIzMzIwYmM5MmIzMDMxMmEzYWJkNmI5YjhiYTY4ZTZiMmZhOTljNjYg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hy b21pdW1fd2luX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvY2hyb21pdW1fd2luX3VuaXR0ZXN0LnB5CkBAIC00MSw2ICs0MSw3IEBAIGNs YXNzIENocm9taXVtV2luVGVzdChwb3J0X3Rlc3RjYXNlLlBvcnRUZXN0Q2FzZSk6CiAgICAgY2xh c3MgUmVnaXN0ZXJDeWd3aW5PcHRpb24ob2JqZWN0KToKICAgICAgICAgZGVmIF9faW5pdF9fKHNl bGYpOgogICAgICAgICAgICAgc2VsZi5yZWdpc3Rlcl9jeWd3aW4gPSBUcnVlCisgICAgICAgICAg ICBzZWxmLnJlc3VsdHNfZGlyZWN0b3J5ID0gJy8nCiAKICAgICBkZWYgc2V0VXAoc2VsZik6CiAg ICAgICAgIHNlbGYub3JpZ19wbGF0Zm9ybSA9IHN5cy5wbGF0Zm9ybQpAQCAtOTQsNyArOTUsNyBA QCBjbGFzcyBDaHJvbWl1bVdpblRlc3QocG9ydF90ZXN0Y2FzZS5Qb3J0VGVzdENhc2UpOgogCiAg ICAgZGVmIHRlc3RfdmVyc2lvbnMoc2VsZik6CiAgICAgICAgIHBvcnQgPSBjaHJvbWl1bV93aW4u Q2hyb21pdW1XaW5Qb3J0KCkKLSAgICAgICAgc2VsZi5hc3NlcnRUcnVlKHBvcnQubmFtZSgpIGlu ICgnY2hyb21pdW0td2luLXhwJywgJ2Nocm9taXVtLXdpbi12aXN0YScsICdjaHJvbWl1bS13aW4t NycpKQorICAgICAgICBzZWxmLmFzc2VydFRydWUocG9ydC5uYW1lKCkgaW4gKCdjaHJvbWl1bS13 aW4teHAnLCAnY2hyb21pdW0td2luLXZpc3RhJywgJ2Nocm9taXVtLXdpbi13aW43JykpCiAKICAg ICAgICAgc2VsZi5hc3NlcnRfbmFtZShOb25lLCAoNSwgMSksICdjaHJvbWl1bS13aW4teHAnKQog ICAgICAgICBzZWxmLmFzc2VydF9uYW1lKCdjaHJvbWl1bS13aW4nLCAoNSwgMSksICdjaHJvbWl1 bS13aW4teHAnKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9wb3J0X3Rlc3RjYXNlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9wb3J0X3Rlc3RjYXNlLnB5CmluZGV4IGNhNTIzODVjYjZkYzk0YjZmZWNmZjYw NTkxOGVkYWJiMzg0YmZmMDQuLjBiZjkwZmE0MzA1MGQ1NmJhMDQxNjEzMWNlNTA4NDIxYzk0YWU5 NmUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv cG9ydF90ZXN0Y2FzZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L3BvcnRfdGVzdGNhc2UucHkKQEAgLTU0LDcgKzU0LDcgQEAgY2xhc3MgUG9ydFRlc3RD YXNlKHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgaWYgbm90IG1ha2VyOgogICAgICAgICAg ICAgcmV0dXJuIE5vbmUKIAotICAgICAgICBwb3J0ID0gbWFrZXIob3B0aW9ucz1tb2NrX29wdGlv bnMpCisgICAgICAgIHBvcnQgPSBtYWtlcihvcHRpb25zPW9wdGlvbnMpCiAgICAgICAgIHBvcnQu X29wdGlvbnMucmVzdWx0c19kaXJlY3RvcnkgPSBwb3J0LnJlc3VsdHNfZGlyZWN0b3J5KCkKICAg ICAgICAgcmV0dXJuIHBvcnQKIAo= 82908 2011-02-17 20:21:15 -0800 2011-02-18 14:51:38 -0800 Patch bug-54652-20110217202114.patch text/plain 3845 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogNzg5NDAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2Zjc4MmUyNTM3MDM3NDJjMGUwMGRmMDhhYzVlMDg1MTgz YThkYWE3Li4xNTE2ZGJiYjZlMDM5MzlhYTQ1NzJkYWQ3NGQ1OTEyNGVjODY2YmYyIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTEtMDItMTcgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KKworICAgICAgICBGaXggdmVyc2lvbiwgYmFz ZWxpbmVfc2VhcmNoX3BhdGggZm9yIGNocm9taXVtLXdpbi13aW43LiBBbHNvCisgICAgICAgIGZp eCBjaHJvbWl1bV93aW5fdW5pdHRlc3RzLCBhbmQgZml4IHBvcnRfdGVzdGNhc2UubWFrZV9wb3J0 KCkKKyAgICAgICAgdG8gY29ycmVjdGx5IHVzZSB0aGUgb3B0aW9ucyBwYXNzZWQgaW50byBpdCBh bmQgb25seSBzZXQKKyAgICAgICAgcmVzdWx0c19kaXJlY3RvcnkoKSBpZiBuZWNlc3NhcnkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0NjUyCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dp bi5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9t aXVtX3dpbl91bml0dGVzdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L3BvcnRfdGVzdGNhc2UucHk6CisKKzIwMTEtMDItMTcgIERpcmsgUHJhbmtlICA8 ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBWYWZhaS4K IAogICAgICAgICBGaXggYSBoYW5nIGluIG5ldy1ydW4td2Via2l0LXRlc3RzIHdoZW4gcnVuIHdp dGgKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv Y2hyb21pdW1fd2luLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9jaHJvbWl1bV93aW4ucHkKaW5kZXggODJkNTIxZjFjZWMyODM4ODY5NjNkMTdiMjYyOWRjMmMy Yjg1ZWQxYy4uYTBhY2NlYzg5YWM5YWJhYmI4NjQyZTBjODE4ZDcyZDEzMjlkZGY5ZSAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93 aW4ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJv bWl1bV93aW4ucHkKQEAgLTk2LDYgKzk2LDEyIEBAIGNsYXNzIENocm9taXVtV2luUG9ydChjaHJv bWl1bS5DaHJvbWl1bVBvcnQpOgogICAgICAgICAgICAgc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21t YW5kKFtzZXR1cF9tb3VudF0pCiAgICAgICAgIHJldHVybiBlbnYKIAorICAgIGRlZiBiYXNlbGlu ZV9wYXRoKHNlbGYpOgorICAgICAgICBpZiBzZWxmLnZlcnNpb24oKSA9PSAnd2luNyc6CisgICAg ICAgICAgICAjIFdpbiA3IGlzIHRoZSBuZXdlc3QgdmVyc2lvbiBvZiB3aW5kb3dzLCBzbyBpdCBn ZXRzIHRoZSBiYXNlIGRpci4KKyAgICAgICAgICAgIHJldHVybiBzZWxmLl93ZWJraXRfYmFzZWxp bmVfcGF0aCgnY2hyb21pdW0td2luJykKKyAgICAgICAgcmV0dXJuIHNlbGYuX3dlYmtpdF9iYXNl bGluZV9wYXRoKHNlbGYubmFtZSgpKQorCiAgICAgZGVmIGJhc2VsaW5lX3NlYXJjaF9wYXRoKHNl bGYpOgogICAgICAgICBwb3J0X25hbWVzID0gc2VsZi5GQUxMQkFDS19QQVRIU1tzZWxmLnZlcnNp b24oKV0KICAgICAgICAgcmV0dXJuIG1hcChzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCwgcG9y dF9uYW1lcykKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvY2hyb21pdW1fd2luX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW5fdW5pdHRlc3QucHkKaW5kZXggOTBiYzM4YWJk ZTIzOTRhOTI4YTNlY2E0MDRkZDRlNmQ2OGQ2Yjg2YS4uMjMzMjBiYzkyYjMwMzEyYTNhYmQ2Yjli OGJhNjhlNmIyZmE5OWM2NiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW5fdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW5fdW5pdHRlc3QucHkKQEAg LTQxLDYgKzQxLDcgQEAgY2xhc3MgQ2hyb21pdW1XaW5UZXN0KHBvcnRfdGVzdGNhc2UuUG9ydFRl c3RDYXNlKToKICAgICBjbGFzcyBSZWdpc3RlckN5Z3dpbk9wdGlvbihvYmplY3QpOgogICAgICAg ICBkZWYgX19pbml0X18oc2VsZik6CiAgICAgICAgICAgICBzZWxmLnJlZ2lzdGVyX2N5Z3dpbiA9 IFRydWUKKyAgICAgICAgICAgIHNlbGYucmVzdWx0c19kaXJlY3RvcnkgPSAnLycKIAogICAgIGRl ZiBzZXRVcChzZWxmKToKICAgICAgICAgc2VsZi5vcmlnX3BsYXRmb3JtID0gc3lzLnBsYXRmb3Jt CkBAIC05NCw3ICs5NSw3IEBAIGNsYXNzIENocm9taXVtV2luVGVzdChwb3J0X3Rlc3RjYXNlLlBv cnRUZXN0Q2FzZSk6CiAKICAgICBkZWYgdGVzdF92ZXJzaW9ucyhzZWxmKToKICAgICAgICAgcG9y dCA9IGNocm9taXVtX3dpbi5DaHJvbWl1bVdpblBvcnQoKQotICAgICAgICBzZWxmLmFzc2VydFRy dWUocG9ydC5uYW1lKCkgaW4gKCdjaHJvbWl1bS13aW4teHAnLCAnY2hyb21pdW0td2luLXZpc3Rh JywgJ2Nocm9taXVtLXdpbi03JykpCisgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShwb3J0Lm5hbWUo KSBpbiAoJ2Nocm9taXVtLXdpbi14cCcsICdjaHJvbWl1bS13aW4tdmlzdGEnLCAnY2hyb21pdW0t d2luLXdpbjcnKSkKIAogICAgICAgICBzZWxmLmFzc2VydF9uYW1lKE5vbmUsICg1LCAxKSwgJ2No cm9taXVtLXdpbi14cCcpCiAgICAgICAgIHNlbGYuYXNzZXJ0X25hbWUoJ2Nocm9taXVtLXdpbics ICg1LCAxKSwgJ2Nocm9taXVtLXdpbi14cCcpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3BvcnRfdGVzdGNhc2UucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3BvcnRfdGVzdGNhc2UucHkKaW5kZXggY2E1MjM4 NWNiNmRjOTRiNmZlY2ZmNjA1OTE4ZWRhYmIzODRiZmYwNC4uYjNhYjk1M2UyYTEyNjY2ZGYwMWIz ZmYxZjg1Zjg3YTQwZGYxZDQ3NyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9wb3J0X3Rlc3RjYXNlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcG9ydF90ZXN0Y2FzZS5weQpAQCAtNTQsOCArNTQsOSBA QCBjbGFzcyBQb3J0VGVzdENhc2UodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBpZiBub3Qg bWFrZXI6CiAgICAgICAgICAgICByZXR1cm4gTm9uZQogCi0gICAgICAgIHBvcnQgPSBtYWtlcihv cHRpb25zPW1vY2tfb3B0aW9ucykKLSAgICAgICAgcG9ydC5fb3B0aW9ucy5yZXN1bHRzX2RpcmVj dG9yeSA9IHBvcnQucmVzdWx0c19kaXJlY3RvcnkoKQorICAgICAgICBwb3J0ID0gbWFrZXIob3B0 aW9ucz1vcHRpb25zKQorICAgICAgICBpZiBoYXNhdHRyKG9wdGlvbnMsICJyZXN1bHRzX2RpcmVj dG9yeSIpOgorICAgICAgICAgICAgcG9ydC5fb3B0aW9ucy5yZXN1bHRzX2RpcmVjdG9yeSA9IHBv cnQucmVzdWx0c19kaXJlY3RvcnkoKQogICAgICAgICByZXR1cm4gcG9ydAogCiAgICAgZGVmIHRl c3RfZHJpdmVyX2NtZF9saW5lKHNlbGYpOgo= 83015 2011-02-18 14:51:41 -0800 2011-02-18 14:54:22 -0800 Patch bug-54652-20110218145140.patch text/plain 1689 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogNzkwMzUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0YTFkYTg0ZmIyZjZmYjE4ZDhiOGU0NGVlYWI0ZWEzNjJl ZDAxMTliLi45OTg0NGZlZjYzZDg1MWZlM2ZkMTRjMTkwOWM5ZmFlZmRhYzk5NWU0IDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYg QEAKIDIwMTEtMDItMTggIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjc4NDk0IGZpeGVk IHRoZSBjaHJvbWl1bV93aW4gdW5pdHRlc3QgZmFpbGluZyB1bmRlciB3aW4zMiwKKyAgICAgICAg YnV0IG5vdCBjeWd3aW4uIFRoaXMgZml4ZXMgY3lnd2luIGFzIHdlbGwuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0NjUyCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX3dpbi5weToKKworMjAx MS0wMi0xOCAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAgICAgICBS ZXZpZXdlZCBieSBPamFuIFZhZmFpLCBNaWhhaSBQYXJwYXJpdGEuCiAKICAgICAgICAgbmV3LXJ1 bi13ZWJraXQtdGVzdHM6IHI3ODUyMiBtYWRlIGl0IGltcG9zc2libGUgdG8gY3JlYXRlIGEKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21p dW1fd2luLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJv bWl1bV93aW4ucHkKaW5kZXggN2VhNjM3OTg4YmQ0ODUxNmZiYjkyMWM3NzU2ZDY1MDlkNzJhNjg4 OS4uZTdjNmU0OTdjZjdmYzc5OTZjOTAwMTg1MTdkMDFhZmRmYTVjOWVjMCAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93aW4ucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV93 aW4ucHkKQEAgLTEwMiw3ICsxMDIsNyBAQCBjbGFzcyBDaHJvbWl1bVdpblBvcnQoY2hyb21pdW0u Q2hyb21pdW1Qb3J0KToKICAgICAgICAgIyBweXRob24gZXhlY3V0YWJsZSB0byBydW4gY2dpIHBy b2dyYW0uCiAgICAgICAgIGVudlsiQ1lHV0lOX1BBVEgiXSA9IHNlbGYucGF0aF9mcm9tX2Nocm9t aXVtX2Jhc2UoCiAgICAgICAgICAgICAidGhpcmRfcGFydHkiLCAiY3lnd2luIiwgImJpbiIpCi0g ICAgICAgIGlmIChzeXMucGxhdGZvcm0gPT0gIndpbjMyIiBhbmQgc2VsZi5nZXRfb3B0aW9uKCdy ZWdpc3Rlcl9jeWd3aW4nKSk6CisgICAgICAgIGlmIChzeXMucGxhdGZvcm0gaW4gKCJjeWd3aW4i LCAid2luMzIiKSBhbmQgc2VsZi5nZXRfb3B0aW9uKCdyZWdpc3Rlcl9jeWd3aW4nKSk6CiAgICAg ICAgICAgICBzZXR1cF9tb3VudCA9IHNlbGYucGF0aF9mcm9tX2Nocm9taXVtX2Jhc2UoInRoaXJk X3BhcnR5IiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAiY3lnd2luIiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAic2V0dXBfbW91bnQuYmF0IikK