54650 2011-02-17 06:50:47 -0800 check-webkit-style falsely complains about WebKitGTK+ public headers 2011-02-18 21:52:09 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Major --- 1 christian webkit-unassigned commit-queue hamaji levin oldest_to_newest 352823 0 christian 2011-02-17 06:50:47 -0800 Source/WebKit/gtk/webkit/webkitwebgroup.h:52: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit/gtk/webkit/webkitwebgroup.h:56: WEBKIT_API should only appear in the chromium public directory. [readability/webkit_api] [5] Source/WebKit/gtk/webkit/webkitwebgroup.h:62: The parameter name "web_group" adds no information, so it should be removed. [readability/parameter_name] [5] These are all false positives. 353707 1 82987 levin 2011-02-18 11:37:52 -0800 Created attachment 82987 Patch 353758 2 82987 eric 2011-02-18 12:41:12 -0800 Comment on attachment 82987 Patch OK. 354055 3 82987 commit-queue 2011-02-18 21:52:05 -0800 Comment on attachment 82987 Patch Clearing flags on attachment: 82987 Committed r79095: <http://trac.webkit.org/changeset/79095> 354056 4 commit-queue 2011-02-18 21:52:09 -0800 All reviewed patches have been landed. Closing bug. 82987 2011-02-18 11:37:52 -0800 2011-02-18 21:52:04 -0800 Patch bug-54650-20110218113751.patch text/plain 6650 levin U3VidmVyc2lvbiBSZXZpc2lvbjogNzkwMTIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhOWU0YjgwMzQ4NzAzMDc5NmEyYWVhZWU2ZjFiOWFhMDk3 NTc2ODRiLi5iY2JkYTU1OWY1M2U0NzVmODcxYzYwM2VlYjUzOTIyOWZiYTI0ZTcxIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDItMTggIERhdmlkIExldmluICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1z dHlsZSBmYWxzZWx5IGNvbXBsYWlucyBhYm91dCBXZWJLaXRHVEsrIHB1YmxpYyBoZWFkZXJzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDY1MAorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5OiBBZGQgc29tZSBleGNl cHRpb25zIGZvciB0aGUgZ3RrIGZpbGVzLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcnMvY3BwLnB5OiBSZXN0cmljdCB0aGUgY2hlY2tzIGZvciBXRUJLSVRfQVBJCisg ICAgICAgICAgdG8gdGhlIGNocm9taXVtIGRpcmVjdG9yeSAoYW5kIGltcHJvdmVkIHRoZSBjaGVj a3Mgc2xpZ2h0bHkpLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwX3VuaXR0ZXN0LnB5OiBBZGRlZCBjb3JyZXNwb25kaW5nIHRlc3RzLgorCiAyMDExLTAyLTE2 ICBNT1JJVEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2VyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5Cmlu ZGV4IDIzYjlhYjMzMmQzYjBlZmQzOTdjOWVmMTI2NWNiMjgyYjA1ZDQzOGUuLjhmM2VkYTRlMjVj MDI2NWI0MjU3NmJjNDA2N2RlN2U2MmVhNGNhOWIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXIucHkKQEAgLTE0NCwxMyArMTQ0LDE2IEBAIF9QQVRIX1JVTEVTX1NQRUNJRklF UiA9IFsKICAgICAgICAiVG9vbHMvTWluaUJyb3dzZXIvcXQiXSwKICAgICAgIFsiLWJ1aWxkL2lu Y2x1ZGUiXSksCiAgICAgKFsjIFRoZSBHVEsrIEFQSXMgdXNlIEdUSysgbmFtaW5nIHN0eWxlLCB3 aGljaCBpbmNsdWRlcwotICAgICAgIyBsb3dlci1jYXNlZCwgdW5kZXJzY29yZS1zZXBhcmF0ZWQg dmFsdWVzLgorICAgICAgIyBsb3dlci1jYXNlZCwgdW5kZXJzY29yZS1zZXBhcmF0ZWQgdmFsdWVz LCB3aGl0ZXNwYWNlIGJlZm9yZQorICAgICAgIyBwYXJlbnMgZm9yIGZ1bmN0aW9uIGNhbGxzLCBh bmQgYWx3YXlzIGhhdmluZyB2YXJpYWJsZSBuYW1lcy4KICAgICAgICMgQWxzbywgR1RLKyBhbGxv d3MgdGhlIHVzZSBvZiBOVUxMLgogICAgICAgIlNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvdGVzdC9HT2JqZWN0IiwKLSAgICAgICJXZWJLaXQvZ3RrL3dlYmtpdC8iLAorICAgICAgIlNv dXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC8iLAogICAgICAgIlRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0 ay8iXSwKICAgICAgWyItcmVhZGFiaWxpdHkvbmFtaW5nIiwKLSAgICAgICItcmVhZGFiaWxpdHkv bnVsbCJdKSwKKyAgICAgICItcmVhZGFiaWxpdHkvcGFyYW1ldGVyX25hbWUiLAorICAgICAgIi1y ZWFkYWJpbGl0eS9udWxsIiwKKyAgICAgICItd2hpdGVzcGFjZS9wYXJlbnMiXSksCiAgICAgKFsj IEhlYWRlciBmaWxlcyBpbiBGb3J3YXJkaW5nSGVhZGVycyBoYXZlIG5vIGhlYWRlciBndWFyZHMg b3IKICAgICAgICMgZXhjZXB0aW9uYWwgaGVhZGVyIGd1YXJkcyAoZS5nLiwgV2ViQ29yZV9GV0Rf RGVidWdnZXJfaCkuCiAgICAgICAiL0ZvcndhcmRpbmdIZWFkZXJzLyJdLApkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCBmMTZmZmZmMzIzZmI5Mjk1 YTk4MWMwYjczNTFlZDYzODViZjZkMGI3Li43ZGMxOWI4MmM5ODg2NWMzNGE4YzRhODZlMWMzNGQ3 MjIzMDM4YjNhIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2Nw cC5weQpAQCAtMTU4Miw4ICsxNTgyLDggQEAgZGVmIGNoZWNrX2Z1bmN0aW9uX2RlZmluaXRpb24o ZmlsZW5hbWUsIGZpbGVfZXh0ZW5zaW9uLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIKICAgICAg ICAgcmV0dXJuCiAKICAgICBtb2RpZmllcnNfYW5kX3JldHVybl90eXBlID0gZnVuY3Rpb25fc3Rh dGUubW9kaWZpZXJzX2FuZF9yZXR1cm5fdHlwZSgpCi0gICAgaWYgc2VhcmNoKHInXGJXRUJLSVRf QVBJXGInLCBtb2RpZmllcnNfYW5kX3JldHVybl90eXBlKToKLSAgICAgICAgaWYgZmlsZW5hbWUu ZmluZCgnY2hyb21pdW0vcHVibGljLycpID09IC0xOgorICAgIGlmIGZpbGVuYW1lLmZpbmQoJy9j aHJvbWl1bS8nKSAhPSAtMSBhbmQgc2VhcmNoKHInXGJXRUJLSVRfQVBJXGInLCBtb2RpZmllcnNf YW5kX3JldHVybl90eXBlKToKKyAgICAgICAgaWYgZmlsZW5hbWUuZmluZCgnL2Nocm9taXVtL3B1 YmxpYy8nKSA9PSAtMToKICAgICAgICAgICAgIGVycm9yKGZ1bmN0aW9uX3N0YXRlLmZ1bmN0aW9u X25hbWVfc3RhcnRfcG9zaXRpb24ucm93LCAncmVhZGFiaWxpdHkvd2Via2l0X2FwaScsIDUsCiAg ICAgICAgICAgICAgICAgICAnV0VCS0lUX0FQSSBzaG91bGQgb25seSBhcHBlYXIgaW4gdGhlIGNo cm9taXVtIHB1YmxpYyBkaXJlY3RvcnkuJykKICAgICAgICAgZWxpZiBub3QgZmlsZV9leHRlbnNp b24gPT0gImgiOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHBfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcF91bml0dGVzdC5weQppbmRleCA4NzdhNjJkZDJiNDAxYTVkYmQxYjA1YjQ5MGQ2ZmVm MjYxYmQ3OWNkLi5iZmViMmJmZjBlMmEyNmUzNzNhNjFiODhiNTVmYjNlNzY5NDg0NGZmIDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVz dC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0 dGVzdC5weQpAQCAtNDMzNywyNSArNDMzNywyNSBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3Bw U3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJytyZWFk YWJpbGl0eS93ZWJraXRfYXBpJykKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoJycsCiAgICAg ICAgICAgICAgICAgICAgICAgICAgIHNlbGYucGVyZm9ybV9saW50KCdXRUJLSVRfQVBJIGludCBm b28oKTtcbicsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdj aHJvbWl1bS9wdWJsaWMvdGVzdC5oJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJ1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvdGVzdC5oJywKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgd2Via2l0X2FwaV9lcnJvcl9ydWxlcykp CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKCdXRUJLSVRfQVBJIHNob3VsZCBvbmx5IGJlIHVz ZWQgaW4gaGVhZGVyIGZpbGVzLiAgW3JlYWRhYmlsaXR5L3dlYmtpdF9hcGldIFs1XScsCiAgICAg ICAgICAgICAgICAgICAgICAgICAgIHNlbGYucGVyZm9ybV9saW50KCdXRUJLSVRfQVBJIGludCBm b28oKTtcbicsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdj aHJvbWl1bS9wdWJsaWMvdGVzdC5jcHAnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAnV2ViS2l0L2Nocm9taXVtL3B1YmxpYy90ZXN0LmNwcCcsCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHdlYmtpdF9hcGlfZXJyb3JfcnVs ZXMpKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFscygnV0VCS0lUX0FQSSBzaG91bGQgb25seSBh cHBlYXIgaW4gdGhlIGNocm9taXVtIHB1YmxpYyBkaXJlY3RvcnkuICBbcmVhZGFiaWxpdHkvd2Vi a2l0X2FwaV0gWzVdJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5wZXJmb3JtX2xp bnQoJ1dFQktJVF9BUEkgaW50IGZvbygpO1xuJywKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgJ290aGVyL3NyYy90ZXN0LmgnLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAnV2ViS2l0L2Nocm9taXVtL3NyYy90ZXN0LmgnLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3ZWJraXRfYXBpX2Vy cm9yX3J1bGVzKSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoJ1dFQktJVF9BUEkgc2hvdWxk IG5vdCBiZSB1c2VkIG9uIGEgZnVuY3Rpb24gd2l0aCBhIGJvZHkuICBbcmVhZGFiaWxpdHkvd2Vi a2l0X2FwaV0gWzVdJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5wZXJmb3JtX2xp bnQoJ1dFQktJVF9BUEkgaW50IGZvbygpIHsgfVxuJywKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgJ2Nocm9taXVtL3B1YmxpYy90ZXN0LmgnLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy90ZXN0LmgnLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3 ZWJraXRfYXBpX2Vycm9yX3J1bGVzKSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoJ1dFQktJ VF9BUEkgc2hvdWxkIG5vdCBiZSB1c2VkIG9uIGEgZnVuY3Rpb24gd2l0aCBhIGJvZHkuICBbcmVh ZGFiaWxpdHkvd2Via2l0X2FwaV0gWzVdJywKICAgICAgICAgICAgICAgICAgICAgICAgICAgc2Vs Zi5wZXJmb3JtX2xpbnQoJ1dFQktJVF9BUEkgaW5saW5lIGludCBmb28oKVxuJwogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAne1xuJwogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnfVxuJywKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgJ2Nocm9taXVtL3B1YmxpYy90ZXN0LmgnLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAnV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy90ZXN0LmgnLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB3ZWJraXRfYXBpX2Vycm9yX3J1bGVzKSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoJ1dF QktJVF9BUEkgc2hvdWxkIG5vdCBiZSB1c2VkIHdpdGggYSBwdXJlIHZpcnR1YWwgZnVuY3Rpb24u ICBbcmVhZGFiaWxpdHkvd2Via2l0X2FwaV0gWzVdJywKICAgICAgICAgICAgICAgICAgICAgICAg ICAgc2VsZi5wZXJmb3JtX2xpbnQoJ3t9XG4nCkBAIC00MzYzLDcgKzQzNjMsMTUgQEAgY2xhc3Mg V2ViS2l0U3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAndmlydHVhbFxuJwogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAnaW50XG4nCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICdmb28oKSA9IDA7XG4nLAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAnY2hyb21pdW0vcHVibGljL3Rlc3QuaCcsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdXZWJLaXQvY2hyb21pdW0vcHVi bGljL3Rlc3QuaCcsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHdlYmtpdF9hcGlfZXJyb3JfcnVsZXMpKQorICAgICAgICBzZWxmLmFzc2VydEVxdWFscygnJywK KyAgICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5wZXJmb3JtX2xpbnQoJ3t9XG4nCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdXRUJLSVRfQVBJXG4nCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICd2aXJ0dWFsXG4nCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdpbnRcbicKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2ZvbygpID0gMDtcbicsCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICd0ZXN0LmgnLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB3ZWJraXRfYXBpX2Vycm9y X3J1bGVzKSkKIAogICAgIGRlZiB0ZXN0X290aGVyKHNlbGYpOgo=