5465 2005-10-23 02:59:18 -0700 REGRESSION: check box onchange event doesn't fire (radio buttons do not get disabled in Bugzilla) 2005-12-14 11:06:05 -0800 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 VERIFIED FIXED P1 Normal --- 1 ap adele bdakin oldest_to_newest 22531 0 ap 2005-10-23 02:59:18 -0700 Radio buttons for content-type are supposed to be disabled for patches in Bugzilla, but they aren't. Steps to reproduce: 1. Click "Create a New Attachment" link for this (any) bug report. 2. Click "patch" checkbox. Expected results: the radio buttons below should get disabled Results: they aren't. Works fine in 2.0.1. This has regressed quite a while ago (a couple of months, perhaps). 24121 1 adele 2005-11-15 15:37:24 -0800 I think the checkbox's onchange event isn't getting fired. 24122 2 4693 adele 2005-11-15 16:17:42 -0800 Created attachment 4693 Patch to call onChange() after a radio button or a checkbox is checked 24123 3 4693 adele 2005-11-15 16:19:59 -0800 Comment on attachment 4693 Patch to call onChange() after a radio button or a checkbox is checked Dave- I saw that in onchange, you had this comment: "// ### make this work with new form events architecture" ... So I wasn't sure if this is too limited of a fix. But it definitely cures the symptom. 24124 4 4694 adele 2005-11-15 16:24:57 -0800 Created attachment 4694 layout test for checkbox onchange. attaching layout test 24126 5 hyatt 2005-11-15 17:15:59 -0800 Not sure what the layout test is trying to illustrate. onchange doesn't fire in Safari 2.0 or Firefox for that test case. 24127 6 4693 hyatt 2005-11-15 17:16:19 -0800 Comment on attachment 4693 Patch to call onChange() after a radio button or a checkbox is checked I don't think the timing of onchange is right here. 24128 7 adele 2005-11-15 17:21:04 -0800 weird, I see onchange fire (and the test case pass) for Safari 2.0.2 and FF, but not on TOT. 25766 8 4693 darin 2005-12-10 08:12:53 -0800 Comment on attachment 4693 Patch to call onChange() after a radio button or a checkbox is checked Dave, the test case *does* fire an onchange event in Firefox. You should reconsider. I think this patch is correct. 25932 9 mjs 2005-12-13 22:11:03 -0800 This patch needs copyright notice, test case included in patch, and ChangeLog entry to comply with WebKit patch submission guidelines. Otherwise the change looks correct to me (I can confirm that the test case passes in Firefox and Safari 2.0.2 but fails in TOT Safari). 25933 10 4693 mjs 2005-12-13 22:11:45 -0800 Comment on attachment 4693 Patch to call onChange() after a radio button or a checkbox is checked I hate to r- a correct-looking one-liner over technicalities but them's the rules. In case of emergency we'd probably merge this anyway. 25936 11 5073 adele 2005-12-13 23:40:00 -0800 Created attachment 5073 updated patch here's an updated patch w/ changelog 25937 12 5074 adele 2005-12-13 23:41:00 -0800 Created attachment 5074 new testcase also tests radio buttons now too 4693 2005-11-15 16:17:42 -0800 2005-12-13 23:40:00 -0800 Patch to call onChange() after a radio button or a checkbox is checked patch_onchange.txt text/plain 597 adele SW5kZXg6IGtodG1sL2h0bWwvaHRtbF9mb3JtaW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog L2N2cy9yb290L1dlYkNvcmUva2h0bWwvaHRtbC9odG1sX2Zvcm1pbXBsLmNwcCx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4yMDMKZGlmZiAtdSAtcjEuMjAzIGh0bWxfZm9ybWltcGwuY3BwCi0tLSBr aHRtbC9odG1sL2h0bWxfZm9ybWltcGwuY3BwCTExIE5vdiAyMDA1IDAyOjE1OjM1IC0wMDAwCTEu MjAzCisrKyBraHRtbC9odG1sL2h0bWxfZm9ybWltcGwuY3BwCTE2IE5vdiAyMDA1IDAwOjE1OjU2 IC0wMDAwCkBAIC0yMTM1LDYgKzIxMzUsNyBAQAogICAgIHNldENoYW5nZWQoKTsKICAgICBpZiAo cmVuZGVyZXIoKSAmJiByZW5kZXJlcigpLT5zdHlsZSgpLT5oYXNBcHBlYXJhbmNlKCkpCiAgICAg ICAgIHRoZW1lKCktPnN0YXRlQ2hhbmdlZChyZW5kZXJlcigpLCBDaGVja2VkU3RhdGUpOworICAg IG9uQ2hhbmdlKCk7CiB9CiAKIHZvaWQgSFRNTElucHV0RWxlbWVudEltcGw6OnNldEluZGV0ZXJt aW5hdGUoYm9vbCBfaW5kZXRlcm1pbmF0ZSkK 4694 2005-11-15 16:24:57 -0800 2005-12-13 23:41:00 -0800 layout test for checkbox onchange. checkbox_onchange.html text/html 323 adele PGh0bWw+Cjxib2R5IG9ubG9hZD0iZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NoJykuY2xpY2so KSI+ClRoaXMgaXMgdG8gdGVzdCBvbmNoYW5nZSBvZiBjaGVja2JveGVzLgo8YnI+CjxpbnB1dCB0 eXBlPSJjaGVja2JveCIgaWQ9ImNoIiBvbmNoYW5nZT0iZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J3Jlc3VsdCcpLmlubmVySFRNTCA9ICdUZXN0IFBhc3NlZC4gb25DaGFuZ2UgZXZlbnQgZmlyZWQu XG4nIj5DaGVja2JveDwvaW5wdXQ+CjxkaXYgaWQ9InJlc3VsdCI+VGVzdCBGYWlsZWQuIG9uQ2hh bmdlIGRpZG4ndCBmaXJlLjwvZGl2Pgo8L2JvZHk+CjwvaHRtbD4= 5073 2005-12-13 23:40:00 -0800 2005-12-13 23:44:17 -0800 updated patch check.txt text/plain 2894 adele SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9D aGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNTI2CmRpZmYgLXUgLXIxLjUyNiBDaGFu Z2VMb2cKLS0tIENoYW5nZUxvZwkxNCBEZWMgMjAwNSAwMjoyMTo1OCAtMDAwMAkxLjUyNgorKysg Q2hhbmdlTG9nCTE0IERlYyAyMDA1IDA3OjM1OjQzIC0wMDAwCkBAIC0xLDMgKzEsMTcgQEAKKzIw MDUtMTItMTMgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cDovL2J1Z3pp bGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD01NDY1CisgICAgICAgIFJFR1JFU1NJ T046IGNoZWNrIGJveCBvbmNoYW5nZSBldmVudCBkb2Vzbid0IGZpcmUgKHJhZGlvIGJ1dHRvbnMg ZG8gbm90IGdldCBkaXNhYmxlZCBpbiBCdWd6aWxsYSkKKworICAgICAgICBUZXN0OiBmYXN0L2Zv cm1zL2NoZWNrYm94LXJhZGlvLW9uY2hhbmdlLmh0bWwKKworICAgICAgICAqIGtodG1sL2h0bWwv aHRtbF9mb3JtaW1wbC5jcHA6CisgICAgICAgIChET006OkhUTUxJbnB1dEVsZW1lbnRJbXBsOjpz ZXRDaGVja2VkKTogY2FsbCBvbkNoYW5nZSBhZnRlciBzZXR0aW5nIHRoZSBjaGVja2VkIHN0YXRl LiAgCisgICAgICAgIFRoaXMgd2lsbCBtYXRjaCBvdXIgb2xkIGJlaGF2aW9yLCBhbmQgRmlyZWZv eCBiZWhhdmlvci4gIAorICAgICAgICBUaGlzIHdpbGwgYWxzbyBmaXJlIG9uQ2hhbmdlIGZvciBy YWRpbyBidXR0b25zIHdoaWNoIG1hdGNoZXMgRmlyZWZveCBiZWhhdmlvci4KKwogMjAwNS0xMi0x MyAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg SHlhdHQgYW5kIERhcmluLgpJbmRleDoga2h0bWwvaHRtbC9odG1sX2Zvcm1pbXBsLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC9odG1sL2h0bWxfZm9ybWlt cGwuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjIwNwpkaWZmIC11IC1yMS4yMDcgaHRtbF9m b3JtaW1wbC5jcHAKLS0tIGtodG1sL2h0bWwvaHRtbF9mb3JtaW1wbC5jcHAJMTIgRGVjIDIwMDUg MTk6MjI6MTUgLTAwMDAJMS4yMDcKKysrIGtodG1sL2h0bWwvaHRtbF9mb3JtaW1wbC5jcHAJMTQg RGVjIDIwMDUgMDc6MzY6MDMgLTAwMDAKQEAgLTQsNyArNCw3IEBACiAgKiBDb3B5cmlnaHQgKEMp IDE5OTkgTGFycyBLbm9sbCAoa25vbGxAa2RlLm9yZykKICAqICAgICAgICAgICAoQykgMTk5OSBB bnR0aSBLb2l2aXN0byAoa29pdmlzdG9Aa2RlLm9yZykKICAqICAgICAgICAgICAoQykgMjAwMSBE aXJrIE11ZWxsZXIgKG11ZWxsZXJAa2RlLm9yZykKLSAqIENvcHlyaWdodCAoQykgMjAwNCBBcHBs ZSBDb21wdXRlciwgSW5jLgorICogQ29weXJpZ2h0IChDKSAyMDA0LCAyMDA1IEFwcGxlIENvbXB1 dGVyLCBJbmMuCiAgKgogICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4g cmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICogbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0 aGUgR05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKQEAgLTE5NjcsNiArMTk2Nyw3IEBACiAgICAg c2V0Q2hhbmdlZCgpOwogICAgIGlmIChyZW5kZXJlcigpICYmIHJlbmRlcmVyKCktPnN0eWxlKCkt Pmhhc0FwcGVhcmFuY2UoKSkKICAgICAgICAgdGhlbWUoKS0+c3RhdGVDaGFuZ2VkKHJlbmRlcmVy KCksIENoZWNrZWRTdGF0ZSk7CisgICAgb25DaGFuZ2UoKTsKIH0KIAogdm9pZCBIVE1MSW5wdXRF bGVtZW50SW1wbDo6c2V0SW5kZXRlcm1pbmF0ZShib29sIF9pbmRldGVybWluYXRlKQoKSW5kZXg6 IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE1MApkaWZmIC11IC1yMS4xNTAgQ2hhbmdl TG9nCi0tLSBDaGFuZ2VMb2cJMTQgRGVjIDIwMDUgMDA6NDA6NTEgLTAwMDAJMS4xNTAKKysrIENo YW5nZUxvZwkxNCBEZWMgMjAwNSAwNzozNzowMyAtMDAwMApAQCAtMSwzICsxLDE1IEBACisyMDA1 LTEyLTEzICBBZGVsZSBQZXRlcnNvbiAgPGFkZWxlQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0IGNhc2UgZm9yIGh0dHA6Ly9i dWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ2NQorICAgICAgICBSRUdS RVNTSU9OOiBjaGVjayBib3ggb25jaGFuZ2UgZXZlbnQgZG9lc24ndCBmaXJlIChyYWRpbyBidXR0 b25zIGRvIG5vdCBnZXQgZGlzYWJsZWQgaW4gQnVnemlsbGEpCisKKyAgICAgICAgKiBmYXN0L2Zv cm1zL2NoZWNrYm94LXJhZGlvLW9uY2hhbmdlLWV4cGVjdGVkLmNoZWNrc3VtOiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2Zvcm1zL2NoZWNrYm94LXJhZGlvLW9uY2hhbmdlLWV4cGVjdGVkLnBuZzog QWRkZWQuCisgICAgICAgICogZmFzdC9mb3Jtcy9jaGVja2JveC1yYWRpby1vbmNoYW5nZS1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvY2hlY2tib3gtcmFkaW8tb25j aGFuZ2UuaHRtbDogQWRkZWQuCisKIDIwMDUtMTItMTMgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90 aHlAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEh5YXR0Lgo= 5074 2005-12-13 23:41:00 -0800 2005-12-13 23:41:00 -0800 new testcase checkbox-radio-onchange.html text/html 690 adele PGh0bWw+Cjxib2R5IG9ubG9hZD0iZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NoJykuY2xpY2so KTsgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3JkMicpLmNsaWNrKCkiPgpUaGlzIGlzIHRvIHRl c3Qgb25jaGFuZ2Ugb2YgY2hlY2tib3hlcyBhbmQgcmFkaW8gYnV0dG9ucy4KPGJyPgo8aW5wdXQg dHlwZT0iY2hlY2tib3giIGlkPSJjaCIgb25jaGFuZ2U9ImRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCdyZXN1bHQnKS5pbm5lckhUTUwgPSAnVGVzdCAxIFBhc3NlZC4gb25DaGFuZ2UgZXZlbnQgZmly ZWQgZm9yIGNoZWNrYm94LlxuJyI+Q2hlY2tib3g8L2lucHV0Pgo8ZGl2IGlkPSJyZXN1bHQiPlRl c3QgMSBGYWlsZWQuIG9uQ2hhbmdlIGRpZG4ndCBmaXJlLjwvZGl2Pgo8aW5wdXQgdHlwZT0icmFk aW8iIGlkPSJyZCIgbmFtZT0idGVzdCI+UmFkaW8gMTwvaW5wdXQ+CjxpbnB1dCB0eXBlPSJyYWRp byIgaWQ9InJkMiIgbmFtZT0idGVzdCIgb25jaGFuZ2U9ImRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCdyZXN1bHQyJykuaW5uZXJIVE1MID0gJ1Rlc3QgMiBQYXNzZWQuIG9uQ2hhbmdlIGV2ZW50IGZp cmVkIGZvciByYWRpbyBidXR0b24uXG4nIj5SYWRpbyAyPC9pbnB1dD4KPGRpdiBpZD0icmVzdWx0 MiI+VGVzdCAyIEZhaWxlZC4gb25DaGFuZ2UgZGlkbid0IGZpcmUuPC9kaXY+CgoKPC9ib2R5Pgo8 L2h0bWw+