54641 2011-02-17 05:39:59 -0800 [Qt] ImageDiff sometimes hangs 2011-03-28 06:44:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ossy ossy ariya.hidayat cmarcelo commit-queue hausmann kling oldest_to_newest 352777 0 ossy 2011-02-17 05:39:59 -0800 On r78808 it is easily reproducable: (Using platform mac to get many pixel differences) $ Tools/Scripts/run-webkit-tests --debug --platform mac -p svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg svg/W3C-SVG-1.1-SE/filters-image-03-f.svg svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg During the 5. test ImageDiff hangs: Tools/DumpRenderTree/qt/ImageDiff.cpp:138: if (fwrite(data.constData(), 1, data.length(), stdout)) {} I'm going to debug and fix this bug. It is the first step to run Qt pixel tests. ;) 352940 1 82816 ossy 2011-02-17 08:47:11 -0800 Created attachment 82816 proposed fix 352948 2 ossy 2011-02-17 08:57:43 -0800 ImageDiff was written by Ariya and reviewed by Simon: https://bugs.webkit.org/show_bug.cgi?id=27813 ImageDiff is able to compare pairs of images. actualImage and baselineImage should be cleared after all comparison: + actualImage = QImage(); + baselineImage = QImage(); 352949 3 82816 kling 2011-02-17 08:59:08 -0800 Comment on attachment 82816 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=82816&action=review > Tools/DumpRenderTree/qt/ImageDiff.cpp:146 > + actualImage = QImage(); > + baselineImage = QImage(); This should be below the next } so they get cleared if one of them isNull(), too. 352950 4 82816 kling 2011-02-17 09:03:36 -0800 Comment on attachment 82816 proposed fix Superficial review fail, didn't realize this was an FSM. r=me, motherlover :) 352980 5 commit-queue 2011-02-17 09:40:04 -0800 The commit-queue encountered the following flaky tests while processing attachment 82816: media/invalid-media-url-crash.html bug 51138 (author: inferno@chromium.org) The commit-queue is continuing to process your patch. 352981 6 82816 commit-queue 2011-02-17 09:41:47 -0800 Comment on attachment 82816 proposed fix Clearing flags on attachment: 82816 Committed r78840: <http://trac.webkit.org/changeset/78840> 352982 7 commit-queue 2011-02-17 09:41:52 -0800 All reviewed patches have been landed. Closing bug. 374460 8 cmarcelo 2011-03-28 06:39:23 -0700 Revision r78840 cherry-picked into qtwebkit-2.1 with commit 3d8aeee68ff7943cc50e4b321b1071195b671d0a <http://gitorious.org/webkit/qtwebkit/commit/3d8aeee68ff7943cc50e4b321b1071195b671d0a> 374461 9 cmarcelo 2011-03-28 06:43:54 -0700 Also merged into qtwebkit-2.1.x 82816 2011-02-17 08:47:11 -0800 2011-02-17 09:41:47 -0800 proposed fix 1.patch text/plain 978 ossy SW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0ltYWdlRGlmZi5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvSW1hZ2VEaWZmLmNwcAkocmV2aXNpb24gNzg4MzEp CisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9JbWFnZURpZmYuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNDIsNiArMTQyLDggQEAKIAogICAgICAgICAgICAgICAgIGZmbHVzaChzdGRvdXQpOwog ICAgICAgICAgICAgfQorICAgICAgICAgICAgYWN0dWFsSW1hZ2UgPSBRSW1hZ2UoKTsKKyAgICAg ICAgICAgIGJhc2VsaW5lSW1hZ2UgPSBRSW1hZ2UoKTsKICAgICAgICAgfQogICAgIH0KIApJbmRl eDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NoYW5nZUxvZwkocmV2aXNp b24gNzg4MzIpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx MyBAQAorMjAxMS0wMi0xNyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gSW1h Z2VEaWZmIHNvbWV0aW1lcyBoYW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTQ2NDEKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L0ltYWdl RGlmZi5jcHA6IENsZWFyIGFjdHVhbEltYWdlIGFuZCBiYXNlbGluZUltYWdlIGFmdGVyIGFsbCBj b21wYXJpc29uLgorICAgICAgICAobWFpbik6CisKIDIwMTEtMDItMTcgIEdhYm9yIFJhcGNzYW55 aSAgPHJnYWJvckB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENzYWJhIE9zenRy b2dvbsOhYy4K