54640 2011-02-17 05:10:16 -0800 [Chromium] media/video-display-toggle.html fails (IMAGE) on all platforms 2011-02-23 00:52:12 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 mnaganov webkit-unassigned annacc commit-queue mihaip oldest_to_newest 352762 0 mnaganov 2011-02-17 05:10:16 -0800 See logs (search for media/video-display-toggle.html): http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5/builds/1315/steps/webkit_tests/logs/stdio http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/2468/steps/webkit_tests/logs/stdio http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win/builds/1607/steps/webkit_tests/logs/stdio This test was already marked as failing, but missed a bugzilla issue. 355433 1 annacc 2011-02-22 11:27:41 -0800 This test assumes that when the "playing" event fires, the controls will change from the "play" glyph to the "pause" glyph. This may or may not be the case as the drawing of the controls happens asynchronously. I propose a change that acts on "canplaythrough" (when the video is loaded and ready) and then seeks to a frame (so that the pixel diff is guaranteed) after toggling the display. Patch coming shortly. 355537 2 83372 annacc 2011-02-22 13:03:40 -0800 Created attachment 83372 Patch 355915 3 83372 commit-queue 2011-02-23 00:27:54 -0800 Comment on attachment 83372 Patch Clearing flags on attachment: 83372 Committed r79415: <http://trac.webkit.org/changeset/79415> 355916 4 commit-queue 2011-02-23 00:27:59 -0800 All reviewed patches have been landed. Closing bug. 355921 5 commit-queue 2011-02-23 00:52:12 -0800 The commit-queue encountered the following flaky tests while processing attachment 83372: http/tests/websocket/tests/multiple-connections.html bug 53825 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 83372 2011-02-22 13:03:40 -0800 2011-02-23 00:27:54 -0800 Patch bug-54640-20110222130339.patch text/plain 2342 annacc U3VidmVyc2lvbiBSZXZpc2lvbjogNzkyMzUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiZTdmN2I1OGI3Y2RiOTZjZDQwZmNm MDU5YTE5NTI0MGZhZjBhNmU3Li5lZDA2ZGRkNjFhNzVmYjcxNTZmZjk5MTYzOGMzZjNmM2M2YTQ3 MDlmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDItMjIgIEFubmEgQ2F2ZW5kZXIgIDxh bm5hY2NAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEF2b2lkIGZsYWtpbmVzcyBkdWUgdG8gYXN5bmMgZHJhd2luZyBvZiBjb250 cm9sIGdseXBocyBieSBhY3Rpbmcgb24gImNhbnBsYXl0aHJvdWdoIiBpbnN0ZWFkIG9mICJwbGF5 aW5nIi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTU0 NjQwCisKKyAgICAgICAgKiBtZWRpYS92aWRlby1kaXNwbGF5LXRvZ2dsZS5odG1sOgorCiAyMDEx LTAyLTIxICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAg VW5yZXZpZXdlZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWRpc3BsYXkt dG9nZ2xlLmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1kaXNwbGF5LXRvZ2dsZS5odG1s CmluZGV4IDI4OWIyMTYzODcwNDhiMjVkNjgzOTdiODAwYzA1ZjM0MmFmYjJhZDcuLjJhOTk1ZDY0 NjM5ZWZjZjViOGNlMTQ0NGI3NWZhYzI1ZWQ5NDEzNDkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L21lZGlhL3ZpZGVvLWRpc3BsYXktdG9nZ2xlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVkaWEv dmlkZW8tZGlzcGxheS10b2dnbGUuaHRtbApAQCAtNywxMSArNywxMCBAQAogICAgICAgICAgICAg ICAgIHZhciB2aWRlbyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd2aWQnKTsKICAgICAgICAg ICAgICAgICBpZiAodmlkZW8uc3R5bGUuZGlzcGxheSA9PSAibm9uZSIpIHsKICAgICAgICAgICAg ICAgICAgICAgdmlkZW8uc3R5bGUuZGlzcGxheSA9ICJpbmxpbmUtYmxvY2siOwotICAgICAgICAg ICAgICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQotICAgICAgICAgICAg ICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgICAgICAg ICAgICAgICAgICB2aWRlby5hZGRFdmVudExpc3RlbmVyKCJzZWVrZWQiLCBkb25lKTsKKyAgICAg ICAgICAgICAgICAgICAgdmlkZW8uY3VycmVudFRpbWUgPSAwOyAvLyBzbyB0aGUgc25hcHNob3Qg YWx3YXlzIGhhcyB0aGUgc2FtZSBmcmFtZQogICAgICAgICAgICAgICAgIH0gZWxzZQogICAgICAg ICAgICAgICAgICAgICB2aWRlby5zdHlsZS5kaXNwbGF5ID0gIm5vbmUiOwotICAgICAgICAgICAg ICAgIGRvY3VtZW50LmJvZHkub2Zmc2V0TGVmdDsKICAgICAgICAgICAgIH0KICAgICAgICAgICAg IGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICAgICAgewpAQCAtMTksMTUgKzE4LDE5IEBACiAgICAg ICAgICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKICAg ICAgICAgICAgICAgICBzZXRTcmNCeUlkKCd2aWQnLCBmaW5kTWVkaWFGaWxlKCd2aWRlbycsICdj b250ZW50L3Rlc3QnKSk7CiAgICAgICAgICAgICAgICAgdmFyIHZpZGVvID0gZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ3ZpZCcpOworICAgICAgICAgICAgICAgIHZpZGVvLmFkZEV2ZW50TGlzdGVu ZXIoImNhbnBsYXl0aHJvdWdoIiwgdGVzdDIpOwogICAgICAgICAgICAgICAgIHZpZGVvLmxvYWQo KTsKLSAgICAgICAgICAgICAgICB2aWRlby5wbGF5KCk7Ci0gICAgICAgICAgICAgICAgdmlkZW8u YWRkRXZlbnRMaXN0ZW5lcigicGxheWluZyIsIHRlc3QyKTsKICAgICAgICAgICAgIH0KICAgICAg ICAgICAgIGZ1bmN0aW9uIHRlc3QyKCkKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICB0 b2dnbGVEaXNwbGF5KCk7CiAgICAgICAgICAgICAgICAgdG9nZ2xlRGlzcGxheSgpOwogICAgICAg ICAgICAgfQorICAgICAgICAgICAgZnVuY3Rpb24gZG9uZSgpCisgICAgICAgICAgICB7CisgICAg ICAgICAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAg ICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworICAgICAgICAgICAg fQogICAgICAgICA8L3NjcmlwdD4KICAgICA8L2hlYWQ+CiAgICAgPGJvZHkgb25sb2FkPSJ0ZXN0 KCkiPgo=