54632 2011-02-17 03:11:44 -0800 [chromium] Printing causes view to scroll 2011-02-18 01:06:03 -0800 1 1 1 Unclassified WebKit Printing 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yuzo yuzo abarth atwilson eric fishd hamaji webkit.review.bot oldest_to_newest 352717 0 yuzo 2011-02-17 03:11:44 -0800 Forked from https://bugs.webkit.org/show_bug.cgi?id=52552 to track Chromium-specific part of the issue. Steps to reproduce: 1. Open https://bug-52552-attachments.webkit.org/attachment.cgi?id=79128 2. Resize the window small enough such that vertical scrollbar appears. 3. Scroll to the bottom. 4. File > Print... > Cancel 5. Observe the scrollbar has moved upward. (For Safari, the upward scroll is observed only for very small (around 400 x 300) window, and the amount of scroll is smaller. The scroll doesn't manifest itself until the window is clicked after printing.) 352726 1 82778 yuzo 2011-02-17 03:23:29 -0800 Created attachment 82778 Patch 352742 2 hamaji 2011-02-17 04:03:04 -0800 IIRC, Darin Fisher said he wants to know all chromium API changes. 352745 3 82778 hamaji 2011-02-17 04:04:44 -0800 Comment on attachment 82778 Patch ... and this change looks good to me. I think it's nice to have a link how this API will be used: http://codereview.chromium.org/6539011/ 352943 4 82778 fishd 2011-02-17 08:53:48 -0800 Comment on attachment 82778 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82778&action=review > Source/WebKit/chromium/public/WebFrame.h:146 > + virtual void setScrollOffset(const WebSize&) = 0; LGTM 352963 5 ap 2011-02-17 09:19:08 -0800 What is different about chromium that makes this problem happen? This doesn't seem to fix the root cause, whatever it is. 353257 6 yuzo 2011-02-17 17:15:06 -0800 (In reply to comment #5) > What is different about chromium that makes this problem happen? This doesn't seem to fix the root cause, whatever it is. Chromium resizes WebView to paper size before printing and then to original on-screen size after printing. The scroll position is lost during the resizing. The intention of this patch is to allow Chromium to save the on-screen scroll position before resizing and restore it after. I'm not sure how Safari does it differently. Perhaps there is an alternative way of resizing WebView, which maintains the scroll position? 353289 7 yuzo 2011-02-17 18:01:33 -0800 Committed r78936: <http://trac.webkit.org/changeset/78936> 353332 8 atwilson 2011-02-17 19:18:52 -0800 Reverted r78936 for reason: Breaks chromium build Committed r78940: <http://trac.webkit.org/changeset/78940> 353452 9 yuzo 2011-02-17 23:44:11 -0800 Committed r78967: <http://trac.webkit.org/changeset/78967> 353470 10 webkit.review.bot 2011-02-18 01:06:03 -0800 http://trac.webkit.org/changeset/78967 might have broken GTK Linux 64-bit Debug 82778 2011-02-17 03:23:29 -0800 2011-02-17 08:53:48 -0800 Patch bug-54632-20110217032327.patch text/plain 2844 yuzo U3VidmVyc2lvbiBSZXZpc2lvbjogNzg4MDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg NjJhNDlkYmZkOGU2ZDZlMzRiYWQyYzNkZmE1ZjMwOTYzN2Y3NzRmNS4uMjYwZDkyNDM4MTU0NWI2 N2M1MTkwOGRkZWVkZTAzOTI0YTlkZWZlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOSBAQAorMjAxMS0wMi0xNyAgWXV6byBGdWppc2hpbWEgIDx5dXpvQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IGZvciBCdWcgNTQ2MzIgLSBbY2hyb21pdW1dIFByaW50aW5nIGNhdXNlcyB2aWV3IHRvIHNjcm9s bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ2MzIK KworICAgICAgICBFeHBvc2Ugc2V0U2Nyb2xsT2Zmc2V0IHN1Y2ggdGhhdCBDaHJvbWl1bSBjYW4g cmVzdG9yZSB0aGUgc2Nyb2xsIG9mZnNldAorICAgICAgICBhZnRlciBwcmludGluZyB0aGUgZG9j dW1lbnQuIFRoZSBidWcgd2lsbCBiZSBmaXhlZCB3aGVuIHRoZSBjb3VudGVycGFydAorICAgICAg ICBwYXRjaCBpcyBsYW5kZWQgZm9yIENocm9taXVtLgorCisgICAgICAgICogcHVibGljL1dlYkZy YW1lLmg6CisgICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYkZyYW1lSW1wbDo6c2V0U2Nyb2xsT2Zmc2V0KToKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJ bXBsLmg6CisKIDIwMTEtMDItMTYgIEJyaWFuIFJ5bmVyICA8YnJ5bmVyQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViRnJhbWUuaAppbmRleCBjMmEwNjUwZTMwYzNmMGExMGJkNTFmZDJmZWM3M2I4 YjRjNjFhZmU3Li44NmZkZWMyZTNiNDI2NDkwZDI5MWZkOTUxZTEwNzFiZTMyMWFiMTFiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgKQEAgLTE0Myw2ICsxNDMsNyBA QCBwdWJsaWM6CiAKICAgICAvLyBUaGUgc2Nyb2xsIG9mZnNldCBmcm9tIHRoZSB0b3AtbGVmdCBj b3JuZXIgb2YgdGhlIGZyYW1lIGluIHBpeGVscy4KICAgICB2aXJ0dWFsIFdlYlNpemUgc2Nyb2xs T2Zmc2V0KCkgY29uc3QgPSAwOworICAgIHZpcnR1YWwgdm9pZCBzZXRTY3JvbGxPZmZzZXQoY29u c3QgV2ViU2l6ZSYpID0gMDsKIAogICAgIC8vIFRoZSBzaXplIG9mIHRoZSBjb250ZW50cyBhcmVh LgogICAgIHZpcnR1YWwgV2ViU2l6ZSBjb250ZW50c1NpemUoKSBjb25zdCA9IDA7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAppbmRleCA1NzYzNDkwOGI4YjUw OTVmN2NkZWY4NDY4YjZhYmY4MmVhMzJkMTg3Li4zMzEwNWRjNTEyZTA3ZTQ3NDUzMjBkMWI2MzRi N2JlM2ZjZTNjMjNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJG cmFtZUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1w bC5jcHAKQEAgLTU0NCw2ICs1NDQsMTIgQEAgV2ViU2l6ZSBXZWJGcmFtZUltcGw6OnNjcm9sbE9m ZnNldCgpIGNvbnN0CiAgICAgcmV0dXJuIFdlYlNpemUoKTsKIH0KIAordm9pZCBXZWJGcmFtZUlt cGw6OnNldFNjcm9sbE9mZnNldChjb25zdCBXZWJTaXplJiBvZmZzZXQpCit7CisgICAgaWYgKEZy YW1lVmlldyogdmlldyA9IGZyYW1lVmlldygpKQorICAgICAgICB2aWV3LT5zZXRTY3JvbGxPZmZz ZXQoSW50UG9pbnQob2Zmc2V0LndpZHRoLCBvZmZzZXQuaGVpZ2h0KSk7Cit9CisKIFdlYlNpemUg V2ViRnJhbWVJbXBsOjpjb250ZW50c1NpemUoKSBjb25zdAogewogICAgIHJldHVybiBmcmFtZSgp LT52aWV3KCktPmNvbnRlbnRzU2l6ZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViRnJhbWVJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJG cmFtZUltcGwuaAppbmRleCBlN2M5MmIwZmYzZjY2MjY2ODk1OGY3YWM0ZTIwNjhiNDIyNDFmMmVh Li41NWE5ZjU0YzdlZWI3ZGRmM2ZkNDE2MjcxNmNjMzA2ZmY0ZDAyNDFkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaApAQCAtNzMsNiArNzMsNyBAQCBwdWJsaWM6 CiAgICAgdmlydHVhbCBXZWJVUkwgb3BlblNlYXJjaERlc2NyaXB0aW9uVVJMKCkgY29uc3Q7CiAg ICAgdmlydHVhbCBXZWJTdHJpbmcgZW5jb2RpbmcoKSBjb25zdDsKICAgICB2aXJ0dWFsIFdlYlNp emUgc2Nyb2xsT2Zmc2V0KCkgY29uc3Q7CisgICAgdmlydHVhbCB2b2lkIHNldFNjcm9sbE9mZnNl dChjb25zdCBXZWJTaXplJik7CiAgICAgdmlydHVhbCBXZWJTaXplIGNvbnRlbnRzU2l6ZSgpIGNv bnN0OwogICAgIHZpcnR1YWwgaW50IGNvbnRlbnRzUHJlZmVycmVkV2lkdGgoKSBjb25zdDsKICAg ICB2aXJ0dWFsIGludCBkb2N1bWVudEVsZW1lbnRTY3JvbGxIZWlnaHQoKSBjb25zdDsK