54628 2011-02-17 02:01:58 -0800 [GStreamer] Add 'location' property in webkitwebsrc 2011-02-21 01:34:08 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 54627 0 ylatuya webkit-unassigned gustavo mrobinson pnormand webkit.review.bot oldest_to_newest 352691 0 82771 ylatuya 2011-02-17 02:01:58 -0800 Created attachment 82771 add 'location' property Add the 'location' property to the webkitwebsrc so that get_element_make_from_uri() can set the uri on the element. 352695 1 pnormand 2011-02-17 02:18:41 -0800 Could you post a patch with a ChangeLog please? See also http://www.webkit.org/coding/contributing.html :) 352722 2 82776 ylatuya 2011-02-17 03:16:59 -0800 Created attachment 82776 Patch 352724 3 webkit.review.bot 2011-02-17 03:18:51 -0800 Attachment 82776 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:122: The parameter name "handler" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:123: The parameter name "handler" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 352747 4 pnormand 2011-02-17 04:08:34 -0800 LGTM apart from the style issue :) 352878 5 82776 mrobinson 2011-02-17 07:41:29 -0800 Comment on attachment 82776 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82776&action=review Looks good, but I have just a few small suggestions. > WebCore/ChangeLog:14 > +2011-02-17 Andoni Morales Alastruey <amorales@flumotion.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Added 'location' property > + https://bugs.webkit.org/show_bug.cgi?id=54628 > + > + The 'location' property is used by gst_element_make_from_uri() > + to set the uri in the source element > + > + * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: > + (webkit_web_src_class_init): > + (webKitWebSrcSetProperty): > + (webKitWebSrcGetProperty): Please generate your ChangeLog with prepare-ChangeLog --bug <bugid>. Some of the tools will unfotunately choke if the format is incorrect. > WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:119 > +static gboolean webKitWebSrcSetUri(GstURIHandler* handler, const gchar* uri); > +static const gchar* webKitWebSrcGetUri(GstURIHandler* handler); The argument names aren't necessary here. > WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:206 > + /* location property for gst_element_make_from_uri */ Please use complete sentences for comments. > WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:298 > + webKitWebSrcSetUri((GstURIHandler *)src, g_value_get_string(value)); Please use either static_cast or reinterpret_cast where appropriate. > WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:328 > + g_value_set_string(value, webKitWebSrcGetUri((GstURIHandler *) src)); Ditto. 353590 6 82959 ylatuya 2011-02-18 08:13:36 -0800 Created attachment 82959 Patch 353595 7 ylatuya 2011-02-18 08:27:23 -0800 I have updated the patch with all your suggestions :) 353601 8 82959 mrobinson 2011-02-18 08:39:18 -0800 Comment on attachment 82959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=82959&action=review Great! > WebCore/ChangeLog:8 > + No new tests. (OOPS!) Generally you shoud explain here why tests are not needed. We can do that whil landing this though. 353603 9 mrobinson 2011-02-18 08:39:38 -0800 Philippe, do you mind landing this one? 354458 10 pnormand 2011-02-21 01:34:08 -0800 Committed r79197: <http://trac.webkit.org/changeset/79197> 82771 2011-02-17 02:01:58 -0800 2011-02-17 02:01:58 -0800 add 'location' property url.txt text/plain 103 ylatuya aHR0cDovL2dpdG9yaW91cy5vcmcvfnlsYXR1eWEvd2Via2l0Z3RrL3lsYXR1eWFzLXdlYmtpdC9j b21taXQvNjk4Y2U1NGVmOGRiOGZmNmFkNWYzOTljN2JjNjVlN2Y0ODcwMWE5NA== 82776 2011-02-17 03:16:59 -0800 2011-02-18 08:13:32 -0800 Patch bug-54628-20110217121852.patch text/plain 3546 ylatuya ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWI2OWM3OS4uZGIzYjBjOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0wMi0xNyAgQW5kb25pIE1vcmFs ZXMgQWxhc3RydWV5ICA8YW1vcmFsZXNAZmx1bW90aW9uLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCAnbG9jYXRpb24nIHByb3BlcnR5 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDYyOAor CisgICAgICAgIFRoZSAnbG9jYXRpb24nIHByb3BlcnR5IGlzIHVzZWQgYnkgZ3N0X2VsZW1lbnRf bWFrZV9mcm9tX3VyaSgpCisgICAgICAgIHRvIHNldCB0aGUgdXJpIGluIHRoZSBzb3VyY2UgZWxl bWVudAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNv dXJjZUdTdHJlYW1lci5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3NyY19jbGFzc19pbml0KToK KyAgICAgICAgKHdlYktpdFdlYlNyY1NldFByb3BlcnR5KToKKyAgICAgICAgKHdlYktpdFdlYlNy Y0dldFByb3BlcnR5KToKKwogMjAxMC0wNi0yMSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5k QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0 cmVhbWVyLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdl YlNvdXJjZUdTdHJlYW1lci5jcHAKaW5kZXggODQ2MmFkMS4uMTJmNjE4MCAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVh bWVyLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRX ZWJTb3VyY2VHU3RyZWFtZXIuY3BwCkBAIC05MCw3ICs5MCw4IEBAIGVudW0gewogICAgIFBST1Bf SVJBRElPX05BTUUsCiAgICAgUFJPUF9JUkFESU9fR0VOUkUsCiAgICAgUFJPUF9JUkFESU9fVVJM LAotICAgIFBST1BfSVJBRElPX1RJVExFCisgICAgUFJPUF9JUkFESU9fVElUTEUsCisgICAgUFJP UF9MT0NBVElPTgogfTsKIAogc3RhdGljIEdzdFN0YXRpY1BhZFRlbXBsYXRlIHNyY1RlbXBsYXRl ID0gR1NUX1NUQVRJQ19QQURfVEVNUExBVEUoInNyYyIsCkBAIC0xMTQsNiArMTE1LDggQEAgc3Rh dGljIHZvaWQgd2ViS2l0V2ViU3JjRW5vdWdoRGF0YUNiKEdzdEFwcFNyYyogYXBwc3JjLCBncG9p bnRlciB1c2VyRGF0YSk7CiBzdGF0aWMgZ2Jvb2xlYW4gd2ViS2l0V2ViU3JjU2Vla0RhdGFDYihH c3RBcHBTcmMqIGFwcHNyYywgZ3VpbnQ2NCBvZmZzZXQsIGdwb2ludGVyIHVzZXJEYXRhKTsKIAog c3RhdGljIHZvaWQgd2ViS2l0V2ViU3JjU3RvcChXZWJLaXRXZWJTcmMqIHNyYywgYm9vbCBzZWVr aW5nKTsKK3N0YXRpYyBnYm9vbGVhbiB3ZWJLaXRXZWJTcmNTZXRVcmkoR3N0VVJJSGFuZGxlciog aGFuZGxlciwgY29uc3QgZ2NoYXIqIHVyaSk7CitzdGF0aWMgY29uc3QgZ2NoYXIqIHdlYktpdFdl YlNyY0dldFVyaShHc3RVUklIYW5kbGVyKiBoYW5kbGVyKTsKIAogc3RhdGljIEdzdEFwcFNyY0Nh bGxiYWNrcyBhcHBzcmNDYWxsYmFja3MgPSB7CiAgICAgd2ViS2l0V2ViU3JjTmVlZERhdGFDYiwK QEAgLTE5OSw2ICsyMDIsMTUgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9zcmNfY2xhc3NfaW5p dChXZWJLaXRXZWJTcmNDbGFzcyoga2xhc3MpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIDAsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChHUGFyYW1GbGFncykgKEdfUEFSQU1fUkVB REFCTEUgfCBHX1BBUkFNX1NUQVRJQ19TVFJJTkdTKSkpOwogCisKKyAgICAvKiBsb2NhdGlvbiBw cm9wZXJ0eSBmb3IgZ3N0X2VsZW1lbnRfbWFrZV9mcm9tX3VyaSAqLworICAgIGdfb2JqZWN0X2Ns YXNzX2luc3RhbGxfcHJvcGVydHkob2tsYXNzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgUFJPUF9MT0NBVElPTiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGdfcGFyYW1fc3BlY19zdHJpbmcoImxvY2F0aW9uIiwKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImxvY2F0aW9uIiwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIkxvY2F0aW9u IHRvIHJlYWQgZnJvbSIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIDAsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIChHUGFyYW1GbGFncykgKEdfUEFSQU1fUkVBRFdSSVRFIHwgR19Q QVJBTV9TVEFUSUNfU1RSSU5HUykpKTsKICAgICBla2xhc3MtPmNoYW5nZV9zdGF0ZSA9IHdlYktp dFdlYlNyY0NoYW5nZVN0YXRlOwogCiAgICAgZ190eXBlX2NsYXNzX2FkZF9wcml2YXRlKGtsYXNz LCBzaXplb2YoV2ViS2l0V2ViU3JjUHJpdmF0ZSkpOwpAQCAtMjgyLDYgKzI5NCw5IEBAIHN0YXRp YyB2b2lkIHdlYktpdFdlYlNyY1NldFByb3BlcnR5KEdPYmplY3QqIG9iamVjdCwgZ3VpbnQgcHJv cElELCBjb25zdCBHVmFsdWUqCiAgICAgY2FzZSBQUk9QX0lSQURJT19NT0RFOgogICAgICAgICBw cml2LT5pcmFkaW9Nb2RlID0gZ192YWx1ZV9nZXRfYm9vbGVhbih2YWx1ZSk7CiAgICAgICAgIGJy ZWFrOworICAgIGNhc2UgUFJPUF9MT0NBVElPTjoKKyAgICAgICAgd2ViS2l0V2ViU3JjU2V0VXJp KChHc3RVUklIYW5kbGVyICopc3JjLCBnX3ZhbHVlX2dldF9zdHJpbmcodmFsdWUpKTsKKyAgICAg ICAgYnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAgICAgR19PQkpFQ1RfV0FSTl9JTlZBTElEX1BS T1BFUlRZX0lEKG9iamVjdCwgcHJvcElELCBwc3BlYyk7CiAgICAgICAgIGJyZWFrOwpAQCAtMzA5 LDYgKzMyNCw5IEBAIHN0YXRpYyB2b2lkIHdlYktpdFdlYlNyY0dldFByb3BlcnR5KEdPYmplY3Qq IG9iamVjdCwgZ3VpbnQgcHJvcElELCBHVmFsdWUqIHZhbHVlCiAgICAgY2FzZSBQUk9QX0lSQURJ T19USVRMRToKICAgICAgICAgZ192YWx1ZV9zZXRfc3RyaW5nKHZhbHVlLCBwcml2LT5pcmFkaW9U aXRsZSk7CiAgICAgICAgIGJyZWFrOworICAgIGNhc2UgUFJPUF9MT0NBVElPTjoKKyAgICAgICAg Z192YWx1ZV9zZXRfc3RyaW5nKHZhbHVlLCB3ZWJLaXRXZWJTcmNHZXRVcmkoKEdzdFVSSUhhbmRs ZXIgKikgc3JjKSk7CisgICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIEdfT0JK RUNUX1dBUk5fSU5WQUxJRF9QUk9QRVJUWV9JRChvYmplY3QsIHByb3BJRCwgcHNwZWMpOwogICAg ICAgICBicmVhazsK 82959 2011-02-18 08:13:36 -0800 2011-02-18 08:39:18 -0800 Patch bug-54628-20110218171540.patch text/plain 3569 ylatuya ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWI2OWM3OS4uY2M5Y2ZhNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wMi0xOCAgQW5kb25pIE1vcmFs ZXMgQWxhc3RydWV5ICA8YW1vcmFsZXNAZmx1bW90aW9uLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1N0cmVhbWVyXSBBZGQgJ2xvY2F0aW9u JyBwcm9wZXJ0eSBpbiB3ZWJraXR3ZWJzcmMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTU0NjI4CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEp CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNl R1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfc3JjX2NsYXNzX2luaXQpOgorICAg ICAgICAod2ViS2l0V2ViU3JjU2V0UHJvcGVydHkpOgorICAgICAgICAod2ViS2l0V2ViU3JjR2V0 UHJvcGVydHkpOgorCiAyMDEwLTA2LTIxICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdh bGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFt ZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291 cmNlR1N0cmVhbWVyLmNwcAppbmRleCA4NDYyYWQxLi43MjAxZjY2IDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIu Y3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNv dXJjZUdTdHJlYW1lci5jcHAKQEAgLTkwLDcgKzkwLDggQEAgZW51bSB7CiAgICAgUFJPUF9JUkFE SU9fTkFNRSwKICAgICBQUk9QX0lSQURJT19HRU5SRSwKICAgICBQUk9QX0lSQURJT19VUkwsCi0g ICAgUFJPUF9JUkFESU9fVElUTEUKKyAgICBQUk9QX0lSQURJT19USVRMRSwKKyAgICBQUk9QX0xP Q0FUSU9OCiB9OwogCiBzdGF0aWMgR3N0U3RhdGljUGFkVGVtcGxhdGUgc3JjVGVtcGxhdGUgPSBH U1RfU1RBVElDX1BBRF9URU1QTEFURSgic3JjIiwKQEAgLTExNCw2ICsxMTUsOCBAQCBzdGF0aWMg dm9pZCB3ZWJLaXRXZWJTcmNFbm91Z2hEYXRhQ2IoR3N0QXBwU3JjKiBhcHBzcmMsIGdwb2ludGVy IHVzZXJEYXRhKTsKIHN0YXRpYyBnYm9vbGVhbiB3ZWJLaXRXZWJTcmNTZWVrRGF0YUNiKEdzdEFw cFNyYyogYXBwc3JjLCBndWludDY0IG9mZnNldCwgZ3BvaW50ZXIgdXNlckRhdGEpOwogCiBzdGF0 aWMgdm9pZCB3ZWJLaXRXZWJTcmNTdG9wKFdlYktpdFdlYlNyYyogc3JjLCBib29sIHNlZWtpbmcp Oworc3RhdGljIGdib29sZWFuIHdlYktpdFdlYlNyY1NldFVyaShHc3RVUklIYW5kbGVyKiwgY29u c3QgZ2NoYXIqKTsKK3N0YXRpYyBjb25zdCBnY2hhciogd2ViS2l0V2ViU3JjR2V0VXJpKEdzdFVS SUhhbmRsZXIqKTsKIAogc3RhdGljIEdzdEFwcFNyY0NhbGxiYWNrcyBhcHBzcmNDYWxsYmFja3Mg PSB7CiAgICAgd2ViS2l0V2ViU3JjTmVlZERhdGFDYiwKQEAgLTE5OSw2ICsyMDIsMTYgQEAgc3Rh dGljIHZvaWQgd2Via2l0X3dlYl9zcmNfY2xhc3NfaW5pdChXZWJLaXRXZWJTcmNDbGFzcyoga2xh c3MpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDAsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChHUGFyYW1GbGFncykgKEdfUEFSQU1fUkVBREFCTEUgfCBHX1BBUkFNX1NUQVRJQ19T VFJJTkdTKSkpOwogCisKKyAgICAvKiBBbGxvd3Mgc2V0dGluZyB0aGUgdXJpIHVzaW5nIHRoZSAn bG9jYXRpb24nIHByb3BlcnR5LCB3aGljaCBpcyB1c2VkCisgICAgICogZm9yIGV4YW1wbGUgYnkg Z3N0X2VsZW1lbnRfbWFrZV9mcm9tX3VyaSgpICovCisgICAgZ19vYmplY3RfY2xhc3NfaW5zdGFs bF9wcm9wZXJ0eShva2xhc3MsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQ Uk9QX0xPQ0FUSU9OLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ19wYXJh bV9zcGVjX3N0cmluZygibG9jYXRpb24iLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAibG9jYXRpb24iLAorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiTG9jYXRpb24gdG8gcmVhZCBm cm9tIiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgMCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKEdQYXJhbUZsYWdzKSAoR19QQVJBTV9SRUFEV1JJVEUgfCBHX1BBUkFNX1NUQVRJ Q19TVFJJTkdTKSkpOwogICAgIGVrbGFzcy0+Y2hhbmdlX3N0YXRlID0gd2ViS2l0V2ViU3JjQ2hh bmdlU3RhdGU7CiAKICAgICBnX3R5cGVfY2xhc3NfYWRkX3ByaXZhdGUoa2xhc3MsIHNpemVvZihX ZWJLaXRXZWJTcmNQcml2YXRlKSk7CkBAIC0yODIsNiArMjk1LDkgQEAgc3RhdGljIHZvaWQgd2Vi S2l0V2ViU3JjU2V0UHJvcGVydHkoR09iamVjdCogb2JqZWN0LCBndWludCBwcm9wSUQsIGNvbnN0 IEdWYWx1ZSoKICAgICBjYXNlIFBST1BfSVJBRElPX01PREU6CiAgICAgICAgIHByaXYtPmlyYWRp b01vZGUgPSBnX3ZhbHVlX2dldF9ib29sZWFuKHZhbHVlKTsKICAgICAgICAgYnJlYWs7CisgICAg Y2FzZSBQUk9QX0xPQ0FUSU9OOgorICAgICAgICB3ZWJLaXRXZWJTcmNTZXRVcmkocmVpbnRlcnBy ZXRfY2FzdDxHc3RVUklIYW5kbGVyKj4oc3JjKSwgZ192YWx1ZV9nZXRfc3RyaW5nKHZhbHVlKSk7 CisgICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIEdfT0JKRUNUX1dBUk5fSU5W QUxJRF9QUk9QRVJUWV9JRChvYmplY3QsIHByb3BJRCwgcHNwZWMpOwogICAgICAgICBicmVhazsK QEAgLTMwOSw2ICszMjUsOSBAQCBzdGF0aWMgdm9pZCB3ZWJLaXRXZWJTcmNHZXRQcm9wZXJ0eShH T2JqZWN0KiBvYmplY3QsIGd1aW50IHByb3BJRCwgR1ZhbHVlKiB2YWx1ZQogICAgIGNhc2UgUFJP UF9JUkFESU9fVElUTEU6CiAgICAgICAgIGdfdmFsdWVfc2V0X3N0cmluZyh2YWx1ZSwgcHJpdi0+ aXJhZGlvVGl0bGUpOwogICAgICAgICBicmVhazsKKyAgICBjYXNlIFBST1BfTE9DQVRJT046Cisg ICAgICAgIGdfdmFsdWVfc2V0X3N0cmluZyh2YWx1ZSwgd2ViS2l0V2ViU3JjR2V0VXJpKHJlaW50 ZXJwcmV0X2Nhc3Q8R3N0VVJJSGFuZGxlcio+KHNyYykpKTsKKyAgICAgICAgYnJlYWs7CiAgICAg ZGVmYXVsdDoKICAgICAgICAgR19PQkpFQ1RfV0FSTl9JTlZBTElEX1BST1BFUlRZX0lEKG9iamVj dCwgcHJvcElELCBwc3BlYyk7CiAgICAgICAgIGJyZWFrOwo=